Fix for case where key may not be checked.
[m6w6/libmemcached] / libmemcached / key.cc
1 /* vim:expandtab:shiftwidth=2:tabstop=2:smarttab:
2 *
3 * Libmemcached library
4 *
5 * Copyright (C) 2011 Data Differential, http://datadifferential.com/
6 * Copyright (C) 2006-2009 Brian Aker All rights reserved.
7 *
8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions are
10 * met:
11 *
12 * * Redistributions of source code must retain the above copyright
13 * notice, this list of conditions and the following disclaimer.
14 *
15 * * Redistributions in binary form must reproduce the above
16 * copyright notice, this list of conditions and the following disclaimer
17 * in the documentation and/or other materials provided with the
18 * distribution.
19 *
20 * * The names of its contributors may not be used to endorse or
21 * promote products derived from this software without specific prior
22 * written permission.
23 *
24 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
25 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
26 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
27 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
28 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
29 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
30 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
31 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
32 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
33 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
34 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
35 *
36 */
37
38 #include <libmemcached/common.h>
39
40 static inline memcached_return_t memcached_validate_key_length(size_t key_length, bool)
41 {
42 if (key_length == 0)
43 {
44 return MEMCACHED_BAD_KEY_PROVIDED;
45 }
46
47 // No one ever reimplemented MEMCACHED to use keys longer then the original ascii length
48 #if 0
49 if (binary)
50 {
51 if (key_length > 0xffff)
52 {
53 return MEMCACHED_BAD_KEY_PROVIDED;
54 }
55 }
56 else
57 #endif
58 {
59 if (key_length >= MEMCACHED_MAX_KEY)
60 {
61 return MEMCACHED_BAD_KEY_PROVIDED;
62 }
63 }
64
65 return MEMCACHED_SUCCESS;
66 }
67
68 memcached_return_t memcached_key_test(memcached_st &memc,
69 const char * const *keys,
70 const size_t *key_length,
71 size_t number_of_keys)
72 {
73 if (number_of_keys == 0)
74 {
75 return memcached_set_error(memc, MEMCACHED_INVALID_ARGUMENTS, MEMCACHED_AT, memcached_literal_param("Numbers of keys provided was zero"));
76 }
77
78 if (keys == NULL or key_length == NULL)
79 {
80 return memcached_set_error(memc, MEMCACHED_BAD_KEY_PROVIDED, MEMCACHED_AT, memcached_literal_param("Key was NULL or length of key was zero."));
81 }
82
83 const bool is_binary= memcached_flag(memc, MEMCACHED_FLAG_BINARY_PROTOCOL);
84
85 // If we don't need to verify the key, or we are using the binary protoocol,
86 // we just check the size of the key
87 for (size_t x= 0; x < number_of_keys; ++x)
88 {
89 // We should set binary key, but the memcached server is broken for
90 // longer keys at the moment.
91 memcached_return_t rc= memcached_validate_key_length(*(key_length +x), false /* memc.flags.binary_protocol */);
92 if (memcached_failed(rc))
93 {
94 return memcached_set_error(memc, rc, MEMCACHED_AT, memcached_literal_param("Key provided was too long."));
95 }
96
97 if (memc.flags.verify_key and is_binary == false)
98 {
99 for (size_t y= 0; y < *(key_length +x); ++y)
100 {
101 if ((isgraph(keys[x][y])) == 0)
102 {
103 return memcached_set_error(memc, MEMCACHED_BAD_KEY_PROVIDED, MEMCACHED_AT, memcached_literal_param("Key provided had invalid character."));
104 }
105 }
106 }
107 }
108
109 return MEMCACHED_SUCCESS;
110 }
111