Merge branch 'v2.6.x'
authorMichael Wallner <mike@php.net>
Wed, 14 Sep 2016 09:39:47 +0000 (11:39 +0200)
committerMichael Wallner <mike@php.net>
Wed, 14 Sep 2016 09:39:47 +0000 (11:39 +0200)
1  2 
src/php_http_encoding.c

diff --combined src/php_http_encoding.c
index 0aa7dc1638301b58bf66b46d4615e98e81ab6657,8c29216ab7added98c5fcdb84823f2d6c7ead1d7..db364b3858e3273d339696bf89c5fe16ea317388
@@@ -28,7 -28,7 +28,7 @@@ static inline int eol_match(char **line
        }
  }
  
 -const char *php_http_encoding_dechunk(const char *encoded, size_t encoded_len, char **decoded, size_t *decoded_len TSRMLS_DC)
 +const char *php_http_encoding_dechunk(const char *encoded, size_t encoded_len, char **decoded, size_t *decoded_len)
  {
        int eol_len = 0;
        char *n_ptr = NULL;
                         * not encoded data and return a copy
                         */
                        if (e_ptr == encoded) {
 -                              php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Data does not seem to be chunked encoded");
 +                              php_error_docref(NULL, E_NOTICE, "Data does not seem to be chunked encoded");
                                memcpy(*decoded, encoded, encoded_len);
                                *decoded_len = encoded_len;
                                return encoded + encoded_len;
                        } else {
                                efree(*decoded);
 -                              php_error_docref(NULL TSRMLS_CC, E_WARNING, "Expected chunk size at pos %tu of %zu but got trash", n_ptr - encoded, encoded_len);
 +                              php_error_docref(NULL, E_WARNING, "Expected chunk size at pos %tu of %zu but got trash", n_ptr - encoded, encoded_len);
                                return NULL;
                        }
                }
@@@ -64,7 -64,7 +64,7 @@@
                /* reached the end */
                if (!chunk_len) {
                        /* move over '0' chunked encoding terminator and any new lines */
-                       do {
+                       while(1) {
                                switch (*e_ptr) {
                                        case '0':
                                        case '\r':
                                                ++e_ptr;
                                                continue;
                                }
-                       } while (0);
+                               break;
+                       }
                        break;
                }
  
                /* there should be CRLF after the chunk size, but we'll ignore SP+ too */
                if (*n_ptr && !eol_match(&n_ptr, &eol_len)) {
                        if (eol_len == 2) {
 -                              php_error_docref(NULL TSRMLS_CC, E_WARNING, "Expected CRLF at pos %tu of %zu but got 0x%02X 0x%02X", n_ptr - encoded, encoded_len, *n_ptr, *(n_ptr + 1));
 +                              php_error_docref(NULL, E_WARNING, "Expected CRLF at pos %tu of %zu but got 0x%02X 0x%02X", n_ptr - encoded, encoded_len, *n_ptr, *(n_ptr + 1));
                        } else {
 -                              php_error_docref(NULL TSRMLS_CC, E_WARNING, "Expected LF at pos %tu of %zu but got 0x%02X", n_ptr - encoded, encoded_len, *n_ptr);
 +                              php_error_docref(NULL, E_WARNING, "Expected LF at pos %tu of %zu but got 0x%02X", n_ptr - encoded, encoded_len, *n_ptr);
                        }
                }
                n_ptr += eol_len;
                
                /* chunk size pretends more data than we actually got, so it's probably a truncated message */
                if (chunk_len > (rest = encoded + encoded_len - n_ptr)) {
 -                      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Truncated message: chunk size %lu exceeds remaining data size %lu at pos %tu of %zu", chunk_len, rest, n_ptr - encoded, encoded_len);
 +                      php_error_docref(NULL, E_WARNING, "Truncated message: chunk size %lu exceeds remaining data size %lu at pos %tu of %zu", chunk_len, rest, n_ptr - encoded, encoded_len);
                        chunk_len = rest;
                }
  
@@@ -148,7 -149,7 +149,7 @@@ static inline int php_http_inflate_roun
        return status;
  }
  
 -ZEND_RESULT_CODE php_http_encoding_deflate(int flags, const char *data, size_t data_len, char **encoded, size_t *encoded_len TSRMLS_DC)
 +ZEND_RESULT_CODE php_http_encoding_deflate(int flags, const char *data, size_t data_len, char **encoded, size_t *encoded_len)
  {
        int status, level, wbits, strategy;
        z_stream Z;
                }
        }
        
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not deflate data: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Could not deflate data: %s", zError(status));
        return FAILURE;
  }
  
 -ZEND_RESULT_CODE php_http_encoding_inflate(const char *data, size_t data_len, char **decoded, size_t *decoded_len TSRMLS_DC)
 +ZEND_RESULT_CODE php_http_encoding_inflate(const char *data, size_t data_len, char **decoded, size_t *decoded_len)
  {
        z_stream Z;
        int status, wbits = PHP_HTTP_WINDOW_BITS_ANY;
@@@ -227,11 -228,11 +228,11 @@@ retry_raw_inflate
                }
        }
        
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not inflate data: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Could not inflate data: %s", zError(status));
        return FAILURE;
  }
  
 -php_http_encoding_stream_t *php_http_encoding_stream_init(php_http_encoding_stream_t *s, php_http_encoding_stream_ops_t *ops, unsigned flags TSRMLS_DC)
 +php_http_encoding_stream_t *php_http_encoding_stream_init(php_http_encoding_stream_t *s, php_http_encoding_stream_ops_t *ops, unsigned flags)
  {
        int freeme;
  
        memset(s, 0, sizeof(*s));
  
        s->flags = flags;
 -      TSRMLS_SET_CTX(s->ts);
  
        if ((s->ops = ops)) {
                php_http_encoding_stream_t *ss = s->ops->init(s);
  
  php_http_encoding_stream_t *php_http_encoding_stream_copy(php_http_encoding_stream_t *from, php_http_encoding_stream_t *to)
  {
 -      TSRMLS_FETCH_FROM_CTX(from->ts);
 -
        if (from->ops->copy) {
                int freeme;
                php_http_encoding_stream_t *ns;
  
                to->flags = from->flags;
                to->ops = from->ops;
 -              TSRMLS_SET_CTX(to->ts);
  
                if ((ns = to->ops->copy(from, to))) {
                        return ns;
  ZEND_RESULT_CODE php_http_encoding_stream_reset(php_http_encoding_stream_t **s)
  {
        php_http_encoding_stream_t *ss;
 +
        if ((*s)->ops->dtor) {
                (*s)->ops->dtor(*s);
        }
@@@ -364,6 -368,7 +365,6 @@@ static php_http_encoding_stream_t *defl
  {
        int status, level, wbits, strategy, p = (s->flags & PHP_HTTP_ENCODING_STREAM_PERSISTENT);
        z_streamp ctx = pecalloc(1, sizeof(z_stream), p);
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        PHP_HTTP_DEFLATE_LEVEL_SET(s->flags, level);
        PHP_HTTP_DEFLATE_WBITS_SET(s->flags, wbits);
                status = Z_MEM_ERROR;
        }
        pefree(ctx, p);
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to initialize deflate encoding stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to initialize deflate encoding stream: %s", zError(status));
        return NULL;
  }
  
@@@ -386,6 -391,7 +387,6 @@@ static php_http_encoding_stream_t *infl
  {
        int status, wbits, p = (s->flags & PHP_HTTP_ENCODING_STREAM_PERSISTENT);
        z_streamp ctx = pecalloc(1, sizeof(z_stream), p);
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        PHP_HTTP_INFLATE_WBITS_SET(s->flags, wbits);
        
                status = Z_MEM_ERROR;
        }
        pefree(ctx, p);
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to initialize inflate stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to initialize inflate stream: %s", zError(status));
        return NULL;
  }
  
@@@ -421,6 -427,7 +422,6 @@@ static php_http_encoding_stream_t *defl
  {
        int status, p = to->flags & PHP_HTTP_ENCODING_STREAM_PERSISTENT;
        z_streamp from_ctx = from->ctx, to_ctx = pecalloc(1, sizeof(*to_ctx), p);
 -      TSRMLS_FETCH_FROM_CTX(from->ts);
  
        if (Z_OK == (status = deflateCopy(to_ctx, from_ctx))) {
                if ((to_ctx->opaque = php_http_buffer_init_ex(NULL, PHP_HTTP_DEFLATE_BUFFER_SIZE, p ? PHP_HTTP_BUFFER_INIT_PERSISTENT : 0))) {
                deflateEnd(to_ctx);
                status = Z_MEM_ERROR;
        }
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to copy deflate encoding stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to copy deflate encoding stream: %s", zError(status));
        return NULL;
  }
  
@@@ -439,6 -446,7 +440,6 @@@ static php_http_encoding_stream_t *infl
  {
        int status, p = from->flags & PHP_HTTP_ENCODING_STREAM_PERSISTENT;
        z_streamp from_ctx = from->ctx, to_ctx = pecalloc(1, sizeof(*to_ctx), p);
 -      TSRMLS_FETCH_FROM_CTX(from->ts);
  
        if (Z_OK == (status = inflateCopy(to_ctx, from_ctx))) {
                if ((to_ctx->opaque = php_http_buffer_init_ex(NULL, PHP_HTTP_DEFLATE_BUFFER_SIZE, p ? PHP_HTTP_BUFFER_INIT_PERSISTENT : 0))) {
                inflateEnd(to_ctx);
                status = Z_MEM_ERROR;
        }
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to copy inflate encoding stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to copy inflate encoding stream: %s", zError(status));
        return NULL;
  }
  
@@@ -457,6 -465,7 +458,6 @@@ static php_http_encoding_stream_t *dech
  {
        int p = from->flags & PHP_HTTP_ENCODING_STREAM_PERSISTENT;
        struct dechunk_ctx *from_ctx = from->ctx, *to_ctx = pemalloc(sizeof(*to_ctx), p);
 -      TSRMLS_FETCH_FROM_CTX(from->ts);
  
        if (php_http_buffer_init_ex(&to_ctx->buffer, PHP_HTTP_BUFFER_DEFAULT_SIZE, p ? PHP_HTTP_BUFFER_INIT_PERSISTENT : 0)) {
                to_ctx->hexlen = from_ctx->hexlen;
                return to;
        }
        pefree(to_ctx, p);
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to copy inflate encoding stream: out of memory");
 +      php_error_docref(NULL, E_WARNING, "Failed to copy inflate encoding stream: out of memory");
        return NULL;
  }
  
@@@ -474,6 -483,7 +475,6 @@@ static ZEND_RESULT_CODE deflate_update(
  {
        int status;
        z_streamp ctx = s->ctx;
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        /* append input to our buffer */
        php_http_buffer_append(PHP_HTTP_BUFFER(ctx->opaque), data, data_len);
        
        PTR_SET(*encoded, NULL);
        *encoded_len = 0;
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to update deflate stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to update deflate stream: %s", zError(status));
        return FAILURE;
  }
  
@@@ -514,6 -524,7 +515,6 @@@ static ZEND_RESULT_CODE inflate_update(
  {
        int status;
        z_streamp ctx = s->ctx;
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        /* append input to buffer */
        php_http_buffer_append(PHP_HTTP_BUFFER(ctx->opaque), data, data_len);
@@@ -544,7 -555,7 +545,7 @@@ retry_raw_inflate
                        break;
        }
        
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to update inflate stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to update inflate stream: %s", zError(status));
        return FAILURE;
  }
  
@@@ -552,9 -563,10 +553,9 @@@ static ZEND_RESULT_CODE dechunk_update(
  {
        php_http_buffer_t tmp;
        struct dechunk_ctx *ctx = s->ctx;
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
  
        if (ctx->zeroed) {
 -              php_error_docref(NULL TSRMLS_CC, E_WARNING, "Dechunk encoding stream has already reached the end of chunked input");
 +              php_error_docref(NULL, E_WARNING, "Dechunk encoding stream has already reached the end of chunked input");
                return FAILURE;
        }
        if ((PHP_HTTP_BUFFER_NOMEM == php_http_buffer_append(&ctx->buffer, data, data_len)) || !php_http_buffer_fix(&ctx->buffer)) {
                                        /*      if strtoul() stops at the beginning of the buffered data
                                                there's something oddly wrong, i.e. bad input */
                                        if (stop == ctx->buffer.data) {
 -                                              php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to parse chunk len from '%.*s'", (int) MIN(16, ctx->buffer.used), ctx->buffer.data);
 +                                              php_error_docref(NULL, E_WARNING, "Failed to parse chunk len from '%.*s'", (int) MIN(16, ctx->buffer.used), ctx->buffer.data);
                                                php_http_buffer_dtor(&tmp);
                                                return FAILURE;
                                        }
@@@ -679,6 -691,7 +680,6 @@@ static ZEND_RESULT_CODE deflate_flush(p
  {
        int status;
        z_streamp ctx = s->ctx;
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        *encoded_len = PHP_HTTP_DEFLATE_BUFFER_SIZE;
        *encoded = emalloc(*encoded_len);
        
        PTR_SET(*encoded, NULL);
        *encoded_len = 0;
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to flush deflate stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to flush deflate stream: %s", zError(status));
        return FAILURE;
  }
  
@@@ -727,6 -740,7 +728,6 @@@ static ZEND_RESULT_CODE deflate_finish(
  {
        int status;
        z_streamp ctx = s->ctx;
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        *encoded_len = PHP_HTTP_DEFLATE_BUFFER_SIZE;
        *encoded = emalloc(*encoded_len);
        
        PTR_SET(*encoded, NULL);
        *encoded_len = 0;
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to finish deflate stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to finish deflate stream: %s", zError(status));
        return FAILURE;
  }
  
@@@ -763,6 -777,7 +764,6 @@@ static ZEND_RESULT_CODE inflate_finish(
  {
        int status;
        z_streamp ctx = s->ctx;
 -      TSRMLS_FETCH_FROM_CTX(s->ts);
        
        if (!PHP_HTTP_BUFFER(ctx->opaque)->used) {
                *decoded = NULL;
        
        PTR_SET(*decoded, NULL);
        *decoded_len = 0;
 -      php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to finish inflate stream: %s", zError(status));
 +      php_error_docref(NULL, E_WARNING, "Failed to finish inflate stream: %s", zError(status));
        return FAILURE;
  }
  
@@@ -900,68 -915,53 +901,68 @@@ php_http_encoding_stream_ops_t *php_htt
  
  static zend_object_handlers php_http_encoding_stream_object_handlers;
  
 -zend_object_value php_http_encoding_stream_object_new(zend_class_entry *ce TSRMLS_DC)
 +zend_object *php_http_encoding_stream_object_new(zend_class_entry *ce)
  {
 -      return php_http_encoding_stream_object_new_ex(ce, NULL, NULL TSRMLS_CC);
 +      return &php_http_encoding_stream_object_new_ex(ce, NULL)->zo;
  }
  
 -zend_object_value php_http_encoding_stream_object_new_ex(zend_class_entry *ce, php_http_encoding_stream_t *s, php_http_encoding_stream_object_t **ptr TSRMLS_DC)
 +php_http_encoding_stream_object_t *php_http_encoding_stream_object_new_ex(zend_class_entry *ce, php_http_encoding_stream_t *s)
  {
        php_http_encoding_stream_object_t *o;
  
 -      o = ecalloc(1, sizeof(*o));
 -      zend_object_std_init((zend_object *) o, ce TSRMLS_CC);
 -      object_properties_init((zend_object *) o, ce);
 -
 -      if (ptr) {
 -              *ptr = o;
 -      }
 +      o = ecalloc(1, sizeof(*o) + zend_object_properties_size(ce));
 +      zend_object_std_init(&o->zo, ce);
 +      object_properties_init(&o->zo, ce);
  
        if (s) {
                o->stream = s;
        }
  
 -      o->zv.handle = zend_objects_store_put((zend_object *) o, NULL, php_http_encoding_stream_object_free, NULL TSRMLS_CC);
 -      o->zv.handlers = &php_http_encoding_stream_object_handlers;
 +      o->zo.handlers = &php_http_encoding_stream_object_handlers;
  
 -      return o->zv;
 +      return o;
  }
  
 -zend_object_value php_http_encoding_stream_object_clone(zval *this_ptr TSRMLS_DC)
 +zend_object *php_http_encoding_stream_object_clone(zval *object)
  {
 -      zend_object_value new_ov;
 -      php_http_encoding_stream_object_t *new_obj = NULL, *old_obj = zend_object_store_get_object(getThis() TSRMLS_CC);
 +      php_http_encoding_stream_object_t *new_obj = NULL, *old_obj = PHP_HTTP_OBJ(NULL, object);
 +      php_http_encoding_stream_t *cpy = php_http_encoding_stream_copy(old_obj->stream, NULL);
  
 -      new_ov = php_http_encoding_stream_object_new_ex(old_obj->zo.ce, php_http_encoding_stream_copy(old_obj->stream, NULL), &new_obj TSRMLS_CC);
 -      zend_objects_clone_members(&new_obj->zo, new_ov, &old_obj->zo, Z_OBJ_HANDLE_P(this_ptr) TSRMLS_CC);
 +      new_obj = php_http_encoding_stream_object_new_ex(old_obj->zo.ce, cpy);
 +      zend_objects_clone_members(&new_obj->zo, &old_obj->zo);
  
 -      return new_ov;
 +      return &new_obj->zo;
  }
  
 -void php_http_encoding_stream_object_free(void *object TSRMLS_DC)
 +void php_http_encoding_stream_object_free(zend_object *object)
  {
 -      php_http_encoding_stream_object_t *o = (php_http_encoding_stream_object_t *) object;
 +      php_http_encoding_stream_object_t *o = PHP_HTTP_OBJ(object, NULL);
  
        if (o->stream) {
                php_http_encoding_stream_free(&o->stream);
        }
 -      zend_object_std_dtor((zend_object *) o TSRMLS_CC);
 -      efree(o);
 +      zend_object_std_dtor(object);
 +}
 +
 +static zend_class_entry *php_http_encoding_stream_class_entry;
 +zend_class_entry *php_http_get_encoding_stream_class_entry(void)
 +{
 +      return php_http_encoding_stream_class_entry;
 +}
 +static zend_class_entry *php_http_deflate_stream_class_entry;
 +zend_class_entry *php_http_get_deflate_stream_class_entry(void)
 +{
 +      return php_http_deflate_stream_class_entry;
 +}
 +static zend_class_entry *php_http_inflate_stream_class_entry;
 +zend_class_entry *php_http_get_inflate_stream_class_entry(void)
 +{
 +      return php_http_inflate_stream_class_entry;
 +}
 +static zend_class_entry *php_http_dechunk_stream_class_entry;
 +zend_class_entry *php_http_get_dechunk_stream_class_entry(void)
 +{
 +      return php_http_dechunk_stream_class_entry;
  }
  
  ZEND_BEGIN_ARG_INFO_EX(ai_HttpEncodingStream___construct, 0, 0, 0)
  ZEND_END_ARG_INFO();
  static PHP_METHOD(HttpEncodingStream, __construct)
  {
 -      long flags = 0;
 +      zend_long flags = 0;
        php_http_encoding_stream_object_t *obj;
        php_http_encoding_stream_ops_t *ops;
  
 -      php_http_expect(SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|l", &flags), invalid_arg, return);
 +      php_http_expect(SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS(), "|l", &flags), invalid_arg, return);
  
 -      obj = zend_object_store_get_object(getThis() TSRMLS_CC);
 +      obj = PHP_HTTP_OBJ(NULL, getThis());
  
        if (obj->stream) {
                php_http_throw(bad_method_call, "http\\Encoding\\Stream cannot be initialized twice", NULL);
                return;
        }
  
 -      if (instanceof_function(obj->zo.ce, php_http_deflate_stream_class_entry TSRMLS_CC)) {
 +      if (instanceof_function(obj->zo.ce, php_http_deflate_stream_class_entry)) {
                ops = &php_http_encoding_deflate_ops;
 -      } else if (instanceof_function(obj->zo.ce, php_http_inflate_stream_class_entry TSRMLS_CC)) {
 +      } else if (instanceof_function(obj->zo.ce, php_http_inflate_stream_class_entry)) {
                ops = &php_http_encoding_inflate_ops;
 -      } else if (instanceof_function(obj->zo.ce, php_http_dechunk_stream_class_entry TSRMLS_CC)) {
 +      } else if (instanceof_function(obj->zo.ce, php_http_dechunk_stream_class_entry)) {
                ops = &php_http_encoding_dechunk_ops;
        } else {
 -              php_http_throw(runtime, "Unknown http\\Encoding\\Stream class '%s'", obj->zo.ce->name);
 +              php_http_throw(runtime, "Unknown http\\Encoding\\Stream class '%s'", obj->zo.ce->name->val);
                return;
        }
  
 -      php_http_expect(obj->stream = php_http_encoding_stream_init(obj->stream, ops, flags TSRMLS_CC), runtime, return);
 +      php_http_expect(obj->stream = php_http_encoding_stream_init(obj->stream, ops, flags), runtime, return);
  }
  
  ZEND_BEGIN_ARG_INFO_EX(ai_HttpEncodingStream_update, 0, 0, 1)
  ZEND_END_ARG_INFO();
  static PHP_METHOD(HttpEncodingStream, update)
  {
 -      int data_len;
 +      size_t data_len;
        char *data_str;
  
 -      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &data_str, &data_len)) {
 -              php_http_encoding_stream_object_t *obj = zend_object_store_get_object(getThis() TSRMLS_CC);
 +      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS(), "s", &data_str, &data_len)) {
 +              php_http_encoding_stream_object_t *obj = PHP_HTTP_OBJ(NULL, getThis());
  
                if (obj->stream) {
 +                      char *encoded_str = NULL;
                        size_t encoded_len;
 -                      char *encoded_str;
  
                        if (SUCCESS == php_http_encoding_stream_update(obj->stream, data_str, data_len, &encoded_str, &encoded_len)) {
 -                              RETURN_STRINGL(encoded_str, encoded_len, 0);
 +                              if (encoded_str) {
 +                                      RETURN_STR(php_http_cs2zs(encoded_str, encoded_len));
 +                              } else {
 +                                      RETURN_EMPTY_STRING();
 +                              }
                        }
                }
        }
@@@ -1027,15 -1023,15 +1028,15 @@@ ZEND_END_ARG_INFO()
  static PHP_METHOD(HttpEncodingStream, flush)
  {
        if (SUCCESS == zend_parse_parameters_none()) {
 -              php_http_encoding_stream_object_t *obj = zend_object_store_get_object(getThis() TSRMLS_CC);
 +              php_http_encoding_stream_object_t *obj = PHP_HTTP_OBJ(NULL, getThis());
  
                if (obj->stream) {
 -                      char *encoded_str;
 +                      char *encoded_str = NULL;
                        size_t encoded_len;
  
                        if (SUCCESS == php_http_encoding_stream_flush(obj->stream, &encoded_str, &encoded_len)) {
                                if (encoded_str) {
 -                                      RETURN_STRINGL(encoded_str, encoded_len, 0);
 +                                      RETURN_STR(php_http_cs2zs(encoded_str, encoded_len));
                                } else {
                                        RETURN_EMPTY_STRING();
                                }
@@@ -1049,7 -1045,7 +1050,7 @@@ ZEND_END_ARG_INFO()
  static PHP_METHOD(HttpEncodingStream, done)
  {
        if (SUCCESS == zend_parse_parameters_none()) {
 -              php_http_encoding_stream_object_t *obj = zend_object_store_get_object(getThis() TSRMLS_CC);
 +              php_http_encoding_stream_object_t *obj = PHP_HTTP_OBJ(NULL, getThis());
  
                if (obj->stream) {
                        RETURN_BOOL(php_http_encoding_stream_done(obj->stream));
@@@ -1062,16 -1058,16 +1063,16 @@@ ZEND_END_ARG_INFO()
  static PHP_METHOD(HttpEncodingStream, finish)
  {
        if (SUCCESS == zend_parse_parameters_none()) {
 -              php_http_encoding_stream_object_t *obj = zend_object_store_get_object(getThis() TSRMLS_CC);
 +              php_http_encoding_stream_object_t *obj = PHP_HTTP_OBJ(NULL, getThis());
  
                if (obj->stream) {
 -                      char *encoded_str;
 +                      char *encoded_str = NULL;
                        size_t encoded_len;
  
                        if (SUCCESS == php_http_encoding_stream_finish(obj->stream, &encoded_str, &encoded_len)) {
                                if (SUCCESS == php_http_encoding_stream_reset(&obj->stream)) {
                                        if (encoded_str) {
 -                                              RETURN_STRINGL(encoded_str, encoded_len, 0);
 +                                              RETURN_STR(php_http_cs2zs(encoded_str, encoded_len));
                                        } else {
                                                RETURN_EMPTY_STRING();
                                        }
@@@ -1099,19 -1095,15 +1100,19 @@@ ZEND_END_ARG_INFO()
  static PHP_METHOD(HttpDeflateStream, encode)
  {
        char *str;
 -      int len;
 -      long flags = 0;
 +      size_t len;
 +      zend_long flags = 0;
  
 -      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|l", &str, &len, &flags)) {
 -              char *enc_str;
 +      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS(), "s|l", &str, &len, &flags)) {
 +              char *enc_str = NULL;
                size_t enc_len;
  
 -              if (SUCCESS == php_http_encoding_deflate(flags, str, len, &enc_str, &enc_len TSRMLS_CC)) {
 -                      RETURN_STRINGL(enc_str, enc_len, 0);
 +              if (SUCCESS == php_http_encoding_deflate(flags, str, len, &enc_str, &enc_len)) {
 +                      if (enc_str) {
 +                              RETURN_STR(php_http_cs2zs(enc_str, enc_len));
 +                      } else {
 +                              RETURN_EMPTY_STRING();
 +                      }
                }
        }
        RETURN_FALSE;
@@@ -1128,18 -1120,14 +1129,18 @@@ ZEND_END_ARG_INFO()
  static PHP_METHOD(HttpInflateStream, decode)
  {
        char *str;
 -      int len;
 +      size_t len;
  
 -      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &str, &len)) {
 -              char *enc_str;
 +      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS(), "s", &str, &len)) {
 +              char *enc_str = NULL;
                size_t enc_len;
  
 -              if (SUCCESS == php_http_encoding_inflate(str, len, &enc_str, &enc_len TSRMLS_CC)) {
 -                      RETURN_STRINGL(enc_str, enc_len, 0);
 +              if (SUCCESS == php_http_encoding_inflate(str, len, &enc_str, &enc_len)) {
 +                      if (enc_str) {
 +                              RETURN_STR(php_http_cs2zs(enc_str, enc_len));
 +                      } else {
 +                              RETURN_EMPTY_STRING();
 +                      }
                }
        }
        RETURN_FALSE;
@@@ -1157,25 -1145,20 +1158,25 @@@ ZEND_END_ARG_INFO()
  static PHP_METHOD(HttpDechunkStream, decode)
  {
        char *str;
 -      int len;
 +      size_t len;
        zval *zlen = NULL;
  
 -      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|z!", &str, &len, &zlen)) {
 +      if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS(), "s|z!", &str, &len, &zlen)) {
                const char *end_ptr;
 -              char *enc_str;
 +              char *enc_str = NULL;
                size_t enc_len;
  
 -              if ((end_ptr = php_http_encoding_dechunk(str, len, &enc_str, &enc_len TSRMLS_CC))) {
 +              if ((end_ptr = php_http_encoding_dechunk(str, len, &enc_str, &enc_len))) {
                        if (zlen) {
 +                              ZVAL_DEREF(zlen);
                                zval_dtor(zlen);
                                ZVAL_LONG(zlen, str + len - end_ptr);
                        }
 -                      RETURN_STRINGL(enc_str, enc_len, 0);
 +                      if (enc_str) {
 +                              RETURN_STR(php_http_cs2zs(enc_str, enc_len));
 +                      } else {
 +                              RETURN_EMPTY_STRING();
 +                      }
                }
        }
        RETURN_FALSE;
@@@ -1186,49 -1169,49 +1187,49 @@@ static zend_function_entry php_http_dec
        EMPTY_FUNCTION_ENTRY
  };
  
 -zend_class_entry *php_http_encoding_stream_class_entry;
 -zend_class_entry *php_http_deflate_stream_class_entry;
 -zend_class_entry *php_http_inflate_stream_class_entry;
 -zend_class_entry *php_http_dechunk_stream_class_entry;
 -
  PHP_MINIT_FUNCTION(http_encoding)
  {
        zend_class_entry ce = {0};
  
        INIT_NS_CLASS_ENTRY(ce, "http\\Encoding", "Stream", php_http_encoding_stream_methods);
 -      php_http_encoding_stream_class_entry = zend_register_internal_class(&ce TSRMLS_CC);
 +      php_http_encoding_stream_class_entry = zend_register_internal_class(&ce);
        php_http_encoding_stream_class_entry->ce_flags |= ZEND_ACC_EXPLICIT_ABSTRACT_CLASS;
        php_http_encoding_stream_class_entry->create_object = php_http_encoding_stream_object_new;
        memcpy(&php_http_encoding_stream_object_handlers, zend_get_std_object_handlers(), sizeof(zend_object_handlers));
 +      php_http_encoding_stream_object_handlers.offset = XtOffsetOf(php_http_encoding_stream_object_t, zo);
        php_http_encoding_stream_object_handlers.clone_obj = php_http_encoding_stream_object_clone;
 +      php_http_encoding_stream_object_handlers.free_obj = php_http_encoding_stream_object_free;
  
 -      zend_declare_class_constant_long(php_http_encoding_stream_class_entry, ZEND_STRL("FLUSH_NONE"), PHP_HTTP_ENCODING_STREAM_FLUSH_NONE TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_encoding_stream_class_entry, ZEND_STRL("FLUSH_SYNC"), PHP_HTTP_ENCODING_STREAM_FLUSH_SYNC TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_encoding_stream_class_entry, ZEND_STRL("FLUSH_FULL"), PHP_HTTP_ENCODING_STREAM_FLUSH_FULL TSRMLS_CC);
 +      zend_declare_class_constant_long(php_http_encoding_stream_class_entry, ZEND_STRL("FLUSH_NONE"), PHP_HTTP_ENCODING_STREAM_FLUSH_NONE);
 +      zend_declare_class_constant_long(php_http_encoding_stream_class_entry, ZEND_STRL("FLUSH_SYNC"), PHP_HTTP_ENCODING_STREAM_FLUSH_SYNC);
 +      zend_declare_class_constant_long(php_http_encoding_stream_class_entry, ZEND_STRL("FLUSH_FULL"), PHP_HTTP_ENCODING_STREAM_FLUSH_FULL);
  
        memset(&ce, 0, sizeof(ce));
        INIT_NS_CLASS_ENTRY(ce, "http\\Encoding\\Stream", "Deflate", php_http_deflate_stream_methods);
 -      php_http_deflate_stream_class_entry = zend_register_internal_class_ex(&ce, php_http_encoding_stream_class_entry, NULL TSRMLS_CC);
 -
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("TYPE_GZIP"), PHP_HTTP_DEFLATE_TYPE_GZIP TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("TYPE_ZLIB"), PHP_HTTP_DEFLATE_TYPE_ZLIB TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("TYPE_RAW"), PHP_HTTP_DEFLATE_TYPE_RAW TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("LEVEL_DEF"), PHP_HTTP_DEFLATE_LEVEL_DEF TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("LEVEL_MIN"), PHP_HTTP_DEFLATE_LEVEL_MIN TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("LEVEL_MAX"), PHP_HTTP_DEFLATE_LEVEL_MAX TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_DEF"), PHP_HTTP_DEFLATE_STRATEGY_DEF TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_FILT"), PHP_HTTP_DEFLATE_STRATEGY_FILT TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_HUFF"), PHP_HTTP_DEFLATE_STRATEGY_HUFF TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_RLE"), PHP_HTTP_DEFLATE_STRATEGY_RLE TSRMLS_CC);
 -      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_FIXED"), PHP_HTTP_DEFLATE_STRATEGY_FIXED TSRMLS_CC);
 +      php_http_deflate_stream_class_entry = zend_register_internal_class_ex(&ce, php_http_encoding_stream_class_entry);
 +      php_http_deflate_stream_class_entry->create_object = php_http_encoding_stream_object_new;
 +
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("TYPE_GZIP"), PHP_HTTP_DEFLATE_TYPE_GZIP);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("TYPE_ZLIB"), PHP_HTTP_DEFLATE_TYPE_ZLIB);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("TYPE_RAW"), PHP_HTTP_DEFLATE_TYPE_RAW);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("LEVEL_DEF"), PHP_HTTP_DEFLATE_LEVEL_DEF);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("LEVEL_MIN"), PHP_HTTP_DEFLATE_LEVEL_MIN);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("LEVEL_MAX"), PHP_HTTP_DEFLATE_LEVEL_MAX);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_DEF"), PHP_HTTP_DEFLATE_STRATEGY_DEF);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_FILT"), PHP_HTTP_DEFLATE_STRATEGY_FILT);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_HUFF"), PHP_HTTP_DEFLATE_STRATEGY_HUFF);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_RLE"), PHP_HTTP_DEFLATE_STRATEGY_RLE);
 +      zend_declare_class_constant_long(php_http_deflate_stream_class_entry, ZEND_STRL("STRATEGY_FIXED"), PHP_HTTP_DEFLATE_STRATEGY_FIXED);
  
        memset(&ce, 0, sizeof(ce));
        INIT_NS_CLASS_ENTRY(ce, "http\\Encoding\\Stream", "Inflate", php_http_inflate_stream_methods);
 -      php_http_inflate_stream_class_entry = zend_register_internal_class_ex(&ce, php_http_encoding_stream_class_entry, NULL TSRMLS_CC);
 +      php_http_inflate_stream_class_entry = zend_register_internal_class_ex(&ce, php_http_encoding_stream_class_entry);
 +      php_http_inflate_stream_class_entry->create_object = php_http_encoding_stream_object_new;
  
        memset(&ce, 0, sizeof(ce));
        INIT_NS_CLASS_ENTRY(ce, "http\\Encoding\\Stream", "Dechunk", php_http_dechunk_stream_methods);
 -      php_http_dechunk_stream_class_entry = zend_register_internal_class_ex(&ce, php_http_encoding_stream_class_entry, NULL TSRMLS_CC);
 +      php_http_dechunk_stream_class_entry = zend_register_internal_class_ex(&ce, php_http_encoding_stream_class_entry);
 +      php_http_dechunk_stream_class_entry->create_object = php_http_encoding_stream_object_new;
  
        return SUCCESS;
  }