fix for changed shutdown order in PHP-7.4
[m6w6/ext-http] / src / php_http_misc.c
index 9873ff85ebdd4ee1424164f9185b786aabab38a3..f0cc25fa32e0d2bf07eac0ef2295d839d009f741 100644 (file)
 
 void php_http_sleep(double s)
 {
-#if defined(PHP_WIN32)
+#if PHP_WIN32
        Sleep((DWORD) PHP_HTTP_MSEC(s));
-#elif defined(HAVE_USLEEP)
+#elif HAVE_USLEEP
        usleep(PHP_HTTP_USEC(s));
-#elif defined(HAVE_NANOSLEEP)
+#elif HAVE_NANOSLEEP
        struct timespec req, rem;
 
        req.tv_sec = (time_t) s;
@@ -50,11 +50,11 @@ int php_http_match(const char *haystack_str, const char *needle_str, int flags)
 {
        int result = 0;
 
-       if (!haystack_str || !needle_str) {
+       if (UNEXPECTED(!haystack_str || !needle_str)) {
                return result;
        }
 
-       if (flags & PHP_HTTP_MATCH_FULL) {
+       if (UNEXPECTED(flags & PHP_HTTP_MATCH_FULL)) {
                if (flags & PHP_HTTP_MATCH_CASE) {
                        result = !strcmp(haystack_str, needle_str);
                } else {
@@ -64,7 +64,7 @@ int php_http_match(const char *haystack_str, const char *needle_str, int flags)
                const char *found;
                char *haystack = estrdup(haystack_str), *needle = estrdup(needle_str);
 
-               if (flags & PHP_HTTP_MATCH_CASE) {
+               if (UNEXPECTED(flags & PHP_HTTP_MATCH_CASE)) {
                        found = zend_memnstr(haystack, needle, strlen(needle), haystack+strlen(haystack));
                } else {
                        found = php_stristr(haystack, needle, strlen(haystack), strlen(needle));
@@ -73,7 +73,7 @@ int php_http_match(const char *haystack_str, const char *needle_str, int flags)
                if (found) {
                        if (!(flags & PHP_HTTP_MATCH_WORD)
                        ||      (       (found == haystack || !PHP_HTTP_IS_CTYPE(alnum, *(found - 1)))
-                               &&      (!*(found + strlen(needle)) || !PHP_HTTP_IS_CTYPE(alnum, *(found + strlen(needle))))
+                               &&      EXPECTED(!*(found + strlen(needle)) || !PHP_HTTP_IS_CTYPE(alnum, *(found + strlen(needle))))
                                )
                        ) {
                                result = 1;
@@ -87,35 +87,45 @@ int php_http_match(const char *haystack_str, const char *needle_str, int flags)
        return result;
 }
 
-char *php_http_pretty_key(register char *key, size_t key_len, zend_bool uctitle, zend_bool xhyphen)
+char *php_http_pretty_key(char *key, size_t key_len, zend_bool uctitle, zend_bool xhyphen)
 {
-       size_t i = 1;
+       size_t i;
        int wasalpha;
 
        if (key && key_len) {
-               if ((wasalpha = PHP_HTTP_IS_CTYPE(alpha, key[0]))) {
-                       key[0] = (char) (uctitle ? PHP_HTTP_TO_CTYPE(upper, key[0]) : PHP_HTTP_TO_CTYPE(lower, key[0]));
+               if (EXPECTED(wasalpha = PHP_HTTP_IS_CTYPE(alpha, key[0]))) {
+                       if (EXPECTED(uctitle)) {
+                               key[0] = PHP_HTTP_TO_CTYPE(upper, key[0]);
+                       } else {
+                               key[0] = PHP_HTTP_TO_CTYPE(lower, key[0]);
+                       }
                }
-               PHP_HTTP_DUFF(key_len,
-                       if (PHP_HTTP_IS_CTYPE(alpha, key[i])) {
-                               key[i] = (char) (((!wasalpha) && uctitle) ? PHP_HTTP_TO_CTYPE(upper, key[i]) : PHP_HTTP_TO_CTYPE(lower, key[i]));
-                               wasalpha = 1;
+               for (i = 1; i < key_len; ++i) {
+                       if (EXPECTED(PHP_HTTP_IS_CTYPE(alpha, key[i]))) {
+                               if (EXPECTED(wasalpha)) {
+                                       key[i] = PHP_HTTP_TO_CTYPE(lower, key[i]);
+                               } else if (EXPECTED(uctitle)) {
+                                       key[i] = PHP_HTTP_TO_CTYPE(upper, key[i]);
+                                       wasalpha = 1;
+                               } else {
+                                       key[i] = PHP_HTTP_TO_CTYPE(lower, key[i]);
+                                       wasalpha = 1;
+                               }
                        } else {
-                               if (xhyphen && (key[i] == '_')) {
+                               if (EXPECTED(xhyphen && (key[i] == '_'))) {
                                        key[i] = '-';
                                }
                                wasalpha = 0;
                        }
-                       ++i;
-               );
+               }
        }
        return key;
 }
 
 
-size_t php_http_boundary(char *buf, size_t buf_len TSRMLS_DC)
+size_t php_http_boundary(char *buf, size_t buf_len)
 {
-       return snprintf(buf, buf_len, "%15.15F", sapi_get_request_time(TSRMLS_C) * php_combined_lcg(TSRMLS_C));
+       return snprintf(buf, buf_len, "%15.15F", sapi_get_request_time() * php_combined_lcg());
 }
 
 int php_http_select_str(const char *cmp, int argc, ...)
@@ -144,73 +154,65 @@ int php_http_select_str(const char *cmp, int argc, ...)
 
 /* ARRAYS */
 
-unsigned php_http_array_list(HashTable *ht TSRMLS_DC, unsigned argc, ...)
+unsigned php_http_array_list(HashTable *ht, unsigned argc, ...)
 {
-       HashPosition pos;
        unsigned argl = 0;
        va_list argv;
+       zval *data;
 
        va_start(argv, argc);
-       for (   zend_hash_internal_pointer_reset_ex(ht, &pos);
-                       SUCCESS == zend_hash_has_more_elements_ex(ht, &pos) && (argl < argc);
-                       zend_hash_move_forward_ex(ht, &pos))
-       {
-               zval **data, ***argp = (zval ***) va_arg(argv, zval ***);
-
-               if (SUCCESS == zend_hash_get_current_data_ex(ht, (void *) &data, &pos)) {
-                       *argp = data;
-                       ++argl;
-               }
-       }
+       ZEND_HASH_FOREACH_VAL(ht, data) {
+               zval **argp = (zval **) va_arg(argv, zval **);
+               *argp = data;
+               ++argl;
+       } ZEND_HASH_FOREACH_END();
        va_end(argv);
 
        return argl;
 }
 
-void php_http_array_copy_strings(void *zpp)
+void php_http_array_copy_strings(zval *zp)
 {
-       zval **zvpp = ((zval **) zpp);
-
-       *zvpp = php_http_zsep(1, IS_STRING, *zvpp);
+       Z_TRY_ADDREF_P(zp);
+       convert_to_string_ex(zp);
 }
 
-int php_http_array_apply_append_func(void *pDest TSRMLS_DC, int num_args, va_list args, zend_hash_key *hash_key)
+int php_http_array_apply_append_func(zval *value, int num_args, va_list args, zend_hash_key *hash_key)
 {
        int flags;
        char *key = NULL;
        HashTable *dst;
-       zval **data = NULL, *value = *((zval **) pDest);
+       zval *data = NULL;
 
        dst = va_arg(args, HashTable *);
        flags = va_arg(args, int);
 
-       if ((!(flags & ARRAY_JOIN_STRONLY)) || hash_key->nKeyLength) {
-               if ((flags & ARRAY_JOIN_PRETTIFY) && hash_key->nKeyLength) {
-                       key = php_http_pretty_key(estrndup(hash_key->arKey, hash_key->nKeyLength - 1), hash_key->nKeyLength - 1, 1, 1);
-                       zend_hash_find(dst, key, hash_key->nKeyLength, (void *) &data);
-               } else if (hash_key->nKeyLength) {
-                       zend_hash_quick_find(dst, hash_key->arKey, hash_key->nKeyLength, hash_key->h, (void *) &data);
+       if ((!(flags & ARRAY_JOIN_STRONLY)) || hash_key->key) {
+               if ((flags & ARRAY_JOIN_PRETTIFY) && hash_key->key) {
+                       key = php_http_pretty_key(estrndup(hash_key->key->val, hash_key->key->len), hash_key->key->len, 1, 1);
+                       data = zend_hash_str_find(dst, key, hash_key->key->len);
+               } else if (hash_key->key) {
+                       data = zend_hash_find(dst, hash_key->key);
                } else {
-                       zend_hash_index_find(dst, hash_key->h, (void *) &data);
+                       data = zend_hash_index_find(dst, hash_key->h);
                }
 
                if (flags & ARRAY_JOIN_STRINGIFY) {
-                       value = php_http_zsep(1, IS_STRING, value);
-               } else {
-                       Z_ADDREF_P(value);
+                       convert_to_string_ex(value);
                }
+               Z_TRY_ADDREF_P(value);
 
                if (data) {
-                       if (Z_TYPE_PP(data) != IS_ARRAY) {
-                               convert_to_array(*data);
+                       if (Z_TYPE_P(data) != IS_ARRAY) {
+                               convert_to_array(data);
                        }
-                       add_next_index_zval(*data, value);
+                       add_next_index_zval(data, value);
                } else if (key) {
-                       zend_symtable_update(dst, key, hash_key->nKeyLength, &value, sizeof(zval *), NULL);
-               } else if (hash_key->nKeyLength) {
-                       zend_hash_quick_add(dst, hash_key->arKey, hash_key->nKeyLength, hash_key->h, &value, sizeof(zval *), NULL);
+                       zend_hash_str_update(dst, key, hash_key->key->len, value);
+               } else if (hash_key->key) {
+                       zend_hash_update(dst, hash_key->key, value);
                } else {
-                       zend_hash_index_update(dst, hash_key->h, (void *) &value, sizeof(zval *), NULL);
+                       zend_hash_index_update(dst, hash_key->h, value);
                }
 
                if (key) {
@@ -221,31 +223,30 @@ int php_http_array_apply_append_func(void *pDest TSRMLS_DC, int num_args, va_lis
        return ZEND_HASH_APPLY_KEEP;
 }
 
-int php_http_array_apply_merge_func(void *pDest TSRMLS_DC, int num_args, va_list args, zend_hash_key *hash_key)
+int php_http_array_apply_merge_func(zval *value, int num_args, va_list args, zend_hash_key *hash_key)
 {
        int flags;
        char *key = NULL;
        HashTable *dst;
-       zval *value = *((zval **) pDest);
 
        dst = va_arg(args, HashTable *);
        flags = va_arg(args, int);
 
-       if ((!(flags & ARRAY_JOIN_STRONLY)) || hash_key->nKeyLength) {
+       if ((!(flags & ARRAY_JOIN_STRONLY)) || hash_key->key) {
                if (flags & ARRAY_JOIN_STRINGIFY) {
-                       value = php_http_zsep(1, IS_STRING, value);
-               } else {
-                       Z_ADDREF_P(value);
+                       convert_to_string_ex(value);
                }
 
-               if ((flags & ARRAY_JOIN_PRETTIFY) && hash_key->nKeyLength) {
-                       key = php_http_pretty_key(estrndup(hash_key->arKey, hash_key->nKeyLength - 1), hash_key->nKeyLength - 1, 1, 1);
-                       zend_hash_update(dst, key, hash_key->nKeyLength, (void *) &value, sizeof(zval *), NULL);
+               Z_TRY_ADDREF_P(value);
+
+               if ((flags & ARRAY_JOIN_PRETTIFY) && hash_key->key) {
+                       key = php_http_pretty_key(estrndup(hash_key->key->val, hash_key->key->len), hash_key->key->len, 1, 1);
+                       zend_hash_str_update(dst, key, hash_key->key->len, value);
                        efree(key);
-               } else if (hash_key->nKeyLength) {
-                       zend_hash_quick_update(dst, hash_key->arKey, hash_key->nKeyLength, hash_key->h, (void *) &value, sizeof(zval *), NULL);
+               } else if (hash_key->key) {
+                       zend_hash_update(dst, hash_key->key, value);
                } else {
-                       zend_hash_index_update(dst, hash_key->h, (void *) &value, sizeof(zval *), NULL);
+                       zend_hash_index_update(dst, hash_key->h, value);
                }
        }
 
@@ -257,13 +258,11 @@ int php_http_array_apply_merge_func(void *pDest TSRMLS_DC, int num_args, va_list
 size_t php_http_pass_fcall_callback(void *cb_arg, const char *str, size_t len)
 {
        php_http_pass_fcall_arg_t *fcd = cb_arg;
-       zval *zdata;
-       TSRMLS_FETCH_FROM_CTX(fcd->ts);
+       zval zdata;
 
-       MAKE_STD_ZVAL(zdata);
-       ZVAL_STRINGL(zdata, str, len, 1);
-       if (SUCCESS == zend_fcall_info_argn(&fcd->fci TSRMLS_CC, 2, &fcd->fcz, &zdata)) {
-               zend_fcall_info_call(&fcd->fci, &fcd->fcc, NULL, NULL TSRMLS_CC);
+       ZVAL_STRINGL(&zdata, str, len);
+       if (SUCCESS == zend_fcall_info_argn(&fcd->fci, 2, &fcd->fcz, &zdata)) {
+               zend_fcall_info_call(&fcd->fci, &fcd->fcc, NULL, NULL);
                zend_fcall_info_args_clear(&fcd->fci, 0);
        }
        zval_ptr_dtor(&zdata);