code cleanup

[m6w6/ext-http] / php_http_env_request.c

diff --git a/php_http_env_request.c b/php_http_env_request.c
index c11f730bcbe31a1b4498adb2ab05f7eea3256d2a..3e88bd0b7cea4f8cf3631901156bcdf45e94260c 100644 (file)
--- a/php_http_env_request.c
+++ b/php_http_env_request.c
@@ -13,8 +13,6 @@
 #include "php_http_api.h"
 
 
-zend_class_entry *php_http_env_request_class_entry;
-
 #undef PHP_HTTP_BEGIN_ARGS
 #undef PHP_HTTP_EMPTY_ARGS
 #define PHP_HTTP_BEGIN_ARGS(method, req_args)          PHP_HTTP_BEGIN_ARGS_EX(HttpEnvRequest, method, 0, req_args)
@@ -22,13 +20,20 @@ zend_class_entry *php_http_env_request_class_entry;
 #define PHP_HTTP_ENV_REQUEST_ME(method, visibility)    PHP_ME(HttpEnvRequest, method, PHP_HTTP_ARGS(HttpEnvRequest, method), visibility)
 
 PHP_HTTP_EMPTY_ARGS(__construct);
-PHP_HTTP_EMPTY_ARGS(getPost);
+PHP_HTTP_EMPTY_ARGS(getForm);
 PHP_HTTP_EMPTY_ARGS(getQuery);
 PHP_HTTP_EMPTY_ARGS(getFiles);
 
+static zend_class_entry *php_http_env_request_class_entry;
+
+zend_class_entry *php_http_env_request_get_class_entry(void)
+{
+       return php_http_env_request_class_entry;
+}
+
 zend_function_entry php_http_env_request_method_entry[] = {
        PHP_HTTP_ENV_REQUEST_ME(__construct, ZEND_ACC_PUBLIC|ZEND_ACC_CTOR)
-       PHP_HTTP_ENV_REQUEST_ME(getPost, ZEND_ACC_PUBLIC)
+       PHP_HTTP_ENV_REQUEST_ME(getForm, ZEND_ACC_PUBLIC)
        PHP_HTTP_ENV_REQUEST_ME(getQuery, ZEND_ACC_PUBLIC)
        PHP_HTTP_ENV_REQUEST_ME(getFiles, ZEND_ACC_PUBLIC)
 
@@ -119,7 +124,7 @@ static int grab_files(void *zpp TSRMLS_DC, int argc, va_list argv, zend_hash_key
 
 PHP_METHOD(HttpEnvRequest, __construct)
 {
-       with_error_handling(EH_THROW, php_http_exception_class_entry) {
+       with_error_handling(EH_THROW, php_http_exception_get_class_entry()) {
                if (SUCCESS == zend_parse_parameters_none()) {
                        php_http_message_object_t *obj = zend_object_store_get_object(getThis() TSRMLS_CC);
                        zval *zsg;
@@ -130,19 +135,21 @@ PHP_METHOD(HttpEnvRequest, __construct)
                                zval *zquery;
 
                                MAKE_STD_ZVAL(zquery);
-                               object_init_ex(zquery, php_http_querystring_class_entry);
+                               object_init_ex(zquery, php_http_querystring_get_class_entry());
                                if (SUCCESS == php_http_querystring_ctor(zquery, zsg TSRMLS_CC)) {
                                        zend_update_property(php_http_env_request_class_entry, getThis(), ZEND_STRL("query"), zquery TSRMLS_CC);
                                }
+                               zval_ptr_dtor(&zquery);
                        }
                        if ((zsg = php_http_env_get_superglobal(ZEND_STRL("_POST") TSRMLS_CC))) {
                                zval *zpost;
 
                                MAKE_STD_ZVAL(zpost);
-                               object_init_ex(zpost, php_http_querystring_class_entry);
+                               object_init_ex(zpost, php_http_querystring_get_class_entry());
                                if (SUCCESS == php_http_querystring_ctor(zpost, zsg TSRMLS_CC)) {
-                                       zend_update_property(php_http_env_request_class_entry, getThis(), ZEND_STRL("post"), zpost TSRMLS_CC);
+                                       zend_update_property(php_http_env_request_class_entry, getThis(), ZEND_STRL("form"), zpost TSRMLS_CC);
                                }
+                               zval_ptr_dtor(&zpost);
                        }
                        if ((zsg = php_http_env_get_superglobal(ZEND_STRL("_FILES") TSRMLS_CC))) {
                                zval *zfiles;
@@ -152,15 +159,16 @@ PHP_METHOD(HttpEnvRequest, __construct)
                                zend_hash_apply_with_arguments(Z_ARRVAL_P(zsg) TSRMLS_CC, grab_files, 1, zfiles);
 
                                zend_update_property(php_http_env_request_class_entry, getThis(), ZEND_STRL("files"), zfiles TSRMLS_CC);
+                               zval_ptr_dtor(&zfiles);
                        }
                }
        } end_error_handling();
 }
 
-PHP_METHOD(HttpEnvRequest, getPost)
+PHP_METHOD(HttpEnvRequest, getForm)
 {
        if (SUCCESS == zend_parse_parameters_none()) {
-               RETURN_PROP(php_http_env_request_class_entry, "post");
+               RETURN_PROP(php_http_env_request_class_entry, "form");
        }
 }
 
@@ -181,9 +189,9 @@ PHP_METHOD(HttpEnvRequest, getFiles)
 
 PHP_MINIT_FUNCTION(http_env_request)
 {
-       PHP_HTTP_REGISTER_CLASS(http\\Env, Request, http_env_request, php_http_message_class_entry, 0);
+       PHP_HTTP_REGISTER_CLASS(http\\Env, Request, http_env_request, php_http_message_get_class_entry(), 0);
        zend_declare_property_null(php_http_env_request_class_entry, ZEND_STRL("query"), ZEND_ACC_PROTECTED TSRMLS_CC);
-       zend_declare_property_null(php_http_env_request_class_entry, ZEND_STRL("post"), ZEND_ACC_PROTECTED TSRMLS_CC);
+       zend_declare_property_null(php_http_env_request_class_entry, ZEND_STRL("form"), ZEND_ACC_PROTECTED TSRMLS_CC);
        zend_declare_property_null(php_http_env_request_class_entry, ZEND_STRL("files"), ZEND_ACC_PROTECTED TSRMLS_CC);
 
        return SUCCESS;