projects
/
m6w6
/
ext-http
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
|
github
raw
|
inline
| side by side
- poor stream filter for chunked encoding
[m6w6/ext-http]
/
http_request_object.c
diff --git
a/http_request_object.c
b/http_request_object.c
index fbddcc6ec8e470e5f5254b19fe70d91f9ae86db2..2ed979789b009c8a93b2c983baca769b5a50a946 100644
(file)
--- a/
http_request_object.c
+++ b/
http_request_object.c
@@
-778,6
+778,7
@@
PHP_METHOD(HttpRequest, setOptions)
{
char *key = NULL;
ulong idx = 0;
{
char *key = NULL;
ulong idx = 0;
+ HashPosition pos;
zval *opts = NULL, *old_opts, **opt;
getObject(http_request_object, obj);
zval *opts = NULL, *old_opts, **opt;
getObject(http_request_object, obj);
@@
-795,7
+796,7
@@
PHP_METHOD(HttpRequest, setOptions)
}
/* some options need extra attention -- thus cannot use array_merge() directly */
}
/* some options need extra attention -- thus cannot use array_merge() directly */
- FOREACH_KEYVAL(opts, key, idx, opt) {
+ FOREACH_KEYVAL(
pos,
opts, key, idx, opt) {
if (key) {
if (!strcmp(key, "headers")) {
zval **headers;
if (key) {
if (!strcmp(key, "headers")) {
zval **headers;
@@
-1664,15
+1665,17
@@
PHP_METHOD(HttpRequest, getResponseCookie)
ulong idx = 0;
char *key = NULL;
zval **header = NULL;
ulong idx = 0;
char *key = NULL;
zval **header = NULL;
+ HashPosition pos1;
- convert_to_array
_ex(
headers);
- FOREACH_HASH_KEYVAL(Z_ARRVAL_PP(headers), key, idx, header) {
+ convert_to_array
(*
headers);
+ FOREACH_HASH_KEYVAL(
pos1,
Z_ARRVAL_PP(headers), key, idx, header) {
if (key && !strcasecmp(key, "Set-Cookie")) {
/* several cookies? */
if (Z_TYPE_PP(header) == IS_ARRAY) {
zval **cookie;
if (key && !strcasecmp(key, "Set-Cookie")) {
/* several cookies? */
if (Z_TYPE_PP(header) == IS_ARRAY) {
zval **cookie;
+ HashPosition pos2;
- FOREACH_HASH_VAL(Z_ARRVAL_PP(header), cookie) {
+ FOREACH_HASH_VAL(
pos2,
Z_ARRVAL_PP(header), cookie) {
zval *cookie_hash;
MAKE_STD_ZVAL(cookie_hash);
array_init(cookie_hash);
zval *cookie_hash;
MAKE_STD_ZVAL(cookie_hash);
array_init(cookie_hash);
@@
-1954,6
+1957,10
@@
PHP_METHOD(HttpRequest, clearHistory)
*
* Returns the received response as HttpMessage object.
*
*
* Returns the received response as HttpMessage object.
*
+ * NOTE: While an exception may be thrown, the transfer could have succeeded
+ * at least partially, so you might want to check the return values of various
+ * HttpRequest::getResponse*() methods.
+ *
* Throws HttpRuntimeException, HttpRequestException,
* HttpMalformedHeaderException, HttpEncodingException.
*
* Throws HttpRuntimeException, HttpRequestException,
* HttpMalformedHeaderException, HttpEncodingException.
*