- fix usage of request time
[m6w6/ext-http] / http_request_api.c
index d07305e6930fb84e51fe953af5ca781f18534623..7bb54a86c7cc4555186c0f666fcddcbe6db0a52f 100644 (file)
@@ -130,7 +130,7 @@ PHP_MINIT_FUNCTION(http_request)
        CRYPTO_set_id_callback(http_openssl_thread_id);
        CRYPTO_set_locking_callback(http_openssl_thread_lock);
 #endif
-#ifdef HTTP_NED_GNUTLS_TSL
+#ifdef HTTP_NEED_GNUTLS_TSL
        gcry_control(GCRYCTL_SET_THREAD_CBS, &http_gnutls_tsl);
 #endif
 
@@ -147,6 +147,11 @@ PHP_MINIT_FUNCTION(http_request)
        HTTP_LONG_CONSTANT("HTTP_VERSION_1_0", CURL_HTTP_VERSION_1_0);
        HTTP_LONG_CONSTANT("HTTP_VERSION_1_1", CURL_HTTP_VERSION_1_1);
 
+#if HTTP_CURL_VERSION(7,15,2)
+       HTTP_LONG_CONSTANT("HTTP_PROXY_SOCKS4", CURLPROXY_SOCKS4);
+#endif
+       HTTP_LONG_CONSTANT("HTTP_PROXY_SOCKS5", CURLPROXY_SOCKS5);
+       HTTP_LONG_CONSTANT("HTTP_PROXY_HTTP", CURLPROXY_HTTP);
        return SUCCESS;
 }
 /* }}} */
@@ -252,7 +257,7 @@ PHP_MSHUTDOWN_FUNCTION(http_request)
        }
 #define HTTP_CURL_OPT_STRING_EX(keyname, optname, obdc) \
        if (!strcasecmp(key, keyname)) { \
-               zval *copy = http_request_option_cache(request, keyname, zval_copy(IS_STRING, *param)); \
+               zval *copy = http_request_option_cache_ex(request, keyname, strlen(keyname)+1, 0, zval_copy(IS_STRING, *param)); \
                if (obdc) { \
                        HTTP_CHECK_OPEN_BASEDIR(Z_STRVAL_P(copy), return FAILURE); \
                } \
@@ -267,9 +272,10 @@ PHP_MSHUTDOWN_FUNCTION(http_request)
        }
 #define HTTP_CURL_OPT_LONG_EX(keyname, optname) \
        if (!strcasecmp(key, keyname)) { \
-               zval *copy = http_request_option_cache(request, keyname, zval_copy(IS_LONG, *param)); \
+               zval *copy = zval_copy(IS_LONG, *param); \
                HTTP_CURL_OPT(optname, Z_LVAL_P(copy)); \
                key = NULL; \
+               zval_free(&copy); \
                continue; \
        }
 /* }}} */
@@ -294,12 +300,12 @@ PHP_HTTP_API CURL * _http_curl_init_ex(CURL *ch, http_request *request)
 {
        if (ch || (ch = curl_easy_init())) {
 #if defined(ZTS)
-               HTTP_CURL_OPT_EX(ch, CURLOPT_NOSIGNAL, 1);
+               HTTP_CURL_OPT_EX(ch, CURLOPT_NOSIGNAL, 1L);
 #endif
-               HTTP_CURL_OPT_EX(ch, CURLOPT_HEADER, 0);
-               HTTP_CURL_OPT_EX(ch, CURLOPT_FILETIME, 1);
-               HTTP_CURL_OPT_EX(ch, CURLOPT_AUTOREFERER, 1);
-               HTTP_CURL_OPT_EX(ch, CURLOPT_VERBOSE, 1);
+               HTTP_CURL_OPT_EX(ch, CURLOPT_HEADER, 0L);
+               HTTP_CURL_OPT_EX(ch, CURLOPT_FILETIME, 1L);
+               HTTP_CURL_OPT_EX(ch, CURLOPT_AUTOREFERER, 1L);
+               HTTP_CURL_OPT_EX(ch, CURLOPT_VERBOSE, 1L);
                HTTP_CURL_OPT_EX(ch, CURLOPT_HEADERFUNCTION, NULL);
                HTTP_CURL_OPT_EX(ch, CURLOPT_DEBUGFUNCTION, http_curl_raw_callback);
                HTTP_CURL_OPT_EX(ch, CURLOPT_READFUNCTION, http_curl_read_callback);
@@ -328,9 +334,9 @@ PHP_HTTP_API void _http_curl_free(CURL **ch)
 {
        if (*ch) {
                /* avoid nasty segfaults with already cleaned up callbacks */
-               HTTP_CURL_OPT_EX(*ch, CURLOPT_NOPROGRESS, 1);
+               HTTP_CURL_OPT_EX(*ch, CURLOPT_NOPROGRESS, 1L);
                HTTP_CURL_OPT_EX(*ch, CURLOPT_PROGRESSFUNCTION, NULL);
-               HTTP_CURL_OPT_EX(*ch, CURLOPT_VERBOSE, 0);
+               HTTP_CURL_OPT_EX(*ch, CURLOPT_VERBOSE, 0L);
                HTTP_CURL_OPT_EX(*ch, CURLOPT_DEBUGFUNCTION, NULL);
                curl_easy_cleanup(*ch);
                *ch = NULL;
@@ -368,8 +374,6 @@ PHP_HTTP_API http_request *_http_request_init_ex(http_request *request, CURL *ch
 /* {{{ void http_request_dtor(http_request *) */
 PHP_HTTP_API void _http_request_dtor(http_request *request)
 {
-       TSRMLS_FETCH_FROM_CTX(request->tsrm_ls);
-       
        http_curl_free(&request->ch);
        http_request_reset(request);
        
@@ -416,38 +420,78 @@ PHP_HTTP_API void _http_request_reset(http_request *request)
 }
 /* }}} */
 
+/* {{{ STATUS http_request_enable_cookies(http_request *) */
+PHP_HTTP_API STATUS _http_request_enable_cookies(http_request *request)
+{
+       TSRMLS_FETCH_FROM_CTX(request->tsrm_ls);
+       if (CURLE_OK == curl_easy_setopt(request->ch, CURLOPT_COOKIEFILE, "")) {
+               return SUCCESS;
+       }
+       http_error(HE_WARNING, HTTP_E_REQUEST, "Could not enable cookies for this session");
+       return FAILURE;
+}
+/* }}} */
+
+/* {{{ STATUS http_request_reset_cookies(http_request *, int) */
+PHP_HTTP_API STATUS _http_request_reset_cookies(http_request *request, int session_only)
+{
+       TSRMLS_FETCH_FROM_CTX(request->tsrm_ls);
+       
+       if (session_only) {
+#if HTTP_CURL_VERSION(7,15,4)
+               curl_easy_setopt(request->ch, CURLOPT_COOKIELIST, "SESS");
+               return SUCCESS;
+#else
+               http_error(HE_WARNING, HTTP_E_REQUEST, "Could not reset session cookies (need libcurl >= v7.15.4)");
+#endif
+       } else {
+#if HTTP_CURL_VERSION(7,14,1)
+               curl_easy_setopt(request->ch, CURLOPT_COOKIELIST, "ALL");
+               return SUCCESS;
+#else
+               http_error(HE_WARNING, HTTP_E_REQUEST, "Could not reset cookies (need libcurl >= v7.14.1)");
+#endif
+       }
+       return FAILURE;
+}
+/* }}} */
+
 /* {{{ void http_request_defaults(http_request *) */
 PHP_HTTP_API void _http_request_defaults(http_request *request)
 {
        if (request->ch) {
                HTTP_CURL_OPT(CURLOPT_PROGRESSFUNCTION, NULL);
                HTTP_CURL_OPT(CURLOPT_URL, NULL);
-               HTTP_CURL_OPT(CURLOPT_NOPROGRESS, 1);
+               HTTP_CURL_OPT(CURLOPT_NOPROGRESS, 1L);
                HTTP_CURL_OPT(CURLOPT_PROXY, NULL);
-               HTTP_CURL_OPT(CURLOPT_PROXYPORT, 0);
+               HTTP_CURL_OPT(CURLOPT_PROXYPORT, 0L);
+               HTTP_CURL_OPT(CURLOPT_PROXYTYPE, 0L);
                HTTP_CURL_OPT(CURLOPT_PROXYUSERPWD, NULL);
-               HTTP_CURL_OPT(CURLOPT_PROXYAUTH, 0);
+               HTTP_CURL_OPT(CURLOPT_PROXYAUTH, 0L);
                HTTP_CURL_OPT(CURLOPT_INTERFACE, NULL);
-               HTTP_CURL_OPT(CURLOPT_PORT, 0);
+               HTTP_CURL_OPT(CURLOPT_PORT, 0L);
+#if HTTP_CURL_VERSION(7,15,2)
+               HTTP_CURL_OPT(CURLOPT_LOCALPORT, 0L);
+               HTTP_CURL_OPT(CURLOPT_LOCALPORTRANGE, 0L);
+#endif
                HTTP_CURL_OPT(CURLOPT_USERPWD, NULL);
-               HTTP_CURL_OPT(CURLOPT_HTTPAUTH, 0);
+               HTTP_CURL_OPT(CURLOPT_HTTPAUTH, 0L);
                HTTP_CURL_OPT(CURLOPT_ENCODING, NULL);
-               HTTP_CURL_OPT(CURLOPT_FOLLOWLOCATION, 0);
-               HTTP_CURL_OPT(CURLOPT_UNRESTRICTED_AUTH, 0);
+               HTTP_CURL_OPT(CURLOPT_FOLLOWLOCATION, 0L);
+               HTTP_CURL_OPT(CURLOPT_UNRESTRICTED_AUTH, 0L);
                HTTP_CURL_OPT(CURLOPT_REFERER, NULL);
                HTTP_CURL_OPT(CURLOPT_USERAGENT, "PECL::HTTP/" PHP_EXT_HTTP_VERSION " (PHP/" PHP_VERSION ")");
                HTTP_CURL_OPT(CURLOPT_HTTPHEADER, NULL);
                HTTP_CURL_OPT(CURLOPT_COOKIE, NULL);
-#if LIBCURL_VERSION_NUM >= 0x070e01
+#if HTTP_CURL_VERSION(7,14,1)
                HTTP_CURL_OPT(CURLOPT_COOKIELIST, NULL);
 #endif
-               HTTP_CURL_OPT(CURLOPT_COOKIEFILE, NULL);
-               HTTP_CURL_OPT(CURLOPT_COOKIEJAR, NULL);
-               HTTP_CURL_OPT(CURLOPT_RESUME_FROM, 0);
-               HTTP_CURL_OPT(CURLOPT_MAXFILESIZE, 0);
-               HTTP_CURL_OPT(CURLOPT_TIMECONDITION, 0);
-               HTTP_CURL_OPT(CURLOPT_TIMEVALUE, 0);
-               HTTP_CURL_OPT(CURLOPT_TIMEOUT, 0);
+               HTTP_CURL_OPT(CURLOPT_RANGE, NULL);
+               HTTP_CURL_OPT(CURLOPT_RESUME_FROM, 0L);
+               HTTP_CURL_OPT(CURLOPT_MAXFILESIZE, 0L);
+               HTTP_CURL_OPT(CURLOPT_TIMECONDITION, 0L);
+               HTTP_CURL_OPT(CURLOPT_TIMEVALUE, 0L);
+               HTTP_CURL_OPT(CURLOPT_TIMEOUT, 0L);
                HTTP_CURL_OPT(CURLOPT_CONNECTTIMEOUT, 3);
                HTTP_CURL_OPT(CURLOPT_SSLCERT, NULL);
                HTTP_CURL_OPT(CURLOPT_SSLCERTTYPE, NULL);
@@ -456,34 +500,32 @@ PHP_HTTP_API void _http_request_defaults(http_request *request)
                HTTP_CURL_OPT(CURLOPT_SSLKEYTYPE, NULL);
                HTTP_CURL_OPT(CURLOPT_SSLKEYPASSWD, NULL);
                HTTP_CURL_OPT(CURLOPT_SSLENGINE, NULL);
-               HTTP_CURL_OPT(CURLOPT_SSLVERSION, 0);
-               HTTP_CURL_OPT(CURLOPT_SSL_VERIFYPEER, 0);
-               HTTP_CURL_OPT(CURLOPT_SSL_VERIFYHOST, 0);
+               HTTP_CURL_OPT(CURLOPT_SSLVERSION, 0L);
+               HTTP_CURL_OPT(CURLOPT_SSL_VERIFYPEER, 0L);
+               HTTP_CURL_OPT(CURLOPT_SSL_VERIFYHOST, 0L);
                HTTP_CURL_OPT(CURLOPT_SSL_CIPHER_LIST, NULL);
                HTTP_CURL_OPT(CURLOPT_CAINFO, NULL);
                HTTP_CURL_OPT(CURLOPT_CAPATH, NULL);
                HTTP_CURL_OPT(CURLOPT_RANDOM_FILE, NULL);
                HTTP_CURL_OPT(CURLOPT_EGDSOCKET, NULL);
                HTTP_CURL_OPT(CURLOPT_POSTFIELDS, NULL);
-               HTTP_CURL_OPT(CURLOPT_POSTFIELDSIZE, 0);
+               HTTP_CURL_OPT(CURLOPT_POSTFIELDSIZE, 0L);
                HTTP_CURL_OPT(CURLOPT_HTTPPOST, NULL);
                HTTP_CURL_OPT(CURLOPT_IOCTLDATA, NULL);
                HTTP_CURL_OPT(CURLOPT_READDATA, NULL);
-               HTTP_CURL_OPT(CURLOPT_INFILESIZE, 0);
+               HTTP_CURL_OPT(CURLOPT_INFILESIZE, 0L);
                HTTP_CURL_OPT(CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_NONE);
                HTTP_CURL_OPT(CURLOPT_CUSTOMREQUEST, NULL);
-               HTTP_CURL_OPT(CURLOPT_NOBODY, 0);
-               HTTP_CURL_OPT(CURLOPT_POST, 0);
-               HTTP_CURL_OPT(CURLOPT_UPLOAD, 0);
-               HTTP_CURL_OPT(CURLOPT_HTTPGET, 1);
+               HTTP_CURL_OPT(CURLOPT_NOBODY, 0L);
+               HTTP_CURL_OPT(CURLOPT_POST, 0L);
+               HTTP_CURL_OPT(CURLOPT_UPLOAD, 0L);
+               HTTP_CURL_OPT(CURLOPT_HTTPGET, 1L);
        }
 }
 /* }}} */
 
 PHP_HTTP_API void _http_request_set_progress_callback(http_request *request, zval *cb)
 {
-       TSRMLS_FETCH_FROM_CTX(request->tsrm_ls);
-       
        if (request->_progress_callback) {
                zval_ptr_dtor(&request->_progress_callback);
        }
@@ -522,7 +564,10 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
                if (Z_STRLEN_P(zoption)) {
                        HTTP_CURL_OPT(CURLOPT_PROXY, Z_STRVAL_P(zoption));
                }
-
+               /* type */
+               if ((zoption = http_request_option(request, options, "proxytype", IS_LONG))) {
+                       HTTP_CURL_OPT(CURLOPT_PROXYTYPE, Z_LVAL_P(zoption));
+               }
                /* port */
                if ((zoption = http_request_option(request, options, "proxyport", IS_LONG))) {
                        HTTP_CURL_OPT(CURLOPT_PROXYPORT, Z_LVAL_P(zoption));
@@ -540,6 +585,27 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
        /* outgoing interface */
        if ((zoption = http_request_option(request, options, "interface", IS_STRING))) {
                HTTP_CURL_OPT(CURLOPT_INTERFACE, Z_STRVAL_P(zoption));
+               
+#if HTTP_CURL_VERSION(7,15,2)
+               if ((zoption = http_request_option(request, options, "portrange", IS_ARRAY))) {
+                       zval **prs, **pre;
+                       
+                       zend_hash_internal_pointer_reset(Z_ARRVAL_P(zoption));
+                       if (SUCCESS == zend_hash_get_current_data(Z_ARRVAL_P(zoption), (void *) &prs)) {
+                               zend_hash_move_forward(Z_ARRVAL_P(zoption));
+                               if (SUCCESS == zend_hash_get_current_data(Z_ARRVAL_P(zoption), (void *) &pre)) {
+                                       zval *prs_cpy = zval_copy(IS_LONG, *prs), *pre_cpy = zval_copy(IS_LONG, *pre);
+                                       
+                                       if (Z_LVAL_P(prs_cpy) && Z_LVAL_P(pre_cpy)) {
+                                               HTTP_CURL_OPT(CURLOPT_LOCALPORT, MIN(Z_LVAL_P(prs_cpy), Z_LVAL_P(pre_cpy)));
+                                               HTTP_CURL_OPT(CURLOPT_LOCALPORTRANGE, labs(Z_LVAL_P(prs_cpy)-Z_LVAL_P(pre_cpy))+1L);
+                                       }
+                                       zval_free(&prs_cpy);
+                                       zval_free(&pre_cpy);
+                               }
+                       }
+               }
+#endif
        }
 
        /* another port */
@@ -557,7 +623,7 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
 
        /* redirects, defaults to 0 */
        if ((zoption = http_request_option(request, options, "redirect", IS_LONG))) {
-               HTTP_CURL_OPT(CURLOPT_FOLLOWLOCATION, Z_LVAL_P(zoption) ? 1 : 0);
+               HTTP_CURL_OPT(CURLOPT_FOLLOWLOCATION, Z_LVAL_P(zoption) ? 1L : 0L);
                HTTP_CURL_OPT(CURLOPT_MAXREDIRS, Z_LVAL_P(zoption));
                if ((zoption = http_request_option(request, options, "unrestrictedauth", IS_BOOL))) {
                        HTTP_CURL_OPT(CURLOPT_UNRESTRICTED_AUTH, Z_LVAL_P(zoption));
@@ -580,10 +646,50 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
        }
 
        /* resume */
-       if ((zoption = http_request_option(request, options, "resume", IS_LONG)) && (Z_LVAL_P(zoption) != 0)) {
+       if ((zoption = http_request_option(request, options, "resume", IS_LONG)) && (Z_LVAL_P(zoption) > 0)) {
                range_req = 1;
                HTTP_CURL_OPT(CURLOPT_RESUME_FROM, Z_LVAL_P(zoption));
        }
+       /* or range of kind array(array(0,499), array(100,1499)) */
+       else if ((zoption = http_request_option(request, options, "range", IS_ARRAY)) && zend_hash_num_elements(Z_ARRVAL_P(zoption))) {
+               HashPosition pos1, pos2;
+               zval **rr, **rb, **re;
+               phpstr rs;
+               
+               phpstr_init(&rs);
+               FOREACH_VAL(pos1, zoption, rr) {
+                       if (Z_TYPE_PP(rr) == IS_ARRAY) {
+                               zend_hash_internal_pointer_reset_ex(Z_ARRVAL_PP(rr), &pos2);
+                               if (SUCCESS == zend_hash_get_current_data_ex(Z_ARRVAL_PP(rr), (void *) &rb, &pos2)) {
+                                       zend_hash_move_forward_ex(Z_ARRVAL_PP(rr), &pos2);
+                                       if (SUCCESS == zend_hash_get_current_data_ex(Z_ARRVAL_PP(rr), (void *) &re, &pos2)) {
+                                               if (    ((Z_TYPE_PP(rb) == IS_LONG) || ((Z_TYPE_PP(rb) == IS_STRING) && is_numeric_string(Z_STRVAL_PP(rb), Z_STRLEN_PP(rb), NULL, NULL, 1))) &&
+                                                               ((Z_TYPE_PP(re) == IS_LONG) || ((Z_TYPE_PP(re) == IS_STRING) && is_numeric_string(Z_STRVAL_PP(re), Z_STRLEN_PP(re), NULL, NULL, 1)))) {
+                                                       zval *rbl = zval_copy(IS_LONG, *rb), *rel = zval_copy(IS_LONG, *re);
+                                                       
+                                                       if ((Z_LVAL_P(rbl) >= 0) && (Z_LVAL_P(rel) >= 0)) {
+                                                               phpstr_appendf(&rs, "%ld-%ld,", Z_LVAL_P(rbl), Z_LVAL_P(rel));
+                                                       }
+                                                       zval_free(&rbl);
+                                                       zval_free(&rel);
+                                               }
+                                       }
+                               }
+                       }
+               }
+               
+               if (PHPSTR_LEN(&rs)) {
+                       zval *cached_range;
+                       
+                       /* ditch last comma */
+                       PHPSTR_VAL(&rs)[PHPSTR_LEN(&rs)-- -1] = '\0';
+                       /* cache string */
+                       MAKE_STD_ZVAL(cached_range);
+                       ZVAL_STRINGL(cached_range, PHPSTR_VAL(&rs), PHPSTR_LEN(&rs), 0);
+                       HTTP_CURL_OPT(CURLOPT_RANGE, Z_STRVAL_P(http_request_option_cache(request, "range", cached_range)));
+                       zval_ptr_dtor(&cached_range);
+               }
+       }
 
        /* additional headers, array('name' => 'value') */
        if (request->_cache.headers) {
@@ -598,7 +704,7 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
                FOREACH_KEY(pos, zoption, header_key, header_idx) {
                        if (header_key) {
                                zval **header_val;
-                               if (SUCCESS == zend_hash_get_current_data_ex(Z_ARRVAL_P(zoption), (void **) &header_val, &pos)) {
+                               if (SUCCESS == zend_hash_get_current_data_ex(Z_ARRVAL_P(zoption), (void *) &header_val, &pos)) {
                                        char header[1024] = {0};
                                        
                                        ZVAL_ADDREF(*header_val);
@@ -639,9 +745,9 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
                        if (Z_LVAL_P(zoption) > 0) {
                                HTTP_CURL_OPT(CURLOPT_TIMEVALUE, Z_LVAL_P(zoption));
                        } else {
-                               HTTP_CURL_OPT(CURLOPT_TIMEVALUE, HTTP_GET_REQUEST_TIME() + Z_LVAL_P(zoption));
+                               HTTP_CURL_OPT(CURLOPT_TIMEVALUE, (long) HTTP_G->request.time + Z_LVAL_P(zoption));
                        }
-                       HTTP_CURL_OPT(CURLOPT_TIMECONDITION, range_req ? CURL_TIMECOND_IFUNMODSINCE : CURL_TIMECOND_IFMODSINCE);
+                       HTTP_CURL_OPT(CURLOPT_TIMECONDITION, (long) (range_req ? CURL_TIMECOND_IFUNMODSINCE : CURL_TIMECOND_IFMODSINCE));
                } else {
                        HTTP_CURL_OPT(CURLOPT_TIMECONDITION, CURL_TIMECOND_NONE);
                }
@@ -660,14 +766,13 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
                                }
                        } else {
                                HashPosition pos;
-                               zval *cookie_val = NULL;
                                char *cookie_key = NULL;
                                ulong cookie_idx;
                                
                                FOREACH_KEY(pos, zoption, cookie_key, cookie_idx) {
                                        if (cookie_key) {
                                                zval **cookie_val;
-                                               if (SUCCESS == zend_hash_get_current_data_ex(Z_ARRVAL_P(zoption), (void **) &cookie_val, &pos)) {
+                                               if (SUCCESS == zend_hash_get_current_data_ex(Z_ARRVAL_P(zoption), (void *) &cookie_val, &pos)) {
                                                        zval *val = zval_copy(IS_STRING, *cookie_val);
                                                        phpstr_appendf(&request->_cache.cookies, "%s=%s; ", cookie_key, Z_STRVAL_P(val));
                                                        zval_free(&val);
@@ -686,27 +791,16 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
                }
        }
 
-#if LIBCURL_VERSION_NUM >= 0x070e01
-       /* reset cookies */
-       if ((zoption = http_request_option(request, options, "resetcookies", IS_BOOL)) && Z_LVAL_P(zoption)) {
-               HTTP_CURL_OPT(CURLOPT_COOKIELIST, "ALL");
-       }
-#endif
-       
-       /* session cookies */
-       if ((zoption = http_request_option(request, options, "cookiesession", IS_BOOL))) {
-               if (Z_LVAL_P(zoption)) {
-                       /* accept cookies for this session */
-                       HTTP_CURL_OPT(CURLOPT_COOKIEFILE, "");
-               } else {
-                       /* reset session cookies */
-                       HTTP_CURL_OPT(CURLOPT_COOKIESESSION, 1);
-               }
+       /* don't load session cookies from cookiestore */
+       if ((zoption = http_request_option(request, options, "cookiesession", IS_BOOL)) && Z_BVAL_P(zoption)) {
+               HTTP_CURL_OPT(CURLOPT_COOKIESESSION, 1L);
        }
 
        /* cookiestore, read initial cookies from that file and store cookies back into that file */
-       if ((zoption = http_request_option(request, options, "cookiestore", IS_STRING)) && Z_STRLEN_P(zoption)) {
-               HTTP_CHECK_OPEN_BASEDIR(Z_STRVAL_P(zoption), return FAILURE);
+       if ((zoption = http_request_option(request, options, "cookiestore", IS_STRING))) {
+               if (Z_STRLEN_P(zoption)) {
+                       HTTP_CHECK_OPEN_BASEDIR(Z_STRVAL_P(zoption), return FAILURE);
+               }
                HTTP_CURL_OPT(CURLOPT_COOKIEFILE, Z_STRVAL_P(zoption));
                HTTP_CURL_OPT(CURLOPT_COOKIEJAR, Z_STRVAL_P(zoption));
        }
@@ -767,23 +861,22 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
        }
 
        /* request method */
-       switch (request->meth)
-       {
+       switch (request->meth) {
                case HTTP_GET:
-                       HTTP_CURL_OPT(CURLOPT_HTTPGET, 1);
-               break;
+                       HTTP_CURL_OPT(CURLOPT_HTTPGET, 1L);
+                       break;
 
                case HTTP_HEAD:
-                       HTTP_CURL_OPT(CURLOPT_NOBODY, 1);
-               break;
+                       HTTP_CURL_OPT(CURLOPT_NOBODY, 1L);
+                       break;
 
                case HTTP_POST:
-                       HTTP_CURL_OPT(CURLOPT_POST, 1);
-               break;
+                       HTTP_CURL_OPT(CURLOPT_POST, 1L);
+                       break;
 
                case HTTP_PUT:
-                       HTTP_CURL_OPT(CURLOPT_UPLOAD, 1);
-               break;
+                       HTTP_CURL_OPT(CURLOPT_UPLOAD, 1L);
+                       break;
 
                default:
                        if (http_request_method_exists(0, request->meth, NULL)) {
@@ -792,37 +885,37 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
                                http_error_ex(HE_WARNING, HTTP_E_REQUEST_METHOD, "Unsupported request method: %d (%s)", request->meth, request->url);
                                return FAILURE;
                        }
-               break;
+                       break;
        }
 
        /* attach request body */
        if (request->body && (request->meth != HTTP_GET) && (request->meth != HTTP_HEAD) && (request->meth != HTTP_OPTIONS)) {
-               switch (request->body->type)
-               {
+               switch (request->body->type) {
                        case HTTP_REQUEST_BODY_EMPTY:
                                /* nothing */
-                       break;
+                               break;
                        
-                       case HTTP_REQUEST_BODY_CSTRING:
-                               HTTP_CURL_OPT(CURLOPT_POSTFIELDS, request->body->data);
-                               HTTP_CURL_OPT(CURLOPT_POSTFIELDSIZE, request->body->size);
-                       break;
-
                        case HTTP_REQUEST_BODY_CURLPOST:
                                HTTP_CURL_OPT(CURLOPT_HTTPPOST, (struct curl_httppost *) request->body->data);
-                       break;
+                               break;
 
+                       case HTTP_REQUEST_BODY_CSTRING:
+                               if (request->meth != HTTP_PUT) {
+                                       HTTP_CURL_OPT(CURLOPT_POSTFIELDS, request->body->data);
+                                       HTTP_CURL_OPT(CURLOPT_POSTFIELDSIZE, request->body->size);
+                                       break;
+                               }
+                               /* fallthrough, PUT/UPLOAD _needs_ READDATA */
                        case HTTP_REQUEST_BODY_UPLOADFILE:
                                HTTP_CURL_OPT(CURLOPT_IOCTLDATA, request);
                                HTTP_CURL_OPT(CURLOPT_READDATA, request);
                                HTTP_CURL_OPT(CURLOPT_INFILESIZE, request->body->size);
-                       break;
+                               break;
 
                        default:
                                /* shouldn't ever happen */
                                http_error_ex(HE_ERROR, 0, "Unknown request body type: %d (%s)", request->body->type, request->url);
                                return FAILURE;
-                       break;
                }
        }
 
@@ -872,12 +965,12 @@ PHP_HTTP_API void _http_request_info(http_request *request, HashTable *info)
        HTTP_CURL_INFO(CURLINFO_CONTENT_TYPE);
        HTTP_CURL_INFO(CURLINFO_HTTPAUTH_AVAIL);
        HTTP_CURL_INFO(CURLINFO_PROXYAUTH_AVAIL);
-       HTTP_CURL_INFO(CURLINFO_OS_ERRNO);
-       add_assoc_string(&array, "error", request->_error, 1);
        HTTP_CURL_INFO(CURLINFO_NUM_CONNECTS);
-#if LIBCURL_VERSION_NUM >= 0x070e01
+#if HTTP_CURL_VERSION(7,14,1)
        HTTP_CURL_INFO_EX(CURLINFO_COOKIELIST, "cookies");
 #endif
+       HTTP_CURL_INFO(CURLINFO_OS_ERRNO);
+       add_assoc_string(&array, "error", request->_error, 1);
 }
 /* }}} */
 
@@ -886,11 +979,26 @@ static size_t http_curl_read_callback(void *data, size_t len, size_t n, void *ct
 {
        http_request *request = (http_request *) ctx;
        TSRMLS_FETCH_FROM_CTX(request->tsrm_ls);
-
-       if (request->body == NULL || request->body->type != HTTP_REQUEST_BODY_UPLOADFILE) {
-               return 0;
+       
+       if (request->body) {
+               switch (request->body->type) {
+                       case HTTP_REQUEST_BODY_CSTRING:
+                       {
+                               size_t out = MIN(len * n, request->body->size - request->body->priv);
+                               
+                               if (out) {
+                                       memcpy(data, ((char *) request->body->data) + request->body->priv, out);
+                                       request->body->priv += out;
+                                       return out;
+                               }
+                               break;
+                       }
+                       
+                       case HTTP_REQUEST_BODY_UPLOADFILE:
+                               return php_stream_read((php_stream *) request->body->data, data, len * n);
+               }
        }
-       return php_stream_read((php_stream *) request->body->data, data, len * n);
+       return 0;
 }
 /* }}} */
 
@@ -911,7 +1019,9 @@ static int http_curl_progress_callback(void *ctx, double dltotal, double dlnow,
        add_assoc_double(param, "ultotal", ultotal);
        add_assoc_double(param, "ulnow", ulnow);
        
-       call_user_function(EG(function_table), NULL, request->_progress_callback, &retval, 1, &param TSRMLS_CC);
+       with_error_handling(EH_NORMAL, NULL) {
+               call_user_function(EG(function_table), NULL, request->_progress_callback, &retval, 1, &param TSRMLS_CC);
+       } end_error_handling();
        
        zval_ptr_dtor(&param);
        zval_dtor(&retval);
@@ -929,12 +1039,23 @@ static curlioerr http_curl_ioctl_callback(CURL *ch, curliocmd cmd, void *ctx)
        if (cmd != CURLIOCMD_RESTARTREAD) {
                return CURLIOE_UNKNOWNCMD;
        }
-       if (    request->body == NULL || 
-                       request->body->type != HTTP_REQUEST_BODY_UPLOADFILE ||
-                       SUCCESS != php_stream_rewind((php_stream *) request->body->data)) {
-               return CURLIOE_FAILRESTART;
+       
+       if (request->body) {
+               switch (request->body->type) {
+                       case HTTP_REQUEST_BODY_CSTRING:
+                               request->body->priv = 0;
+                               return CURLIOE_OK;
+                               break;
+                               
+                       case HTTP_REQUEST_BODY_UPLOADFILE:
+                               if (SUCCESS == php_stream_rewind((php_stream *) request->body->data)) {
+                                       return CURLIOE_OK;
+                               }
+                               break;
+               }
        }
-       return CURLIOE_OK;
+       
+       return CURLIOE_FAILRESTART;
 }
 /* }}} */
 
@@ -943,22 +1064,21 @@ static int http_curl_raw_callback(CURL *ch, curl_infotype type, char *data, size
 {
        http_request *request = (http_request *) ctx;
 
-       switch (type)
-       {
+       switch (type) {
                case CURLINFO_DATA_IN:
                        if (request->conv.last_type == CURLINFO_HEADER_IN) {
                                phpstr_appends(&request->conv.response, HTTP_CRLF);
                        }
                case CURLINFO_HEADER_IN:
                        phpstr_append(&request->conv.response, data, length);
-               break;
+                       break;
                case CURLINFO_DATA_OUT:
                        if (request->conv.last_type == CURLINFO_HEADER_OUT) {
                                phpstr_appends(&request->conv.request, HTTP_CRLF);
                        }
                case CURLINFO_HEADER_OUT:
                        phpstr_append(&request->conv.request, data, length);
-               break;
+                       break;
                default:
 #if 0
                        fprintf(stderr, "## ", type);
@@ -978,7 +1098,7 @@ static int http_curl_raw_callback(CURL *ch, curl_infotype type, char *data, size
                                fprintf(stderr, "\n");
                        }
 #endif
-               break;
+                       break;
        }
 
        if (type) {
@@ -1000,9 +1120,9 @@ static inline zval *_http_request_option_ex(http_request *r, HashTable *options,
        
        if (!options || 
 #ifdef ZEND_ENGINE_2
-                       (SUCCESS != zend_hash_quick_find(options, key, keylen, h, (void **) &zoption))
+                       (SUCCESS != zend_hash_quick_find(options, key, keylen, h, (void *) &zoption))
 #else
-                       (SUCCESS != zend_hash_find(options, key, keylen, (void **) &zoption))
+                       (SUCCESS != zend_hash_find(options, key, keylen, (void *) &zoption))
 #endif
        ) {
                return NULL;