- typo
[m6w6/ext-http] / http_request_api.c
index 0b71ef7d837770de9d5258e73da0fed4dc7b7cb7..49b699b04dba59a7fea3b83827273d72f5b2a2a7 100644 (file)
 #include "php_http_std_defs.h"
 #include "php_http_api.h"
 #include "php_http_request_api.h"
+#include "php_http_request_object.h"
+#include "php_http_requestpool_object.h"
 #include "php_http_url_api.h"
 
+#ifndef HTTP_CURL_USE_ZEND_MM
+#      define HTTP_CURL_USE_ZEND_MM 0
+#endif
+
+#ifndef HTTP_DEBUG_REQPOOLS
+#      define HTTP_DEBUG_REQPOOLS 0
+#endif
+
 ZEND_EXTERN_MODULE_GLOBALS(http)
 
 #if LIBCURL_VERSION_NUM < 0x070c00
-#      define curl_easy_strerror(code) HTTP_G(request).curl.error
+#      define curl_easy_strerror(code) HTTP_G(request).error
 #endif
 
 #define HTTP_CURL_INFO(I) HTTP_CURL_INFO_EX(I, I)
@@ -48,7 +58,7 @@ ZEND_EXTERN_MODULE_GLOBALS(http)
                { \
                        char *c; \
                        if (CURLE_OK == curl_easy_getinfo(ch, CURLINFO_ ##I, &c)) { \
-                               add_assoc_string(&array, pretty_key(http_curl_copystr(#X), sizeof(#X)-1, 0, 0), c ? c : "", 1); \
+                               add_assoc_string(&array, pretty_key(http_request_data_copy(COPY_STRING, #X), sizeof(#X)-1, 0, 0), c ? c : "", 1); \
                        } \
                } \
                break; \
@@ -57,7 +67,7 @@ ZEND_EXTERN_MODULE_GLOBALS(http)
                { \
                        double d; \
                        if (CURLE_OK == curl_easy_getinfo(ch, CURLINFO_ ##I, &d)) { \
-                               add_assoc_double(&array, pretty_key(http_curl_copystr(#X), sizeof(#X)-1, 0, 0), d); \
+                               add_assoc_double(&array, pretty_key(http_request_data_copy(COPY_STRING, #X), sizeof(#X)-1, 0, 0), d); \
                        } \
                } \
                break; \
@@ -66,7 +76,7 @@ ZEND_EXTERN_MODULE_GLOBALS(http)
                { \
                        long l; \
                        if (CURLE_OK == curl_easy_getinfo(ch, CURLINFO_ ##I, &l)) { \
-                               add_assoc_long(&array, pretty_key(http_curl_copystr(#X), sizeof(#X)-1, 0, 0), l); \
+                               add_assoc_long(&array, pretty_key(http_request_data_copy(COPY_STRING, #X), sizeof(#X)-1, 0, 0), l); \
                        } \
                } \
                break; \
@@ -79,7 +89,7 @@ ZEND_EXTERN_MODULE_GLOBALS(http)
 #define HTTP_CURL_OPT_STRING_EX(keyname, optname) \
        if (!strcasecmp(key, #keyname)) { \
                convert_to_string_ex(param); \
-               HTTP_CURL_OPT(optname, http_curl_copystr(Z_STRVAL_PP(param))); \
+               HTTP_CURL_OPT(optname, http_request_data_copy(COPY_STRING, Z_STRVAL_PP(param))); \
                key = NULL; \
                continue; \
        }
@@ -96,8 +106,6 @@ ZEND_EXTERN_MODULE_GLOBALS(http)
 
 
 static const char *const http_request_methods[HTTP_MAX_REQUEST_METHOD + 1];
-#define http_curl_copystr(s) _http_curl_copystr((s) TSRMLS_CC)
-static inline char *_http_curl_copystr(const char *str TSRMLS_DC);
 #define http_curl_getopt(o, k, t) _http_curl_getopt_ex((o), (k), sizeof(k), (t) TSRMLS_CC)
 #define http_curl_getopt_ex(o, k, l, t) _http_curl_getopt_ex((o), (k), (l), (t) TSRMLS_CC)
 static inline zval *_http_curl_getopt_ex(HashTable *options, char *key, size_t keylen, int type TSRMLS_DC);
@@ -106,6 +114,98 @@ static size_t http_curl_read_callback(void *, size_t, size_t, void *);
 static int http_curl_progress_callback(void *, double, double, double, double);
 static int http_curl_debug_callback(CURL *, curl_infotype, char *, size_t, void *);
 
+typedef struct {
+       void ***tsrm_ctx;
+       void *data;
+} http_curl_callback_ctx;
+
+#define HTTP_CURL_CALLBACK_DATA(from, type, var) \
+       http_curl_callback_ctx *__CTX = (http_curl_callback_ctx *) (from); \
+       TSRMLS_FETCH_FROM_CTX(__CTX->tsrm_ctx); \
+       type (var) = (type) (__CTX->data)
+
+#define http_curl_callback_data(data) _http_curl_callback_data((data) TSRMLS_CC)
+static http_curl_callback_ctx *_http_curl_callback_data(void *data TSRMLS_DC);
+
+static void http_request_pool_freebody(http_request_body **body);
+static void http_request_pool_freehandle(zval **request, http_request_pool *pool TSRMLS_DC);
+
+#if HTTP_CURL_USE_ZEND_MM
+static void http_curl_free(void *p)                                    { efree(p); }
+static char *http_curl_strdup(const char *p)           { return estrdup(p); }
+static void *http_curl_malloc(size_t s)                                { return emalloc(s); }
+static void *http_curl_realloc(void *p, size_t s)      { return erealloc(p, s); }
+static void *http_curl_calloc(size_t n, size_t s)      { return ecalloc(n, s); }
+#endif
+
+/* {{{ STATUS http_request_global_init() */
+STATUS _http_request_global_init(void)
+{
+#if HTTP_CURL_USE_ZEND_MM
+       if (CURLE_OK != curl_global_init_mem(CURL_GLOBAL_ALL,
+                       http_curl_malloc,
+                       http_curl_free,
+                       http_curl_realloc,
+                       http_curl_strdup,
+                       http_curl_calloc)) {
+               return FAILURE;
+       }
+#else
+       if (CURLE_OK != curl_global_init(CURL_GLOBAL_ALL)) {
+               return FAILURE;
+       }
+#endif
+       return SUCCESS;
+}
+/* }}} */
+
+/* {{{ void *http_request_data_copy(int, void *) */
+void *_http_request_data_copy(int type, void *data TSRMLS_DC)
+{
+       switch (type)
+       {
+               case COPY_STRING:
+               {
+                       char *new_str = estrdup((const char*) data);
+                       zend_llist_add_element(&HTTP_G(request).copies.strings, &new_str);
+                       return new_str;
+               }
+
+               case COPY_SLIST:
+               {
+                       zend_llist_add_element(&HTTP_G(request).copies.slists, &data);
+                       return data;
+               }
+
+               default:
+               {
+                       return data;
+               }
+       }
+}
+/* }}} */
+
+/* {{{ void http_request_data_free_string(char **) */
+void _http_request_data_free_string(void *string)
+{
+       efree(*((char **)string));
+}
+/* }}} */
+
+/* {{{ void http_request_data_free_slist(struct curl_slist **) */
+void _http_request_data_free_slist(void *list)
+{
+       curl_slist_free_all(*((struct curl_slist **) list));
+}
+/* }}} */
+
+/* {{{ http_request_body *http_request_body_new() */
+PHP_HTTP_API http_request_body *_http_request_body_new(TSRMLS_D)
+{
+       http_request_body *body = ecalloc(1, sizeof(http_request_body));
+       return body;
+}
+/* }}} */
 
 /* {{{ STATUS http_request_body_fill(http_request_body *body, HashTable *, HashTable *) */
 PHP_HTTP_API STATUS _http_request_body_fill(http_request_body *body, HashTable *fields, HashTable *files TSRMLS_DC)
@@ -186,48 +286,56 @@ PHP_HTTP_API STATUS _http_request_body_fill(http_request_body *body, HashTable *
 /* {{{ void http_request_body_dtor(http_request_body *) */
 PHP_HTTP_API void _http_request_body_dtor(http_request_body *body TSRMLS_DC)
 {
-       switch (body->type)
-       {
-               case HTTP_REQUEST_BODY_CSTRING:
-                       efree(body->data);
-               break;
+       if (body) {
+               switch (body->type)
+               {
+                       case HTTP_REQUEST_BODY_CSTRING:
+                               if (body->data) {
+                                       efree(body->data);
+                               }
+                       break;
 
-               case HTTP_REQUEST_BODY_CURLPOST:
-                       curl_formfree(body->data);
-               break;
+                       case HTTP_REQUEST_BODY_CURLPOST:
+                               curl_formfree(body->data);
+                       break;
 
-               case HTTP_REQUEST_BODY_UPLOADFILE:
-                       php_stream_close(body->data);
-               break;
+                       case HTTP_REQUEST_BODY_UPLOADFILE:
+                               php_stream_close(body->data);
+                       break;
+               }
        }
 }
 /* }}} */
 
-/* {{{ STATUS http_request_ex(CURL *, http_request_method, char *, http_request_body, HashTable, HashTable, phpstr *) */
-PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const char *url, http_request_body *body, HashTable *options, HashTable *info, phpstr *response TSRMLS_DC)
+/* {{{ void http_request_body_free(http_request_body *) */
+PHP_HTTP_API void _http_request_body_free(http_request_body *body TSRMLS_DC)
+{
+       if (body) {
+               http_request_body_dtor(body);
+               efree(body);
+       }
+}
+/* }}} */
+
+/* {{{ STATUS http_request_init(CURL *, http_request_method, char *, http_request_body *, HashTable *, phpstr *) */
+PHP_HTTP_API STATUS _http_request_init(CURL *ch, http_request_method meth, const char *url, http_request_body *body, HashTable *options, phpstr *response TSRMLS_DC)
 {
-       CURLcode result = CURLE_OK;
-       STATUS status = SUCCESS;
-       zend_bool clean_curl = 0, range_req = 0;
        zval *zoption;
+       zend_bool range_req = 0;
 
-       /* check/init CURL handle */
-       if (ch) {
+       /* reset CURL handle */
 #if LIBCURL_VERSION_NUM >= 0x070c01
-               curl_easy_reset(ch);
+       curl_easy_reset(ch);
 #endif
-       } else {
-               if (ch = curl_easy_init()) {
-                       clean_curl = 1;
-               } else {
-                       http_error(E_WARNING, HTTP_E_CURL, "Could not initialize curl");
-                       return FAILURE;
-               }
-       }
 
        /* set options */
        if (url) {
-               HTTP_CURL_OPT(URL, url);
+               HTTP_CURL_OPT(URL, http_request_data_copy(COPY_STRING, (void *) url));
+       }
+
+       if (response) {
+               HTTP_CURL_OPT(WRITEDATA, http_curl_callback_data(response));
+               HTTP_CURL_OPT(WRITEHEADER, http_curl_callback_data(response));
        }
 
        HTTP_CURL_OPT(HEADER, 0);
@@ -237,23 +345,17 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
        HTTP_CURL_OPT(WRITEFUNCTION, http_curl_write_callback);
        HTTP_CURL_OPT(HEADERFUNCTION, http_curl_write_callback);
 
-       if (response) {
-               HTTP_CURL_OPT(WRITEDATA, response);
-               HTTP_CURL_OPT(WRITEHEADER, response);
-       }
-
 #if defined(ZTS) && (LIBCURL_VERSION_NUM >= 0x070a00)
        HTTP_CURL_OPT(NOSIGNAL, 1);
 #endif
 #if LIBCURL_VERSION_NUM < 0x070c00
-       HTTP_CURL_OPT(ERRORBUFFER, HTTP_G(request).curl.error);
+       HTTP_CURL_OPT(ERRORBUFFER, HTTP_G(request).error);
 #endif
 
        /* progress callback */
        if (zoption = http_curl_getopt(options, "onprogress", 0)) {
-               HTTP_CURL_OPT(NOPROGRESS, 0);
                HTTP_CURL_OPT(PROGRESSFUNCTION, http_curl_progress_callback);
-               HTTP_CURL_OPT(PROGRESSDATA, zoption);
+               HTTP_CURL_OPT(PROGRESSDATA,  http_curl_callback_data(zoption));
        } else {
                HTTP_CURL_OPT(NOPROGRESS, 1);
        }
@@ -262,21 +364,21 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
        if (zoption = http_curl_getopt(options, "ondebug", 0)) {
                HTTP_CURL_OPT(VERBOSE, 1);
                HTTP_CURL_OPT(DEBUGFUNCTION, http_curl_debug_callback);
-               HTTP_CURL_OPT(DEBUGDATA, zoption);
+               HTTP_CURL_OPT(DEBUGDATA, http_curl_callback_data(zoption));
        } else {
                HTTP_CURL_OPT(VERBOSE, 0);
        }
 
        /* proxy */
        if (zoption = http_curl_getopt(options, "proxyhost", IS_STRING)) {
-               HTTP_CURL_OPT(PROXY, http_curl_copystr(Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(PROXY, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
                /* port */
                if (zoption = http_curl_getopt(options, "proxyport", IS_LONG)) {
                        HTTP_CURL_OPT(PROXYPORT, Z_LVAL_P(zoption));
                }
                /* user:pass */
                if (zoption = http_curl_getopt(options, "proxyauth", IS_STRING)) {
-                       HTTP_CURL_OPT(PROXYUSERPWD, http_curl_copystr(Z_STRVAL_P(zoption)));
+                       HTTP_CURL_OPT(PROXYUSERPWD, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
                }
 #if LIBCURL_VERSION_NUM >= 0x070a07
                /* auth method */
@@ -288,7 +390,7 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
 
        /* outgoing interface */
        if (zoption = http_curl_getopt(options, "interface", IS_STRING)) {
-               HTTP_CURL_OPT(INTERFACE, http_curl_copystr(Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(INTERFACE, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
        }
 
        /* another port */
@@ -298,7 +400,7 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
 
        /* auth */
        if (zoption = http_curl_getopt(options, "httpauth", IS_STRING)) {
-               HTTP_CURL_OPT(USERPWD, http_curl_copystr(Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(USERPWD, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
        }
 #if LIBCURL_VERSION_NUM >= 0x070a06
        if (zoption = http_curl_getopt(options, "httpauthtype", IS_LONG)) {
@@ -309,7 +411,7 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
        /* compress, empty string enables deflate and gzip */
        if (zoption = http_curl_getopt(options, "compress", IS_BOOL)) {
                if (Z_LVAL_P(zoption)) {
-                       HTTP_CURL_OPT(ENCODING, http_curl_copystr(""));
+                       HTTP_CURL_OPT(ENCODING, http_request_data_copy(COPY_STRING, ""));
                }
        }
 
@@ -326,14 +428,14 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
 
        /* referer */
        if (zoption = http_curl_getopt(options, "referer", IS_STRING)) {
-               HTTP_CURL_OPT(REFERER, http_curl_copystr(Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(REFERER, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
        }
 
        /* useragent, default "PECL::HTTP/version (PHP/version)" */
        if (zoption = http_curl_getopt(options, "useragent", IS_STRING)) {
-               HTTP_CURL_OPT(USERAGENT, http_curl_copystr(Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(USERAGENT, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
        } else {
-               HTTP_CURL_OPT(USERAGENT, "PECL::HTTP/" HTTP_PEXT_VERSION " (PHP/" PHP_VERSION ")");
+               HTTP_CURL_OPT(USERAGENT, http_request_data_copy(COPY_STRING, "PECL::HTTP/" HTTP_PEXT_VERSION " (PHP/" PHP_VERSION ")"));
        }
 
        /* additional headers, array('name' => 'value') */
@@ -348,7 +450,7 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
                                if (SUCCESS == zend_hash_get_current_data(Z_ARRVAL_P(zoption), (void **) &header_val)) {
                                        char header[1024] = {0};
                                        snprintf(header, 1023, "%s: %s", header_key, Z_STRVAL_PP(header_val));
-                                       headers = curl_slist_append(headers, http_curl_copystr(header));
+                                       headers = curl_slist_append(headers, http_request_data_copy(COPY_STRING, header));
                                }
 
                                /* reset */
@@ -357,8 +459,10 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
                }
 
                if (headers) {
-                       HTTP_CURL_OPT(HTTPHEADER, headers);
+                       HTTP_CURL_OPT(HTTPHEADER, http_request_data_copy(COPY_SLIST, headers));
                }
+       } else {
+               HTTP_CURL_OPT(HTTPHEADER, NULL);
        }
 
        /* cookies, array('name' => 'value') */
@@ -381,15 +485,15 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
 
                if (qstr->used) {
                        phpstr_fix(qstr);
-                       HTTP_CURL_OPT(COOKIE, http_curl_copystr(qstr->data));
+                       HTTP_CURL_OPT(COOKIE, http_request_data_copy(COPY_STRING, qstr->data));
                }
                phpstr_free(qstr);
        }
 
        /* cookiestore */
        if (zoption = http_curl_getopt(options, "cookiestore", IS_STRING)) {
-               HTTP_CURL_OPT(COOKIEFILE, http_curl_copystr(Z_STRVAL_P(zoption)));
-               HTTP_CURL_OPT(COOKIEJAR, http_curl_copystr(Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(COOKIEFILE, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
+               HTTP_CURL_OPT(COOKIEJAR, http_request_data_copy(COPY_STRING, Z_STRVAL_P(zoption)));
        }
 
        /* resume */
@@ -488,8 +592,7 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
                                curl_easy_setopt(ch, CURLOPT_CUSTOMREQUEST, http_request_method_name(meth));
                        } else {
                                http_error_ex(E_WARNING, HTTP_E_CURL, "Unsupported request method: %d", meth);
-                               status = FAILURE;
-                               goto http_request_end;
+                               return FAILURE;
                        }
                break;
        }
@@ -499,7 +602,7 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
                switch (body->type)
                {
                        case HTTP_REQUEST_BODY_CSTRING:
-                               curl_easy_setopt(ch, CURLOPT_POSTFIELDS, (char *) body->data);
+                               curl_easy_setopt(ch, CURLOPT_POSTFIELDS, body->data);
                                curl_easy_setopt(ch, CURLOPT_POSTFIELDSIZE, body->size);
                        break;
 
@@ -508,92 +611,113 @@ PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const c
                        break;
 
                        case HTTP_REQUEST_BODY_UPLOADFILE:
-                       case HTTP_REQUEST_BODY_UPLOADDATA:
-                               curl_easy_setopt(ch, CURLOPT_READDATA, body);
+                               curl_easy_setopt(ch, CURLOPT_READDATA, http_curl_callback_data(body));
                                curl_easy_setopt(ch, CURLOPT_INFILESIZE, body->size);
                        break;
 
                        default:
-                               http_error_ex(E_WARNING, HTTP_E_CURL, "Unkown request body type: %d", body->type);
-                               status = FAILURE;
-                               goto http_request_end;
+                               http_error_ex(E_WARNING, HTTP_E_CURL, "Unknown request body type: %d", body->type);
+                               return FAILURE;
                        break;
                }
        }
 
+       return SUCCESS;
+}
+/* }}} */
+
+/* {{{ STATUS http_request_exec(CURL *, HashTable *) */
+PHP_HTTP_API STATUS _http_request_exec(CURL *ch, HashTable *info TSRMLS_DC)
+{
+       CURLcode result;
+
        /* perform request */
-       if (CURLE_OK == (result = curl_easy_perform(ch))) {
+       if (CURLE_OK != (result = curl_easy_perform(ch))) {
+               http_error_ex(E_WARNING, HTTP_E_CURL, "Could not perform request: %s", curl_easy_strerror(result));
+               return FAILURE;
+       } else {
                /* get curl info */
                if (info) {
-                       zval array;
-                       Z_ARRVAL(array) = info;
+                       http_request_info(ch, info);
+               }
+               return SUCCESS;
+       }
+}
+/* }}} */
 
-                       HTTP_CURL_INFO(EFFECTIVE_URL);
+/* {{{ void http_request_info(CURL *, HashTable *) */
+PHP_HTTP_API void _http_request_info(CURL *ch, HashTable *info TSRMLS_DC)
+{
+       zval array;
+       Z_ARRVAL(array) = info;
+
+       HTTP_CURL_INFO(EFFECTIVE_URL);
 #if LIBCURL_VERSION_NUM >= 0x070a07
-                       HTTP_CURL_INFO(RESPONSE_CODE);
+       HTTP_CURL_INFO(RESPONSE_CODE);
 #else
-                       HTTP_CURL_INFO_EX(HTTP_CODE, RESPONSE_CODE);
+       HTTP_CURL_INFO_EX(HTTP_CODE, RESPONSE_CODE);
 #endif
-                       HTTP_CURL_INFO(HTTP_CONNECTCODE);
+       HTTP_CURL_INFO(HTTP_CONNECTCODE);
 #if LIBCURL_VERSION_NUM >= 0x070500
-                       HTTP_CURL_INFO(FILETIME);
+       HTTP_CURL_INFO(FILETIME);
 #endif
-                       HTTP_CURL_INFO(TOTAL_TIME);
-                       HTTP_CURL_INFO(NAMELOOKUP_TIME);
-                       HTTP_CURL_INFO(CONNECT_TIME);
-                       HTTP_CURL_INFO(PRETRANSFER_TIME);
-                       HTTP_CURL_INFO(STARTTRANSFER_TIME);
+       HTTP_CURL_INFO(TOTAL_TIME);
+       HTTP_CURL_INFO(NAMELOOKUP_TIME);
+       HTTP_CURL_INFO(CONNECT_TIME);
+       HTTP_CURL_INFO(PRETRANSFER_TIME);
+       HTTP_CURL_INFO(STARTTRANSFER_TIME);
 #if LIBCURL_VERSION_NUM >= 0x070907
-                       HTTP_CURL_INFO(REDIRECT_TIME);
-                       HTTP_CURL_INFO(REDIRECT_COUNT);
-#endif
-                       HTTP_CURL_INFO(SIZE_UPLOAD);
-                       HTTP_CURL_INFO(SIZE_DOWNLOAD);
-                       HTTP_CURL_INFO(SPEED_DOWNLOAD);
-                       HTTP_CURL_INFO(SPEED_UPLOAD);
-                       HTTP_CURL_INFO(HEADER_SIZE);
-                       HTTP_CURL_INFO(REQUEST_SIZE);
-                       HTTP_CURL_INFO(SSL_VERIFYRESULT);
+       HTTP_CURL_INFO(REDIRECT_TIME);
+       HTTP_CURL_INFO(REDIRECT_COUNT);
+#endif
+       HTTP_CURL_INFO(SIZE_UPLOAD);
+       HTTP_CURL_INFO(SIZE_DOWNLOAD);
+       HTTP_CURL_INFO(SPEED_DOWNLOAD);
+       HTTP_CURL_INFO(SPEED_UPLOAD);
+       HTTP_CURL_INFO(HEADER_SIZE);
+       HTTP_CURL_INFO(REQUEST_SIZE);
+       HTTP_CURL_INFO(SSL_VERIFYRESULT);
 #if LIBCURL_VERSION_NUM >= 0x070c03
-                       /*HTTP_CURL_INFO(SSL_ENGINES); todo: CURLINFO_SLIST */
+       /*HTTP_CURL_INFO(SSL_ENGINES); todo: CURLINFO_SLIST */
 #endif
-                       HTTP_CURL_INFO(CONTENT_LENGTH_DOWNLOAD);
-                       HTTP_CURL_INFO(CONTENT_LENGTH_UPLOAD);
-                       HTTP_CURL_INFO(CONTENT_TYPE);
+       HTTP_CURL_INFO(CONTENT_LENGTH_DOWNLOAD);
+       HTTP_CURL_INFO(CONTENT_LENGTH_UPLOAD);
+       HTTP_CURL_INFO(CONTENT_TYPE);
 #if LIBCURL_VERSION_NUM >= 0x070a03
-                       /*HTTP_CURL_INFO(PRIVATE);*/
+       /*HTTP_CURL_INFO(PRIVATE);*/
 #endif
 #if LIBCURL_VERSION_NUM >= 0x070a08
-                       HTTP_CURL_INFO(HTTPAUTH_AVAIL);
-                       HTTP_CURL_INFO(PROXYAUTH_AVAIL);
+       HTTP_CURL_INFO(HTTPAUTH_AVAIL);
+       HTTP_CURL_INFO(PROXYAUTH_AVAIL);
 #endif
 #if LIBCURL_VERSION_NUM >= 0x070c02
-                       /*HTTP_CURL_INFO(OS_ERRNO);*/
+       /*HTTP_CURL_INFO(OS_ERRNO);*/
 #endif
 #if LIBCURL_VERSION_NUM >= 0x070c03
-                       HTTP_CURL_INFO(NUM_CONNECTS);
+       HTTP_CURL_INFO(NUM_CONNECTS);
 #endif
+}
+/* }}} */
+
+/* {{{ STATUS http_request_ex(CURL *, http_request_method, char *, http_request_body, HashTable, HashTable, phpstr *) */
+PHP_HTTP_API STATUS _http_request_ex(CURL *ch, http_request_method meth, const char *url, http_request_body *body, HashTable *options, HashTable *info, phpstr *response TSRMLS_DC)
+{
+       STATUS status;
+       zend_bool clean_curl;
+
+       if ((clean_curl = (!ch))) {
+               if (!(ch = curl_easy_init())) {
+                       http_error(E_WARNING, HTTP_E_CURL, "Could not initialize curl.");
+                       return FAILURE;
                }
-       } else {
-               http_error_ex(E_WARNING, HTTP_E_CURL, "Could not perform request: %s", curl_easy_strerror(result));
-               status = FAILURE;
        }
 
-http_request_end:
-       /* free strings copied with http_curl_copystr() */
-       zend_llist_clean(&HTTP_G(request).curl.copies);
+       status =        ((SUCCESS == http_request_init(ch, meth, url, body, options, response)) &&
+                               (SUCCESS == http_request_exec(ch, info))) ? SUCCESS : FAILURE;
 
-       /* clean curl handle if acquired */
        if (clean_curl) {
                curl_easy_cleanup(ch);
-               ch = NULL;
        }
-
-       /* finalize response */
-       if (response) {
-               phpstr_fix(PHPSTR(response));
-       }
-
        return status;
 }
 /* }}} */
@@ -648,10 +772,16 @@ PHP_HTTP_API unsigned long _http_request_method_exists(zend_bool by_name, unsign
 PHP_HTTP_API unsigned long _http_request_method_register(const char *method TSRMLS_DC)
 {
        zval array;
+       char *http_method;
        unsigned long meth_num = HTTP_G(request).methods.custom.nNextFreeElement + HTTP_MAX_REQUEST_METHOD;
 
        Z_ARRVAL(array) = &HTTP_G(request).methods.custom;
        add_next_index_string(&array, estrdup(method), 0);
+
+       spprintf(&http_method, 0, "HTTP_%s", method);
+       zend_register_long_constant(http_method, strlen(http_method) + 1, meth_num, CONST_CS, http_module_number TSRMLS_CC);
+       efree(http_method);
+
        return meth_num;
 }
 /* }}} */
@@ -659,7 +789,214 @@ PHP_HTTP_API unsigned long _http_request_method_register(const char *method TSRM
 /* {{{ STATUS http_request_method_unregister(usngigned long) */
 PHP_HTTP_API STATUS _http_request_method_unregister(unsigned long method TSRMLS_DC)
 {
-       return zend_hash_index_del(&HTTP_G(request).methods.custom, HTTP_CUSTOM_REQUEST_METHOD(method));
+       zval **zmethod;
+       char *http_method;
+
+       if (SUCCESS != zend_hash_index_find(&HTTP_G(request).methods.custom, HTTP_CUSTOM_REQUEST_METHOD(method), (void **) &zmethod)) {
+               http_error_ex(E_NOTICE, HTTP_E_PARAM, "Request method with id %lu does not exist", method);
+               return FAILURE;
+       }
+
+       spprintf(&http_method, 0, "HTTP_%s", Z_STRVAL_PP(zmethod));
+
+       if (    (SUCCESS != zend_hash_index_del(&HTTP_G(request).methods.custom, HTTP_CUSTOM_REQUEST_METHOD(method)))
+               ||      (SUCCESS != zend_hash_del(EG(zend_constants), http_method, strlen(http_method) + 1))) {
+               http_error_ex(E_NOTICE, 0, "Could not unregister request method: %s", http_method);
+               efree(http_method);
+               return FAILURE;
+       }
+
+       efree(http_method);
+       return SUCCESS;
+}
+/* }}} */
+
+
+/* {{{ http_request_pool *http_request_pool_init(http_request_pool *) */
+PHP_HTTP_API http_request_pool *_http_request_pool_init(http_request_pool *pool TSRMLS_DC)
+{
+       zend_bool free_pool;
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Initializing request pool\n");
+#endif
+       if ((free_pool = (!pool))) {
+               pool = emalloc(sizeof(http_request_pool));
+               pool->ch = NULL;
+       }
+
+       if (!pool->ch) {
+               if (!(pool->ch = curl_multi_init())) {
+                       http_error(E_WARNING, HTTP_E_CURL, "Could not initialize curl");
+                       if (free_pool) {
+                               efree(pool);
+                       }
+                       return NULL;
+               }
+       }
+
+       pool->unfinished = 0;
+       zend_llist_init(&pool->handles, sizeof(zval *), (llist_dtor_func_t) ZVAL_PTR_DTOR, 0);
+       zend_llist_init(&pool->bodies, sizeof(http_request_body *), (llist_dtor_func_t) http_request_pool_freebody, 0);
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Initialized request pool %p\n", pool);
+#endif
+       return pool;
+}
+/* }}} */
+
+/* {{{ STATUS http_request_pool_attach(http_request_pool *, zval *) */
+PHP_HTTP_API STATUS _http_request_pool_attach(http_request_pool *pool, zval *request TSRMLS_DC)
+{
+       getObjectEx(http_request_object, req, request);
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Attaching request %p to pool %p\n", req, pool);
+#endif
+       if (req->pool) {
+               http_error(E_WARNING, HTTP_E_CURL, "HttpRequest object is already member of an HttpRequestPool");
+       } else {
+               CURLMcode code;
+               http_request_body *body = http_request_body_new();
+               zval *info = GET_PROP_EX(req, request, responseInfo);
+
+               if (SUCCESS != http_request_object_requesthandler(req, request, body)) {
+                       http_error_ex(E_WARNING, HTTP_E_CURL, "Could not initialize HttpRequest object for attaching to the HttpRequestPool");
+               } else if (CURLM_OK != (code = curl_multi_add_handle(pool->ch, req->ch))) {
+                       http_error_ex(E_WARNING, HTTP_E_CURL, "Could not attach HttpRequest object to the HttpRequestPool: %s", curl_multi_strerror(code));
+               } else {
+                       req->pool = pool;
+                       zval_add_ref(&request);
+                       zend_llist_add_element(&pool->handles, &request);
+                       zend_llist_add_element(&pool->bodies, &body);
+                       return SUCCESS;
+               }
+               efree(body);
+       }
+       return FAILURE;
+}
+/* }}} */
+
+/* {{{ STATUS http_request_pool_detach(http_request_pool *, zval *) */
+PHP_HTTP_API STATUS _http_request_pool_detach(http_request_pool *pool, zval *request TSRMLS_DC)
+{
+       getObjectEx(http_request_object, req, request);
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Detaching request %p (pool: %p) from pool %p\n", req, req->pool, pool);
+#endif
+       if (req->pool != pool) {
+               http_error(E_WARNING, HTTP_E_CURL, "HttpRequest object is not attached to this HttpRequestPool");
+       } else {
+               CURLMcode code;
+
+               if (CURLM_OK != (code = curl_multi_remove_handle(pool->ch, req->ch))) {
+                       http_error_ex(E_WARNING, HTTP_E_CURL, "Could not detach HttpRequest object from the HttpRequestPool: %s", curl_multi_strerror(code));
+               } else {
+                       req->pool = NULL;
+                       zval_ptr_dtor(&request);
+                       return SUCCESS;
+               }
+       }
+       return FAILURE;
+}
+/* }}} */
+
+/* {{{ void http_request_pool_detach_all(http_request_pool *) */
+PHP_HTTP_API void _http_request_pool_detach_all(http_request_pool *pool TSRMLS_DC)
+{
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Detaching all requests from pool %p\n", pool);
+#endif
+       zend_llist_apply_with_argument(&pool->handles, (llist_apply_with_arg_func_t) http_request_pool_freehandle, pool TSRMLS_CC);
+}
+
+
+/* {{{ STATUS http_request_pool_send(http_request_pool *) */
+PHP_HTTP_API STATUS _http_request_pool_send(http_request_pool *pool TSRMLS_DC)
+{
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Attempt to send requests of pool %p\n", pool);
+#endif
+       while (http_request_pool_perform(pool)) {
+#if HTTP_DEBUG_REQPOOLS
+               fprintf(stderr, "%d unfinished requests of pool %p remaining\n", pool->unfinished, pool);
+#endif
+               if (SUCCESS != http_request_pool_select(pool)) {
+                       http_error(E_WARNING, HTTP_E_CURL, "Socket error");
+                       return FAILURE;
+               }
+       }
+       zend_llist_apply(&pool->handles, (llist_apply_func_t) http_request_pool_responsehandler TSRMLS_CC);
+       return SUCCESS;
+}
+/* }}} */
+
+/* {{{ void http_request_pool_dtor(http_request_pool *) */
+PHP_HTTP_API void _http_request_pool_dtor(http_request_pool *pool TSRMLS_DC)
+{
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Destructing request pool %p\n", pool);
+#endif
+       pool->unfinished = 0;
+       zend_llist_clean(&pool->handles);
+       zend_llist_clean(&pool->bodies);
+       curl_multi_cleanup(pool->ch);
+}
+/* }}} */
+
+/* {{{ STATUS http_request_pool_select(http_request_pool *) */
+PHP_HTTP_API STATUS _http_request_pool_select(http_request_pool *pool)
+{
+       int MAX;
+       fd_set R, W, E;
+       struct timeval timeout = {1, 0};
+
+       FD_ZERO(&R);
+       FD_ZERO(&W);
+       FD_ZERO(&E);
+
+       curl_multi_fdset(pool->ch, &R, &W, &E, &MAX);
+       return (-1 != select(MAX + 1, &R, &W, &E, &timeout)) ? SUCCESS : FAILURE;
+}
+/* }}} */
+
+/* {{{ int http_request_pool_perform(http_request_pool *) */
+PHP_HTTP_API int _http_request_pool_perform(http_request_pool *pool)
+{
+       while (CURLM_CALL_MULTI_PERFORM == curl_multi_perform(pool->ch, &pool->unfinished));
+       return pool->unfinished;
+}
+/* }}} */
+
+/* {{{ void http_request_pool_responsehandler(zval **) */
+void _http_request_pool_responsehandler(zval **req TSRMLS_DC)
+{
+       getObjectEx(http_request_object, obj, *req);
+#if HTTP_DEBUG_REQPOOLS
+       fprintf(stderr, "Fetching data from request %p of pool %p\n", obj, obj->pool);
+#endif
+       http_request_object_responsehandler(obj, *req, NULL);
+}
+/* }}} */
+
+/*#*/
+
+/* {{{ static void http_request_pool_freebody(http_request_body **) */
+static void http_request_pool_freebody(http_request_body **body)
+{
+       TSRMLS_FETCH();
+       http_request_body_free(*body);
+}
+/* }}} */
+
+/* {{{ static void http_request_pool_freehandle(zval **, http_request_pool *) */
+static void http_request_pool_freehandle(zval **request, http_request_pool *pool TSRMLS_DC)
+{
+       getObjectEx(http_request_object, req, *request);
+       if (req->pool) {
+               http_request_pool_detach(pool, *request);
+       }
+#if HTTP_DEBUG_REQPOOLS
+       else fprintf(stderr, "Request %p (pool: %p) is not (anymore) attached to pool %p\n", req, req->pool, pool);
+#endif
 }
 /* }}} */
 
@@ -701,19 +1038,11 @@ static const char *const http_request_methods[] = {
 };
 /* }}} */
 
-/* {{{ static inline char *http_curl_copystr(char *) */
-static inline char *_http_curl_copystr(const char *str TSRMLS_DC)
-{
-       char *new_str = estrdup(str);
-       zend_llist_add_element(&HTTP_G(request).curl.copies, &new_str);
-       return new_str;
-}
-/* }}} */
-
 /* {{{ static size_t http_curl_write_callback(char *, size_t, size_t, void *) */
 static size_t http_curl_write_callback(char *buf, size_t len, size_t n, void *s)
 {
-       return s ? phpstr_append(PHPSTR(s), buf, len * n) : len * n;
+       HTTP_CURL_CALLBACK_DATA(s, phpstr *, str);
+       return str ? phpstr_append(PHPSTR(str), buf, len * n) : len * n;
 }
 /* }}} */
 
@@ -721,50 +1050,30 @@ static size_t http_curl_write_callback(char *buf, size_t len, size_t n, void *s)
 static size_t http_curl_read_callback(void *data, size_t len, size_t n, void *s)
 {
        static char *offset = NULL, *original = NULL;
-       http_request_body *body = (http_request_body *) s;
-
-       switch (body->type)
-       {
-               case HTTP_REQUEST_BODY_UPLOADFILE:
-               {
-                       TSRMLS_FETCH();
-                       return php_stream_read((php_stream *) body->data, data, len * n);
-               }
-               break;
-
-               case HTTP_REQUEST_BODY_UPLOADDATA:
-               {
-                       size_t avail;
-                       if (original != s) {
-                               original = offset = s;
-                       }
-                       if ((avail = body->size - (offset - original)) < 1) {
-                               return 0;
-                       }
-                       if (avail < (len * n)) {
-                               memcpy(data, offset, avail);
-                               offset += avail;
-                               return avail;
-                       } else {
-                               memcpy(data, offset, len * n);
-                               offset += len * n;
-                               return len * n;
-                       }
-               }
-               break;
+       HTTP_CURL_CALLBACK_DATA(s, http_request_body *, body);
 
-               default:
-                       return 0;
-               break;
+       if (body->type != HTTP_REQUEST_BODY_UPLOADFILE) {
+               return 0;
        }
+       return php_stream_read((php_stream *) body->data, data, len * n);
+}
+/* }}} */
+
+/* {{{ http_curl_callback_ctx http_curl_callback_data(void *) */
+static http_curl_callback_ctx *_http_curl_callback_data(void *data TSRMLS_DC)
+{
+       http_curl_callback_ctx *ctx = emalloc(sizeof(http_curl_callback_ctx));
+       TSRMLS_SET_CTX(ctx->tsrm_ctx);
+       ctx->data = data;
+       return ctx;
 }
 /* }}} */
 
 /* {{{ static int http_curl_progress_callback(void *, double, double, double, double) */
 static int http_curl_progress_callback(void *data, double dltotal, double dlnow, double ultotal, double ulnow)
 {
-       zval *params_pass[4], params_local[4], retval, *func = (zval *) data;
-       TSRMLS_FETCH();
+       zval *params_pass[4], params_local[4], retval;
+       HTTP_CURL_CALLBACK_DATA(data, zval *, func);
 
        params_pass[0] = &params_local[0];
        params_pass[1] = &params_local[1];
@@ -782,8 +1091,8 @@ static int http_curl_progress_callback(void *data, double dltotal, double dlnow,
 
 static int http_curl_debug_callback(CURL *ch, curl_infotype type, char *string, size_t length, void *data)
 {
-       zval *params_pass[2], params_local[2], retval, *func = (zval *) data;
-       TSRMLS_FETCH();
+       zval *params_pass[2], params_local[2], retval;
+       HTTP_CURL_CALLBACK_DATA(data, zval *, func);
 
        params_pass[0] = &params_local[0];
        params_pass[1] = &params_local[1];