* weird, weird
[m6w6/ext-http] / http.c
diff --git a/http.c b/http.c
index f6ea5ebffc3821042d8d6bb6af003f435eb3e128..af002673be7499e01335e92558dc2e4247a055d0 100644 (file)
--- a/http.c
+++ b/http.c
@@ -117,8 +117,9 @@ function_entry http_functions[] = {
 #define RETURN_SUCCESS(v) RETURN_BOOL(SUCCESS == (v))
 #define HASH_ORNULL(z) ((z) ? Z_ARRVAL_P(z) : NULL)
 #define NO_ARGS if (ZEND_NUM_ARGS()) WRONG_PARAM_COUNT
-#define HTTP_URL_ARGSEP_OVERRIDE zend_alter_ini_entry("arg_separator.output", sizeof("arg_separator.output") - 1, "&", 1, ZEND_INI_ALL, ZEND_INI_STAGE_RUNTIME)
-#define HTTP_URL_ARGSEP_RESTORE zend_restore_ini_entry("arg_separator.output", sizeof("arg_separator.output") - 1, ZEND_INI_STAGE_RUNTIME)
+
+#define array_copy(src, dst) zend_hash_copy(Z_ARRVAL_P(dst), Z_ARRVAL_P(src), (copy_ctor_func_t) zval_add_ref, NULL, sizeof(zval *))
+#define array_merge(src, dst) zend_hash_merge(Z_ARRVAL_P(dst), Z_ARRVAL_P(src), (copy_ctor_func_t) zval_add_ref, NULL, sizeof(zval *), 1)
 
 #ifdef ZEND_ENGINE_2
 
@@ -152,6 +153,24 @@ function_entry http_functions[] = {
 #      define SET_PROP(o, n, z) zend_update_property(o->zo.ce, getThis(), (#n), sizeof(#n), (z) TSRMLS_CC)
 #      define GET_PROP(o, n) zend_read_property(o->zo.ce, getThis(), (#n), sizeof(#n), 0 TSRMLS_CC)
 
+#      define INIT_PARR(o, n) \
+       { \
+               zval *__tmp; \
+               MAKE_STD_ZVAL(__tmp); \
+               array_init(__tmp); \
+               SET_PROP(o, n, __tmp); \
+       }
+
+#      define FREE_PARR(o, p) \
+       { \
+               zval *__tmp = NULL; \
+               if (__tmp = GET_PROP(o, p)) { \
+                       zval_dtor(__tmp); \
+                       FREE_ZVAL(__tmp); \
+                       __tmp = NULL; \
+               } \
+       }
+
 /* {{{ HTTPi */
 
 zend_class_entry *httpi_ce;
@@ -233,7 +252,7 @@ zend_object_value _httpi_response_new_object(zend_class_entry *ce TSRMLS_DC)
        zend_object_value ov;
        httpi_response_object *o;
 
-       o = ecalloc(sizeof(httpi_response_object), 1);
+       o = ecalloc(1, sizeof(httpi_response_object));
        o->zo.ce = ce;
 
        ALLOC_HASHTABLE(OBJ_PROP(o));
@@ -715,8 +734,11 @@ zend_class_entry *httpi_request_ce;
 static zend_object_handlers httpi_request_object_handlers;
 
 typedef struct {
-       zend_object     zo;
+       zend_object zo;
        CURL *ch;
+
+       struct curl_httppost *post_data[2];
+
 } httpi_request_object;
 
 #define httpi_request_declare_default_properties(ce) _httpi_request_declare_default_properties(ce TSRMLS_CC)
@@ -725,24 +747,29 @@ static inline void _httpi_request_declare_default_properties(zend_class_entry *c
        DCL_PROP_N(PROTECTED, options);
        DCL_PROP_N(PROTECTED, responseInfo);
        DCL_PROP_N(PROTECTED, responseData);
-       
+       DCL_PROP_N(PROTECTED, postData);
+       DCL_PROP_N(PROTECTED, postFiles);
+
        DCL_PROP(PROTECTED, long, method, HTTP_GET);
-       
+
        DCL_PROP(PROTECTED, string, url, "");
        DCL_PROP(PROTECTED, string, contentType, "");
        DCL_PROP(PROTECTED, string, queryData, "");
+       DCL_PROP(PROTECTED, string, postData, "");
 }
 
-#define httpi_request_destroy_object _httpi_request_destroy_object
-void _httpi_request_destroy_object(void *object, zend_object_handle handle TSRMLS_DC)
+#define httpi_request_free_object _httpi_request_free_object
+void _httpi_request_free_object(zend_object /* void */ *object TSRMLS_DC)
 {
-       httpi_request_object *o = object;
+       httpi_request_object *o = (httpi_request_object *) object;
+
        if (OBJ_PROP(o)) {
                zend_hash_destroy(OBJ_PROP(o));
                FREE_HASHTABLE(OBJ_PROP(o));
        }
        if (o->ch) {
                curl_easy_cleanup(o->ch);
+               o->ch = NULL;
        }
        efree(o);
 }
@@ -753,15 +780,17 @@ zend_object_value _httpi_request_new_object(zend_class_entry *ce TSRMLS_DC)
        zend_object_value ov;
        httpi_request_object *o;
 
-       o = ecalloc(sizeof(httpi_request_object), 1);
+       o = ecalloc(1, sizeof(httpi_request_object));
        o->zo.ce = ce;
        o->ch = curl_easy_init();
+       o->post_data[0] = NULL;
+       o->post_data[1] = NULL;
 
        ALLOC_HASHTABLE(OBJ_PROP(o));
        zend_hash_init(OBJ_PROP(o), 0, NULL, ZVAL_PTR_DTOR, 0);
        zend_hash_copy(OBJ_PROP(o), &ce->default_properties, (copy_ctor_func_t) zval_add_ref, NULL, sizeof(zval *));
-       
-       ov.handle = zend_objects_store_put(o, httpi_request_destroy_object, NULL, NULL TSRMLS_CC);
+
+       ov.handle = zend_objects_store_put(o, (zend_objects_store_dtor_t) zend_objects_destroy_object, httpi_request_free_object, NULL TSRMLS_CC);
        ov.handlers = &httpi_request_object_handlers;
 
        return ov;
@@ -769,11 +798,11 @@ zend_object_value _httpi_request_new_object(zend_class_entry *ce TSRMLS_DC)
 
 zend_function_entry httpi_request_class_methods[] = {
        PHP_ME(HTTPi_Request, __construct, NULL, ZEND_ACC_PUBLIC|ZEND_ACC_CTOR)
-/*     PHP_ME(HTTPi_Request, __destruct, NULL, ZEND_ACC_PUBLIC|ZEND_ACC_DTOR)
+       PHP_ME(HTTPi_Request, __destruct, NULL, ZEND_ACC_PUBLIC|ZEND_ACC_DTOR)
 
        PHP_ME(HTTPi_Request, setOptions, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, getOptions, NULL, ZEND_ACC_PUBLIC)
-*/
+
        PHP_ME(HTTPi_Request, setMethod, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, getMethod, NULL, ZEND_ACC_PUBLIC)
 
@@ -787,23 +816,27 @@ zend_function_entry httpi_request_class_methods[] = {
        PHP_ME(HTTPi_Request, getQueryData, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, addQueryData, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, unsetQueryData, NULL, ZEND_ACC_PUBLIC)
-/*
+
        PHP_ME(HTTPi_Request, setPostData, NULL, ZEND_ACC_PUBLIC)
+       PHP_ME(HTTPi_Request, getPostData, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, addPostData, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, unsetPostData, NULL, ZEND_ACC_PUBLIC)
 
        PHP_ME(HTTPi_Request, addPostFile, NULL, ZEND_ACC_PUBLIC)
-*/
+       PHP_ME(HTTPi_Request, getPostFiles, NULL, ZEND_ACC_PUBLIC)
+       PHP_ME(HTTPi_Request, unsetPostFiles, NULL, ZEND_ACC_PUBLIC)
+
        PHP_ME(HTTPi_Request, send, NULL, ZEND_ACC_PUBLIC)
-       
+
        PHP_ME(HTTPi_Request, getResponseData, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, getResponseHeaders, NULL, ZEND_ACC_PUBLIC)
        PHP_ME(HTTPi_Request, getResponseBody, NULL, ZEND_ACC_PUBLIC)
+       PHP_ME(HTTPi_Request, getResponseInfo, NULL, ZEND_ACC_PUBLIC)
 
        {NULL, NULL, NULL}
 };
 
-/* {{{ proto void HTTPi_request::__construct([string url[, long request_method = HTTP_GET]])
+/* {{{ proto void HTTPi_Request::__construct([string url[, long request_method = HTTP_GET]])
  *
  */
 PHP_METHOD(HTTPi_Request, __construct)
@@ -813,15 +846,17 @@ PHP_METHOD(HTTPi_Request, __construct)
        long meth = -1;
        zval *info, *opts, *resp;
        getObject(httpi_request_object, obj);
-       
+
        if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|sl", &URL, &URL_len, &meth)) {
                return;
        }
-       
-       MAKE_STD_ZVAL(opts); array_init(opts); SET_PROP(obj, options, opts);
-       MAKE_STD_ZVAL(info); array_init(info); SET_PROP(obj, responseInfo, info);
-       MAKE_STD_ZVAL(resp); array_init(resp); SET_PROP(obj, responseData, resp);
-       
+
+       INIT_PARR(obj, options);
+       INIT_PARR(obj, responseInfo);
+       INIT_PARR(obj, responseData);
+       INIT_PARR(obj, postData);
+       INIT_PARR(obj, postFiles);
+
        if (URL) {
                UPD_PROP(obj, string, url, URL);
        }
@@ -831,7 +866,82 @@ PHP_METHOD(HTTPi_Request, __construct)
 }
 /* }}} */
 
-/* {{{ proto bool HTTPi_request::setURL(string url)
+/* {{{ proto void HTTPi_Request::__destruct()
+ *
+ */
+PHP_METHOD(HTTPi_Request, __destruct)
+{
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       FREE_PARR(obj, options);
+       FREE_PARR(obj, responseInfo);
+       FREE_PARR(obj, responseData);
+       FREE_PARR(obj, postData);
+       FREE_PARR(obj, postFiles);
+}
+/* }}} */
+
+/* {{{ proto bool HTTPi_Request::setOptions(array options)
+ *
+ */
+PHP_METHOD(HTTPi_Request, setOptions)
+{
+       zval *opts, *old_opts, **opt;
+       getObject(httpi_request_object, obj);
+
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a/", &opts)) {
+               RETURN_FALSE;
+       }
+
+       old_opts = GET_PROP(obj, options);
+
+       /* headers and cookies need extra attention -- thus cannot use zend_hash_merge() or php_array_merge() directly */
+       for (   zend_hash_internal_pointer_reset(Z_ARRVAL_P(opts));
+                       zend_hash_get_current_data(Z_ARRVAL_P(opts), (void **) &opt) == SUCCESS;
+                       zend_hash_move_forward(Z_ARRVAL_P(opts))) {
+               char *key;
+               long idx;
+               if (HASH_KEY_IS_STRING == zend_hash_get_current_key(Z_ARRVAL_P(opts), &key, &idx, 0)) {
+                       if (!strcmp(key, "headers")) {
+                               zval **headers;
+                               if (SUCCESS == zend_hash_find(Z_ARRVAL_P(old_opts), "headers", sizeof("headers"), (void **) &headers)) {
+                                       array_merge(*opt, *headers);
+                                       continue;
+                               }
+                       } else if (!strcmp(key, "cookies")) {
+                               zval **cookies;
+                               if (SUCCESS == zend_hash_find(Z_ARRVAL_P(old_opts), "cookies", sizeof("cookies"), (void **) &cookies)) {
+                                       array_merge(*opt, *cookies);
+                                       continue;
+                               }
+                       }
+                       zval_add_ref(opt);
+                       add_assoc_zval(old_opts, key, *opt);
+               }
+       }
+       RETURN_TRUE;
+}
+/* }}} */
+
+/* {{{ proto array HTTPi_Request::getOptions()
+ *
+ */
+PHP_METHOD(HTTPi_Request, getOptions)
+{
+       zval *opts;
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       opts = GET_PROP(obj, options);
+       array_init(return_value);
+       array_copy(opts, return_value);
+}
+/* }}} */
+
+/* {{{ proto bool HTTPi_Request::setURL(string url)
  *
  */
 PHP_METHOD(HTTPi_Request, setURL)
@@ -839,64 +949,64 @@ PHP_METHOD(HTTPi_Request, setURL)
        char *URL = NULL;
        int URL_len;
        getObject(httpi_request_object, obj);
-       
+
        if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &URL, &URL_len)) {
                RETURN_FALSE;
        }
-       
+
        UPD_PROP(obj, string, url, URL);
        RETURN_TRUE;
 }
 /* }}} */
 
-/* {{{ proto string HTTPi_request::getUrl()
+/* {{{ proto string HTTPi_Request::getUrl()
  *
  */
 PHP_METHOD(HTTPi_Request, getURL)
 {
        zval *URL;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        URL = GET_PROP(obj, url);
        RETURN_STRINGL(Z_STRVAL_P(URL), Z_STRLEN_P(URL), 1);
 }
 /* }}} */
 
-/* {{{ proto bool HTTPi_request::setMethod(long request_method)
+/* {{{ proto bool HTTPi_Request::setMethod(long request_method)
  *
  */
 PHP_METHOD(HTTPi_Request, setMethod)
 {
        long meth;
        getObject(httpi_request_object, obj);
-       
+
        if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &meth)) {
                RETURN_FALSE;
        }
-       
+
        UPD_PROP(obj, long, method, meth);
        RETURN_TRUE;
 }
 /* }}} */
 
-/* {{{ proto long HTTPi_request::getMethod()
+/* {{{ proto long HTTPi_Request::getMethod()
  *
  */
 PHP_METHOD(HTTPi_Request, getMethod)
 {
        zval *meth;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        meth = GET_PROP(obj, method);
        RETURN_LONG(Z_LVAL_P(meth));
 }
 /* }}} */
 
-/* {{{ proto bool HTTPi_request::setContentType(string content_type)
+/* {{{ proto bool HTTPi_Request::setContentType(string content_type)
  *
  */
 PHP_METHOD(HTTPi_Request, setContentType)
@@ -904,50 +1014,50 @@ PHP_METHOD(HTTPi_Request, setContentType)
        char *ctype;
        int ct_len;
        getObject(httpi_request_object, obj);
-       
+
        if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &ctype, &ct_len)) {
                RETURN_FALSE;
        }
-       
+
        if (!strchr(ctype, '/')) {
-               php_error_docref(NULL TSRMLS_CC, E_WARNING, 
-                       "Content-Type '%s' doesn't seem to contain a primary and a secondary part", 
+               php_error_docref(NULL TSRMLS_CC, E_WARNING,
+                       "Content-Type '%s' doesn't seem to contain a primary and a secondary part",
                        ctype);
                RETURN_FALSE;
        }
-       
+
        UPD_PROP(obj, string, contentType, ctype);
        RETURN_TRUE;
 }
 /* }}} */
 
-/* {{{ proto string HTTPi_request::getContentType()
+/* {{{ proto string HTTPi_Request::getContentType()
  *
  */
 PHP_METHOD(HTTPi_Request, getContentType)
 {
        zval *ctype;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        ctype = GET_PROP(obj, contentType);
        RETURN_STRINGL(Z_STRVAL_P(ctype), Z_STRLEN_P(ctype), 1);
 }
 /* }}} */
 
-/* {{{ proto bool HTTPi_request::setQueryData(mixed query_data)
+/* {{{ proto bool HTTPi_Request::setQueryData(mixed query_data)
  *
  */
 PHP_METHOD(HTTPi_Request, setQueryData)
 {
        zval *qdata;
        getObject(httpi_request_object, obj);
-       
+
        if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &qdata)) {
                RETURN_FALSE;
        }
-       
+
        if ((Z_TYPE_P(qdata) == IS_ARRAY) || (Z_TYPE_P(qdata) == IS_OBJECT)) {
                smart_str qstr = {0};
                HTTP_URL_ARGSEP_OVERRIDE;
@@ -965,29 +1075,29 @@ PHP_METHOD(HTTPi_Request, setQueryData)
                efree(qstr.c);
                RETURN_TRUE;
        }
-       
+
        convert_to_string(qdata);
        UPD_PROP(obj, string, queryData, Z_STRVAL_P(qdata));
        RETURN_TRUE;
 }
 /* }}} */
 
-/* {{{ proto string HTTPi_request::getQueryData()
+/* {{{ proto string HTTPi_Request::getQueryData()
  *
  */
 PHP_METHOD(HTTPi_Request, getQueryData)
 {
        zval *qdata;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        qdata = GET_PROP(obj, queryData);
        RETURN_STRINGL(Z_STRVAL_P(qdata), Z_STRLEN_P(qdata), 1);
 }
 /* }}} */
 
-/* {{{ proto bool HTTPi_request::addQueryData(array query_params)
+/* {{{ proto bool HTTPi_Request::addQueryData(array query_params)
  *
  */
 PHP_METHOD(HTTPi_Request, addQueryData)
@@ -996,16 +1106,16 @@ PHP_METHOD(HTTPi_Request, addQueryData)
        smart_str qstr = {0};
        char *separator;
        getObject(httpi_request_object, obj);
-       
+
        if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a", &qdata)) {
                RETURN_FALSE;
        }
-       
+
        old_qdata = GET_PROP(obj, queryData);
        if (Z_STRLEN_P(old_qdata)) {
                smart_str_appendl(&qstr, Z_STRVAL_P(old_qdata), Z_STRLEN_P(old_qdata));
        }
-       
+
        HTTP_URL_ARGSEP_OVERRIDE;
        if (SUCCESS != php_url_encode_hash_ex(HASH_OF(qdata), &qstr, NULL, 0, NULL, 0, NULL, 0, NULL TSRMLS_CC)) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Couldn't encode query data");
@@ -1016,72 +1126,212 @@ PHP_METHOD(HTTPi_Request, addQueryData)
                RETURN_FALSE;
        }
        HTTP_URL_ARGSEP_RESTORE;
-       
+
        smart_str_0(&qstr);
-       
+
        UPD_PROP(obj, string, queryData, qstr.c);
        efree(qstr.c);
        RETURN_TRUE;
 }
 /* }}} */
 
-/* {{{ proto void HTTPi_request::unsetQueryData()
+/* {{{ proto void HTTPi_Request::unsetQueryData()
  *
  */
 PHP_METHOD(HTTPi_Request, unsetQueryData)
 {
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        UPD_PROP(obj, string, queryData, "");
 }
 /* }}} */
 
-/* {{{ proto array HTTPi_request::getResponseData()
+/* {{{ proto bool HTTPi_Request::addPostData(array post_data)
+ *
+ */
+PHP_METHOD(HTTPi_Request, addPostData)
+{
+       zval *post, *post_data;
+       getObject(httpi_request_object, obj);
+
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a", &post_data)) {
+               RETURN_FALSE;
+       }
+
+       post = GET_PROP(obj, postData);
+       array_merge(post_data, post);
+
+       RETURN_TRUE;
+}
+/* }}} */
+
+/* {{{ proto bool HTTPi_Request::setPostData(array post_data)
+ *
+ */
+PHP_METHOD(HTTPi_Request, setPostData)
+{
+       zval *post, *post_data;
+       getObject(httpi_request_object, obj);
+
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a", &post_data)) {
+               RETURN_FALSE;
+       }
+
+       post = GET_PROP(obj, postData);
+       zend_hash_clean(Z_ARRVAL_P(post));
+       array_copy(post_data, post);
+
+       RETURN_TRUE;
+}
+/* }}}*/
+
+/* {{{ proto array HTTPi_Request::getPostData()
+ *
+ */
+PHP_METHOD(HTTPi_Request, getPostData)
+{
+       zval *post_data;
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       post_data = GET_PROP(obj, postData);
+       array_init(return_value);
+       array_copy(post_data, return_value);
+}
+/* }}} */
+
+/* {{{ proto void HTTPi_Request::unsetPostData()
+ *
+ */
+PHP_METHOD(HTTPi_Request, unsetPostData)
+{
+       zval *post_data;
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       post_data = GET_PROP(obj, postData);
+       zend_hash_clean(Z_ARRVAL_P(post_data));
+}
+/* }}} */
+
+/* {{{ proto bool HTTPi_Request::addPostFile(string name, string file[, string content_type = "application/x-octetstream"])
+ *
+ */
+PHP_METHOD(HTTPi_Request, addPostFile)
+{
+       zval *files, *entry;
+       char *name, *file, *type = NULL;
+       int name_len, file_len, type_len = 0;
+       getObject(httpi_request_object, obj);
+
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss|s", &name, &name_len, &file, &file_len, &type, &type_len)) {
+               RETURN_FALSE;
+       }
+
+       if (type_len) {
+               if (!strchr(type, '/')) {
+                       php_error_docref(NULL TSRMLS_CC, E_WARNING, "Content-Type '%s' doesn't seem to contain a primary and a secondary part", type);
+                       RETURN_FALSE;
+               }
+       } else {
+               type = "application/x-octetstream";
+               type_len = sizeof("application/x-octetstream") - 1;
+       }
+
+       MAKE_STD_ZVAL(entry);
+       array_init(entry);
+
+       add_assoc_stringl(entry, "name", name, name_len, 1);
+       add_assoc_stringl(entry, "type", type, type_len, 1);
+       add_assoc_stringl(entry, "file", file, file_len, 1);
+
+       files  = GET_PROP(obj, postFiles);
+       add_next_index_zval(files, entry);
+
+       RETURN_TRUE;
+}
+/* }}} */
+
+/* {{{ proto array HTTPi_Request::getPostFiles()
+ *
+ */
+PHP_METHOD(HTTPi_Request, getPostFiles)
+{
+       zval *files;
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       files = GET_PROP(obj, postFiles);
+
+       array_init(return_value);
+       array_copy(files, return_value);
+}
+/* }}} */
+
+/* {{{ proto void HTTPi_Request::unsetPostFiles()
+ *
+ */
+PHP_METHOD(HTTPi_Request, unsetPostFiles)
+{
+       zval *files;
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       files = GET_PROP(obj, postFiles);
+       zend_hash_clean(Z_ARRVAL_P(files));
+}
+/* }}} */
+
+/* {{{ proto array HTTPi_Request::getResponseData()
  *
  */
 PHP_METHOD(HTTPi_Request, getResponseData)
 {
        zval *data;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        data = GET_PROP(obj, responseData);
        array_init(return_value);
-       zend_hash_copy(Z_ARRVAL_P(return_value), Z_ARRVAL_P(data), (copy_ctor_func_t) zval_add_ref, NULL, sizeof(zval *));
+       array_copy(data, return_value);
 }
 /* }}} */
 
-/* {{{ proto array HTTPi_request::getResponseHeaders()
+/* {{{ proto array HTTPi_Request::getResponseHeaders()
  *
  */
 PHP_METHOD(HTTPi_Request, getResponseHeaders)
 {
        zval *data, **headers;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        array_init(return_value);
        data = GET_PROP(obj, responseData);
        if (SUCCESS == zend_hash_find(Z_ARRVAL_P(data), "headers", sizeof("headers"), (void **) &headers)) {
-               zend_hash_copy(Z_ARRVAL_P(return_value), Z_ARRVAL_PP(headers), (copy_ctor_func_t) zval_add_ref, NULL, sizeof(zval *));
+               array_copy(*headers, return_value);
        }
 }
 /* }}} */
 
-/* {{{ proto string HTTPi_request::getResponseBody()
+/* {{{ proto string HTTPi_Request::getResponseBody()
  *
  */
 PHP_METHOD(HTTPi_Request, getResponseBody)
 {
        zval *data, **body;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        data = GET_PROP(obj, responseData);
        if (SUCCESS == zend_hash_find(Z_ARRVAL_P(data), "body", sizeof("body"), (void **) &body)) {
                RETURN_STRINGL(Z_STRVAL_PP(body), Z_STRLEN_PP(body), 1);
@@ -1091,31 +1341,50 @@ PHP_METHOD(HTTPi_Request, getResponseBody)
 }
 /* }}} */
 
-/* {{{ proto bool HTTPi_request::send()
+/* {{{ proto array HTTPi_Request::getResponseInfo()
+ *
+ */
+PHP_METHOD(HTTPi_Request, getResponseInfo)
+{
+       zval *info;
+       getObject(httpi_request_object, obj);
+
+       NO_ARGS;
+
+       info = GET_PROP(obj, responseInfo);
+       array_init(return_value);
+       array_copy(info, return_value);
+}
+/* }}}*/
+
+/* {{{ proto bool HTTPi_Request::send()
  *
  */
 PHP_METHOD(HTTPi_Request, send)
 {
+       STATUS status = FAILURE;
        zval *meth, *URL, *qdata, *opts, *info, *resp;
        char *response_data, *request_uri;
        size_t response_len;
        getObject(httpi_request_object, obj);
-       
+
        NO_ARGS;
-       
+
        if ((!obj->ch) && (!(obj->ch = curl_easy_init()))) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not initilaize cURL");
                RETURN_FALSE;
        }
-       
+
        meth  = GET_PROP(obj, method);
        URL   = GET_PROP(obj, url);
        qdata = GET_PROP(obj, queryData);
        opts  = GET_PROP(obj, options);
        info  = GET_PROP(obj, responseInfo);
        resp  = GET_PROP(obj, responseData);
-       
+
+       // HTTP_URI_MAXLEN+1 big char *
        request_uri = http_absolute_uri(Z_STRVAL_P(URL), NULL);
+
        if (Z_STRLEN_P(qdata) && (strlen(request_uri) < HTTP_URI_MAXLEN)) {
                if (!strchr(request_uri, '?')) {
                        strcat(request_uri, "?");
@@ -1124,46 +1393,112 @@ PHP_METHOD(HTTPi_Request, send)
                }
                strncat(request_uri, Z_STRVAL_P(qdata), HTTP_URI_MAXLEN - strlen(request_uri));
        }
-       
+
        switch (Z_LVAL_P(meth))
        {
                case HTTP_GET:
-                       if (SUCCESS != http_get_ex(obj->ch, request_uri, Z_ARRVAL_P(opts), Z_ARRVAL_P(info), &response_data, &response_len)) {
-                               RETURN_FALSE;
-                       }
+                       status = http_get_ex(obj->ch, request_uri, Z_ARRVAL_P(opts), Z_ARRVAL_P(info), &response_data, &response_len);
                break;
-               
+
                case HTTP_HEAD:
-                       if (SUCCESS != http_head_ex(obj->ch, request_uri, Z_ARRVAL_P(opts), Z_ARRVAL_P(info), &response_data, &response_len)) {
-                               RETURN_FALSE;
-                       }
+                       status = http_head_ex(obj->ch, request_uri, Z_ARRVAL_P(opts), Z_ARRVAL_P(info), &response_data, &response_len);
                break;
-               
+
                case HTTP_POST:
+                       {
+                               zval *post_files, *post_data, **data;
+
+                               post_files = GET_PROP(obj, postFiles);
+                               post_data  = GET_PROP(obj, postData);
+
+                               if (!zend_hash_num_elements(Z_ARRVAL_P(post_files))) {
+
+                                       /* urlencoded post */
+                                       status = http_post_array_ex(obj->ch, request_uri, Z_ARRVAL_P(post_data), Z_ARRVAL_P(opts), Z_ARRVAL_P(info), &response_data, &response_len);
+
+                               } else {
+
+                                       /*
+                                        * multipart post
+                                        */
+
+                                       /* normal data */
+                                       for (   zend_hash_internal_pointer_reset(Z_ARRVAL_P(post_data));
+                                                       zend_hash_get_current_data(Z_ARRVAL_P(post_data), (void **) &data) == SUCCESS;
+                                                       zend_hash_move_forward(Z_ARRVAL_P(post_data))) {
+
+                                               char *key;
+                                               long idx;
+
+                                               if (HASH_KEY_IS_STRING == zend_hash_get_current_key(Z_ARRVAL_P(post_data), &key, &idx, 0)) {
+                                                       convert_to_string_ex(data);
+                                                       curl_formadd(&obj->post_data[0], &obj->post_data[1],
+                                                               CURLFORM_COPYNAME,                      key,
+                                                               CURLFORM_COPYCONTENTS,          Z_STRVAL_PP(data),
+                                                               CURLFORM_CONTENTSLENGTH,        Z_STRLEN_PP(data),
+                                                               CURLFORM_END
+                                                       );
+                                               }
+                                       }
+
+                                       /* file data */
+                                       for (   zend_hash_internal_pointer_reset(Z_ARRVAL_P(post_files));
+                                                       zend_hash_get_current_data(Z_ARRVAL_P(post_files), (void **) &data) == SUCCESS;
+                                                       zend_hash_move_forward(Z_ARRVAL_P(post_files))) {
+
+                                               zval **file, **type, **name;
+
+                                               if (
+                                                       SUCCESS == zend_hash_find(Z_ARRVAL_PP(data), "name", sizeof("name"), (void **) &name) &&
+                                                       SUCCESS == zend_hash_find(Z_ARRVAL_PP(data), "type", sizeof("type"), (void **) &type) &&
+                                                       SUCCESS == zend_hash_find(Z_ARRVAL_PP(data), "file", sizeof("file"), (void **) &file)
+                                               ) {
+
+                                                       curl_formadd(&obj->post_data[0], &obj->post_data[1],
+                                                               CURLFORM_COPYNAME,              Z_STRVAL_PP(name),
+                                                               CURLFORM_FILENAME,              Z_STRVAL_PP(name),
+                                                               CURLFORM_FILE,                  Z_STRVAL_PP(file),
+                                                               CURLFORM_CONTENTTYPE,   Z_STRVAL_PP(type),
+                                                               CURLFORM_END
+                                                       );
+                                               }
+                                       }
+
+                                       status = http_post_curldata_ex(obj->ch, request_uri, obj->post_data[0], Z_ARRVAL_P(opts), Z_ARRVAL_P(info), &response_data, &response_len);
+                                       curl_formfree(obj->post_data[0]);
+                               }
+                       }
                break;
-               
+
                default:
                break;
        }
-       
+
+       efree(request_uri);
+
        /* final data handling */
-       {
+       if (status != SUCCESS) {
+               RETURN_FALSE;
+       } else {
                zval *zheaders, *zbody;
-               
+
                MAKE_STD_ZVAL(zbody);
                MAKE_STD_ZVAL(zheaders)
                array_init(zheaders);
-               
+
                if (SUCCESS != http_split_response_ex(response_data, response_len, zheaders, zbody)) {
                        zval_dtor(zheaders);
                        efree(zheaders),
                        efree(zbody);
+                       efree(response_data);
                        RETURN_FALSE;
                }
-               
+
                add_assoc_zval(resp, "headers", zheaders);
                add_assoc_zval(resp, "body", zbody);
-               
+
+               efree(response_data);
+
                RETURN_TRUE;
        }
        /* */
@@ -2144,7 +2479,7 @@ PHP_MINIT_FUNCTION(http)
        ZEND_INIT_MODULE_GLOBALS(http, php_http_init_globals, NULL);
        REGISTER_INI_ENTRIES();
 
-#ifdef HTTP_HAVE_CURL
+#if defined(HTTP_HAVE_CURL) && (LIBCURL_VERSION_NUM >= 0x070a05)
        REGISTER_LONG_CONSTANT("HTTP_AUTH_BASIC", CURLAUTH_BASIC, CONST_CS | CONST_PERSISTENT);
        REGISTER_LONG_CONSTANT("HTTP_AUTH_DIGEST", CURLAUTH_DIGEST, CONST_CS | CONST_PERSISTENT);
        REGISTER_LONG_CONSTANT("HTTP_AUTH_NTLM", CURLAUTH_NTLM, CONST_CS | CONST_PERSISTENT);