Fix situation where test case might bomb if not enough memory is available.

diff --git a/libmemcached-1.0/error.h b/libmemcached-1.0/error.h
index 81492597d745c97e852627fb8ee346db67210e0e..7fdc18b82e99f541a02e838cc75fa7f28bdf2cae 100644 (file)
--- a/libmemcached-1.0/error.h
+++ b/libmemcached-1.0/error.h
@@ -41,6 +41,9 @@
 extern "C" {
 #endif
 
+LIBMEMCACHED_API
+  const char *memcached_error(const memcached_st *);
+
 LIBMEMCACHED_API
   const char *memcached_last_error_message(const memcached_st *);
 

diff --git a/libmemcached/error.cc b/libmemcached/error.cc
index 99316f1d18f7b0a5e0ef2474eb6d9bd264565f84..6ae5cba18342e0ecb92d95181035c8f5e107a69b 100644 (file)
--- a/libmemcached/error.cc
+++ b/libmemcached/error.cc
@@ -495,24 +495,29 @@ void memcached_error_free(memcached_server_st& self)
   self.error_messages= NULL;
 }
 
+const char *memcached_error(const memcached_st *memc)
+{
+  return memcached_last_error_message(memc);
+}
+
 const char *memcached_last_error_message(const memcached_st *memc)
 {
-  if (memc == NULL)
+  if (memc)
   {
-    return memcached_strerror(memc, MEMCACHED_INVALID_ARGUMENTS);
-  }
+    if (memc->error_messages)
+    {
+      if (memc->error_messages->size == 0)
+      {
+        return memc->error_messages->message;
+      }
 
-  if (memc->error_messages == NULL)
-  {
-    return memcached_strerror(memc, MEMCACHED_SUCCESS);
-  }
+      return memcached_strerror(memc, memc->error_messages->rc);
+    }
 
-  if (memc->error_messages->size == 0)
-  {
-    return memcached_strerror(memc, memc->error_messages->rc);
+    return memcached_strerror(memc, MEMCACHED_SUCCESS);
   }
 
-  return memc->error_messages->message;
+  return memcached_strerror(memc, MEMCACHED_INVALID_ARGUMENTS);
 }
 
 bool memcached_has_current_error(memcached_st &memc)
@@ -534,17 +539,17 @@ bool memcached_has_current_error(org::libmemcached::Instance& server)
 
 memcached_return_t memcached_last_error(const memcached_st *memc)
 {
-  if (memc == NULL)
+  if (memc)
   {
-    return MEMCACHED_INVALID_ARGUMENTS;
-  }
+    if (memc->error_messages)
+    {
+      return memc->error_messages->rc;
+    }
 
-  if (memc->error_messages == NULL)
-  {
     return MEMCACHED_SUCCESS;
   }
 
-  return memc->error_messages->rc;
+  return MEMCACHED_INVALID_ARGUMENTS;
 }
 
 int memcached_last_error_errno(const memcached_st *memc)

diff --git a/tests/libmemcached-1.0/mem_functions.cc b/tests/libmemcached-1.0/mem_functions.cc
index d439e35ec1386c4241b559b1c94a43faecf79f83..a6adac1b433b39b513d298d27912e95b162e05dd 100644 (file)
--- a/tests/libmemcached-1.0/mem_functions.cc
+++ b/tests/libmemcached-1.0/mem_functions.cc
@@ -1754,6 +1754,11 @@ test_return_t block_add_regression(memcached_st *memc)
                                                 global_pairs[x].key, global_pairs[x].key_length,
                                                 &blob[0], blob.size(),
                                                 time_t(0), uint32_t(0));
+    if (rc == MEMCACHED_MEMORY_ALLOCATION_FAILURE)
+    {
+      Error << memcached_last_error_message(memc);
+      return TEST_SKIPPED;
+    }
     test_compare(*memc, MEMCACHED_SUCCESS);
     test_compare(rc, MEMCACHED_SUCCESS);
   }