projects
/
m6w6
/
ext-pq
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
|
github
raw
|
inline
| side by side
add php_pq_version_to_string() helper (factorization)
[m6w6/ext-pq]
/
src
/
php_pqconn.c
diff --git
a/src/php_pqconn.c
b/src/php_pqconn.c
index 32cc5264effd3e76264428d582ae7d5f25299415..0e9e32fc34f8bbe49f60b1e825789c3254e70085 100644
(file)
--- a/
src/php_pqconn.c
+++ b/
src/php_pqconn.c
@@
-495,13
+495,8
@@
static void php_pqconn_object_write_def_auto_conv(void *o, zval *value)
static void php_pqconn_object_read_lib_version(void *o, zval *return_value)
{
char ver[16];
static void php_pqconn_object_read_lib_version(void *o, zval *return_value)
{
char ver[16];
- int v = PQlibVersion();
- if (v < 100000) {
- slprintf(ver, sizeof(ver), "%d.%d.%d", v/10000, v/100%100, v%100);
- } else {
- slprintf(ver, sizeof(ver), "%d.%d", v/10000, v%100);
- }
+ php_pq_version_to_string(PQlibVersion(), ver, sizeof(ver));
RETVAL_STRING(ver);
}
#endif
RETVAL_STRING(ver);
}
#endif
@@
-518,13
+513,8
@@
static void php_pqconn_object_read_server_version(void *o, zval *return_value)
{
php_pqconn_object_t *obj = o;
char ver[16];
{
php_pqconn_object_t *obj = o;
char ver[16];
- int v = PQserverVersion(obj->intern->conn);
- if (v < 100000) {
- slprintf(ver, sizeof(ver), "%d.%d.%d", v/10000, v/100%100, v%100);
- } else {
- slprintf(ver, sizeof(ver), "%d.%d", v/10000, v%100);
- }
+ php_pq_version_to_string(PQserverVersion(obj->intern->conn), ver, sizeof(ver));
RETVAL_STRING(ver);
}
#endif
RETVAL_STRING(ver);
}
#endif