raising the head after a three-weeks refactoring

[m6w6/ext-psi] / src / types / decl_abi.c

diff --git a/src/types/decl_abi.c b/src/types/decl_abi.c
index 2994f25ded8b8216b8a2b4cebeeae9aaa2d652ba..3db51e6c8be2108853dbff41cd78406bd8b40977 100644 (file)
--- a/src/types/decl_abi.c
+++ b/src/types/decl_abi.c
@@ -5,11 +5,11 @@
  Redistribution and use in source and binary forms, with or without
  modification, are permitted provided that the following conditions are met:
 
-     * Redistributions of source code must retain the above copyright notice,
-       this list of conditions and the following disclaimer.
-     * Redistributions in binary form must reproduce the above copyright
-       notice, this list of conditions and the following disclaimer in the
-       documentation and/or other materials provided with the distribution.
+ * Redistributions of source code must retain the above copyright notice,
+ this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
 
  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
@@ -21,35 +21,34 @@
  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
  OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-*******************************************************************************/
-
-#ifdef HAVE_CONFIG_H
-# include "config.h"
-#else
-# include "php_config.h"
-#endif
-
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
+ *******************************************************************************/
 
+#include "php_psi_stdinc.h"
 #include "data.h"
 
-decl_abi *init_decl_abi(const char *convention) {
-       decl_abi *abi = calloc(1, sizeof(*abi));
+struct psi_decl_abi *psi_decl_abi_init(const char *convention)
+{
+       struct psi_decl_abi *abi = calloc(1, sizeof(*abi));
        abi->convention = strdup(convention);
        return abi;
 }
 
-void free_decl_abi(decl_abi *abi) {
-       if (abi->token) {
-               free(abi->token);
+void psi_decl_abi_free(struct psi_decl_abi **abi_ptr)
+{
+       if (*abi_ptr) {
+               struct psi_decl_abi *abi = *abi_ptr;
+
+               *abi_ptr = NULL;
+               if (abi->token) {
+                       free(abi->token);
+               }
+               free(abi->convention);
+               free(abi);
        }
-       free(abi->convention);
-       free(abi);
 }
 
-void dump_decl_abi(int fd, decl_abi *abi) {
+void psi_decl_abi_dump(int fd, struct psi_decl_abi *abi)
+{
        dprintf(fd, "%s", abi->convention);
 }
 
@@ -62,13 +61,14 @@ static const char * const abi_ccs[] = {
                "fastcall",
 };
 
-int validate_decl_abi(struct psi_data *data, decl_abi *abi) {
+bool psi_decl_abi_validate(struct psi_data *data, struct psi_decl_abi *abi)
+{
        size_t i;
 
-       for (i = 0; i < sizeof(abi_ccs)/sizeof(char*); ++i) {
+       for (i = 0; i < sizeof(abi_ccs) / sizeof(char *); ++i) {
                if (strcasecmp(abi->convention, abi_ccs[i])) {
-                       return 1;
+                       return true;
                }
        }
-       return 0;
+       return false;
 }