Fix case where --socket was not always been stored correctly.

[awesomized/libmemcached] / libmemcached / string.cc

diff --git a/libmemcached/string.cc b/libmemcached/string.cc
index a94d442111da9abd37e8ed1fbba4cb0373b464a9..1c44e996d680e46e7143463fe51b15aa09e7cf93 100644 (file)
--- a/libmemcached/string.cc
+++ b/libmemcached/string.cc
@@ -43,17 +43,19 @@ inline static memcached_return_t _string_check(memcached_string_st *string, size
   if (need && need > (size_t)(string->current_size - (size_t)(string->end - string->string)))
   {
     size_t current_offset= (size_t) (string->end - string->string);
-    size_t adjust;
-    size_t new_size;
 
     /* This is the block multiplier. To keep it larger and surive division errors we must round it up */
-    adjust= (need - (size_t)(string->current_size - (size_t)(string->end - string->string))) / MEMCACHED_BLOCK_SIZE;
+    size_t adjust= (need - (size_t)(string->current_size - (size_t)(string->end - string->string))) / MEMCACHED_BLOCK_SIZE;
     adjust++;
 
-    new_size= sizeof(char) * (size_t)((adjust * MEMCACHED_BLOCK_SIZE) + string->current_size);
+    size_t new_size= sizeof(char) * (size_t)((adjust * MEMCACHED_BLOCK_SIZE) + string->current_size);
     /* Test for overflow */
     if (new_size < need)
-      return memcached_set_error(*string->root, MEMCACHED_MEMORY_ALLOCATION_FAILURE, MEMCACHED_AT);
+    {
+      char error_message[1024];
+      int error_message_length= snprintf(error_message, sizeof(error_message),"Needed %ld, got %ld", (long)need, (long)new_size);
+      return memcached_set_error(*string->root, MEMCACHED_MEMORY_ALLOCATION_FAILURE, MEMCACHED_AT, error_message, error_message_length);
+    }
 
     char *new_value= libmemcached_xrealloc(string->root, string->string, new_size, char);
 
@@ -120,6 +122,18 @@ memcached_string_st *memcached_string_create(memcached_st *memc, memcached_strin
   return self;
 }
 
+static memcached_return_t memcached_string_append_null(memcached_string_st& string)
+{
+  if (memcached_failed(_string_check(&string, 1)))
+  {
+    return MEMCACHED_MEMORY_ALLOCATION_FAILURE;
+  }
+
+  *string.end= 0;
+
+  return MEMCACHED_SUCCESS;
+}
+
 static memcached_return_t memcached_string_append_null(memcached_string_st *string)
 {
   if (memcached_failed(_string_check(string, 1)))
@@ -166,13 +180,17 @@ memcached_return_t memcached_string_append(memcached_string_st *string,
 
 char *memcached_string_c_copy(memcached_string_st *string)
 {
-  if (not memcached_string_length(string))
+  if (memcached_string_length(string) == 0)
+  {
     return NULL;
+  }
 
   char *c_ptr= static_cast<char *>(libmemcached_malloc(string->root, (memcached_string_length(string)+1) * sizeof(char)));
 
-  if (not c_ptr)
+  if (c_ptr == NULL)
+  {
     return NULL;
+  }
 
   memcpy(c_ptr, memcached_string_value(string), memcached_string_length(string));
   c_ptr[memcached_string_length(string)]= 0;
@@ -180,16 +198,31 @@ char *memcached_string_c_copy(memcached_string_st *string)
   return c_ptr;
 }
 
-memcached_return_t memcached_string_reset(memcached_string_st *string)
+bool memcached_string_set(memcached_string_st& string, const char* value, size_t length)
+{
+  memcached_string_reset(&string);
+  if (memcached_success(memcached_string_append(&string, value, length)))
+  {
+    memcached_string_append_null(string);
+    return true;
+  }
+
+  return false;
+}
+
+void memcached_string_reset(memcached_string_st *string)
 {
   string->end= string->string;
+}
 
-  return MEMCACHED_SUCCESS;
+void memcached_string_free(memcached_string_st& ptr)
+{
+  memcached_string_free(&ptr);
 }
 
 void memcached_string_free(memcached_string_st *ptr)
 {
-  if (not ptr)
+  if (ptr == NULL)
   {
     return;
   }
@@ -214,11 +247,21 @@ memcached_return_t memcached_string_check(memcached_string_st *string, size_t ne
   return _string_check(string, need);
 }
 
+bool memcached_string_resize(memcached_string_st& string, const size_t need)
+{
+  return memcached_success(_string_check(&string, need));
+}
+
 size_t memcached_string_length(const memcached_string_st *self)
 {
   return size_t(self->end -self->string);
 }
 
+size_t memcached_string_length(const memcached_string_st& self)
+{
+  return size_t(self.end -self.string);
+}
+
 size_t memcached_string_size(const memcached_string_st *self)
 {
   return self->current_size;
@@ -229,6 +272,11 @@ const char *memcached_string_value(const memcached_string_st *self)
   return self->string;
 }
 
+const char *memcached_string_value(const memcached_string_st& self)
+{
+  return self.string;
+}
+
 char *memcached_string_take_value(memcached_string_st *self)
 {
   assert_msg(self, "Invalid memcached_string_st");
@@ -250,7 +298,26 @@ char *memcached_string_value_mutable(const memcached_string_st *self)
   return self->string;
 }
 
+char *memcached_string_c_str(memcached_string_st& self)
+{
+  return self.string;
+}
+
 void memcached_string_set_length(memcached_string_st *self, size_t length)
 {
-  self->end= self->string + length;
+  self->end= self->string +length;
+}
+
+void memcached_string_set_length(memcached_string_st& self, const size_t length)
+{
+  assert(self.current_size >= length);
+  size_t set_length= length;
+  if (self.current_size > length)
+  {
+    if (memcached_failed(_string_check(&self, length)))
+    {
+      set_length= self.current_size;
+    }
+  }
+  self.end= self.string +set_length;
 }