Cleaned up a -Wconversion warning check for tarball-related builds.

diff --git a/m4/pandora_warnings.m4 b/m4/pandora_warnings.m4
index 55e9e0bbdd30439c133c7c2df36b3b2515949b3a..2af759a401bc86423df07510ee57b70602f7e6f5 100644 (file)
--- a/m4/pandora_warnings.m4
+++ b/m4/pandora_warnings.m4
@@ -6,6 +6,9 @@ dnl with or without modifications, as long as this notice is preserved.
 dnl AC_PANDORA_WARNINGS([less-warnings|warnings-always-on])
 dnl   less-warnings turn on a limited set of warnings
 dnl   warnings-always-on always set warnings=error regardless of tarball/vc
+
+dnl @TODO: remove less-warnings option as soon as Drizzle is clean enough to
+dnl        allow it
  
 AC_DEFUN([PANDORA_WARNINGS],[
   m4_define([PW_LESS_WARNINGS],[no])
@@ -79,7 +82,9 @@ AC_DEFUN([PANDORA_WARNINGS],[
     AC_CACHE_CHECK([whether it is safe to use -Wconversion],
       [ac_cv_safe_to_use_wconversion_],
       [save_CFLAGS="$CFLAGS"
-       CFLAGS="-Wconversion ${W_FAIL} -pedantic ${AM_CFLAGS}"
+       dnl Use -Werror here instead of ${W_FAIL} so that we don't spew
+       dnl conversion warnings to all the tarball folks
+       CFLAGS="-Wconversion -Werror -pedantic ${AM_CFLAGS}"
        AC_COMPILE_IFELSE(
          [AC_LANG_PROGRAM([[
 #include <stdbool.h>
@@ -99,7 +104,9 @@ foo(0);
       AC_CACHE_CHECK([whether it is safe to use -Wconversion with htons],
         [ac_cv_safe_to_use_Wconversion_],
         [save_CFLAGS="$CFLAGS"
-         CFLAGS="-Wconversion ${W_FAIL} -pedantic ${AM_CFLAGS}"
+         dnl Use -Werror here instead of ${W_FAIL} so that we don't spew
+         dnl conversion warnings to all the tarball folks
+         CFLAGS="-Wconversion -Werror -pedantic ${AM_CFLAGS}"
          AC_COMPILE_IFELSE(
            [AC_LANG_PROGRAM(
              [[