Working on getting version patch working

diff --git a/docs/Makefile.am b/docs/Makefile.am
index 0234e8337792e43adaab49618be416811ad3b9c2..6eaf8eeb5c97f632de11378435bb304218385c87 100644 (file)
--- a/docs/Makefile.am
+++ b/docs/Makefile.am
@@ -22,6 +22,7 @@ EXTRA_DIST = libmemcached.pod\
        memcp.pod\\r
        memcached_delete.pod\\r
        memcached_set.pod\\r
+  memcached_version.pod\\r
        memflush.pod\r
 \r
 man_MANS = libmemcached.3\\r
@@ -77,7 +78,9 @@ man_MANS = libmemcached.3\
        memcached_stat_servername.3\\r
        memcached_strerror.3\\r
        memcached_quit.3\\r
-       memcached_verbosity.3\r
+       memcached_verbosity.3\\r
+       memcached_lib_version.3\\r
+       memcached_version.3\r
 \r
 libmemcached.3: libmemcached.pod \r
        pod2man -c "libmemcached" -r "" -s 3 libmemcached.pod > libmemcached.3\r
@@ -253,6 +256,12 @@ memcached_result_flags.3: memcached_result_st.pod
 memcached_result_cas.3: memcached_result_st.pod\r
        pod2man -c "libmemcached" -r "" -s 3 memcached_result_st.pod > memcached_result_cas.3\r
 \r
+memcached_version.3: memcached_version.pod\r
+       pod2man -c "libmemcached" -r "" -s 3 memcached_version.pod > memcached_version.3\r
+\r
+memcached_lib_version.3: memcached_version.pod\r
+       pod2man -c "libmemcached" -r "" -s 3 memcached_version.pod  > memcached_lib_version.3\r
+\r
 memcp.1: memcp.pod\r
        pod2man -c "libmemcached" -r "" -s 1 memcp.pod > memcp.1\r
 \r
@@ -274,6 +283,7 @@ memerror.1: memerror.pod
 memflush.1: memflush.pod\r
        pod2man -c "libmemcached" -r "" -s 1 memflush.pod > memflush.1\r
 \r
+\r
 clean:\r
        rm -f *.1\r
        rm -f *.3\r

diff --git a/docs/libmemcached.pod b/docs/libmemcached.pod
index c40072f67e03753c8e4bc643dabaeb8742d954fa..6c98bc323474d88723514e9ee4466e4b544e6a3f 100755 (executable)
--- a/docs/libmemcached.pod
+++ b/docs/libmemcached.pod
@@ -81,6 +81,23 @@ This is the "stride" used in the consistent hash used between replicas.
 
 Maximum allowed size of the hostname.
 
+=item MEMCACHED_VERSION_STRING
+
+String value of libmemcached version such as "1.23.4"
+
+=item MEMCACHED_MAJOR_VERSION
+
+Major version value. Such as 1.23.4, would be 1 
+
+=item MEMCACHED_MINOR_VERSION
+
+Major version value. Such as 1.23.4, would be 23 
+
+=item MEMCACHED_MICRO_VERSION
+
+Major version value. Such as 1.23.4, would be 4 
+
+
 =back
 
 

diff --git a/include/memcached.h b/include/memcached.h
index 05cb74a81d081aed67b895a919f0ff44786359c7..1f1479c9272fa05934a1c3a89591383705ece434 100644 (file)
--- a/include/memcached.h
+++ b/include/memcached.h
@@ -31,6 +31,13 @@ extern "C" {
 #define MEMCACHED_STRIDE 4
 #define MEMCACHED_DEFAULT_TIMEOUT INT32_MAX
 
+/* string value */
+#define MEMCACHED_VERSION_STRING "0.14"
+/* binary values */
+#define MEMCACHED_MAJOR_VERSION 0
+#define MEMCACHED_MAJOR_VERSION 14
+#define MEMCACHED_MICRO_VERSION 0
+
 typedef enum {
   MEMCACHED_SUCCESS,
   MEMCACHED_FAILURE,
@@ -220,6 +227,8 @@ struct memcached_st {
 };
 
 /* Public API */
+const char * memcached_lib_version(void);
+
 memcached_st *memcached_create(memcached_st *ptr);
 void memcached_free(memcached_st *ptr);
 memcached_st *memcached_clone(memcached_st *clone, memcached_st *ptr);

diff --git a/lib/memcached_version.c b/lib/memcached_version.c
index 2863b76bf921bb69f3976ac9fabf594e994fa393..f4a04d7d233b422ed8979f4ba1a4f14f63d9ea48 100644 (file)
--- a/lib/memcached_version.c
+++ b/lib/memcached_version.c
@@ -1,5 +1,9 @@
 #include "common.h"
 
+const char * memcached_lib_version(void) {
+  return LIBMEMCACHED_VERSION_STRING;
+}
+
 memcached_return memcached_version(memcached_st *ptr)
 {
   unsigned int x;

diff --git a/tests/function.c b/tests/function.c
index 6ca61d7d5addb443a35899af8f99e8a49f9e2f0b..748eac57a76c726e1f604f94fd81385bd8a65eed 100644 (file)
--- a/tests/function.c
+++ b/tests/function.c
@@ -889,6 +889,14 @@ uint8_t get_stats_keys(memcached_st *memc)
  return 0;
 }
 
+uint8_t version_string_test
+{
+  const char *version_string;
+  version_string= memcached_lib_version();
+  assert(!strcmp(version_string, MEMCACHE_VERSION_STRING));
+  return 0;
+}
+
 uint8_t get_stats(memcached_st *memc)
 {
  unsigned int x;
@@ -2134,6 +2142,7 @@ test_st tests[] ={
   {"get_stats_keys", 0, get_stats_keys },
   {"behavior_test", 0, get_stats_keys },
   {"callback_test", 0, get_stats_keys },
+  {"version_string_test", 0, version_string_test},
   {0, 0, 0}
 };