Portability patches from Kevin Dalley for Freebsd 4.0.

diff --git a/ChangeLog b/ChangeLog
index 0f9fd436a6c7b65b3a847af37af9b6b3ea69dcbc..f364840d178bcd3e0fa897b2a46bd7be22fe4000 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@
   * Fixed uint16_t issues around flags. Turns out the documentation on the
     protocol was wrong.
   * Lingering socket fixes for FreeBSD.
+  * Patches from Kevin Dalley for FreeBSD 4.0
 
 0.12 Tue Dec 11 15:20:55 PST 2007
   * Updates for consistent hashing

diff --git a/configure.ac b/configure.ac
index 3e3acbc40b8c6e6d49c418df72f2ddadea1102dd..f052f5f02b35d04d2e613d341919a5197f3d34d4 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -70,4 +70,5 @@ fi
 AC_C_CONST
 AC_HEADER_TIME
 AC_TYPE_SIZE_T
+AC_SEARCH_LIBS(getopt_long, gnugetopt)
 AC_OUTPUT(Makefile src/Makefile tests/Makefile docs/Makefile lib/Makefile include/Makefile support/Makefile support/libmemcached.pc support/libmemcached.spec)

diff --git a/lib/common.h b/lib/common.h
index 76c734ed1fe25c4c7bd7ab294818ea07bfc174ab..395b80ef83730863c5fbe9d248bdf498fa9a41a6 100644 (file)
--- a/lib/common.h
+++ b/lib/common.h
@@ -17,11 +17,22 @@
 #include <unistd.h>
 #include <limits.h>
 #include <assert.h>
-#include <time.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/un.h>
 #include <netinet/tcp.h>
+#include "libmemcached_config.h"
+
+#if TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# if HAVE_SYS_TIME_H
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
 
 
 

diff --git a/lib/memcached_connect.c b/lib/memcached_connect.c
index 0bb28177f060b6ff9f8b6d17e33a22aa1c8d0dbf..42390a9af30cd92319c2a8695b9b24c1de5c0c21 100644 (file)
--- a/lib/memcached_connect.c
+++ b/lib/memcached_connect.c
@@ -110,9 +110,10 @@ static memcached_return tcp_connect(memcached_st *ptr, unsigned int server_key)
 {
   if (ptr->hosts[server_key].fd == -1)
   {
+    struct addrinfo *use;
+
     /* Old connection junk still is in the structure */
     WATCHPOINT_ASSERT(ptr->hosts[server_key].cursor_active == 0);
-    struct addrinfo *use;
 
     if (ptr->hosts[server_key].sockaddr_inited == MEMCACHED_NOT_ALLOCATED || 
         (!(ptr->flags & MEM_USE_CACHE_LOOKUPS)))

diff --git a/src/memcat.c b/src/memcat.c
index 79dc62207c4c458885401d24e7a8023f866a4496..4aaffb95ca71f9cfa8a19bd6db5887a90d740cae 100644 (file)
--- a/src/memcat.c
+++ b/src/memcat.c
@@ -1,5 +1,5 @@
 #include <stdio.h>
-#include <stdint.h>
+#include <inttypes.h>
 #include <string.h>
 #include <unistd.h>
 #include <getopt.h>

diff --git a/src/memerror.c b/src/memerror.c
index d6bfbf7f92c882e942d33692dfb119d10cd896e9..f6cf1abae7791bc872d02efad4f82fc4ff214bf1 100644 (file)
--- a/src/memerror.c
+++ b/src/memerror.c
@@ -1,5 +1,5 @@
 #include <stdio.h>
-#include <stdint.h>
+#include <inttypes.h>
 #include <string.h>
 #include <unistd.h>
 #include <getopt.h>

diff --git a/src/utilities.h b/src/utilities.h
index 857f78039694409d8f64dd2dd84ad7e7842b82f8..1fba99bf72f7808d20d8b3e95a6118d81eabb272 100644 (file)
--- a/src/utilities.h
+++ b/src/utilities.h
@@ -1,6 +1,18 @@
 #include <memcached.h>
 #include <getopt.h>
 #include "client_options.h"
+#include "libmemcached_config.h"
+
+#if TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# if HAVE_SYS_TIME_H
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
 
 typedef struct memcached_programs_help_st memcached_programs_help_st;
 

diff --git a/tests/function.c b/tests/function.c
index 0be895d66a1d7e97b37040bd762168049a1ded56..e717c3b8464592a79622b1647b2f3bf3b89efb61 100644 (file)
--- a/tests/function.c
+++ b/tests/function.c
@@ -15,6 +15,14 @@
 #include "../src/generator.h"
 #include "../src/execute.h"
 
+#ifndef INT64_MAX
+#define INT64_MAX LONG_MAX
+#endif
+#ifndef INT32_MAX
+#define INT32_MAX INT_MAX
+#endif
+
+
 #include "test.h"
 
 #define GLOBAL_COUNT 100000
@@ -1099,6 +1107,10 @@ uint8_t user_supplied_bug4(memcached_st *memc)
   size_t key_length[]= {5, 3, 4};
   unsigned int x;
   uint32_t flags;
+  char return_key[MEMCACHED_MAX_KEY];
+  size_t return_key_length;
+  char *return_value;
+  size_t return_value_length;
 
   /* Here we free everything before running a bunch of mget tests */
   {
@@ -1107,10 +1119,6 @@ uint8_t user_supplied_bug4(memcached_st *memc)
     memc->number_of_hosts= 0;
   }
 
-  char return_key[MEMCACHED_MAX_KEY];
-  size_t return_key_length;
-  char *return_value;
-  size_t return_value_length;
 
   /* We need to empty the server before continueing test */
   rc= memcached_flush(memc, 0);

diff --git a/tests/test.c b/tests/test.c
index 60db54cbd8969269d3dad0b6468a4f6be50dc9f6..653a3ddc905511e932814ab823eb6b388c14a5b9 100644 (file)
--- a/tests/test.c
+++ b/tests/test.c
@@ -76,6 +76,7 @@ int main(int argc, char *argv[])
   char *wildcard= NULL;
   memcached_server_st *servers;
   collection_st *collection;
+  collection_st *next;
   uint8_t failed;
 
   collection= gets_collections();
@@ -113,7 +114,6 @@ int main(int argc, char *argv[])
 
   printf("\n");
 
-  collection_st *next;
   for (next= collection; next->name; next++)
   {
     test_st *run;
@@ -130,6 +130,7 @@ int main(int argc, char *argv[])
       memcached_st *memc;
       memcached_return rc;
       struct timeval start_time, end_time;
+      long int load_time;
 
       if (wildcard && fnmatch(wildcard, run->name, 0))
         continue;
@@ -169,7 +170,7 @@ int main(int argc, char *argv[])
       gettimeofday(&start_time, NULL);
       failed= run->function(memc);
       gettimeofday(&end_time, NULL);
-      long int load_time= timedif(end_time, start_time);
+      load_time= timedif(end_time, start_time);
       if (failed)
         fprintf(stderr, "\t\t\t\t\t %ld.%03ld [ failed ]\n", load_time / 1000, 
                 load_time % 1000);