Small cleanup.

diff --git a/libmemcached/constants.h b/libmemcached/constants.h
index 561f00c4c3e5f46cde426954b96ee676fadd2229..f05b03ebb0316fe0dce49002ce284fc87bb409a8 100644 (file)
--- a/libmemcached/constants.h
+++ b/libmemcached/constants.h
@@ -16,7 +16,6 @@
 #define MEMCACHED_DEFAULT_PORT 11211
 #define MEMCACHED_MAX_KEY 251 /* We add one to have it null terminated */
 #define MEMCACHED_MAX_BUFFER 8196
-#define MEMCACHED_MAX_HOST_LENGTH 64
 #define MEMCACHED_MAX_HOST_SORT_LENGTH 86 /* Used for Ketama */
 #define MEMCACHED_POINTS_PER_SERVER 100
 #define MEMCACHED_POINTS_PER_SERVER_KETAMA 160

diff --git a/libmemcached/memcached.h b/libmemcached/memcached.h
index 66f8a495aac8238152cdf37e0e17078564258ecd..32879c9fb84a0a278b08b53ea8e19e6664b1b6b6 100644 (file)
--- a/libmemcached/memcached.h
+++ b/libmemcached/memcached.h
@@ -13,16 +13,17 @@
 #ifndef __LIBMEMCACHED_MEMCACHED_H__
 #define __LIBMEMCACHED_MEMCACHED_H__
 
-#include <stdlib.h>
 #include <inttypes.h>
+#include <netdb.h>
+#include <netinet/in.h>
+#include <stdlib.h>
+#include <sys/types.h>
+
 
 #if !defined(__cplusplus)
 # include <stdbool.h>
 #endif
 
-#include <sys/types.h>
-#include <netinet/in.h>
-
 #include <libmemcached/visibility.h>
 #include <libmemcached/configure.h>
 #include <libmemcached/constants.h>

diff --git a/libmemcached/server.c b/libmemcached/server.c
index 68e1ebaa4faf58118eea118dd2938dbfc343802f..6fd685feac76dcece0dce6aaaa498f2fe094ef37 100644 (file)
--- a/libmemcached/server.c
+++ b/libmemcached/server.c
@@ -53,7 +53,7 @@ static inline void _server_init(memcached_server_st *self, const memcached_st *r
   if (hostname == NULL)
     self->hostname[0]= 0;
   else
-    strncpy(self->hostname, hostname, MEMCACHED_MAX_HOST_LENGTH - 1);
+    strncpy(self->hostname, hostname, NI_MAXHOST - 1);
 }
 
 static memcached_server_st *_server_create(memcached_server_st *self, const memcached_st *memc)
@@ -244,7 +244,7 @@ memcached_return_t memcached_server_remove(memcached_server_st *st_ptr)
 
   for (x= 0, host_index= 0; x < memcached_server_count(root); x++)
   {
-    if (strncmp(list[x].hostname, st_ptr->hostname, MEMCACHED_MAX_HOST_LENGTH) != 0 || list[x].port != st_ptr->port)
+    if (strncmp(list[x].hostname, st_ptr->hostname, NI_MAXHOST) != 0 || list[x].port != st_ptr->port)
     {
       if (host_index != x)
         memcpy(list+host_index, list+x, sizeof(memcached_server_st));

diff --git a/libmemcached/server.h b/libmemcached/server.h
index 76400ee3838026c75a3a9babf95bdb6ea0a5db75..141d71d21c04184429619fd160581434ac654fb8 100644 (file)
--- a/libmemcached/server.h
+++ b/libmemcached/server.h
@@ -45,7 +45,7 @@ struct memcached_server_st {
   uint64_t limit_maxbytes;
   char read_buffer[MEMCACHED_MAX_BUFFER];
   char write_buffer[MEMCACHED_MAX_BUFFER];
-  char hostname[MEMCACHED_MAX_HOST_LENGTH];
+  char hostname[NI_MAXHOST];
 };
 
 

diff --git a/tests/hashkit_functions.c b/tests/hashkit_functions.c
index 005143a0b2e44f7794b70778211fda92ad992d16..2dad25fa95ed2838b5e9833ed0c800b386d958a1 100644 (file)
--- a/tests/hashkit_functions.c
+++ b/tests/hashkit_functions.c
@@ -467,6 +467,7 @@ static test_return_t hashkit_compare_test(hashkit_st *hashk)
   clone= hashkit_clone(NULL, hashk);
 
   test_true(hashkit_compare(clone, hashk));
+  hashkit_free(clone);
 
   return TEST_SUCCESS;
 }