more refactoring; now the package hook starts to make sense
[pharext/pharext] / src / pharext / Packager.php
index a848e2d39ce672fc5a0ff67dfb652376d526c2e8..3cf4f5bfbd3bfa8e7afffd9782f5fd35411cf600 100644 (file)
@@ -3,17 +3,16 @@
 namespace pharext;
 
 use Phar;
+use pharext\Cli\Args as CliArgs;
+use pharext\Cli\Command as CliCommand;
+use pharext\Exception;
 
 /**
  * The extension packaging command executed by bin/pharext
  */
 class Packager implements Command
 {
-       /**
-        * Command line arguments
-        * @var pharext\CliArgs
-        */
-       private $args;
+       use CliCommand;
        
        /**
         * Extension source directory
@@ -21,6 +20,12 @@ class Packager implements Command
         */
        private $source;
        
+       /**
+        * Cleanups
+        * @var array
+        */
+       private $cleanup = [];
+       
        /**
         * Create the command
         */
@@ -32,24 +37,43 @@ class Packager implements Command
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG],
                        ["q", "quiet", "Less output",
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG],
+                       ["n", "name", "Extension name",
+                               CliArgs::REQUIRED|CliArgs::SINGLE|CliArgs::REQARG],
+                       ["r", "release", "Extension release version",
+                               CliArgs::REQUIRED|CliArgs::SINGLE|CliArgs::REQARG],
                        ["s", "source", "Extension source directory",
                                CliArgs::REQUIRED|CliArgs::SINGLE|CliArgs::REQARG],
-                       ["g", "git", "Use `git ls-files` instead of the standard ignore filter",
+                       ["g", "git", "Use `git ls-tree` to determine file list",
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG],
-                       ["p", "pecl", "Use PECL package.xml instead of the standard ignore filter",
+                       ["p", "pecl", "Use PECL package.xml to determine file list, name and release",
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG],
                        ["d", "dest", "Destination directory",
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::REQARG,
                                "."],
-                       ["n", "name", "Extension name",
-                               CliArgs::REQUIRED|CliArgs::SINGLE|CliArgs::REQARG],
-                       ["r", "release", "Extension release version",
-                               CliArgs::REQUIRED|CliArgs::SINGLE|CliArgs::REQARG],
                        ["z", "gzip", "Create additional PHAR compressed with gzip",
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG],
                        ["Z", "bzip", "Create additional PHAR compressed with bzip",
                                CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG],
-]);
+                       ["S", "sign", "Sign the PHAR with a private key",
+                               CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::REQARG],
+                       ["E", "zend", "Mark as Zend Extension",
+                               CliArgs::OPTIONAL|CliARgs::SINGLE|CliArgs::NOARG],
+                       [null, "signature", "Show pharext signature",
+                               CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG|CliArgs::HALT],
+                       [null, "license", "Show pharext license",
+                               CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG|CliArgs::HALT],
+                       [null, "version", "Show pharext version",
+                               CliArgs::OPTIONAL|CliArgs::SINGLE|CliArgs::NOARG|CliArgs::HALT],
+               ]);
+       }
+       
+       /**
+        * Perform cleaniup
+        */
+       function __destruct() {
+               foreach ($this->cleanup as $cleanup) {
+                       $cleanup->run();
+               }
        }
        
        /**
@@ -57,139 +81,231 @@ class Packager implements Command
         * @see \pharext\Command::run()
         */
        public function run($argc, array $argv) {
+               $errs = [];
                $prog = array_shift($argv);
                foreach ($this->args->parse(--$argc, $argv) as $error) {
-                       $this->error("%s\n", $error);
+                       $errs[] = $error;
                }
                
                if ($this->args["help"]) {
-                       $this->args->help($prog);
+                       $this->header();
+                       $this->help($prog);
                        exit;
                }
-               
-               if ($this->args["source"]) {
-                       if ($this->args["pecl"]) {
-                               $this->source = new PeclSourceDir($this, $this->args["source"]);
-                       } elseif ($this->args["git"]) {
-                               $this->source = new GitSourceDir($this, $this->args["source"]);
-                       } else {
-                               $this->source = new FilteredSourceDir($this, $this->args["source"]);
+               try {
+                       foreach (["signature", "license", "version"] as $opt) {
+                               if ($this->args[$opt]) {
+                                       printf("%s\n", $this->metadata($opt));
+                                       exit;
+                               }
                        }
+               } catch (\Exception $e) {
+                       $this->error("%s\n", $e->getMessage());
+                       exit(self::EARGS);
+               }
+
+               try {
+                       /* source needs to be evaluated before CliArgs validation, 
+                        * so e.g. name and version can be overriden and CliArgs 
+                        * does not complain about missing arguments
+                        */
+                       $this->loadSource();
+               } catch (\Exception $e) {
+                       $errs[] = $e->getMessage();
                }
                
                foreach ($this->args->validate() as $error) {
-                       $this->error("%s\n", $error);
+                       $errs[] = $error;
                }
                
-               if (isset($error)) {
+               if ($errs) {
+                       if (!$this->args["quiet"]) {
+                               $this->header();
+                       }
+                       foreach ($errs as $err) {
+                               $this->error("%s\n", $err);
+                       }
+                       printf("\n");
                        if (!$this->args["quiet"]) {
-                               $this->args->help($prog);
+                               $this->help($prog);
                        }
-                       exit(1);
+                       exit(self::EARGS);
                }
                
                $this->createPackage();
        }
        
        /**
-        * @inheritdoc
-        * @see \pharext\Command::getArgs()
+        * Download remote source
+        * @param string $source
+        * @return string local source
         */
-       public function getArgs() {
-               return $this->args;
+       private function download($source) {
+               $this->info("Fetching remote source %s ...\n", $source);
+               
+               if ($this->args->git) {
+                       $task = new Task\GitClone($source);
+               } else {
+                       $task = new Task\StreamFetch($source, function($bytes_pct) {
+                               $this->info(" %3d%% [%s>%s] \r%s",
+                                       floor($bytes_pct*100),
+                                       str_repeat("=", round(50*$bytes_pct)),
+                                       str_repeat(" ", round(50*(1-$bytes_pct))),
+                                       $bytes_pct == 1 ? "\n":""
+                               );
+                       });
+               }
+               $local = $task->run($this->verbosity());
+
+               $this->cleanup[] = new Task\Cleanup($local);
+               return $local;
        }
-       
+
        /**
-        * @inheritdoc
-        * @see \pharext\Command::info()
+        * Extract local archive
+        * @param stirng $source
+        * @return string extracted directory
         */
-       public function info($fmt) {
-               if (!$this->args->quiet) {
-                       vprintf($fmt, array_slice(func_get_args(), 1));
-               }
+       private function extract($source) {
+               $this->debug("Extracting %s ...\n", $source);
+               
+               $task = new Task\Extract($source);
+               $dest = $task->run($this->verbosity());
+               
+               $this->cleanup[] = new Task\Cleanup($dest);
+               return $dest;
        }
-       
+
        /**
-        * @inheritdoc
-        * @see \pharext\Command::error()
+        * Localize a possibly remote source
+        * @param string $source
+        * @return string local source directory
         */
-       public function error($fmt) {
-               if (!$this->args->quiet) {
-                       vfprintf(STDERR, "ERROR: $fmt", array_slice(func_get_args(), 1));
+       private function localize($source) {
+               if (!stream_is_local($source)) {
+                       $source = $this->download($source);
+                       $this->cleanup[] = new Task\Cleanup($source);
+               }
+               $source = realpath($source);
+               if (!is_dir($source)) {
+                       $source = $this->extract($source);
+                       $this->cleanup[] = new Task\Cleanup($source);
+                       
+                       if ($this->args->pecl) {
+                               $this->debug("Sanitizing PECL dir ...\n");
+                               $source = (new Task\PeclFixup($source))->run($this->verbosity());
+                       }
                }
+               return $source;
        }
-       
+
        /**
-        * Traverses all pharext source files to bundle
-        * @return Generator
+        * Load the source dir
+        * @throws \pharext\Exception
         */
-       private function bundle() {
-               foreach (scandir(__DIR__) as $entry) {
-                       if (fnmatch("*.php", $entry)) {
-                               yield "pharext/$entry" => __DIR__."/$entry";
+       private function loadSource(){
+               if ($this->args["source"]) {
+                       $source = $this->localize($this->args["source"]);
+
+                       if ($this->args["pecl"]) {
+                               $this->source = new SourceDir\Pecl($source);
+                       } elseif ($this->args["git"]) {
+                               $this->source = new SourceDir\Git($source);
+                       } elseif (is_file("$source/parext_package.php")) {
+                               $this->source = include "$source/pharext_package.php";
+                       }
+
+                       if (!$this->source instanceof SourceDir) {
+                               throw new Exception("Unknown source dir $source");
+                       }
+
+                       foreach ($this->source->getPackageInfo() as $key => $val) {
+                               $this->args->$key = $val;
                        }
                }
        }
-       
+
        /**
         * Creates the extension phar
         */
        private function createPackage() {
-               $pkguniq = uniqid();
-               $pkgtemp = sys_get_temp_dir() ."/{$pkguniq}.phar";
-               $pkgdesc = "{$this->args->name}-{$this->args->release}";
-       
-               $this->info("Creating phar %s ...%s", $pkgtemp, $this->args->verbose ? "\n" : " ");
                try {
-                       $package = new Phar($pkgtemp, 0, "ext.phar");
-                       $package->startBuffering();
-                       $package->buildFromIterator($this->source, $this->source->getBaseDir());
-                       $package->buildFromIterator($this->bundle());
-                       $package->addFile(__DIR__."/../pharext_installer.php", "pharext_installer.php");
-                       $package->setDefaultStub("pharext_installer.php");
-                       $package->setStub("#!/usr/bin/php -dphar.readonly=1\n".$package->getStub());
-                       $package->stopBuffering();
-                       
-                       chmod($pkgtemp, 0770);
-                       if ($this->args->verbose) {
-                               $this->info("Created executable phar %s\n", $pkgtemp);
-                       } else {
-                               $this->info("OK\n");
+                       $meta = array_merge($this->metadata(), [
+                               "date" => date("Y-m-d"),
+                               "name" => $this->args->name,
+                               "release" => $this->args->release,
+                               "license" => @file_get_contents(current(glob($this->source->getBaseDir()."/LICENSE*"))),
+                               "stub" => "pharext_installer.php",
+                               "type" => $this->args->zend ? "zend_extension" : "extension",
+                       ]);
+                       $file = (new Task\PharBuild($this->source, $meta))->run();
+               } catch (\Exception $e) {
+                       $this->error("%s\n", $e->getMessage());
+                       exit(self::EBUILD);
+               }
+
+               try {
+                       if ($this->args->sign) {
+                               $this->info("Using private key to sign phar ...\n");
+                               $pass = (new Task\Askpass)->run($this->verbosity());
+                               $sign = new Task\PharSign($file, $this->args->sign, $pass);
+                               $pkey = $sign->run($this->verbosity());
                        }
-                       if ($this->args->gzip) {
-                               $this->info("Compressing with gzip ... ");
-                               try {
-                                       $package->compress(Phar::GZ);
-                                       $this->info("OK\n");
-                               } catch (\Exception $e) {
-                                       $this->error("%s\n", $e->getMessage());
+
+               } catch (\Exception $e) {
+                       $this->error("%s\n", $e->getMessage());
+                       exit(self::ESIGN);
+               }
+
+               if ($this->args->gzip) {
+                       try {
+                               $gzip = (new Task\PharCompress($file, Phar::GZ))->run();
+                               $move = new Task\PharRename($gzip, $this->args->dest, $this->args->name ."-". $this->args->release);
+                               $name = $move->run($this->verbosity());
+
+                               $this->info("Created gzipped phar %s\n", $name);
+
+                               if ($this->args->sign) {
+                                       $sign = new Task\PharSign($name, $this->args->sign, $pass);
+                                       $sign->run($this->verbosity())->exportPublicKey($name.".pubkey");
                                }
+
+                       } catch (\Exception $e) {
+                               $this->warn("%s\n", $e->getMessage());
                        }
-                       if ($this->args->bzip) {
-                               $this->info("Compressing with bzip ... ");
-                               try {
-                                       $package->compress(Phar::BZ2);
-                                       $this->info("OK\n");
-                               } catch (\Exception $e) {
-                                       $this->error("%s\n", $e->getMessage());
+               }
+               
+               if ($this->args->bzip) {
+                       try {
+                               $bzip = (new Task\PharCompress($file, Phar::BZ2))->run();
+                               $move = new Task\PharRename($bzip, $this->args->dest, $this->args->name ."-". $this->args->release);
+                               $name = $move->run($this->verbosity());
+
+                               $this->info("Created bzipped phar %s\n", $name);
+
+                               if ($this->args->sign) {
+                                       $sign = new Task\PharSign($name, $this->args->sign, $pass);
+                                       $sign->run($this->verbosity())->exportPublicKey($name.".pubkey");
                                }
+
+                       } catch (\Exception $e) {
+                               $this->warn("%s\n", $e->getMessage());
                        }
-                       
-                       unset($package);
-               } catch (\Exception $e) {
-                       $this->error("%s\n", $e->getMessage());
-                       exit(4);
                }
 
-               foreach (glob($pkgtemp."*") as $pkgtemp) {
-                       $pkgfile = str_replace($pkguniq, "{$pkgdesc}.ext", $pkgtemp);
-                       $pkgname = $this->args->dest ."/". basename($pkgfile);
-                       $this->info("Finalizing %s ... ", $pkgname);
-                       if (!rename($pkgtemp, $pkgname)) {
-                               $this->error("%s\n", error_get_last()["message"]);
-                               exit(5);
+               try {
+                       $move = new Task\PharRename($file, $this->args->dest, $this->args->name ."-". $this->args->release);
+                       $name = $move->run($this->verbosity());
+
+                       $this->info("Created executable phar %s\n", $name);
+
+                       if (isset($pkey)) {
+                               $pkey->exportPublicKey($name.".pubkey");
                        }
-                       $this->info("OK\n");
-               } 
+
+               } catch (\Exception $e) {
+                       $this->error("%s\n", $e->getMessage());
+                       exit(self::EBUILD);
+               }
        }
 }