Updated return code from memcached_response to send proper return to

[awesomized/libmemcached] / src / memstat.c

diff --git a/src/memstat.c b/src/memstat.c
index d6e315078749285fd56bda874cce033c8629d84b..6b7f0ae52770e05cec8b6b1b0fa7fecde05a6d0d 100644 (file)
--- a/src/memstat.c
+++ b/src/memstat.c
@@ -11,6 +11,9 @@
 #include "client_options.h"
 #include "utilities.h"
 
+#define PROGRAM_NAME "memstat"
+#define PROGRAM_DESCRIPTION "Output the state of a memcached cluster."
+
 /* Prototypes */
 void options_parse(int argc, char *argv[]);
 
@@ -20,68 +23,92 @@ static char *opt_servers= NULL;
 
 int main(int argc, char *argv[])
 {
+  unsigned int x;
+  memcached_return rc;
   memcached_st *memc;
+  memcached_stat_st *stat;
+  memcached_server_st *servers;
+  memcached_server_st *server_list;
 
-  memc= memcached_init(NULL);
   options_parse(argc, argv);
 
-  if (opt_servers)
+  if (!opt_servers)
   {
-    unsigned int x;
-    memcached_return rc;
-    memcached_stat_st *stat;
-    memcached_server_st *server_list;
+    char *temp;
 
-    parse_opt_servers(memc, opt_servers);
-    stat= memcached_stat(memc, NULL, &rc);
+    if ((temp= getenv("MEMCACHED_SERVERS")))
+      opt_servers= strdup(temp);
+    else
+      exit(1);
+  }
 
-    server_list= memcached_server_list(memc);
+  memc= memcached_create(NULL);
 
-    printf("Listing %u Server\n\n", memcached_server_count(memc));
-    for (x= 0; x < memcached_server_count(memc); x++)
-    {
-      char **list;
-      char **ptr;
+  servers= memcached_servers_parse(opt_servers);
+  memcached_server_push(memc, servers);
+  memcached_server_list_free(servers);
+
+  stat= memcached_stat(memc, NULL, &rc);
+
+  if (rc != MEMCACHED_SUCCESS && rc != MEMCACHED_SOME_ERRORS)
+  {
+    printf("Failure to communicate with servers (%s)\n",
+          memcached_strerror(memc, rc));
+    exit(1);
+  }
 
-      list= memcached_stat_get_keys(memc, &stat[x], &rc);
-      assert(rc == MEMCACHED_SUCCESS);
+  server_list= memcached_server_list(memc);
 
-      printf("Server: %s (%u)\n", memcached_server_name(memc, server_list[x]),
-             memcached_server_port(memc, server_list[x]));
-      for (ptr= list; *ptr; ptr++)
-      {
-        memcached_return rc;
-        char *value= memcached_stat_get_value(memc, &stat[x], *ptr, &rc);
+  printf("Listing %u Server\n\n", memcached_server_count(memc));
+  for (x= 0; x < memcached_server_count(memc); x++)
+  {
+    char **list;
+    char **ptr;
+
+    list= memcached_stat_get_keys(memc, &stat[x], &rc);
+    assert(list);
+    assert(rc == MEMCACHED_SUCCESS);
 
-        printf("\t %s: %s\n", *ptr, value);
-        free(value);
-      }
+    printf("Server: %s (%u)\n", memcached_server_name(memc, server_list[x]),
+          memcached_server_port(memc, server_list[x]));
+    for (ptr= list; *ptr; ptr++)
+    {
+      memcached_return rc;
+      char *value= memcached_stat_get_value(memc, &stat[x], *ptr, &rc);
 
-      free(list);
-      printf("\n");
+      printf("\t %s: %s\n", *ptr, value);
+      free(value);
     }
 
-    free(stat);
-    free(opt_servers);
+    free(list);
+    printf("\n");
   }
 
-  memcached_deinit(memc);
+  free(stat);
+  free(opt_servers);
+
+  memcached_free(memc);
 
   return 0;
 }
 
 void options_parse(int argc, char *argv[])
 {
+  memcached_programs_help_st help_options[]=
+  {
+    {0},
+  };
+
   static struct option long_options[]=
-    {
-      {"version", no_argument, NULL, OPT_VERSION},
-      {"help", no_argument, NULL, OPT_HELP},
-      {"verbose", no_argument, &opt_verbose, OPT_VERBOSE},
-      {"debug", no_argument, &opt_verbose, OPT_DEBUG},
-      {"servers", required_argument, NULL, OPT_SERVERS},
-      {"flag", no_argument, &opt_displayflag, OPT_FLAG},
-      {0, 0, 0, 0},
-    };
+  {
+    {"version", no_argument, NULL, OPT_VERSION},
+    {"help", no_argument, NULL, OPT_HELP},
+    {"verbose", no_argument, &opt_verbose, OPT_VERBOSE},
+    {"debug", no_argument, &opt_verbose, OPT_DEBUG},
+    {"servers", required_argument, NULL, OPT_SERVERS},
+    {"flag", no_argument, &opt_displayflag, OPT_FLAG},
+    {0, 0, 0, 0},
+  };
 
   int option_index= 0;
   int option_rv;
@@ -101,12 +128,10 @@ void options_parse(int argc, char *argv[])
       opt_verbose = OPT_DEBUG;
       break;
     case OPT_VERSION: /* --version or -V */
-      printf("memcache tools, memcat, v1.0\n");
-      exit(0);
+      version_command(PROGRAM_NAME);
       break;
     case OPT_HELP: /* --help or -h */
-      printf("useful help messages go here\n");
-      exit(0);
+      help_command(PROGRAM_NAME, PROGRAM_DESCRIPTION, long_options, help_options);
       break;
     case OPT_SERVERS: /* --servers or -s */
       opt_servers= strdup(optarg);