p9y

[awesomized/libmemcached] / src / bin / memcapable.cc

diff --git a/src/bin/memcapable.cc b/src/bin/memcapable.cc
index d90c71688b7f6c91d88031df3f54687a6d288e9a..54e9c2242bea3c28061814a83fda375e75dba85f 100644 (file)
--- a/src/bin/memcapable.cc
+++ b/src/bin/memcapable.cc
@@ -17,12 +17,6 @@
 
 #include "mem_config.h"
 
-#ifdef HAVE_POLL_H
-#  include <poll.h>
-#else
-#  include "poll/poll.h"
-#endif
-
 #include <cassert>
 #include <cerrno>
 #include <cstdio>
@@ -31,15 +25,18 @@
 #include <cctype>
 #include <fcntl.h>
 #include <cinttypes>
-#include <pthread.h>
+#include <ciso646>
 #include <csignal>
 #include <sys/types.h>
 #if HAVE_UNISTD_H
 #  include <unistd.h>
 #endif
-#include "libmemcached-1.0/memcached.h"
 
-#include "libmemcached/socket.hpp"
+#include "p9y/getopt.hpp"
+#include "p9y/socket.hpp"
+#include "p9y/poll.hpp"
+
+#include "libmemcached-1.0/memcached.h"
 #include "libmemcachedprotocol-0.0/binary.h"
 #include "libmemcached/byteorder.h"
 
@@ -133,14 +130,14 @@ static memcached_socket_t set_noblock(void) {
   int flags = fcntl(sock, F_GETFL, 0);
   if (flags == -1) {
     perror("Failed to get socket flags");
-    memcached_close_socket(sock);
+    closesocket(sock);
     return INVALID_SOCKET;
   }
 
   if ((flags & O_NONBLOCK) != O_NONBLOCK) {
     if (fcntl(sock, F_SETFL, flags | O_NONBLOCK) == -1) {
       perror("Failed to set socket to nonblocking mode");
-      memcached_close_socket(sock);
+      closesocket(sock);
       return INVALID_SOCKET;
     }
   }
@@ -176,16 +173,16 @@ static memcached_socket_t connect_server(const char *hostname, const char *port)
   return sock;
 }
 
-static ssize_t timeout_io_op(memcached_socket_t fd, short direction, void *buf, size_t len) {
+static ssize_t timeout_io_op(memcached_socket_t fd, short direction, const char *buf, size_t len) {
   ssize_t ret;
 
   if (direction == POLLOUT) {
     ret = send(fd, buf, len, 0);
   } else {
-    ret = recv(fd, buf, len, 0);
+    ret = recv(fd, const_cast<char *>(buf), len, 0);
   }
-
-  if (ret == SOCKET_ERROR && get_socket_errno() == EWOULDBLOCK) {
+  int local_errno = get_socket_errno();
+  if (ret == SOCKET_ERROR && local_errno == EWOULDBLOCK || (EAGAIN != EWOULDBLOCK && local_errno == EAGAIN)) {
     struct pollfd fds;
     memset(&fds, 0, sizeof(struct pollfd));
     fds.events = direction;
@@ -196,7 +193,7 @@ static ssize_t timeout_io_op(memcached_socket_t fd, short direction, void *buf,
       if (direction == POLLOUT) {
         ret = send(fd, buf, len, 0);
       } else {
-        ret = recv(fd, buf, len, 0);
+        ret = recv(fd, const_cast<char *>(buf), len, 0);
       }
     } else if (err == 0) {
       errno = ETIMEDOUT;
@@ -251,7 +248,7 @@ static enum test_return retry_write(const void *buf, size_t len) {
 
   do {
     size_t num_bytes = len - offset;
-    ssize_t nw = timeout_io_op(sock, POLLOUT, (void *) (ptr + offset), num_bytes);
+    ssize_t nw = timeout_io_op(sock, POLLOUT, (ptr + offset), num_bytes);
     if (nw == -1) {
       verify(get_socket_errno() == EINTR || get_socket_errno() == EAGAIN);
     } else {
@@ -1882,10 +1879,17 @@ int main(int argc, char **argv) {
     return EXIT_FAILURE;
   }
 
-  //initialize_sockets();
+  #ifdef _WIN32
+  WSADATA wsaData;
+  if (WSAStartup(MAKEWORD(2, 2), &wsaData)) {
+    fprintf(stderr, "Socket Initialization Error.\n");
+    return EXIT_FAILURE;
+  }
+#endif // _WIN32
+
   sock = connect_server(hostname, port);
   if (sock == INVALID_SOCKET) {
-    fprintf(stderr, "Failed to connect to <%s:%s>: %s\n", hostname ?: "(null)", port ?: "(null)",
+    fprintf(stderr, "Failed to connect to <%s:%s>: %s\n", hostname, port,
             strerror(get_socket_errno()));
     return EXIT_FAILURE;
   }
@@ -1943,8 +1947,8 @@ int main(int argc, char **argv) {
     if (reconnect) {
       closesocket(sock);
       if ((sock = connect_server(hostname, port)) == INVALID_SOCKET) {
-        fprintf(stderr, "Failed to connect to <%s:%s>: %s\n", hostname ?: "(null)",
-                port ?: "(null)", strerror(get_socket_errno()));
+        fprintf(stderr, "Failed to connect to <%s:%s>: %s\n", hostname,
+                port, strerror(get_socket_errno()));
         fprintf(stderr, "%d of %d tests failed\n", failed, total);
         return EXIT_FAILURE;
       }
@@ -1958,5 +1962,9 @@ int main(int argc, char **argv) {
     fprintf(stderr, "%d of %d tests failed\n", failed, total);
   }
 
+#ifdef _WIN32
+  WSACleanup();
+#endif
+
   return (failed == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
 }