using namespace libtest;
+namespace {
+ bool is_memcached_libtool()
+ {
+ if (MEMCACHED_BINARY and strcmp(MEMCACHED_BINARY, "memcached/memcached") == 0)
+ {
+ return true;
+ }
+
+ return false;
+ }
+}
+
class Memcached : public libtest::Server
{
std::string _username;
std::string _password;
public:
- Memcached(const std::string& host_arg, const in_port_t port_arg, const bool is_socket_arg, const std::string& username_arg, const std::string& password_arg) :
- libtest::Server(host_arg, port_arg, is_socket_arg),
+ Memcached(const std::string& host_arg,
+ const in_port_t port_arg,
+ const bool is_socket_arg,
+ const std::string& username_arg,
+ const std::string& password_arg) :
+ libtest::Server(host_arg, port_arg,
+ MEMCACHED_BINARY, is_memcached_libtool(), is_socket_arg),
_username(username_arg),
_password(password_arg)
{ }
Memcached(const std::string& host_arg, const in_port_t port_arg, const bool is_socket_arg) :
- libtest::Server(host_arg, port_arg, is_socket_arg)
+ libtest::Server(host_arg, port_arg,
+ MEMCACHED_BINARY, is_memcached_libtool(), is_socket_arg)
{
set_pid_file();
}
return _username;
}
- pid_t get_pid(bool error_is_ok)
+ bool wait_for_pidfile() const
{
- // Memcached is slow to start, so we need to do this
- if (pid_file().empty() == false)
- {
- if (error_is_ok and not wait_for_pidfile())
- {
- Error << "Pidfile was not found:" << pid_file();
- return -1;
- }
- }
+ Wait wait(pid(), 4);
- pid_t local_pid;
- memcached_return_t rc= MEMCACHED_SUCCESS;
- if (has_socket())
- {
- if (socket().empty())
- {
- return -1;
- }
-
- local_pid= libmemcached_util_getpid(socket().c_str(), port(), &rc);
- }
- else
- {
- local_pid= libmemcached_util_getpid(hostname().c_str(), port(), &rc);
- }
-
- if (error_is_ok and ((memcached_failed(rc) or not is_pid_valid(local_pid))))
- {
- Error << "libmemcached_util_getpid(" << memcached_strerror(NULL, rc) << ") pid: " << local_pid << " for:" << *this;
- }
-
- return local_pid;
+ return wait.successful();
}
bool ping()
{
+#if 0
// Memcached is slow to start, so we need to do this
- if (not pid_file().empty())
+ if (pid_file().empty() == false)
{
if (wait_for_pidfile() == false)
{
- Error << "Pidfile was not found:" << pid_file();
+ Error << "Pidfile was not found:" << pid_file() << " :" << running();
return -1;
}
}
+#endif
memcached_return_t rc;
bool ret;
if (has_socket())
{
- ret= libmemcached_util_ping(socket().c_str(), 0, &rc);
+ ret= libmemcached_util_ping(socket().c_str(), 0, &rc);
}
else
{
ret= libmemcached_util_ping(hostname().c_str(), port(), &rc);
}
- if (memcached_failed(rc) or not ret)
+ if (memcached_failed(rc) or ret == false)
{
Error << "libmemcached_util_ping(" << hostname() << ", " << port() << ") error: " << memcached_strerror(NULL, rc);
}
return MEMCACHED_BINARY;
}
+ bool is_libtool()
+ {
+ return is_memcached_libtool();
+ }
+
virtual void pid_file_option(Application& app, const std::string& arg)
{
if (arg.empty() == false)
return "-s ";
}
- const char *daemon_file_option()
- {
- return "-d";
- }
-
virtual void port_option(Application& app, in_port_t arg)
{
char buffer[30];
}
}
- bool is_libtool()
- {
- return false;
- }
-
bool broken_socket_cleanup()
{
return true;
{
public:
- MemcachedLight(const std::string& host_arg, const in_port_t port_arg):
- libtest::Server(host_arg, port_arg)
+ MemcachedLight(const std::string& host_arg, const in_port_t port_arg) :
+ libtest::Server(host_arg, port_arg, MEMCACHED_LIGHT_BINARY, true)
{
set_pid_file();
}
- pid_t get_pid(bool error_is_ok)
- {
- // Memcached is slow to start, so we need to do this
- if (not pid_file().empty())
- {
- if (error_is_ok and not wait_for_pidfile())
- {
- Error << "Pidfile was not found:" << pid_file();
- return -1;
- }
- }
-
- bool success= false;
- std::stringstream error_message;
- pid_t local_pid= get_pid_from_file(pid_file(), error_message);
- if (local_pid > 0)
- {
- if (::kill(local_pid, 0) > 0)
- {
- success= true;
- }
- }
-
- if (error_is_ok and ((success or not is_pid_valid(local_pid))))
- {
- Error << "kill(" << " pid: " << local_pid << " errno:" << strerror(errno) << " for:" << *this;
- }
-
- return local_pid;
- }
-
bool ping()
{
// Memcached is slow to start, so we need to do this
return MEMCACHED_LIGHT_BINARY;
}
- const char *daemon_file_option()
- {
- return "--daemon";
- }
-
virtual void port_option(Application& app, in_port_t arg)
{
char buffer[1024];
class MemcachedSaSL : public Memcached
{
public:
- MemcachedSaSL(const std::string& host_arg, const in_port_t port_arg, const bool is_socket_arg, const std::string& username_arg, const std::string &password_arg) :
+ MemcachedSaSL(const std::string& host_arg,
+ const in_port_t port_arg,
+ const bool is_socket_arg,
+ const std::string& username_arg,
+ const std::string &password_arg) :
Memcached(host_arg, port_arg, is_socket_arg, username_arg, password_arg)
{ }
return MEMCACHED_SASL_BINARY;
}
- pid_t get_pid(bool error_is_ok)
- {
- // Memcached is slow to start, so we need to do this
- if (not pid_file().empty())
- {
- if (error_is_ok and not wait_for_pidfile())
- {
- Error << "Pidfile was not found:" << pid_file();
- return -1;
- }
- }
-
- pid_t local_pid;
- memcached_return_t rc;
- if (has_socket())
- {
- local_pid= libmemcached_util_getpid2(socket().c_str(), 0, username().c_str(), password().c_str(), &rc);
- }
- else
- {
- local_pid= libmemcached_util_getpid2(hostname().c_str(), port(), username().c_str(), password().c_str(), &rc);
- }
-
- if (error_is_ok and ((memcached_failed(rc) or not is_pid_valid(local_pid))))
- {
- Error << "libmemcached_util_getpid2(" << memcached_strerror(NULL, rc) << ") username: " << username() << " password: " << password() << " pid: " << local_pid << " for:" << *this;
- }
-
- return local_pid;
- }
-
bool ping()
{
// Memcached is slow to start, so we need to do this
- if (not pid_file().empty())
+ if (pid_file().empty() == false)
{
- if (not wait_for_pidfile())
+ if (wait_for_pidfile() == false)
{
Error << "Pidfile was not found:" << pid_file();
return -1;
ret= libmemcached_util_ping2(hostname().c_str(), port(), username().c_str(), password().c_str(), &rc);
}
- if (memcached_failed(rc) or not ret)
+ if (memcached_failed(rc) or ret == false)
{
Error << "libmemcached_util_ping2(" << hostname() << ", " << port() << ", " << username() << ", " << password() << ") error: " << memcached_strerror(NULL, rc);
}
bool Memcached::build(size_t argc, const char *argv[])
{
- std::stringstream arg_buffer;
-
if (getuid() == 0 or geteuid() == 0)
{
add_option("-u", "root");
bool MemcachedLight::build(size_t argc, const char *argv[])
{
- for (int x= 0 ; x < argc ; x++)
+ for (size_t x= 0 ; x < argc ; x++)
{
add_option(argv[x]);
}
projects / m6w6 / libmemcached / blobdiff