memcached_return_t memcached_server_push(memcached_st *ptr, memcached_server_st *list)
{
- uint32_t x;
uint32_t count;
memcached_server_st *new_host_list;
memcached_server_list_set(ptr, new_host_list);
- for (x= 0; x < count; x++)
+ for (uint32_t x= 0; x < count; x++)
{
memcached_server_instance_st *instance;
instance= memcached_server_instance_fetch(ptr, memcached_server_count(ptr));
- memcached_server_create(ptr, instance);
/* TODO check return type */
(void)memcached_server_create_with(ptr, instance, list[x].hostname,
list[x].port, list[x].weight, list[x].type);
return run_distribution(ptr);
}
+/**
+ @todo allow lists to query themselves even if they lack a root
+*/
memcached_return_t memcached_server_remove(memcached_server_st *st_ptr)
{
uint32_t x, host_index;
- memcached_st *ptr= st_ptr->root;
- memcached_server_st *list= memcached_server_list(ptr);
+ memcached_st *root= (memcached_st *)st_ptr->root;
+ memcached_server_st *list;
- for (x= 0, host_index= 0; x < memcached_server_count(ptr); x++)
+ if (root == NULL)
+ return MEMCACHED_FAILURE;
+
+ list= memcached_server_list(root);
+
+ for (x= 0, host_index= 0; x < memcached_server_count(root); x++)
{
if (strncmp(list[x].hostname, st_ptr->hostname, MEMCACHED_MAX_HOST_LENGTH) != 0 || list[x].port != st_ptr->port)
{
host_index++;
}
}
- ptr->number_of_hosts= host_index;
+ root->number_of_hosts= host_index;
if (st_ptr->address_info)
{
freeaddrinfo(st_ptr->address_info);
st_ptr->address_info= NULL;
}
- run_distribution(ptr);
+ run_distribution(root);
return MEMCACHED_SUCCESS;
}