Fix from Charles Aylward for reuse of buffer.

[m6w6/libmemcached] / lib / memcached_storage.c

diff --git a/lib/memcached_storage.c b/lib/memcached_storage.c
index 43a18a98336a7474f027e5a493e792c8390fec97..aac9b9227cae8d1c77f62ee0a912a86f53e39fb3 100644 (file)
--- a/lib/memcached_storage.c
+++ b/lib/memcached_storage.c
@@ -20,7 +20,7 @@ typedef enum {
 } memcached_storage_action;
 
 /* Inline this */
-char *storage_op_string(memcached_storage_action verb)
+static char *storage_op_string(memcached_storage_action verb)
 {
   switch (verb)
   {
@@ -46,26 +46,27 @@ static inline memcached_return memcached_send(memcached_st *ptr,
                                               char *key, size_t key_length, 
                                               char *value, size_t value_length, 
                                               time_t expiration,
-                                              uint16_t flags,
+                                              uint32_t flags,
                                               uint64_t cas,
                                               memcached_storage_action verb)
 {
   char to_write;
   size_t write_length;
   ssize_t sent_length;
-  memcached_return rc;
+  memcached_return rc[MEMCACHED_MAX_REPLICAS];
   char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];
   unsigned int server_key;
+  uint8_t replicas= 0;
 
-  WATCHPOINT_ASSERT(!(value == NULL && value_length > 0));
-  WATCHPOINT_ASSERT(!(value && value_length == 0));
-
-  if (key_length == 0)
+  unlikely (key_length == 0)
     return MEMCACHED_NO_KEY_PROVIDED;
 
-  if (ptr->number_of_hosts == 0)
+  unlikely (ptr->number_of_hosts == 0)
     return MEMCACHED_NO_SERVERS;
 
+  if ((ptr->flags & MEM_VERIFY_KEY) && (memcachd_key_test(&key, &key_length, 1) == MEMCACHED_BAD_KEY_PROVIDED))
+    return MEMCACHED_BAD_KEY_PROVIDED;
+
   server_key= memcached_generate_hash(ptr, master_key, master_key_length);
 
   if (cas)
@@ -81,56 +82,65 @@ static inline memcached_return memcached_send(memcached_st *ptr,
                            (unsigned long long)expiration, value_length);
 
   if (write_length >= MEMCACHED_DEFAULT_COMMAND_SIZE)
-  {
-    rc= MEMCACHED_WRITE_FAILURE;
-    goto error;
-  }
-
-  rc=  memcached_do(ptr, server_key, buffer, write_length, 0);
-  if (rc != MEMCACHED_SUCCESS)
-    goto error;
+    return MEMCACHED_WRITE_FAILURE;
 
-  if ((sent_length= memcached_io_write(ptr, server_key, value, value_length, 0)) == -1)
-  {
-    rc= MEMCACHED_WRITE_FAILURE;
-    goto error;
-  }
-
-  if ((ptr->flags & MEM_NO_BLOCK) && verb == SET_OP)
+  if ((ptr->flags & MEM_BUFFER_REQUESTS) && verb == SET_OP)
     to_write= 0;
   else
     to_write= 1;
 
-  if ((sent_length= memcached_io_write(ptr, server_key, "\r\n", 2, to_write)) == -1)
+  do
   {
-    rc= MEMCACHED_WRITE_FAILURE;
-    goto error;
-  }
+    char response_buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];
 
-  if (to_write == 0)
-  {
-    rc= MEMCACHED_SUCCESS;
-    memcached_server_response_increment(ptr, server_key);
-  }
-  else
-  {
-    rc= memcached_response(ptr, buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, server_key);
-  }
-  if (rc == MEMCACHED_STORED)
-    return MEMCACHED_SUCCESS;
-  else 
-    return rc;
+    rc[replicas]=  memcached_do(&ptr->hosts[server_key], buffer, write_length, 0);
+
+    if (rc[replicas] != MEMCACHED_SUCCESS)
+      goto error;
+
+    if ((sent_length= memcached_io_write(&ptr->hosts[server_key], value, value_length, 0)) == -1)
+    {
+      rc[replicas]= MEMCACHED_WRITE_FAILURE;
+      goto error;
+    }
 
+    if ((sent_length= memcached_io_write(&ptr->hosts[server_key], "\r\n", 2, to_write)) == -1)
+    {
+      rc[replicas]= MEMCACHED_WRITE_FAILURE;
+      goto error;
+    }
+
+    if (to_write == 0)
+      return MEMCACHED_BUFFERED;
+    else
+      rc[replicas]= memcached_response(&ptr->hosts[server_key],
+                                       response_buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, NULL);
+
+    /* On error we just jump to the next potential server */
 error:
-  memcached_io_reset(ptr, server_key);
+    if (replicas > 1 && ptr->distribution == MEMCACHED_DISTRIBUTION_CONSISTENT)
+    {
+      if (server_key == (ptr->number_of_hosts - 1))
+        server_key= 0;
+      else
+        server_key++;
+    }
+  } while ((++replicas) < ptr->number_of_replicas);
+
+  /* As long as one object gets stored, we count this as a success */
+  while (replicas--)
+  {
+    if (rc[replicas] == MEMCACHED_STORED)
+      return MEMCACHED_SUCCESS;
+  }
 
-  return rc;
+  return rc[0];
 }
 
 memcached_return memcached_set(memcached_st *ptr, char *key, size_t key_length, 
                                char *value, size_t value_length, 
                                time_t expiration,
-                               uint16_t flags)
+                               uint32_t flags)
 {
   memcached_return rc;
   LIBMEMCACHED_MEMCACHED_SET_START();
@@ -145,7 +155,7 @@ memcached_return memcached_add(memcached_st *ptr,
                                char *key, size_t key_length,
                                char *value, size_t value_length, 
                                time_t expiration,
-                               uint16_t flags)
+                               uint32_t flags)
 {
   memcached_return rc;
   LIBMEMCACHED_MEMCACHED_ADD_START();
@@ -160,7 +170,7 @@ memcached_return memcached_replace(memcached_st *ptr,
                                    char *key, size_t key_length,
                                    char *value, size_t value_length, 
                                    time_t expiration,
-                                   uint16_t flags)
+                                   uint32_t flags)
 {
   memcached_return rc;
   LIBMEMCACHED_MEMCACHED_REPLACE_START();
@@ -175,7 +185,7 @@ memcached_return memcached_prepend(memcached_st *ptr,
                                    char *key, size_t key_length,
                                    char *value, size_t value_length, 
                                    time_t expiration,
-                                   uint16_t flags)
+                                   uint32_t flags)
 {
   memcached_return rc;
   rc= memcached_send(ptr, key, key_length, 
@@ -188,7 +198,7 @@ memcached_return memcached_append(memcached_st *ptr,
                                   char *key, size_t key_length,
                                   char *value, size_t value_length, 
                                   time_t expiration,
-                                  uint16_t flags)
+                                  uint32_t flags)
 {
   memcached_return rc;
   rc= memcached_send(ptr, key, key_length, 
@@ -201,13 +211,13 @@ memcached_return memcached_cas(memcached_st *ptr,
                                char *key, size_t key_length,
                                char *value, size_t value_length, 
                                time_t expiration,
-                               uint16_t flags,
+                               uint32_t flags,
                                uint64_t cas)
 {
   memcached_return rc;
   rc= memcached_send(ptr, key, key_length, 
                      key, key_length, value, value_length,
-                     expiration, flags, cas, APPEND_OP);
+                     expiration, flags, cas, CAS_OP);
   return rc;
 }
 
@@ -216,7 +226,7 @@ memcached_return memcached_set_by_key(memcached_st *ptr,
                                       char *key, size_t key_length, 
                                       char *value, size_t value_length, 
                                       time_t expiration,
-                                      uint16_t flags)
+                                      uint32_t flags)
 {
   memcached_return rc;
   LIBMEMCACHED_MEMCACHED_SET_START();
@@ -232,7 +242,7 @@ memcached_return memcached_add_by_key(memcached_st *ptr,
                                       char *key, size_t key_length,
                                       char *value, size_t value_length, 
                                       time_t expiration,
-                                      uint16_t flags)
+                                      uint32_t flags)
 {
   memcached_return rc;
   LIBMEMCACHED_MEMCACHED_ADD_START();
@@ -248,7 +258,7 @@ memcached_return memcached_replace_by_key(memcached_st *ptr,
                                           char *key, size_t key_length,
                                           char *value, size_t value_length, 
                                           time_t expiration,
-                                          uint16_t flags)
+                                          uint32_t flags)
 {
   memcached_return rc;
   LIBMEMCACHED_MEMCACHED_REPLACE_START();
@@ -264,7 +274,7 @@ memcached_return memcached_prepend_by_key(memcached_st *ptr,
                                           char *key, size_t key_length,
                                           char *value, size_t value_length, 
                                           time_t expiration,
-                                          uint16_t flags)
+                                          uint32_t flags)
 {
   memcached_return rc;
   rc= memcached_send(ptr, key, key_length, 
@@ -278,7 +288,7 @@ memcached_return memcached_append_by_key(memcached_st *ptr,
                                          char *key, size_t key_length,
                                          char *value, size_t value_length, 
                                          time_t expiration,
-                                         uint16_t flags)
+                                         uint32_t flags)
 {
   memcached_return rc;
   rc= memcached_send(ptr, key, key_length, 
@@ -292,12 +302,12 @@ memcached_return memcached_cas_by_key(memcached_st *ptr,
                                       char *key, size_t key_length,
                                       char *value, size_t value_length, 
                                       time_t expiration,
-                                      uint16_t flags,
+                                      uint32_t flags,
                                       uint64_t cas)
 {
   memcached_return rc;
   rc= memcached_send(ptr, key, key_length, 
                      key, key_length, value, value_length,
-                     expiration, flags, cas, APPEND_OP);
+                     expiration, flags, cas, CAS_OP);
   return rc;
 }