Adding buffered IO to reads

[awesomized/libmemcached] / lib / memcached_delete.c

diff --git a/lib/memcached_delete.c b/lib/memcached_delete.c
index e601e6fa969fca32cbb4a6e9c879edb6215cec75..ecd7d8dc1b203cad509f1616939981b1b0a1a48a 100644 (file)
--- a/lib/memcached_delete.c
+++ b/lib/memcached_delete.c
@@ -1,13 +1,15 @@
-#include <memcached.h>
+#include "common.h"
 
 memcached_return memcached_delete(memcached_st *ptr, char *key, size_t key_length,
                                   time_t expiration)
 {
-  size_t send_length;
+  size_t send_length, sent_length;
   memcached_return rc;
   char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];
   unsigned int server_key;
 
+  LIBMEMCACHED_MEMCACHED_DELETE_START();
+
   rc= memcached_connect(ptr);
 
   if (rc != MEMCACHED_SUCCESS)
@@ -17,16 +19,33 @@ memcached_return memcached_delete(memcached_st *ptr, char *key, size_t key_lengt
 
   if (expiration)
     send_length= snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, 
-                          "delete %.*s %u\r\n", key_length, key, expiration);
+                          "delete %.*s %llu\r\n", (int)key_length, key, 
+                          (unsigned long long)expiration);
   else
     send_length= snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, 
-                          "delete %.*s\r\n", key_length, key);
-  if ((write(ptr->hosts[server_key].fd, buffer, send_length) == -1))
+                          "delete %.*s\r\n", (int)key_length, key);
+
+  if (send_length >= MEMCACHED_DEFAULT_COMMAND_SIZE)
   {
-    fprintf(stderr, "failed set on %.*s TCP\n", key_length+1, key);
+    rc= MEMCACHED_WRITE_FAILURE;
+    goto error;
+  }
+
+  sent_length= send(ptr->hosts[server_key].fd, buffer, send_length, 0);
 
-    return MEMCACHED_WRITE_FAILURE;
+  if (sent_length == -1 || sent_length != send_length)
+  {
+    rc= MEMCACHED_WRITE_FAILURE;
+    goto error;
   }
 
-  return memcached_response(ptr, buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, server_key);
+  rc= memcached_response(ptr, buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, server_key);
+
+  if (rc == MEMCACHED_DELETED)
+    rc= MEMCACHED_SUCCESS;
+
+  LIBMEMCACHED_MEMCACHED_DELETE_END();
+
+error:
+  return rc;
 }