From 8189a52ebb8f7663aabfdbd1a3ff931db9553495 Mon Sep 17 00:00:00 2001 From: Michael Wallner Date: Wed, 9 Mar 2016 16:45:13 +0100 Subject: [PATCH] fix response if no action is to be taken --- app/Controller/Github/Hook/Receive.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/app/Controller/Github/Hook/Receive.php b/app/Controller/Github/Hook/Receive.php index 9bc1323..1094fd2 100644 --- a/app/Controller/Github/Hook/Receive.php +++ b/app/Controller/Github/Hook/Receive.php @@ -51,12 +51,14 @@ class Receive implements Controller case "create": case "release": if (($json = json_decode($request->getBody()))) { - $this->$evt($json)->done(function($result) use($response) { - list($created) = $result; - $response->setResponseCode(201); - $response->setHeader("Location", $created->url); - }); - $this->github->drain(); + if (($queue = $this->$evt($json))) { + $queue->done(function($result) use($response) { + list($created) = $result; + $response->setResponseCode(201); + $response->setHeader("Location", $created->url); + }); + $this->github->drain(); + } } else { $response->setResponseCode(415); $response->setContentType($request->getHeader("Content-Type")); -- 2.30.2