projects
/
m6w6
/
ext-psi
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
|
github
raw
|
patch
|
inline
| side by side (parent:
216e7ac
)
interned strings++
author
Michael Wallner
<mike@php.net>
Fri, 2 Nov 2018 11:47:45 +0000
(12:47 +0100)
committer
Michael Wallner
<mike@php.net>
Tue, 4 Dec 2018 11:13:42 +0000
(12:13 +0100)
TODO
patch
|
blob
|
history
src/types/decl_extvar.c
patch
|
blob
|
history
diff --git
a/TODO
b/TODO
index 1e1462672791f37714143cc72a1b3fb8afd33067..3e6e55a15fa4ea5c6bdd9e4c6b4de2514952f44c 100644
(file)
--- a/
TODO
+++ b/
TODO
@@
-2,10
+2,8
@@
* let the various list types be hashtables where appropriate
* check out jit-dynamic
* fix arginfo with nullable types
* let the various list types be hashtables where appropriate
* check out jit-dynamic
* fix arginfo with nullable types
-* pemalloc
* think about a better system for EXTVARs, separate \set and \get functions are clunky
* think about a better system for EXTVARs, separate \set and \get functions are clunky
-* impl_def_val: allow num_exp
* fix right recursion of let_exp and set_exp
* improve varargs support, currently it's impossible to map e.g. curl_easy_setopt
* fix right recursion of let_exp and set_exp
* improve varargs support, currently it's impossible to map e.g. curl_easy_setopt
-* cpp: asm aliasing/redirects
* impl_var.name: remove leading '$'
* impl_var.name: remove leading '$'
+* really solve the array/pointer problem
diff --git
a/src/types/decl_extvar.c
b/src/types/decl_extvar.c
index 4490a0a12781454cdc1de111dde0a11e1ef3ceb6..21323da0fbe07cf4136bd27771cdc767f74743cb 100644
(file)
--- a/
src/types/decl_extvar.c
+++ b/
src/types/decl_extvar.c
@@
-134,7
+134,7
@@
struct psi_decl *psi_decl_extvar_setter(struct psi_decl_extvar *evar)
smart_str_append_ex(&name, func_var->name, 1);
smart_str_appendl_ex(&name, ZEND_STRL("_set"), 1);
zend_string_release(func_var->name);
smart_str_append_ex(&name, func_var->name, 1);
smart_str_appendl_ex(&name, ZEND_STRL("_set"), 1);
zend_string_release(func_var->name);
- func_var->name =
smart_str_extract(&name
);
+ func_var->name =
zend_new_interned_string(smart_str_extract(&name)
);
decl->extvar = 1;
decl->extvar = 1;
@@
-157,7
+157,7
@@
struct psi_decl *psi_decl_extvar_getter(struct psi_decl_extvar *evar)
smart_str_append_ex(&name, func_var->name, 1);
smart_str_appendl_ex(&name, ZEND_STRL("_get"), 1);
zend_string_release(func_var->name);
smart_str_append_ex(&name, func_var->name, 1);
smart_str_appendl_ex(&name, ZEND_STRL("_get"), 1);
zend_string_release(func_var->name);
- func_var->name =
smart_str_extract(&name
);
+ func_var->name =
zend_new_interned_string(smart_str_extract(&name)
);
decl->extvar = 1;
decl->extvar = 1;