X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-psi;a=blobdiff_plain;f=src%2Flibffi.c;h=2c68fbf0ee4bb34834dd51b910bdb1ec39e3f3e5;hp=c6df4276d0f70dbae707e391a8d93a93f5cbfb23;hb=70136a34090807976d66b361fbc8963c0c91f17e;hpb=7eb47ef2fc5655e7196e4e0fbf5104eed8274601

diff --git a/src/libffi.c b/src/libffi.c
index c6df427..2c68fbf 100644
--- a/src/libffi.c
+++ b/src/libffi.c
@@ -5,10 +5,42 @@
 #include <ffi.h>
 
 #ifndef PSI_HAVE_FFI_CLOSURE_ALLOC
-# include <unistd.h>
-# include <sys/mman.h>
+# if HAVE_UNISTD_H
+#  include <unistd.h>
+# endif
+# if HAVE_SYS_MMAN_H
+#  include <sys/mman.h>
+#  ifndef MAP_ANONYMOUS
+#   define MAP_ANONYMOUS MAP_ANON
+#  endif
+# endif
 #endif
 
+static void *psi_ffi_closure_alloc(size_t s, void **code)
+{
+#ifdef PSI_HAVE_FFI_CLOSURE_ALLOC
+	return ffi_closure_alloc(s, code);
+#elif HAVE_MMAP
+	*code = mmap(NULL, s, PROT_EXEC|PROT_WRITE|PROT_READ,
+			MAP_PRIVATE|MAP_ANONYMOUS, -1, 0);
+	if (MAP_FAILED == *code) {
+		return NULL;
+	}
+	return *code;
+#else
+	return NULL;
+#endif
+}
+
+static void psi_ffi_closure_free(void *c)
+{
+#ifdef PSI_HAVE_FFI_CLOSURE_ALLOC
+	ffi_closure_free(c);
+#elif HAVE_MMAP
+	munmap(c, sizeof(ffi_closure));
+#endif
+}
+
 static void handler(ffi_cif *signature, void *_result, void **_args, void *_data);
 
 static inline ffi_abi psi_ffi_abi(const char *convention) {
@@ -104,8 +136,9 @@ static inline PSI_LibffiData *PSI_LibffiDataAlloc(PSI_LibffiContext *context, im
 			data->params);
 	ZEND_ASSERT(FFI_OK == rc);
 
-#ifdef PSI_HAVE_FFI_CLOSURE_ALLOC
-	data->closure = ffi_closure_alloc(sizeof(ffi_closure), &data->code);
+	data->closure = psi_ffi_closure_alloc(sizeof(ffi_closure), &data->code);
+	ZEND_ASSERT(data->closure != NULL);
+#if PSI_HAVE_FFI_PREP_CLOSURE_LOC
 	rc = ffi_prep_closure_loc(
 			data->closure,
 			&context->signature,
@@ -113,14 +146,11 @@ static inline PSI_LibffiData *PSI_LibffiDataAlloc(PSI_LibffiContext *context, im
 			data,
 			data->code);
 	ZEND_ASSERT(FFI_OK == rc);
-#else
-	i = getpagesize();
-	data->closure = malloc(sizeof(ffi_closure) + i);
-	data->code = (void *) (((intptr_t) data->closure + i - 1) & ~((intptr_t) i - 1));
-	rc = mprotect(data->code, sizeof(ffi_closure), PROT_EXEC|PROT_WRITE);
-	ZEND_ASSERT(rc == 0);
+#elif PSI_HAVE_FFI_PREP_CLOSURE
 	rc = ffi_prep_closure(data->code, &context->signature, handler, data);
 	ZEND_ASSERT(FFI_OK == rc);
+#else
+# error "Neither ffi_prep_closure() nor ffi_prep_closure_loc() available"
 #endif
 
 	context->data.list = realloc(context->data.list, ++context->data.count * sizeof(*context->data.list));
@@ -130,12 +160,8 @@ static inline PSI_LibffiData *PSI_LibffiDataAlloc(PSI_LibffiContext *context, im
 }
 
 static inline void PSI_LibffiDataFree(PSI_LibffiData *data) {
+	psi_ffi_closure_free(data->closure);
 	free(data->arginfo);
-#ifdef PSI_HAVE_FFI_CLOSURE_FREE
-	ffi_closure_free(data->closure);
-#else
-	free(data->closure);
-#endif
 	free(data);
 }
 
@@ -193,7 +219,8 @@ static void handler(ffi_cif *_sig, void *_result, void **_args, void *_data)
 			decl_arg *darg = data->impl->decl->args->args[i];
 
 			arg_ptr[i] = psi_do_let(darg);
-			arg_prm[i] = darg->let->val->is_reference ? &arg_ptr[i] : arg_ptr[i];
+			arg_prm[i] = (darg->let->val && darg->let->val->is_reference)
+					? &arg_ptr[i] : arg_ptr[i];
 
 			darg->let->ptr = arg_ptr[i];
 		}