improved type validation

[m6w6/ext-psi] / src / types / decl_union.c

diff --git a/src/types/decl_union.c b/src/types/decl_union.c
index 71e70eb378b2bf5b7bfd7141037f1d4f94b7038a..1d24f95e5f9d3dd45a989de69eb67a3f151639b9 100644 (file)
--- a/src/types/decl_union.c
+++ b/src/types/decl_union.c
@@ -74,11 +74,17 @@ struct psi_decl_arg *psi_decl_union_get_arg(struct psi_decl_union *u,
        return NULL;
 }
 
-bool psi_decl_union_validate(struct psi_data *data, struct psi_decl_union *u)
+bool psi_decl_union_validate(struct psi_data *data, struct psi_decl_union *u,
+               struct psi_validate_stack *type_stack)
 {
        size_t i, pos, len, size = 0, align;
        struct psi_decl_arg *darg;
 
+       if (psi_validate_stack_has_union(type_stack, u->name)) {
+               return true;
+       }
+       psi_validate_stack_add_union(type_stack, u->name, u);
+
        if (!u->size && !psi_plist_count(u->args)) {
                data->error(data, u->token, PSI_WARNING,
                                "Cannot compute size of empty union %s", u->name);
@@ -88,7 +94,7 @@ bool psi_decl_union_validate(struct psi_data *data, struct psi_decl_union *u)
        for (i = 0; psi_plist_get(u->args, i, &darg); ++i) {
                darg->var->arg = darg;
 
-               if (!psi_decl_arg_validate(data, darg)) {
+               if (!psi_decl_arg_validate(data, darg, type_stack)) {
                        return false;
                }