X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-pq;a=blobdiff_plain;f=src%2Fphp_pqtypes.c;h=5e5ef2ca7c4a75beecc1347b135898b161160843;hp=8fd12e064e26e4ab92a0859e49a4af0c1f7a7116;hb=0b9658d38885a944bd65cc1f2266c431d9bf9d92;hpb=c753ebfed3a4b21409cfa46212fd2c55227c809f

diff --git a/src/php_pqtypes.c b/src/php_pqtypes.c
index 8fd12e0..5e5ef2c 100644
--- a/src/php_pqtypes.c
+++ b/src/php_pqtypes.c
@@ -143,6 +143,16 @@ static zval *php_pqtypes_object_read_dimension(zval *object, zval *member, int t
 	return data;
 }
 
+static void php_pqtypes_object_write_dimension(zval *object, zval *offset, zval *value)
+{
+	throw_exce(EX_RUNTIME, "pq\\Types object must not be modified");
+}
+
+static void php_pqtypes_object_unset_dimension(zval *object, zval *offset)
+{
+	throw_exce(EX_RUNTIME, "pq\\Types object must not be modified");
+}
+
 ZEND_BEGIN_ARG_INFO_EX(ai_pqtypes_construct, 0, 0, 1)
 	ZEND_ARG_OBJ_INFO(0, connection, pq\\Connection, 0)
 	ZEND_ARG_ARRAY_INFO(0, namespaces, 1)
@@ -179,10 +189,9 @@ static PHP_METHOD(pqtypes, __construct) {
 }
 
 #define PHP_PQ_TYPES_QUERY \
-	"select t.oid, t.* " \
+	"select t.oid, t.typname, t.* " \
 	"from pg_type t join pg_namespace n on t.typnamespace=n.oid " \
-	"where typisdefined " \
-	"and typrelid=0"
+	"where typisdefined"
 #ifndef PHP_PQ_OID_TEXT
 # define PHP_PQ_OID_TEXT 25
 #endif
@@ -272,7 +281,7 @@ static PHP_METHOD(pqtypes, refresh) {
 }
 
 static zend_function_entry php_pqtypes_methods[] = {
-	PHP_ME(pqtypes, __construct, ai_pqtypes_construct, ZEND_ACC_PUBLIC|ZEND_ACC_CTOR)
+	PHP_ME(pqtypes, __construct, ai_pqtypes_construct, ZEND_ACC_PUBLIC)
 	PHP_ME(pqtypes, refresh, ai_pqtypes_refresh, ZEND_ACC_PUBLIC)
 	{0}
 };
@@ -302,14 +311,14 @@ PHP_MINIT_FUNCTION(pqtypes)
 	php_pqtypes_object_handlers.read_property = php_pq_object_read_prop;
 	php_pqtypes_object_handlers.write_property = php_pq_object_write_prop;
 	php_pqtypes_object_handlers.clone_obj = NULL;
-	php_pqtypes_object_handlers.get_property_ptr_ptr = NULL;
+	php_pqtypes_object_handlers.get_property_ptr_ptr = php_pq_object_get_prop_ptr_null;
 	php_pqtypes_object_handlers.get_gc = php_pq_object_get_gc;
 	php_pqtypes_object_handlers.get_properties = php_pq_object_properties;
 	php_pqtypes_object_handlers.get_debug_info = php_pq_object_debug_info;
 	php_pqtypes_object_handlers.has_dimension = php_pqtypes_object_has_dimension;
 	php_pqtypes_object_handlers.read_dimension = php_pqtypes_object_read_dimension;
-	php_pqtypes_object_handlers.unset_dimension = NULL;
-	php_pqtypes_object_handlers.write_dimension = NULL;
+	php_pqtypes_object_handlers.unset_dimension = php_pqtypes_object_unset_dimension;
+	php_pqtypes_object_handlers.write_dimension = php_pqtypes_object_write_dimension;
 
 	zend_hash_init(&php_pqtypes_object_prophandlers, 1, NULL, php_pq_object_prophandler_dtor, 1);