Fix empty arrays parsing
[m6w6/ext-pq] / src / php_pq_misc.c
index 0f4c83a0f72810098418d410eecde3520efa3471..619559d0fe724d393d299b72b467c0b84cd5a673 100644 (file)
 #include <php.h>
 #include <ext/date/php_date.h>
 #include <ext/standard/php_string.h>
-#if defined(HAVE_JSON) && !defined(COMPILE_DL_JSON)
-#      include <ext/json/php_json.h>
-#endif
 
 #include <Zend/zend_interfaces.h>
 
 #include <libpq/libpq-fs.h>
 
 #include "php_pq.h"
+#include "php_pqexc.h"
 #include "php_pq_misc.h"
+#include "php_pqconn_event.h"
+#undef PHP_PQ_TYPE
+#include "php_pq_type.h"
+
+
+/* clear result object associated with a result handle */
+void php_pqres_clear(PGresult *r) {
+       php_pq_object_t *o = PQresultInstanceData(r, php_pqconn_event);
+
+       if (o) {
+               php_pq_object_delref(o);
+       } else {
+               PQclear(r);
+       }
+}
+
+/* clear any asynchronous results */
+void php_pqconn_clear(PGconn *conn) {
+       PGresult *r;
+       php_pqconn_event_data_t *evdata = PQinstanceData(conn, php_pqconn_event);
+
+       while ((r = PQgetResult(conn))) {
+               php_pqres_clear(r);
+       }
+
+       if (evdata && evdata->obj) {
+               if (php_pq_callback_is_enabled(&evdata->obj->intern->onevent)) {
+                       if (php_pq_callback_is_locked(&evdata->obj->intern->onevent)) {
+                               php_pq_callback_disable(&evdata->obj->intern->onevent);
+                       } else {
+                               php_pq_callback_dtor(&evdata->obj->intern->onevent);
+                       }
+               }
+       }
+}
+
+/* safe wrappers to clear any asynchronous wrappers before querying synchronously */
+PGresult *php_pq_exec(PGconn *conn, const char *query) {
+       php_pqconn_clear(conn);
+       return PQexec(conn, query);
+}
+PGresult *php_pq_exec_params(PGconn *conn, const char *command, int nParams, const Oid *paramTypes, const char *const * paramValues, const int *paramLengths, const int *paramFormats, int resultFormat) {
+       php_pqconn_clear(conn);
+       return PQexecParams(conn, command, nParams, paramTypes, paramValues, paramLengths, paramFormats, resultFormat);
+}
+PGresult *php_pq_prepare(PGconn *conn, const char *stmtName, const char *query, int nParams, const Oid *paramTypes) {
+       php_pqconn_clear(conn);
+       return PQprepare(conn, stmtName, query, nParams, paramTypes);
+}
+PGresult *php_pq_exec_prepared(PGconn *conn, const char *stmtName, int nParams, const char *const * paramValues, const int *paramLengths, const int *paramFormats, int resultFormat) {
+       php_pqconn_clear(conn);
+       return PQexecPrepared(conn, stmtName, nParams, paramValues, paramLengths, paramFormats, resultFormat);
+}
 
-char *rtrim(char *e)
+char *php_pq_rtrim(char *e)
 {
        size_t l = strlen(e);
 
@@ -38,7 +89,7 @@ char *rtrim(char *e)
        return e;
 }
 
-const char *strmode(long mode)
+const char *php_pq_strmode(long mode)
 {
        switch (mode & (INV_READ|INV_WRITE)) {
        case INV_READ|INV_WRITE:
@@ -52,285 +103,168 @@ const char *strmode(long mode)
        }
 }
 
-int compare_index(const void *lptr, const void *rptr TSRMLS_DC)
+int php_pq_compare_index(const void *lptr, const void *rptr)
 {
-       const Bucket *l = *(const Bucket **) lptr;
-       const Bucket *r = *(const Bucket **) rptr;
+       zend_ulong l = ((const Bucket *) lptr)->h;
+       zend_ulong r = ((const Bucket *) rptr)->h;
 
-       if (l->h < r->h) {
+       if (l < r) {
                return -1;
        }
-       if (l->h > r->h) {
+       if (l > r) {
                return 1;
        }
        return 0;
 }
 
-static int apply_to_oid(void *p, void *arg TSRMLS_DC)
+void php_pq_hash_ptr_dtor(zval *p)
 {
-       Oid **types = arg;
-       zval **ztype = p;
-
-       if (Z_TYPE_PP(ztype) != IS_LONG) {
-               convert_to_long_ex(ztype);
-       }
-
-       **types = Z_LVAL_PP(ztype);
-       ++*types;
-
-       if (*ztype != *(zval **)p) {
-               zval_ptr_dtor(ztype);
-       }
-       return ZEND_HASH_APPLY_KEEP;
+       efree(Z_PTR_P(p));
 }
 
-static int apply_to_param_from_array(void *p TSRMLS_DC, int argc, va_list argv, zend_hash_key *key)
-{
-       zval **zparam = p;
-       unsigned j, *i = va_arg(argv, unsigned *);
-       smart_str *s = va_arg(argv, smart_str *);
-       char *tmp;
-       size_t len;
-       int tmp_len;
-
-       if ((*i)++) {
-               smart_str_appendc(s, ',');
-       }
-
-       switch (Z_TYPE_PP(zparam)) {
-       case IS_NULL:
-               smart_str_appends(s, "NULL");
-               break;
-
-       case IS_BOOL:
-               smart_str_appends(s, Z_BVAL_PP(zparam) ? "t" : "f");
-               break;
-
-       case IS_LONG:
-               smart_str_append_long(s, Z_LVAL_PP(zparam));
-               break;
-
-       case IS_DOUBLE:
-               len = spprintf(&tmp, 0, "%F", Z_DVAL_PP(zparam));
-               smart_str_appendl(s, tmp, len);
-               efree(tmp);
-               break;
-
-       case IS_ARRAY:
-               j = 0;
-               smart_str_appendc(s, '{');
-               zend_hash_apply_with_arguments(Z_ARRVAL_PP(zparam) TSRMLS_CC, apply_to_param_from_array, 2, &j, s);
-               smart_str_appendc(s, '}');
-               break;
-
-       default:
-       {
-               SEPARATE_ZVAL(zparam);
-               if (Z_TYPE_PP(zparam) != IS_STRING) {
-                       convert_to_string(*zparam);
-               }
-
-               tmp = php_addslashes(Z_STRVAL_PP(zparam), Z_STRLEN_PP(zparam), &tmp_len, 0 TSRMLS_CC);
-               smart_str_appendc(s, '"');
-               smart_str_appendl(s, tmp, tmp_len);
-               smart_str_appendc(s, '"');
-
-               if (*zparam != *((zval **) p)) {
-                       zval_ptr_dtor(zparam);
-               }
-               break;
-       }
-       }
-
-       ++(*i);
-       return ZEND_HASH_APPLY_KEEP;
-}
+zend_class_entry *php_pqdt_class_entry;
 
-static void array_param_to_string(HashTable *ht, char **str, int *len TSRMLS_DC)
+ZEND_BEGIN_ARG_INFO_EX(ai_pqdt_to_string, 0, 0, 0)
+ZEND_END_ARG_INFO();
+static PHP_METHOD(pqdt, __toString)
 {
-       smart_str s = {0};
-       unsigned i = 0;
-
-       smart_str_appendc(&s, '{');
-       zend_hash_apply_with_arguments(ht TSRMLS_CC, apply_to_param_from_array, 2, &i, &s);
-       smart_str_appendc(&s, '}');
+       zval rv, tmp;
 
-       smart_str_0(&s);
-       *str = s.c;
-       *len = s.len;
+       ZVAL_NULL(&rv);
+       zend_call_method_with_1_params(getThis(), php_pqdt_class_entry, NULL, "format", &rv,
+                       zend_read_property(php_pqdt_class_entry, getThis(), ZEND_STRL("format"), 0, &tmp));
+       RETVAL_ZVAL(&rv, 1, 1);
 }
 
-static int apply_to_param(void *p TSRMLS_DC, int argc, va_list argv, zend_hash_key *key)
+ZEND_BEGIN_ARG_INFO_EX(ai_pqdt_create_from_format, 0, 0, 2)
+       ZEND_ARG_INFO(0, format)
+       ZEND_ARG_INFO(0, datetime)
+#if PHP_VERSION_ID >= 70200
+       ZEND_ARG_OBJ_INFO(0, object, DateTimeZone, 1)
+#else
+       ZEND_ARG_INFO(0, timezone)
+#endif
+ZEND_END_ARG_INFO();
+static PHP_METHOD(pqdt, createFromFormat)
 {
-       char ***params;
-       HashTable *zdtor;
-       zval **zparam = p;
-
-       params = (char ***) va_arg(argv, char ***);
-       zdtor = (HashTable *) va_arg(argv, HashTable *);
-
-       switch (Z_TYPE_PP(zparam)) {
-       case IS_NULL:
-               **params = NULL;
-               ++*params;
-               return ZEND_HASH_APPLY_KEEP;
-
-       case IS_BOOL:
-               **params = Z_BVAL_PP(zparam) ? "t" : "f";
-               ++*params;
-               return ZEND_HASH_APPLY_KEEP;
-
-       case IS_DOUBLE:
-               SEPARATE_ZVAL(zparam);
-               Z_TYPE_PP(zparam) = IS_STRING;
-               Z_STRLEN_PP(zparam) = spprintf(&Z_STRVAL_PP(zparam), 0, "%F", Z_DVAL_PP((zval **)p));
-               break;
-
-       case IS_ARRAY:
-       {
-               zval *tmp;
-               MAKE_STD_ZVAL(tmp);
-               Z_TYPE_P(tmp) = IS_STRING;
-               array_param_to_string(Z_ARRVAL_PP(zparam), &Z_STRVAL_P(tmp), &Z_STRLEN_P(tmp) TSRMLS_CC);
-               zparam = &tmp;
-               break;
+       zend_error_handling zeh;
+       char *fmt_str, *dt_str;
+       size_t fmt_len, dt_len;
+       zval *ztz = NULL;
+       ZEND_RESULT_CODE rv;
+
+       zend_replace_error_handling(EH_THROW, exce(EX_INVALID_ARGUMENT), &zeh);
+       rv = zend_parse_parameters(ZEND_NUM_ARGS(), "ss|O", &fmt_str, &fmt_len, &dt_str, &dt_len, &ztz, php_date_get_timezone_ce());
+       zend_restore_error_handling(&zeh);
+
+       if (SUCCESS == rv) {
+               php_pqdt_from_string(return_value, fmt_str, dt_str, dt_len, "Y-m-d H:i:s.uO", ztz);
        }
-
-       default:
-               convert_to_string_ex(zparam);
-               break;
-       }
-
-       **params = Z_STRVAL_PP(zparam);
-       ++*params;
-
-       if (*zparam != *(zval **)p) {
-               zend_hash_next_index_insert(zdtor, zparam, sizeof(zval *), NULL);
-       }
-       return ZEND_HASH_APPLY_KEEP;
 }
 
-int php_pq_types_to_array(HashTable *ht, Oid **types TSRMLS_DC)
-{
-       int count = zend_hash_num_elements(ht);
-
-       *types = NULL;
+static zend_function_entry php_pqdt_methods[] = {
+       PHP_ME(pqdt, createFromFormat, ai_pqdt_create_from_format, ZEND_ACC_PUBLIC|ZEND_ACC_STATIC)
+       PHP_ME(pqdt, __toString, ai_pqdt_to_string, ZEND_ACC_PUBLIC)
+       PHP_MALIAS(pqdt, jsonSerialize, __toString, ai_pqdt_to_string, ZEND_ACC_PUBLIC)
+       {0}
+};
 
-       if (count) {
-               Oid *tmp;
+zval *php_pqdt_from_string(zval *zv, char *input_fmt, char *dt_str, size_t dt_len, char *output_fmt, zval *ztimezone)
+{
+       php_date_obj *dobj;
 
-               /* +1 for when less types than params are specified */
-               *types = tmp = ecalloc(count + 1, sizeof(**types));
-               zend_hash_apply_with_argument(ht, apply_to_oid, &tmp TSRMLS_CC);
+       php_date_instantiate(php_pqdt_class_entry, zv);
+       dobj = php_date_obj_from_obj(Z_OBJ_P(zv));
+       if (!php_date_initialize(dobj, dt_str, dt_len, input_fmt, ztimezone, 1)) {
+               zval_dtor(zv);
+               ZVAL_NULL(zv);
+       } else if (output_fmt) {
+               zend_update_property_string(php_pqdt_class_entry, zv, ZEND_STRL("format"), output_fmt);
        }
 
-       return count;
+       return zv;
 }
 
-int php_pq_params_to_array(HashTable *ht, char ***params, HashTable *zdtor TSRMLS_DC)
+zend_string *php_pqdt_to_string(zval *zdt, const char *format)
 {
-       int count = zend_hash_num_elements(ht);
+       zval rv;
 
-       *params = NULL;
+       ZVAL_NULL(&rv);
 
-       if (count) {
-               char **tmp;
+       if (Z_OBJ_HT_P(zdt)->cast_object
+       &&      SUCCESS == Z_OBJ_HT_P(zdt)->cast_object(zdt, &rv, IS_STRING)
+       ) {
+               return Z_STR(rv);
+       } else if (instanceof_function(Z_OBJCE_P(zdt), php_date_get_date_ce())) {
+               zval rv, zfmt;
 
-               *params = tmp = ecalloc(count, sizeof(char *));
-               zend_hash_apply_with_arguments(ht TSRMLS_CC, apply_to_param, 2, &tmp, zdtor);
-       }
-
-       return count;
-}
+               ZVAL_NULL(&rv);
+               ZVAL_STRING(&zfmt, format);
+               zend_call_method_with_1_params(zdt, Z_OBJCE_P(zdt), NULL, "format", &rv, &zfmt);
+               zval_ptr_dtor(&zfmt);
 
-/*
-Oid *php_pq_ntypes_to_array(zend_bool fill, int argc, ...)
-{
-       int i;
-       Oid *oids = ecalloc(argc + 1, sizeof(*oids));
-       va_list argv;
-
-       va_start(argv, argc);
-       for (i = 0; i < argc; ++i) {
-               if (!fill || !i) {
-                       oids[i] = va_arg(argv, Oid);
-               } else {
-                       oids[i] = oids[0];
+               if (Z_TYPE(rv) == IS_STRING) {
+                       return Z_STR(rv);
                }
+               zval_ptr_dtor(&rv);
        }
-       va_end(argv);
 
-       return oids;
+       return NULL;
 }
-*/
 
-zend_class_entry *php_pqdt_class_entry;
+zend_class_entry *php_pqconv_class_entry;
 
-ZEND_BEGIN_ARG_INFO_EX(ai_pqdt_to_string, 0, 0, 0)
+ZEND_BEGIN_ARG_INFO_EX(ai_pqconv_convert_types, 0, 0, 0)
 ZEND_END_ARG_INFO();
-static PHP_METHOD(pqdt, __toString)
-{
-       zval *rv;
 
-       zend_call_method_with_1_params(&getThis(), php_pqdt_class_entry, NULL, "format", &rv,
-                       zend_read_property(php_pqdt_class_entry, getThis(), ZEND_STRL("format"), 0 TSRMLS_CC));
-       RETVAL_ZVAL(rv, 1, 1);
-}
+ZEND_BEGIN_ARG_INFO_EX(ai_pqconv_convert_from_string, 0, 0, 2)
+       ZEND_ARG_INFO(0, data)
+       ZEND_ARG_INFO(0, type)
+ZEND_END_ARG_INFO();
 
-static zend_function_entry php_pqdt_methods[] = {
-       PHP_ME(pqdt, __toString, ai_pqdt_to_string, ZEND_ACC_PUBLIC)
-       PHP_MALIAS(pqdt, jsonSerialize, __toString, ai_pqdt_to_string, ZEND_ACC_PUBLIC)
+ZEND_BEGIN_ARG_INFO_EX(ai_pqconv_convert_to_string, 0, 0, 2)
+       ZEND_ARG_INFO(0, data)
+       ZEND_ARG_INFO(0, type)
+ZEND_END_ARG_INFO();
+
+zend_function_entry php_pqconv_methods[] = {
+       PHP_ABSTRACT_ME(pqconv, convertTypes, ai_pqconv_convert_types)
+       PHP_ABSTRACT_ME(pqconv, convertFromString, ai_pqconv_convert_from_string)
+       PHP_ABSTRACT_ME(pqconv, convertToString, ai_pqconv_convert_to_string)
        {0}
 };
 
-zval *php_pqdt_from_string(char *dt_str, size_t dt_len, char *fmt, zval *zv TSRMLS_DC)
-{
-       php_date_obj *dobj;
-
-       if (!zv) {
-               MAKE_STD_ZVAL(zv);
-       }
-
-       php_date_instantiate(php_pqdt_class_entry, zv TSRMLS_CC);
-       dobj = zend_object_store_get_object(zv TSRMLS_CC);
-       if (!php_date_initialize(dobj, dt_str, dt_len, NULL, NULL, 1 TSRMLS_CC)) {
-               zval_dtor(zv);
-               ZVAL_NULL(zv);
-       } else if (fmt) {
-               zend_update_property_string(php_pqdt_class_entry, zv, ZEND_STRL("format"), fmt TSRMLS_CC);
-       }
-
-       return zv;
-}
 
 PHP_MINIT_FUNCTION(pq_misc)
 {
-       zend_class_entry **json, ce = {0};
+       zend_class_entry *json, ce = {0};
+
+       INIT_NS_CLASS_ENTRY(ce, "pq", "Converter", php_pqconv_methods);
+       php_pqconv_class_entry = zend_register_internal_interface(&ce);
 
+       memset(&ce, 0, sizeof(ce));
        INIT_NS_CLASS_ENTRY(ce ,"pq", "DateTime", php_pqdt_methods);
-       php_pqdt_class_entry = zend_register_internal_class_ex(&ce, php_date_get_date_ce(), "DateTime" TSRMLS_CC);
+       php_pqdt_class_entry = zend_register_internal_class_ex(&ce, php_date_get_date_ce());
 
-       zend_declare_property_stringl(php_pqdt_class_entry, ZEND_STRL("format"), ZEND_STRL("Y-m-d H:i:s.u"), ZEND_ACC_PUBLIC TSRMLS_CC);
+       zend_declare_property_stringl(php_pqdt_class_entry, ZEND_STRL("format"), ZEND_STRL("Y-m-d H:i:s.uO"), ZEND_ACC_PUBLIC);
 
        /* stop reading this file right here! */
-       if (SUCCESS == zend_hash_find(CG(class_table), ZEND_STRS("jsonserializable"), (void *) &json)) {
-               zend_class_implements(php_pqdt_class_entry TSRMLS_CC, 1, *json);
+       if ((json = zend_hash_str_find_ptr(CG(class_table), ZEND_STRL("jsonserializable")))) {
+               zend_class_implements(php_pqdt_class_entry, 1, json);
        }
 
        return SUCCESS;
 }
 
 typedef struct _HashTableList {
-       HashTable ht;
+       zval arr;
        struct _HashTableList *parent;
 } HashTableList;
 
 typedef struct _ArrayParserState {
        const char *ptr, *end;
        HashTableList *list;
-#ifdef ZTS
-       void ***ts;
-#endif
+       php_pqres_t *res;
        Oid typ;
        unsigned quotes:1;
        unsigned escaped:1;
@@ -339,7 +273,6 @@ typedef struct _ArrayParserState {
 static char caa(ArrayParserState *a, const char *any, unsigned advance)
 {
        const char *p = any;
-       TSRMLS_FETCH_FROM_CTX(a->ts);
 
        do {
                if (*p == *a->ptr) {
@@ -348,51 +281,46 @@ static char caa(ArrayParserState *a, const char *any, unsigned advance)
                }
        } while (*++p);
 
-       php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to parse array: expected one of '%s', got '%c'", any, *a->ptr); \
+       php_error_docref(NULL, E_WARNING, "Failed to parse array: expected one of '%s', got '%c'", any, *a->ptr); \
        return 0;
 }
 
-static STATUS add_element(ArrayParserState *a, const char *start)
+static ZEND_RESULT_CODE add_element(ArrayParserState *a, const char *start)
 {
-       zval *zelem;
-       size_t el_len = a->ptr - start;
-       char *el_str = estrndup(start, el_len);
-       TSRMLS_FETCH_FROM_CTX(a->ts);
+       zval zelem;
+       zend_string *zstr = zend_string_init(start, a->ptr - start, 0);
 
        if (a->quotes) {
-               int tmp_len = el_len;
-
-               php_stripslashes(el_str, &tmp_len TSRMLS_CC);
-               el_len = tmp_len;
-       } else if ((a->ptr - start == 4) && !strncmp(start, "NULL", 4)) {
-               efree(el_str);
-               el_str = NULL;
-               el_len = 0;
-       }
-
-       if (!el_str) {
-               MAKE_STD_ZVAL(zelem);
-               ZVAL_NULL(zelem);
+               php_stripslashes(zstr);
+               ZVAL_STR(&zelem, zstr);
+       } else if (!zend_string_equals_literal(zstr, "NULL")) {
+               ZVAL_STR(&zelem, zstr);
        } else {
-               zelem = php_pq_typed_zval(el_str, el_len, a->typ TSRMLS_CC);
+               zend_string_release(zstr);
+               ZVAL_NULL(&zelem);
+       }
 
-               efree(el_str);
+       if (!ZVAL_IS_NULL(&zelem)) {
+               php_pqres_typed_zval(a->res, a->typ, &zelem);
        }
 
-       return zend_hash_next_index_insert(&a->list->ht, &zelem, sizeof(zval *), NULL);
+       add_next_index_zval(&a->list->arr, &zelem);
+       return SUCCESS;
 }
 
-static STATUS parse_array(ArrayParserState *a);
+static ZEND_RESULT_CODE parse_array(ArrayParserState *a);
 
-static STATUS parse_element(ArrayParserState *a)
+static ZEND_RESULT_CODE parse_element(ArrayParserState *a, char delim)
 {
        const char *el;
-       TSRMLS_FETCH_FROM_CTX(a->ts);
 
        switch (*a->ptr) {
        case '{':
                return parse_array(a);
 
+       case '}':
+               return SUCCESS;
+
        case '"':
                a->quotes = 1;
                ++a->ptr;
@@ -401,6 +329,10 @@ static STATUS parse_element(ArrayParserState *a)
 
        for (el = a->ptr; a->ptr < a->end; ++a->ptr) {
                switch (*a->ptr) {
+               case '\\':
+                       a->escaped = !a->escaped;
+                       break;
+
                case '"':
                        if (a->escaped) {
                                a->escaped = 0;
@@ -412,38 +344,36 @@ static STATUS parse_element(ArrayParserState *a)
                                ++a->ptr;
                                return SUCCESS;
                        } else {
-                               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to parse element, unexpected quote: '%.*s'", (int) (a->ptr - el), el);
+                               php_error_docref(NULL, E_WARNING, "Failed to parse element, unexpected quote: '%.*s'", (int) (a->ptr - el), el);
                                return FAILURE;
                        }
                        break;
 
-               case ',':
+               default:
+                       if (delim != *a->ptr) {
+                               a->escaped = 0;
+                               break;
+                       }
+                       /* no break */
                case '}':
                        if (!a->quotes) {
                                return add_element(a, el);
                        }
                        break;
 
-               case '\\':
-                       a->escaped = !a->escaped;
-                       break;
-
-               default:
-                       a->escaped = 0;
-                       break;
                }
        }
 
-       php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to parse element, reached end of input");
+       php_error_docref(NULL, E_WARNING, "Failed to parse element, reached end of input");
        return FAILURE;
 }
 
-static STATUS parse_elements(ArrayParserState *a)
+static ZEND_RESULT_CODE parse_elements(ArrayParserState *a)
 {
-       TSRMLS_FETCH_FROM_CTX(a->ts);
+       char delims[] = {'}', (char) PHP_PQ_DELIM_OF_ARRAY(a->typ), 0};
 
-       while (SUCCESS == parse_element(a)) {
-               switch (caa(a, ",}", 0)) {
+       while (SUCCESS == parse_element(a, delims[1])) {
+               switch (caa(a, delims, 0)) {
                case 0:
                        return FAILURE;
 
@@ -452,7 +382,7 @@ static STATUS parse_elements(ArrayParserState *a)
 
                default:
                        if (!*++a->ptr) {
-                               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to parse elements, reached end of input");
+                               php_error_docref(NULL, E_WARNING, "Failed to parse elements, reached end of input");
                                return FAILURE;
                        }
                        break;
@@ -462,7 +392,7 @@ static STATUS parse_elements(ArrayParserState *a)
        return FAILURE;
 }
 
-static STATUS parse_array(ArrayParserState *a)
+static ZEND_RESULT_CODE parse_array(ArrayParserState *a)
 {
        HashTableList *list;
 
@@ -471,17 +401,10 @@ static STATUS parse_array(ArrayParserState *a)
        }
 
        list = ecalloc(1, sizeof(*list));
-       ZEND_INIT_SYMTABLE(&list->ht);
+       array_init(&list->arr);
 
        if (a->list) {
-               zval *zcur;
-
-               MAKE_STD_ZVAL(zcur);
-               Z_TYPE_P(zcur) = IS_ARRAY;
-               Z_ARRVAL_P(zcur) = &list->ht;
-
-               zend_hash_next_index_insert(&a->list->ht, &zcur, sizeof(zval *), NULL);
-
+               add_next_index_zval(&a->list->arr, &list->arr);
                list->parent = a->list;
        }
        a->list = list;
@@ -494,28 +417,32 @@ static STATUS parse_array(ArrayParserState *a)
                return FAILURE;
        }
 
+       /* step one level back up */
        if (a->list->parent) {
-               a->list = a->list->parent;
+               HashTableList *l = a->list->parent;
+
+               efree(a->list);
+               a->list = l;
        }
 
        return SUCCESS;
 }
 
-HashTable *php_pq_parse_array(const char *val_str, size_t val_len, Oid typ TSRMLS_DC)
+HashTable *php_pq_parse_array(php_pqres_t *res, const char *val_str, size_t val_len, Oid typ)
 {
        HashTable *ht = NULL;
        ArrayParserState a = {0};
-       TSRMLS_SET_CTX(a.ts);
 
        a.typ = typ;
        a.ptr = val_str;
        a.end = val_str + val_len;
+       a.res = res;
 
        if (SUCCESS != parse_array(&a)) {
                while (a.list) {
                        HashTableList *l = a.list->parent;
 
-                       zend_hash_destroy(&a.list->ht);
+                       zval_dtor(&a.list->arr);
                        efree(a.list);
                        a.list = l;
                }
@@ -523,81 +450,21 @@ HashTable *php_pq_parse_array(const char *val_str, size_t val_len, Oid typ TSRML
        }
 
        if (*a.ptr) {
-               php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Trailing input: '%s'", a.ptr);
+               php_error_docref(NULL, E_NOTICE, "Trailing input: '%s'", a.ptr);
        }
 
-       do {
-               ht = &a.list->ht;
-       } while ((a.list = a.list->parent));
-
-       return ht;
-}
-
-zval *php_pq_typed_zval(char *val, size_t len, Oid typ TSRMLS_DC)
-{
-       zval *zv;
-
-       MAKE_STD_ZVAL(zv);
-
-       switch (typ) {
-#ifdef HAVE_PHP_PQ_TYPE_H
-#      undef PHP_PQ_TYPE
-#      include "php_pq_type.h"
-       case PHP_PQ_OID_BOOL:
-               ZVAL_BOOL(zv, *val == 't');
-               break;
-#if SIZEOF_LONG >= 8
-       case PHP_PQ_OID_INT8:
-       case PHP_PQ_OID_TID:
-#endif
-       case PHP_PQ_OID_INT4:
-       case PHP_PQ_OID_INT2:
-       case PHP_PQ_OID_XID:
-       case PHP_PQ_OID_OID:
-               ZVAL_LONG(zv, zend_atol(val, len));
-               break;
-
-       case PHP_PQ_OID_FLOAT4:
-       case PHP_PQ_OID_FLOAT8:
-               ZVAL_DOUBLE(zv, zend_strtod(val, NULL));
-               break;
-
-       case PHP_PQ_OID_DATE:
-               php_pqdt_from_string(val, len, "Y-m-d", zv TSRMLS_CC);
-               break;
-
-       case PHP_PQ_OID_ABSTIME:
-               php_pqdt_from_string(val, len, "Y-m-d H:i:s", zv TSRMLS_CC);
-               break;
-
-       case PHP_PQ_OID_TIMESTAMP:
-               php_pqdt_from_string(val, len, "Y-m-d H:i:s.u", zv TSRMLS_CC);
-               break;
-
-       case PHP_PQ_OID_TIMESTAMPTZ:
-               php_pqdt_from_string(val, len, "Y-m-d H:i:s.uO", zv TSRMLS_CC);
-               break;
-
-       default:
-               if (PHP_PQ_TYPE_IS_ARRAY(typ) && (Z_ARRVAL_P(zv) = php_pq_parse_array(val, len, PHP_PQ_TYPE_OF_ARRAY(typ) TSRMLS_CC))) {
-                       Z_TYPE_P(zv) = IS_ARRAY;
-               } else {
-                       ZVAL_STRINGL(zv, val, len, 1);
-               }
-               break;
-#else
-       case 16: /* BOOL */
-               ZVAL_BOOL(zv, *val == 't');
-               break;
+       while (a.list) {
+               HashTableList *l = a.list->parent;
 
-       default:
-               ZVAL_STRINGL(zv, val, len, 1);
-#endif
+               ht = Z_ARRVAL(a.list->arr);
+               efree(a.list);
+               a.list = l;
        }
 
-       return zv;
+       return ht;
 }
 
+
 /*
  * Local variables:
  * tab-width: 4