- finish work on encoding api