From: Michael Wallner Date: Thu, 13 Aug 2015 16:46:15 +0000 (+0200) Subject: attempt to fix leak X-Git-Tag: RELEASE_3_0_0_RC1~29 X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-http;a=commitdiff_plain;h=cd3cad9da098f0dae2997dd6a52a907bfaaf6041;hp=1544c4a7fadfb04f46ab1e3ca99628fd9e9cfbbb;ds=sidebyside attempt to fix leak --- diff --git a/php_http_message.c b/php_http_message.c index 0982f06..f06065a 100644 --- a/php_http_message.c +++ b/php_http_message.c @@ -878,6 +878,8 @@ static zval *php_http_message_object_read_prop(zval *object, zval *member, int t zval_ptr_dtor(return_value); ZVAL_COPY_VALUE(return_value, tmp); } + zend_string_release(member_name); + return return_value; } else { php_property_proxy_t *proxy; php_property_proxy_object_t *proxy_obj; @@ -886,12 +888,9 @@ static zval *php_http_message_object_read_prop(zval *object, zval *member, int t proxy_obj = php_property_proxy_object_new_ex(NULL, proxy); ZVAL_OBJ(tmp, &proxy_obj->zo); + zend_string_release(member_name); return tmp; } - - zend_string_release(member_name); - - return return_value; } static void php_http_message_object_write_prop(zval *object, zval *member, zval *value, void **cache_slot)