- yet better a memleak than a segfault
authorMichael Wallner <mike@php.net>
Mon, 13 Jun 2005 17:02:12 +0000 (17:02 +0000)
committerMichael Wallner <mike@php.net>
Mon, 13 Jun 2005 17:02:12 +0000 (17:02 +0000)
http_request_object.c

index bc2cfa014514fef54a6ef9c3c1db731f59c50114..8343507f34a51b190a6fcafa9314a587bec03630 100644 (file)
@@ -301,7 +301,7 @@ STATUS _http_request_object_responsehandler(http_request_object *obj, zval *this
        if (msg = http_message_parse(PHPSTR_VAL(&obj->response), PHPSTR_LEN(&obj->response))) {
                char *body;
                size_t body_len;
-               zval *headers, *message = GET_PROP(obj, responseMessage), *resp = GET_PROP(obj, responseData), *info = GET_PROP(obj, responseInfo);
+               zval *headers, *message, *resp = GET_PROP(obj, responseData), *info = GET_PROP(obj, responseInfo);
 
                UPD_PROP(obj, long, responseCode, msg->info.response.code);
 
@@ -314,6 +314,8 @@ STATUS _http_request_object_responsehandler(http_request_object *obj, zval *this
                add_assoc_zval(resp, "headers", headers);
                add_assoc_stringl(resp, "body", body, body_len, 0);
 
+               /* XXX */
+               MAKE_STD_ZVAL(message);
                Z_TYPE_P(message)  = IS_OBJECT;
                message->value.obj = http_message_object_from_msg(msg);
                SET_PROP(obj, responseMessage, message);