X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-http;a=blobdiff_plain;f=http_send_api.c;h=f22a3d1fd398fb2a3e75ee46ff926accb5523659;hp=e74d20d9564d515f9dab4547bbb39f4bb6106aa6;hb=b5ea35825528c10ee3d78727437317a9d3bc3336;hpb=0ef9c0b48c3ef484004231878a6c8c1e9c33a2b3

diff --git a/http_send_api.c b/http_send_api.c
index e74d20d..f22a3d1 100644
--- a/http_send_api.c
+++ b/http_send_api.c
@@ -158,7 +158,11 @@ PHP_HTTP_API STATUS _http_send_header_ex(const char *name, size_t name_len, cons
 	header[header_len] = '\0';
 	snprintf(header, header_len, "%s: %s", name, value);
 	ret = http_send_header_string_ex(header, replace);
-	efree(header);
+	if (sent_header) {
+		*sent_header = header;
+	} else {
+		efree(header);
+	}
 	return ret;
 }
 /* }}} */
@@ -185,7 +189,7 @@ PHP_HTTP_API STATUS _http_send_last_modified_ex(time_t t, char **sent_header TSR
 		return FAILURE;
 	}
 
-	ret = http_send_header_ex("Last-Modified", lenof("Last-Modifed"), date, strlen(date), 1, sent_header);
+	ret = http_send_header_ex("Last-Modified", lenof("Last-Modified"), date, strlen(date), 1, sent_header);
 	efree(date);
 
 	/* remember */
@@ -263,33 +267,33 @@ PHP_HTTP_API STATUS _http_send_content_disposition(const char *filename, size_t
 /* {{{ STATUS http_send_ranges(HashTable *, void *, size_t, http_send_mode) */
 PHP_HTTP_API STATUS _http_send_ranges(HashTable *ranges, const void *data, size_t size, http_send_mode mode TSRMLS_DC)
 {
-	long **begin, **end;
-	zval **zrange;
+	zval **zbegin, **zend, **zrange;
 
 	/* single range */
 	if (zend_hash_num_elements(ranges) == 1) {
 		char range_header[256] = {0};
 
 		if (SUCCESS != zend_hash_index_find(ranges, 0, (void **) &zrange) ||
-			SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 0, (void **) &begin) ||
-			SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 1, (void **) &end)) {
+			SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 0, (void **) &zbegin) ||
+			SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 1, (void **) &zend)) {
 			http_send_status(500);
 			return FAILURE;
 		}
-
+		
 		/* Send HTTP 206 Partial Content */
 		http_send_status(206);
 
 		/* send content range header */
-		snprintf(range_header, 255, "Content-Range: bytes %ld-%ld/%lu", **begin, **end, (ulong) size);
+		snprintf(range_header, 255, "Content-Range: bytes %ld-%ld/%lu", Z_LVAL_PP(zbegin), Z_LVAL_PP(zend), (ulong) size);
 		http_send_header_string(range_header);
 
 		/* send requested chunk */
-		return http_send_chunk(data, **begin, **end + 1, mode);
+		return http_send_chunk(data, Z_LVAL_PP(zbegin), Z_LVAL_PP(zend) + 1, mode);
 	}
 
 	/* multi range */
 	else {
+		size_t preface_len;
 		char bound[23] = {0}, preface[1024] = {0},
 			multi_header[68] = "Content-Type: multipart/byteranges; boundary=";
 
@@ -303,12 +307,12 @@ PHP_HTTP_API STATUS _http_send_ranges(HashTable *ranges, const void *data, size_
 
 		/* send each requested chunk */
 		FOREACH_HASH_VAL(ranges, zrange) {
-			if (SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 0, (void **) &begin) ||
-				SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 1, (void **) &end)) {
+			if (SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 0, (void **) &zbegin) ||
+				SUCCESS != zend_hash_index_find(Z_ARRVAL_PP(zrange), 1, (void **) &zend)) {
 				break;
 			}
 
-			snprintf(preface, 1023,
+			preface_len = snprintf(preface, 1023,
 				HTTP_CRLF "%s"
 				HTTP_CRLF "Content-Type: %s"
 				HTTP_CRLF "Content-Range: bytes %ld-%ld/%lu"
@@ -317,13 +321,13 @@ PHP_HTTP_API STATUS _http_send_ranges(HashTable *ranges, const void *data, size_
 
 				bound,
 				HTTP_G(send).content_type ? HTTP_G(send).content_type : "application/x-octetstream",
-				**begin,
-				**end,
+				Z_LVAL_PP(zbegin),
+				Z_LVAL_PP(zend),
 				(ulong) size
 			);
 
-			PHPWRITE(preface, strlen(preface));
-			http_send_chunk(data, **begin, **end + 1, mode);
+			PHPWRITE(preface, preface_len);
+			http_send_chunk(data, Z_LVAL_PP(zbegin), Z_LVAL_PP(zend) + 1, mode);
 		}
 
 		/* write boundary once more */
@@ -351,10 +355,7 @@ PHP_HTTP_API STATUS _http_send_ex(const void *data_ptr, size_t data_size, http_s
 	}
 
 	/* stop on-the-fly etag generation */
-	if (cache_etag = HTTP_G(etag).started) {
-		/* interrupt ob_etaghandler */
-		HTTP_G(etag).started = 0;
-	}
+	cache_etag = http_interrupt_ob_etaghandler();
 
 	/* enable partial dl and resume */
 	http_send_header_string("Accept-Ranges: bytes");
@@ -383,13 +384,11 @@ PHP_HTTP_API STATUS _http_send_ex(const void *data_ptr, size_t data_size, http_s
 	/* send 304 Not Modified if etag matches - DON'T return on ETag generation failure */
 	if (!no_cache && cache_etag) {
 		char *etag = NULL;
-
-		if (!(etag = http_etag(data_ptr, data_size, data_mode))) {
-			http_error(HE_NOTICE, HTTP_E_RUNTIME, "Failed to generate ETag for data source");
-		} else {
+		
+		if (etag = http_etag(data_ptr, data_size, data_mode)) {
 			char *sent_header = NULL;
 			
-			http_send_etag_ex(etag, 32, &sent_header);
+			http_send_etag_ex(etag, strlen(etag), &sent_header);
 			if (http_match_etag("HTTP_IF_NONE_MATCH", etag)) {
 				return http_exit_ex(304, sent_header, NULL, 0);
 			} else {