X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-http;a=blobdiff_plain;f=http_querystring_object.c;h=4c82edabcff853fb0dfa9fe14886c9e0991b662f;hp=c6a1bdbe93a49fb4df8717502309874a6d51fc11;hb=refs%2Fheads%2Fv1.7.x;hpb=d309416dd166624d97ee795bd87ee5b06714f932 diff --git a/http_querystring_object.c b/http_querystring_object.c index c6a1bdb..4c82eda 100644 --- a/http_querystring_object.c +++ b/http_querystring_object.c @@ -6,7 +6,7 @@ | modification, are permitted provided that the conditions mentioned | | in the accompanying LICENSE file are met. | +--------------------------------------------------------------------+ - | Copyright (c) 2004-2006, Michael Wallner | + | Copyright (c) 2004-2010, Michael Wallner | +--------------------------------------------------------------------+ */ @@ -41,6 +41,12 @@ HTTP_BEGIN_ARGS(singleton, 0) HTTP_END_ARGS; #endif +HTTP_BEGIN_ARGS(factory, 0) + HTTP_ARG_VAL(global, 0) + HTTP_ARG_VAL(params, 0) + HTTP_ARG_VAL(class_name, 0) +HTTP_END_ARGS; + HTTP_EMPTY_ARGS(toArray); HTTP_EMPTY_ARGS(toString); @@ -95,7 +101,7 @@ HTTP_BEGIN_ARGS(offsetUnset, 1) HTTP_END_ARGS; -#define OBJ_PROP_CE http_querystring_object_ce +#define THIS_CE http_querystring_object_ce zend_class_entry *http_querystring_object_ce; zend_function_entry http_querystring_object_fe[] = { HTTP_QUERYSTRING_ME(__construct, ZEND_ACC_PUBLIC|ZEND_ACC_CTOR|ZEND_ACC_FINAL) @@ -115,6 +121,7 @@ zend_function_entry http_querystring_object_fe[] = { HTTP_QUERYSTRING_GME(getArray, ZEND_ACC_PUBLIC) HTTP_QUERYSTRING_GME(getObject, ZEND_ACC_PUBLIC) + HTTP_QUERYSTRING_ME(factory, ZEND_ACC_PUBLIC|ZEND_ACC_STATIC) #ifndef WONKY HTTP_QUERYSTRING_ME(singleton, ZEND_ACC_PUBLIC|ZEND_ACC_STATIC) #endif @@ -144,17 +151,17 @@ PHP_MINIT_FUNCTION(http_querystring_object) zend_class_implements(http_querystring_object_ce TSRMLS_CC, 2, zend_ce_serializable, zend_ce_arrayaccess); #endif - DCL_STATIC_PROP_N(PRIVATE, instance); - DCL_PROP_N(PRIVATE, queryArray); - DCL_PROP(PRIVATE, string, queryString, ""); + zend_declare_property_null(THIS_CE, ZEND_STRS("instance")-1, (ZEND_ACC_STATIC|ZEND_ACC_PRIVATE) TSRMLS_CC); + zend_declare_property_null(THIS_CE, ZEND_STRS("queryArray")-1, ZEND_ACC_PRIVATE TSRMLS_CC); + zend_declare_property_string(THIS_CE, ZEND_STRS("queryString")-1, "", ZEND_ACC_PRIVATE TSRMLS_CC); #ifndef WONKY - DCL_CONST(long, "TYPE_BOOL", HTTP_QUERYSTRING_TYPE_BOOL); - DCL_CONST(long, "TYPE_INT", HTTP_QUERYSTRING_TYPE_INT); - DCL_CONST(long, "TYPE_FLOAT", HTTP_QUERYSTRING_TYPE_FLOAT); - DCL_CONST(long, "TYPE_STRING", HTTP_QUERYSTRING_TYPE_STRING); - DCL_CONST(long, "TYPE_ARRAY", HTTP_QUERYSTRING_TYPE_ARRAY); - DCL_CONST(long, "TYPE_OBJECT", HTTP_QUERYSTRING_TYPE_OBJECT); + zend_declare_class_constant_long(THIS_CE, ZEND_STRS("TYPE_BOOL")-1, HTTP_QUERYSTRING_TYPE_BOOL TSRMLS_CC); + zend_declare_class_constant_long(THIS_CE, ZEND_STRS("TYPE_INT")-1, HTTP_QUERYSTRING_TYPE_INT TSRMLS_CC); + zend_declare_class_constant_long(THIS_CE, ZEND_STRS("TYPE_FLOAT")-1, HTTP_QUERYSTRING_TYPE_FLOAT TSRMLS_CC); + zend_declare_class_constant_long(THIS_CE, ZEND_STRS("TYPE_STRING")-1, HTTP_QUERYSTRING_TYPE_STRING TSRMLS_CC); + zend_declare_class_constant_long(THIS_CE, ZEND_STRS("TYPE_ARRAY")-1, HTTP_QUERYSTRING_TYPE_ARRAY TSRMLS_CC); + zend_declare_class_constant_long(THIS_CE, ZEND_STRS("TYPE_OBJECT")-1, HTTP_QUERYSTRING_TYPE_OBJECT TSRMLS_CC); #endif HTTP_LONG_CONSTANT("HTTP_QUERYSTRING_TYPE_BOOL", HTTP_QUERYSTRING_TYPE_BOOL); @@ -169,10 +176,10 @@ PHP_MINIT_FUNCTION(http_querystring_object) zend_object_value _http_querystring_object_new(zend_class_entry *ce TSRMLS_DC) { - return http_querystring_object_new_ex(ce, NULL); + return http_querystring_object_new_ex(ce, NULL, NULL); } -zend_object_value _http_querystring_object_new_ex(zend_class_entry *ce, http_querystring_object **ptr TSRMLS_DC) +zend_object_value _http_querystring_object_new_ex(zend_class_entry *ce, void *nothing, http_querystring_object **ptr TSRMLS_DC) { zend_object_value ov; http_querystring_object *o; @@ -184,9 +191,14 @@ zend_object_value _http_querystring_object_new_ex(zend_class_entry *ce, http_que *ptr = o; } +#ifdef ZEND_ENGINE_2_4 + zend_object_std_init(o, ce TSRMLS_CC); + object_properties_init(o, ce); +#else ALLOC_HASHTABLE(OBJ_PROP(o)); zend_hash_init(OBJ_PROP(o), zend_hash_num_elements(&ce->default_properties), NULL, ZVAL_PTR_DTOR, 0); zend_hash_copy(OBJ_PROP(o), &ce->default_properties, (copy_ctor_func_t) zval_add_ref, NULL, sizeof(zval *)); +#endif ov.handle = putObject(http_querystring_object, o); ov.handlers = &http_querystring_object_handlers; @@ -198,46 +210,95 @@ void _http_querystring_object_free(zend_object *object TSRMLS_DC) { http_querystring_object *o = (http_querystring_object *) object; - if (OBJ_PROP(o)) { - zend_hash_destroy(OBJ_PROP(o)); - FREE_HASHTABLE(OBJ_PROP(o)); - } - efree(o); + freeObject(o); } /* {{{ querystring helpers */ -#define http_querystring_instantiate(g) _http_querystring_instantiate((g) TSRMLS_CC) -static inline zval *_http_querystring_instantiate(zend_bool global TSRMLS_DC) +#define http_querystring_instantiate(t, g, p, u) _http_querystring_instantiate((t), (g), (p), (u) TSRMLS_CC) +static inline zval *_http_querystring_instantiate(zval *this_ptr, zend_bool global, zval *params, zend_bool defer_update TSRMLS_DC) { - zval *zobj, *zglobal; - - MAKE_STD_ZVAL(zglobal); - ZVAL_BOOL(zglobal, global); + zval *qarray = NULL, *qstring = NULL, **_SERVER = NULL, **_GET = NULL, **QUERY_STRING = NULL;; - MAKE_STD_ZVAL(zobj); - Z_TYPE_P(zobj) = IS_OBJECT; - Z_OBJVAL_P(zobj) = http_querystring_object_new(http_querystring_object_ce); - zend_call_method_with_1_params(&zobj, Z_OBJCE_P(zobj), NULL, "__construct", NULL, zglobal); + if (!this_ptr) { + MAKE_STD_ZVAL(this_ptr); + Z_TYPE_P(this_ptr) = IS_OBJECT; + this_ptr->value.obj = http_querystring_object_new(http_querystring_object_ce); + } + if (global) { +#ifdef ZEND_ENGINE_2 + zend_is_auto_global("_SERVER", lenof("_SERVER") TSRMLS_CC); +#endif + if ( (SUCCESS == zend_hash_find(&EG(symbol_table), "_SERVER", sizeof("_SERVER"), (void *) &_SERVER)) && + (Z_TYPE_PP(_SERVER) == IS_ARRAY) && + (SUCCESS == zend_hash_find(Z_ARRVAL_PP(_SERVER), "QUERY_STRING", sizeof("QUERY_STRING"), (void *) &QUERY_STRING))) { + + qstring = *QUERY_STRING; +#ifdef ZEND_ENGINE_2 + zend_is_auto_global("_GET", lenof("_GET") TSRMLS_CC); +#endif + if ((SUCCESS == zend_hash_find(&EG(symbol_table), "_GET", sizeof("_GET"), (void *) &_GET)) && (Z_TYPE_PP(_GET) == IS_ARRAY)) { + qarray = *_GET; + } else { + http_error(HE_WARNING, HTTP_E_QUERYSTRING, "Could not acquire reference to superglobal GET array"); + } + } else { + http_error(HE_WARNING, HTTP_E_QUERYSTRING, "Could not acquire reference to QUERY_STRING"); + } + + if (qarray && qstring) { + if (Z_TYPE_P(qstring) != IS_STRING) { + convert_to_string(qstring); + } + + zend_update_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, qarray TSRMLS_CC); + zend_update_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, qstring TSRMLS_CC); +#ifdef Z_SET_ISREF + Z_SET_ISREF_P(zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC)); + Z_SET_ISREF_P(zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)); +#else + zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC)->is_ref = 1; + zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)->is_ref = 1; +#endif - zval_ptr_dtor(&zglobal); + if (params) { + http_querystring_modify(zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC), params); + } + if (!defer_update) { + http_querystring_update(zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC), zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)); + } + } + } else { + MAKE_STD_ZVAL(qarray); + array_init(qarray); + + zend_update_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, qarray TSRMLS_CC); + zend_update_property_stringl(THIS_CE, getThis(), ZEND_STRS("queryString")-1, "", 0 TSRMLS_CC); + + if (params && http_querystring_modify(qarray, params) && !defer_update) { + http_querystring_update(qarray, zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)); + } + + zval_ptr_dtor(&qarray); + } - return zobj; + return this_ptr; } #define http_querystring_get(o, t, n, l, def, del, r) _http_querystring_get((o), (t), (n), (l), (def), (del), (r) TSRMLS_CC) static inline void _http_querystring_get(zval *this_ptr, int type, char *name, uint name_len, zval *defval, zend_bool del, zval *return_value TSRMLS_DC) { - zval **arrval, *qarray = GET_PROP(queryArray); + zval **arrval, *qarray = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC); if ((Z_TYPE_P(qarray) == IS_ARRAY) && (SUCCESS == zend_hash_find(Z_ARRVAL_P(qarray), name, name_len + 1, (void *) &arrval))) { - RETVAL_ZVAL(*arrval, 1, 0); - if (type) { - convert_to_type(type, return_value); + zval *value = http_zsep(type, *arrval); + RETVAL_ZVAL(value, 1, 1); + } else { + RETVAL_ZVAL(*arrval, 1, 0); } if (del && (SUCCESS == zend_hash_del(Z_ARRVAL_P(qarray), name, name_len + 1))) { - http_querystring_update(qarray, GET_PROP(queryString)); + http_querystring_update(qarray, zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)); } } else if(defval) { RETURN_ZVAL(defval, 1, 0); @@ -246,75 +307,46 @@ static inline void _http_querystring_get(zval *this_ptr, int type, char *name, u /* }}} */ /* {{{ proto final void HttpQueryString::__construct([bool global = true[, mixed add]) - * - * Creates a new HttpQueryString object instance. - * Operates on and modifies $_GET and $_SERVER['QUERY_STRING'] if global is TRUE. - */ + Creates a new HttpQueryString object instance. Operates on and modifies $_GET and $_SERVER['QUERY_STRING'] if global is TRUE. */ PHP_METHOD(HttpQueryString, __construct) { zend_bool global = 1; - zval *params = NULL, *qarray = NULL, *qstring = NULL, **_GET, **_SERVER, **QUERY_STRING; + zval *params = NULL; SET_EH_THROW_HTTP(); if (!sapi_module.treat_data) { http_error(HE_ERROR, HTTP_E_QUERYSTRING, "The SAPI does not have a treat_data function registered"); } else if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|bz", &global, ¶ms)) { - if (global) { -#ifdef ZEND_ENGINE_2 - zend_is_auto_global("_SERVER", lenof("_SERVER") TSRMLS_CC); -#endif - if ( (SUCCESS == zend_hash_find(&EG(symbol_table), "_SERVER", sizeof("_SERVER"), (void *) &_SERVER)) && - (Z_TYPE_PP(_SERVER) == IS_ARRAY) && - (SUCCESS == zend_hash_find(Z_ARRVAL_PP(_SERVER), "QUERY_STRING", sizeof("QUERY_STRING"), (void *) &QUERY_STRING))) { - - qstring = *QUERY_STRING; -#ifdef ZEND_ENGINE_2 - zend_is_auto_global("_GET", lenof("_GET") TSRMLS_CC); -#endif - if ((SUCCESS == zend_hash_find(&EG(symbol_table), "_GET", sizeof("_GET"), (void *) &_GET)) && (Z_TYPE_PP(_GET) == IS_ARRAY)) { - qarray = *_GET; - } else { - http_error(HE_WARNING, HTTP_E_QUERYSTRING, "Could not acquire reference to superglobal GET array"); - } - } else { - http_error(HE_WARNING, HTTP_E_QUERYSTRING, "Could not acquire reference to QUERY_STRING"); - } - - if (qarray && qstring) { - if (Z_TYPE_P(qstring) != IS_STRING) { - convert_to_string(qstring); - } - - SET_PROP(queryArray, qarray); - SET_PROP(queryString, qstring); - GET_PROP(queryArray)->is_ref = 1; - GET_PROP(queryString)->is_ref = 1; - - if (params) { - http_querystring_modify(GET_PROP(queryArray), params); - } - http_querystring_update(GET_PROP(queryArray), GET_PROP(queryString)); - } - } else { - qarray = ecalloc(1, sizeof(zval)); - array_init(qarray); - - SET_PROP(queryArray, qarray); - UPD_STRL(queryString, "", 0); - - if (params && http_querystring_modify(qarray, params)) { - http_querystring_update(qarray, GET_PROP(queryString)); - } - } + http_querystring_instantiate(getThis(), global, params, 0); + } + SET_EH_NORMAL(); +} +/* }}} */ + +/* {{{ proto HttpQueryString HttpQueryString::factory([bool global = TRUE[, mixed params[, string class_name = "HttpQueryString"]) + Creates a new HttpQueryString object instance. */ +PHP_METHOD(HttpQueryString, factory) +{ + zend_bool global = 1; + zval *params = NULL; + char *cn = NULL; + int cl = 0; + zend_object_value ov; + + SET_EH_THROW_HTTP(); + if (!sapi_module.treat_data) { + http_error(HE_ERROR, HTTP_E_QUERYSTRING, "The SAPI does not have a treat_data function registered"); + } else if ( SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|bzs", &global, ¶ms, &cn, &cl) && + SUCCESS == http_object_new(&ov, cn, cl, _http_querystring_object_new_ex, http_querystring_object_ce, NULL, NULL)) { + RETVAL_OBJVAL(ov, 0); + http_querystring_instantiate(return_value, global, params, 0); } SET_EH_NORMAL(); } /* }}} */ /* {{{ proto string HttpQueryString::toString() - * - * Returns the string representation. - */ + Returns the string representation. */ PHP_METHOD(HttpQueryString, toString) { NO_ARGS; @@ -323,9 +355,7 @@ PHP_METHOD(HttpQueryString, toString) /* }}} */ /* {{{ proto array HttpQueryString::toArray() - * - * Returns the array representation. - */ + Returns the array representation. */ PHP_METHOD(HttpQueryString, toArray) { NO_ARGS; @@ -334,12 +364,7 @@ PHP_METHOD(HttpQueryString, toArray) /* }}} */ /* {{{ proto mixed HttpQueryString::get([string key[, mixed type = 0[, mixed defval = NULL[, bool delete = false]]]]) - * - * Get (part of) the query string. - * - * The type parameter is either one of the HttpQueryString::TYPE_* constants or a type abbreviation like - * "b" for bool, "i" for int, "f" for float, "s" for string, "a" for array and "o" for a stdClass object. - */ + Get (part of) the query string. The type parameter is either one of the HttpQueryString::TYPE_* constants or a type abbreviation like "b" for bool, "i" for int, "f" for float, "s" for string, "a" for array and "o" for a stdClass object. */ PHP_METHOD(HttpQueryString, get) { char *name = NULL; @@ -379,17 +404,15 @@ PHP_METHOD(HttpQueryString, get) /* }}} */ /* {{{ proto string HttpQueryString::set(mixed params) - * - * Set query string entry/entries. NULL values will unset the variable. - */ + Set query string entry/entries. NULL values will unset the variable. */ PHP_METHOD(HttpQueryString, set) { zval *params; if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", ¶ms)) { - zval *qarray = GET_PROP(queryArray); + zval *qarray = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC); if (http_querystring_modify(qarray, params)) { - http_querystring_update(qarray, GET_PROP(queryString)); + http_querystring_update(qarray, zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)); } } @@ -400,30 +423,19 @@ PHP_METHOD(HttpQueryString, set) /* }}} */ /* {{{ proto HttpQueryString HttpQueryString::mod(mixed params) - * - * Copies the query string object and sets provided params at the clone. - * This is basically shorthand for: - * 
- * set($other_params);
- * ?>
- *
- */ + Copies the query string object and sets provided params at the clone. */ PHP_METHOD(HttpQueryString, mod) { - zval *orig, *zobj, *qarr, *qstr, *params; + zval *zobj, *qarr, *qstr, *params; if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", ¶ms)) { - zobj = http_querystring_instantiate(0); - orig = GET_PROP(queryArray); - qarr = GET_PROP_EX(zobj, queryArray); - qstr = GET_PROP_EX(zobj, queryString); + zobj = http_querystring_instantiate(NULL, 0, zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC), 1); + qarr = zend_read_property(THIS_CE, zobj, ZEND_STRS("queryArray")-1, 0 TSRMLS_CC); + qstr = zend_read_property(THIS_CE, zobj, ZEND_STRS("queryString")-1, 0 TSRMLS_CC); - http_querystring_modify(qarr, orig); http_querystring_modify(qarr, params); http_querystring_update(qarr, qstr); - + RETURN_ZVAL(zobj, 1, 1); } } @@ -431,13 +443,11 @@ PHP_METHOD(HttpQueryString, mod) #ifndef WONKY /* {{{ proto static HttpQueryString HttpQueryString::singleton([bool global = true]) - * - * Get a single instance (differentiates between the global setting). - */ + Get a single instance (differentiates between the global setting). */ PHP_METHOD(HttpQueryString, singleton) { zend_bool global = 1; - zval *instance = GET_STATIC_PROP(instance); + zval *instance = *zend_std_get_static_property(THIS_CE, ZEND_STRS("instance")-1, 0 ZEND_LITERAL_NIL_CC TSRMLS_CC); SET_EH_THROW_HTTP(); if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|b", &global)) { @@ -447,7 +457,7 @@ PHP_METHOD(HttpQueryString, singleton) if (SUCCESS == zend_hash_index_find(Z_ARRVAL_P(instance), global, (void *) &zobj_ptr)) { RETVAL_ZVAL(*zobj_ptr, 1, 0); } else { - zobj = http_querystring_instantiate(global); + zobj = http_querystring_instantiate(NULL, global, NULL, (zend_bool) !global); add_index_zval(instance, global, zobj); RETVAL_OBJECT(zobj, 1); } @@ -455,11 +465,11 @@ PHP_METHOD(HttpQueryString, singleton) MAKE_STD_ZVAL(instance); array_init(instance); - zobj = http_querystring_instantiate(global); + zobj = http_querystring_instantiate(NULL, global, NULL, (zend_bool) !global); add_index_zval(instance, global, zobj); RETVAL_OBJECT(zobj, 1); - SET_STATIC_PROP(instance, instance); + zend_update_static_property(THIS_CE, ZEND_STRS("instance")-1, instance TSRMLS_CC); zval_ptr_dtor(&instance); } } @@ -490,12 +500,7 @@ HTTP_QUERYSTRING_GETTER(getObject, IS_OBJECT); #ifdef HTTP_HAVE_ICONV /* {{{ proto bool HttpQueryString::xlate(string ie, string oe) - * - * Converts the query string from the source encoding ie to the target encoding oe. - * WARNING: Don't use any character set that can contain NUL bytes like UTF-16. - * - * Returns TRUE on success or FALSE on failure. - */ + Converts the query string from the source encoding ie to the target encoding oe. WARNING: Don't use any character set that can contain NUL bytes like UTF-16. */ PHP_METHOD(HttpQueryString, xlate) { char *ie, *oe; @@ -507,8 +512,8 @@ PHP_METHOD(HttpQueryString, xlate) RETURN_FALSE; } - qa = GET_PROP(queryArray); - qs = GET_PROP(queryString); + qa = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC); + qs = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC); INIT_PZVAL(&xa); array_init(&xa); @@ -525,9 +530,7 @@ PHP_METHOD(HttpQueryString, xlate) #endif /* HAVE_ICONV */ /* {{{ proto string HttpQueryString::serialize() - * - * Implements Serializable. - */ + Implements Serializable::serialize(). */ PHP_METHOD(HttpQueryString, serialize) { NO_ARGS; @@ -536,9 +539,7 @@ PHP_METHOD(HttpQueryString, serialize) /* }}} */ /* {{{ proto void HttpQueryString::unserialize(string serialized) - * - * Implements Serializable. - */ + Implements Serializable::unserialize(). */ PHP_METHOD(HttpQueryString, unserialize) { zval *serialized; @@ -546,11 +547,7 @@ PHP_METHOD(HttpQueryString, unserialize) SET_EH_THROW_HTTP(); if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &serialized)) { if (Z_TYPE_P(serialized) == IS_STRING) { - zval *qa = GET_PROP(queryArray); - - zend_hash_clean(Z_ARRVAL_P(qa)); - http_querystring_modify(qa, serialized); - http_querystring_update(qa, GET_PROP(queryString)); + http_querystring_instantiate(getThis(), 0, serialized, 0); } else { http_error(HE_WARNING, HTTP_E_QUERYSTRING, "Expected a string as parameter"); } @@ -560,9 +557,7 @@ PHP_METHOD(HttpQueryString, unserialize) /* }}} */ /* {{{ proto mixed HttpQueryString::offsetGet(string offset) - * - * Implements ArrayAccess. - */ + Implements ArrayAccess::offsetGet(). */ PHP_METHOD(HttpQueryString, offsetGet) { char *offset_str; @@ -570,16 +565,14 @@ PHP_METHOD(HttpQueryString, offsetGet) zval **value; if ( (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) && - (SUCCESS == zend_hash_find(Z_ARRVAL_P(GET_PROP(queryArray)), offset_str, offset_len + 1, (void *) &value))) { + (SUCCESS == zend_hash_find(Z_ARRVAL_P(zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC)), offset_str, offset_len + 1, (void *) &value))) { RETVAL_ZVAL(*value, 1, 0); } } /* }}} */ /* {{{ proto void HttpQueryString::offsetSet(string offset, mixed value) - * - * Implements ArrayAccess. - */ + Implements ArrayAccess::offsetGet(). */ PHP_METHOD(HttpQueryString, offsetSet) { char *offset_str; @@ -587,7 +580,7 @@ PHP_METHOD(HttpQueryString, offsetSet) zval *value; if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sz", &offset_str, &offset_len, &value)) { - zval *qarr = GET_PROP(queryArray), *qstr = GET_PROP(queryString); + zval *qarr = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC), *qstr = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC); ZVAL_ADDREF(value); add_assoc_zval_ex(qarr, offset_str, offset_len + 1, value); @@ -597,9 +590,7 @@ PHP_METHOD(HttpQueryString, offsetSet) /* }}} */ /* {{{ proto bool HttpQueryString::offsetExists(string offset) - * - * Implements ArrayAccess. - */ + Implements ArrayAccess::offsetExists(). */ PHP_METHOD(HttpQueryString, offsetExists) { char *offset_str; @@ -607,25 +598,23 @@ PHP_METHOD(HttpQueryString, offsetExists) zval **value; if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) { - RETURN_BOOL((SUCCESS == zend_hash_find(Z_ARRVAL_P(GET_PROP(queryArray)), offset_str, offset_len + 1, (void *) &value)) && (Z_TYPE_PP(value) != IS_NULL)); + RETURN_BOOL((SUCCESS == zend_hash_find(Z_ARRVAL_P(zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC)), offset_str, offset_len + 1, (void *) &value)) && (Z_TYPE_PP(value) != IS_NULL)); } } /* }}} */ /* {{{ proto void HttpQueryString::offsetUnset(string offset) - * - * Implements ArrayAccess. - */ + Implements ArrayAccess::offsetUnset(). */ PHP_METHOD(HttpQueryString, offsetUnset) { char *offset_str; int offset_len; if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) { - zval *qarr = GET_PROP(queryArray); + zval *qarr = zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryArray")-1, 0 TSRMLS_CC); if (SUCCESS == zend_hash_del(Z_ARRVAL_P(qarr), offset_str, offset_len + 1)) { - http_querystring_update(qarr, GET_PROP(queryString)); + http_querystring_update(qarr, zend_read_property(THIS_CE, getThis(), ZEND_STRS("queryString")-1, 0 TSRMLS_CC)); } } }