X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-http;a=blobdiff_plain;f=http_functions.c;h=dd24050b00ae818878e2f1c7c36ca98424a1950f;hp=cbb487f132798457507f130277d8882b743d01dc;hb=47d531af5faac1df8dedeb383867850ab430f0a1;hpb=8b5eb376ae8f5e53cfb66752327043be2669498a

diff --git a/http_functions.c b/http_functions.c
index cbb487f..dd24050 100644
--- a/http_functions.c
+++ b/http_functions.c
@@ -956,7 +956,7 @@ PHP_FUNCTION(http_match_request_header)
  *  - compress:         bool, whether to allow gzip/deflate content encoding
  *                      (defaults to true)
  *  - port:             int, use another port as specified in the url
- *  - referer:          string, the referer to sends
+ *  - referer:          string, the referer to send
  *  - useragent:        string, the user agent to send
  *                      (defaults to PECL::HTTP/version (PHP/version)))
  *  - headers:          array, list of custom headers as associative array
@@ -1028,6 +1028,7 @@ PHP_FUNCTION(http_get)
 	if (SUCCESS == http_get(URL, options ? Z_ARRVAL_P(options) : NULL, info ? Z_ARRVAL_P(info) : NULL, &response)) {
 		RETURN_PHPSTR_VAL(&response);
 	} else {
+		phpstr_dtor(&response);
 		RETURN_FALSE;
 	}
 }
@@ -1061,6 +1062,7 @@ PHP_FUNCTION(http_head)
 	if (SUCCESS == http_head(URL, options ? Z_ARRVAL_P(options) : NULL, info ? Z_ARRVAL_P(info) : NULL, &response)) {
 		RETURN_PHPSTR_VAL(&response);
 	} else {
+		phpstr_dtor(&response);
 		RETURN_FALSE;
 	}
 }
@@ -1100,6 +1102,7 @@ PHP_FUNCTION(http_post_data)
 	if (SUCCESS == http_post(URL, &body, options ? Z_ARRVAL_P(options) : NULL, info ? Z_ARRVAL_P(info) : NULL, &response)) {
 		RETVAL_PHPSTR_VAL(&response);
 	} else {
+		phpstr_dtor(&response);
 		RETVAL_FALSE;
 	}
 }
@@ -1139,6 +1142,7 @@ PHP_FUNCTION(http_post_fields)
 	if (SUCCESS == http_post(URL, &body, options ? Z_ARRVAL_P(options) : NULL, info ? Z_ARRVAL_P(info) : NULL, &response)) {
 		RETVAL_PHPSTR_VAL(&response);
 	} else {
+		phpstr_dtor(&response);
 		RETVAL_FALSE;
 	}
 	http_request_body_dtor(&body);
@@ -1189,6 +1193,7 @@ PHP_FUNCTION(http_put_file)
 	if (SUCCESS == http_put(URL, &body, options ? Z_ARRVAL_P(options) : NULL, info ? Z_ARRVAL_P(info) : NULL, &response)) {
 		RETVAL_PHPSTR_VAL(&response);
 	} else {
+		phpstr_dtor(&response);
 		RETVAL_FALSE;
 	}
 	http_request_body_dtor(&body);
@@ -1237,6 +1242,7 @@ PHP_FUNCTION(http_put_stream)
 	if (SUCCESS == http_put(URL, &body, options ? Z_ARRVAL_P(options) : NULL, info ? Z_ARRVAL_P(info) : NULL, &response)) {
 		RETURN_PHPSTR_VAL(&response);
 	} else {
+		phpstr_dtor(&response);
 		RETURN_NULL();
 	}
 }
@@ -1596,20 +1602,22 @@ PHP_FUNCTION(http_uncompress)
  * 
  * Accpepts an optional in parameter specifying which feature to probe for.
  * If the parameter is 0 or omitted, the return value contains a bitmask of 
- * all supported featuers that depend on external libraries.
+ * all supported features that depend on external libraries.
  * 
  * Available features to probe for are:
- *  - HTTP_SUPPORT: always set
- *  - HTTP_SUPPORT_REQUESTS: whether ext/http was linked against libcurl,
- *    and HTTP requests can be issued
- *  - HTTP_SUPPORT_SSLREQUESTS: whether libcurl was linked against openssl,
- *    and SSL requests can be issued 
- *  - HTTP_SUPPORT_ENCODINGS: whether ext/http was linked against zlib,
- *    and compressed HTTP responses can be decoded
- *  - HTTP_SUPPORT_MHASHETAGS: whether ext/http was linked against libmhash,
- *    and ETags can be generated with the available mhash algorithms
- *  - HTTP_SUPPORT_MAGICMIME: whether ext/http was linked against libmagic,
- *    and the HttpResponse::guessContentType() method is usable
+ * <ul> 
+ *  <li> HTTP_SUPPORT: always set
+ *  <li> HTTP_SUPPORT_REQUESTS: whether ext/http was linked against libcurl,
+ *       and HTTP requests can be issued
+ *  <li> HTTP_SUPPORT_SSLREQUESTS: whether libcurl was linked against openssl,
+ *       and SSL requests can be issued 
+ *  <li> HTTP_SUPPORT_ENCODINGS: whether ext/http was linked against zlib,
+ *       and compressed HTTP responses can be decoded
+ *  <li> HTTP_SUPPORT_MHASHETAGS: whether ext/http was linked against libmhash,
+ *       and ETags can be generated with the available mhash algorithms
+ *  <li> HTTP_SUPPORT_MAGICMIME: whether ext/http was linked against libmagic,
+ *       and the HttpResponse::guessContentType() method is usable
+ * </ul>
  * 
  * Returns int, whether requested feature is supported, or a bitmask with
  * all supported features.