X-Git-Url: https://git.m6w6.name/?p=m6w6%2Fext-http;a=blobdiff_plain;f=http_api.c;h=4718e3d1b1fcdcbc4233e05526dc53768aaacb82;hp=f68f57e3d6aed62b6a6fec835f46e94ae3b1b286;hb=318bb3459a12dc26362978413cde00cde6616d89;hpb=68a779badeace396e3a86caf9cb86b7e70ff636a diff --git a/http_api.c b/http_api.c index f68f57e..4718e3d 100644 --- a/http_api.c +++ b/http_api.c @@ -15,10 +15,11 @@ /* $Id$ */ +#define _WINSOCKAPI_ #define ZEND_INCLUDE_FULL_WINDOWS_HEADERS #ifdef HAVE_CONFIG_H -#include "config.h" +# include "config.h" #endif #include @@ -37,9 +38,9 @@ #include "SAPI.h" #ifdef ZEND_ENGINE_2 -#include "ext/standard/php_http.h" +# include "ext/standard/php_http.h" #else -#include "http_build_query.c" + #include "http_build_query.c" #endif #include "php_http.h" @@ -47,13 +48,14 @@ #ifdef HTTP_HAVE_CURL -#ifdef PHP_WIN32 -#include -#include -#endif +# ifdef PHP_WIN32 +# include +# include +# endif + +# include +# include -#include -#include #endif @@ -143,6 +145,10 @@ static int check_day(char *day, size_t len); static int check_month(char *month); static int check_tzone(char *tzone); +static char *pretty_key(char *key, int key_len, int uctitle, int xhyphen); + +static int http_ob_stack_get(php_ob_buffer *, php_ob_buffer **); + /* {{{ HAVE_CURL */ #ifdef HTTP_HAVE_CURL #define http_curl_initbuf(m) _http_curl_initbuf((m) TSRMLS_CC) @@ -199,7 +205,8 @@ static int http_sort_q(const void *a, const void *b TSRMLS_DC) static inline char *_http_etag(char **new_etag, const void *data_ptr, const size_t data_len, const http_send_mode data_mode TSRMLS_DC) { - char ssb_buf[127], digest[16]; + char ssb_buf[127]; + unsigned char digest[16]; PHP_MD5_CTX ctx; PHP_MD5Init(&ctx); @@ -286,8 +293,7 @@ static STATUS _http_send_chunk(const void *data, const size_t begin, break; case SEND_DATA: - return len == php_body_write( - Z_STRVAL_P((zval *) data) + begin, len TSRMLS_CC) + return len == php_body_write(((char *)data) + begin, len TSRMLS_CC) ? SUCCESS : FAILURE; break; @@ -590,7 +596,7 @@ static inline void _http_curl_setopts(CURL *ch, const char *url, HashTable *opti if (key_type == HASH_KEY_IS_STRING) { zend_hash_get_current_key(Z_ARRVAL_P(zoption), &header_key, NULL, 0); zend_hash_get_current_data(Z_ARRVAL_P(zoption), (void **) &header_val); - snprintf(header, 1024, "%s: %s", header_key, Z_STRVAL_PP(header_val)); + snprintf(header, 1023, "%s: %s", header_key, Z_STRVAL_PP(header_val)); headers = curl_slist_append(headers, header); zend_hash_move_forward(Z_ARRVAL_P(zoption)); } @@ -605,7 +611,7 @@ static inline void _http_curl_setopts(CURL *ch, const char *url, HashTable *opti /* {{{ static inline char *http_curl_getinfoname(CURLINFO) */ static inline char *_http_curl_getinfoname(CURLINFO i TSRMLS_DC) { -#define CASE(I) case CURLINFO_ ##I : return #I +#define CASE(I) case CURLINFO_ ##I : return pretty_key(estrdup( #I ), strlen(#I), 0, 0) switch (i) { /* CURLINFO_EFFECTIVE_URL = CURLINFO_STRING +1, */ @@ -682,7 +688,7 @@ static inline void _http_curl_getinfo_ex(CURL *ch, CURLINFO i, zval *array TSRML { double d; if (CURLE_OK == curl_easy_getinfo(ch, i, &d)) { - add_assoc_double(array, key, (double) d); + add_assoc_double(array, key, d); } } break; @@ -691,7 +697,7 @@ static inline void _http_curl_getinfo_ex(CURL *ch, CURLINFO i, zval *array TSRML { long l; if (CURLE_OK == curl_easy_getinfo(ch, i, &l)) { - add_assoc_long(array, key, (long) l); + add_assoc_long(array, key, l); } } break; @@ -703,12 +709,10 @@ static inline void _http_curl_getinfo_ex(CURL *ch, CURLINFO i, zval *array TSRML /* {{{ static inline http_curl_getinfo(CURL, HashTable *) */ static inline void _http_curl_getinfo(CURL *ch, HashTable *info TSRMLS_DC) { - zval *array; - - MAKE_STD_ZVAL(array); - Z_ARRVAL_P(array) = info; + zval array; + Z_ARRVAL(array) = info; -#define INFO(I) http_curl_getinfo_ex(ch, CURLINFO_ ##I , array) +#define INFO(I) http_curl_getinfo_ex(ch, CURLINFO_ ##I , &array) /* CURLINFO_EFFECTIVE_URL = CURLINFO_STRING +1, */ INFO(EFFECTIVE_URL); /* CURLINFO_RESPONSE_CODE = CURLINFO_LONG +2, */ @@ -758,10 +762,12 @@ static inline void _http_curl_getinfo(CURL *ch, HashTable *info TSRMLS_DC) /* CURLINFO_PROXYAUTH_AVAIL = CURLINFO_LONG +24, */ INFO(PROXYAUTH_AVAIL); #undef INFO - efree(array); } /* }}} */ +#endif +/* }}} HAVE_CURL */ + /* {{{ Day/Month/TZ checks for http_parse_date() Originally by libcurl, Copyright (C) 1998 - 2004, Daniel Stenberg, , et al. */ static int check_day(char *day, size_t len) @@ -807,8 +813,44 @@ static int check_tzone(char *tzone) } /* }}} */ -#endif -/* }}} HAVE_CURL */ +/* static char *pretty_key(char *, int, int, int) */ +static char *pretty_key(char *key, int key_len, int uctitle, int xhyphen) +{ + if (key && key_len) { + int i, wasalpha; + if (wasalpha = isalpha(key[0])) { + key[0] = uctitle ? toupper(key[0]) : tolower(key[0]); + } + for (i = 1; i < key_len; i++) { + if (isalpha(key[i])) { + key[i] = ((!wasalpha) && uctitle) ? toupper(key[i]) : tolower(key[i]); + wasalpha = 1; + } else { + if (xhyphen && (key[i] == '_')) { + key[i] = '-'; + } + wasalpha = 0; + } + } + } + return key; +} +/* }}} */ + +/* {{{ static STATUS http_ob_stack_get(php_ob_buffer *, php_ob_buffer **) */ +static STATUS http_ob_stack_get(php_ob_buffer *o, php_ob_buffer **s) +{ + static int i = 0; + php_ob_buffer *b = emalloc(sizeof(php_ob_buffer)); + b->handler_name = estrdup(o->handler_name); + b->buffer = estrndup(o->buffer, o->text_length); + b->text_length = o->text_length; + b->chunk_size = o->chunk_size; + b->erase = o->erase; + s[i++] = b; + return SUCCESS; +} +/* }}} */ /* }}} internals */ @@ -818,7 +860,7 @@ static int check_tzone(char *tzone) PHP_HTTP_API char *_http_date(time_t t TSRMLS_DC) { struct tm *gmtime, tmbuf; - char *date = ecalloc(1, 30); + char *date = ecalloc(31, 1); gmtime = php_gmtime_r(&t, &tmbuf); snprintf(date, 30, @@ -1070,6 +1112,44 @@ PHP_HTTP_API void _http_ob_etaghandler(char *output, uint output_len, } /* }}} */ +/* {{{ STATUS http_start_ob_handler(php_output_handler_func_t, char *, uint, zend_bool) */ +PHP_HTTP_API STATUS _http_start_ob_handler(php_output_handler_func_t handler_func, + char *handler_name, uint chunk_size, zend_bool erase TSRMLS_DC) +{ + php_ob_buffer **stack; + int count, i; + + if (count = OG(ob_nesting_level)) { + stack = ecalloc(sizeof(php_ob_buffer), count); + + if (count > 1) { + zend_stack_apply_with_argument(&OG(ob_buffers), ZEND_STACK_APPLY_BOTTOMUP, + (int (*)(void *elem, void *)) http_ob_stack_get, stack); + } + + if (count > 0) { + http_ob_stack_get(&OG(active_ob_buffer), stack); + } + + while (OG(ob_nesting_level)) { + php_end_ob_buffer(0, 0 TSRMLS_CC); + } + } + + php_ob_set_internal_handler(handler_func, chunk_size, handler_name, erase TSRMLS_CC); + + for (i = 0; i < count; i++) { + php_ob_buffer *s = stack[i]; + if (strcmp(s->handler_name, "default output handler")) { + php_start_ob_buffer_named(s->handler_name, s->chunk_size, s->erase TSRMLS_CC); + } + php_body_write(s->buffer, s->text_length TSRMLS_CC); + } + + return SUCCESS; +} +/* }}} */ + /* {{{ int http_modified_match(char *, int) */ PHP_HTTP_API int _http_modified_match(const char *entry, const time_t t TSRMLS_DC) { @@ -1138,12 +1218,17 @@ PHP_HTTP_API STATUS _http_send_etag(const char *etag, int header_len; char *etag_header; - header_len = strlen("ETag: \"\"") + etag_len + 1; - etag_header = (char *) emalloc(header_len); - snprintf(etag_header, header_len, "ETag: \"%s\"", etag); + header_len = sizeof("ETag: \"\"") + etag_len + 1; + etag_header = ecalloc(header_len, 1); + sprintf(etag_header, "ETag: \"%s\"", etag); ret = http_send_header(etag_header); efree(etag_header); + if (!etag_len){ + php_error_docref(NULL TSRMLS_CC,E_ERROR, + "Sending empty Etag (previous: %s)\n", HTTP_G(etag)); + return FAILURE; + } /* remember */ if (HTTP_G(etag)) { efree(HTTP_G(etag)); @@ -1300,7 +1385,7 @@ PHP_HTTP_API http_range_status _http_get_request_ranges(zval *zranges, if (strncmp(range, "bytes=", strlen("bytes="))) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Range header misses bytes="); - return RANGE_ERR; + return RANGE_NO; } ptr = &begin; @@ -1406,7 +1491,7 @@ PHP_HTTP_API http_range_status _http_get_request_ranges(zval *zranges, break; default: - return RANGE_ERR; + return RANGE_NO; break; } } while (c != 0); @@ -1418,16 +1503,17 @@ PHP_HTTP_API http_range_status _http_get_request_ranges(zval *zranges, /* {{{ STATUS http_send_ranges(zval *, void *, size_t, http_send_mode) */ PHP_HTTP_API STATUS _http_send_ranges(zval *zranges, const void *data, const size_t size, const http_send_mode mode TSRMLS_DC) { - zval **zrange; + int c; long **begin, **end; - char range_header[255], multi_header[68] = "Content-Type: multipart/byteranges; boundary=", bound[23], preface[1024]; - int i, c; + zval **zrange; /* Send HTTP 206 Partial Content */ http_send_status(206); /* single range */ if ((c = zend_hash_num_elements(Z_ARRVAL_P(zranges))) == 1) { + char range_header[256] = {0}; + zend_hash_index_find(Z_ARRVAL_P(zranges), 0, (void **) &zrange); zend_hash_index_find(Z_ARRVAL_PP(zrange), 0, (void **) &begin); zend_hash_index_find(Z_ARRVAL_PP(zrange), 1, (void **) &end); @@ -1441,37 +1527,52 @@ PHP_HTTP_API STATUS _http_send_ranges(zval *zranges, const void *data, const siz } /* multi range */ + else { + int i; + char bound[23] = {0}, preface[1024] = {0}, + multi_header[68] = "Content-Type: multipart/byteranges; boundary="; + + snprintf(bound, 22, "--%d%0.9f", time(NULL), php_combined_lcg(TSRMLS_C)); + strncat(multi_header, bound + 2, 21); + http_send_header(multi_header); + + /* send each requested chunk */ + for ( i = 0, zend_hash_internal_pointer_reset(Z_ARRVAL_P(zranges)); + i < c; + i++, zend_hash_move_forward(Z_ARRVAL_P(zranges))) { + if ( HASH_KEY_NON_EXISTANT == zend_hash_get_current_data( + Z_ARRVAL_P(zranges), (void **) &zrange) || + SUCCESS != zend_hash_index_find( + Z_ARRVAL_PP(zrange), 0, (void **) &begin) || + SUCCESS != zend_hash_index_find( + Z_ARRVAL_PP(zrange), 1, (void **) &end)) { + break; + } - snprintf(bound, 23, "--%d%0.9f", time(NULL), php_combined_lcg(TSRMLS_C)); - strncat(multi_header, bound + 2, 21); - http_send_header(multi_header); - - /* send each requested chunk */ - for ( i = 0, zend_hash_internal_pointer_reset(Z_ARRVAL_P(zranges)); - i < c; - i++, zend_hash_move_forward(Z_ARRVAL_P(zranges))) { - if ( HASH_KEY_NON_EXISTANT == zend_hash_get_current_data( - Z_ARRVAL_P(zranges), (void **) &zrange) || - SUCCESS != zend_hash_index_find( - Z_ARRVAL_PP(zrange), 0, (void **) &begin) || - SUCCESS != zend_hash_index_find( - Z_ARRVAL_PP(zrange), 1, (void **) &end)) { - break; - } + snprintf(preface, 1023, + HTTP_CRLF "%s" + HTTP_CRLF "Content-Type: %s" + HTTP_CRLF "Content-Range: bytes %ld-%ld/%ld" + HTTP_CRLF + HTTP_CRLF, + + bound, + HTTP_G(ctype) ? HTTP_G(ctype) : "application/x-octetstream", + **begin, + **end, + size + ); - snprintf(preface, 1024, - "\r\n%s\r\nContent-Type: %s\r\nContent-Range: bytes %d-%d/%d\r\n\r\n", bound, - HTTP_G(ctype) ? HTTP_G(ctype) : "application/x-octetstream", - **begin, **end, size); - php_body_write(preface, strlen(preface) TSRMLS_CC); - http_send_chunk(data, **begin, **end + 1, mode); - } + php_body_write(preface, strlen(preface) TSRMLS_CC); + http_send_chunk(data, **begin, **end + 1, mode); + } - /* write boundary once more */ - php_body_write("\r\n", 1 TSRMLS_CC); - php_body_write(bound, strlen(bound) TSRMLS_CC); + /* write boundary once more */ + php_body_write(HTTP_CRLF, 2 TSRMLS_CC); + php_body_write(bound, strlen(bound) TSRMLS_CC); - return SUCCESS; + return SUCCESS; + } } /* }}} */ @@ -1479,7 +1580,6 @@ PHP_HTTP_API STATUS _http_send_ranges(zval *zranges, const void *data, const siz PHP_HTTP_API STATUS _http_send(const void *data_ptr, const size_t data_size, const http_send_mode data_mode TSRMLS_DC) { - char *new_etag = NULL; int is_range_request = http_is_range_request(); if (!data_ptr) { @@ -1488,24 +1588,24 @@ PHP_HTTP_API STATUS _http_send(const void *data_ptr, const size_t data_size, /* etag handling */ if (HTTP_G(etag_started)) { - new_etag = (char *) emalloc(33); - - /* never ever use the output to compute the ETag if http_send() is used */ + char *etag = ecalloc(33, 1); + /* interrupt */ HTTP_G(etag_started) = 0; + /* never ever use the output to compute the ETag if http_send() is used */ php_end_ob_buffer(0, 0 TSRMLS_CC); - if (NULL == http_etag(&new_etag, data_ptr, data_size, data_mode)) { - efree(new_etag); + if (NULL == http_etag(&etag, data_ptr, data_size, data_mode)) { + efree(etag); return FAILURE; } /* send 304 Not Modified if etag matches */ - if ((!is_range_request) && http_etag_match("HTTP_IF_NONE_MATCH", new_etag)) { - efree(new_etag); + if ((!is_range_request) && http_etag_match("HTTP_IF_NONE_MATCH", etag)) { + efree(etag); return http_send_status(304); } - http_send_etag(new_etag, 32); - efree(new_etag); + http_send_etag(etag, 32); + efree(etag); } /* send 304 Not Modified if last-modified matches*/ @@ -1572,7 +1672,7 @@ PHP_HTTP_API STATUS _http_send_data(const zval *zdata TSRMLS_DC) return FAILURE; } - return http_send(zdata, Z_STRLEN_P(zdata), SEND_DATA); + return http_send(Z_STRVAL_P(zdata), Z_STRLEN_P(zdata), SEND_DATA); } /* }}} */ @@ -1616,7 +1716,7 @@ PHP_HTTP_API STATUS _http_chunked_decode(const char *encoded, char *d_ptr; *decoded_len = 0; - *decoded = (char *) ecalloc(1, encoded_len); + *decoded = (char *) ecalloc(encoded_len, 1); d_ptr = *decoded; e_ptr = encoded; @@ -1636,8 +1736,22 @@ PHP_HTTP_API STATUS _http_chunked_decode(const char *encoded, hex_len[i++] = *e_ptr++; } + /* reached the end */ + if (!strcmp(hex_len, "0")) { + break; + } + + /* new line */ + if (strncmp(e_ptr, HTTP_CRLF, 2)) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, + "Invalid character (expected 0x0D 0x0A; got: %x %x)", + *e_ptr, *(e_ptr + 1)); + efree(*decoded); + return FAILURE; + } + /* hex to long */ - if (strcmp(hex_len, "0")) { + { char *error = NULL; chunk_len = strtol(hex_len, &error, 16); if (error == hex_len) { @@ -1646,20 +1760,9 @@ PHP_HTTP_API STATUS _http_chunked_decode(const char *encoded, efree(*decoded); return FAILURE; } - } else { - break; - } - - /* new line */ - if (*e_ptr++ != '\r' || *e_ptr++ != '\n') { - php_error_docref(NULL TSRMLS_CC, E_WARNING, - "Invalid character (expected 0x0A, 0x0D; got: %x)", - *(e_ptr - 1)); - efree(*decoded); - return FAILURE; } - memcpy(d_ptr, e_ptr, chunk_len); + memcpy(d_ptr, e_ptr += 2, chunk_len); d_ptr += chunk_len; e_ptr += chunk_len + 2; *decoded_len += chunk_len; @@ -1693,22 +1796,22 @@ PHP_HTTP_API STATUS _http_split_response(const zval *zresponse, zval *zheaders, Z_TYPE_P(zbody) = IS_NULL; } - return http_parse_header(header, body - Z_STRVAL_P(zresponse), zheaders); + return http_parse_headers(header, body - Z_STRVAL_P(zresponse), zheaders); } /* }}} */ -/* {{{ STATUS http_parse_header(char *, long, zval *) */ -PHP_HTTP_API STATUS _http_parse_header(char *header, long header_len, zval *array TSRMLS_DC) +/* {{{ STATUS http_parse_headers(char *, long, zval *) */ +PHP_HTTP_API STATUS _http_parse_headers(char *header, int header_len, zval *array TSRMLS_DC) { char *colon = NULL, *line = NULL, *begin = header; - if (header_len < 8) { + if (header_len < 2) { return FAILURE; } /* status code */ if (!strncmp(header, "HTTP/1.", 7)) { - char *end = strstr(header, "\r\n"); + char *end = strstr(header, HTTP_CRLF); add_assoc_stringl(array, "Status", header + strlen("HTTP/1.x "), end - (header + strlen("HTTP/1.x ")), 1); @@ -1717,21 +1820,38 @@ PHP_HTTP_API STATUS _http_parse_header(char *header, long header_len, zval *arra line = header; - /* - * FIXXME: support for folded headers - */ - while (header_len > (line - begin)) { + while (header_len >= (line - begin)) { + int value_len = 0; + switch (*line++) { case 0: - case '\r': - if (colon && (*line == '\n')) { - char *key = estrndup(header, colon - header); - add_assoc_stringl(array, key, colon + 2, line - colon - 3, 1); - efree(key); + --value_len; /* we don't have CR so value length is one char less */ + case '\n': + if (colon && ((!(*line - 1)) || ((*line != ' ') && (*line != '\t')))) { + + /* skip empty key */ + if (header != colon) { + char *key = estrndup(header, colon - header); + value_len += line - colon - 1; + + /* skip leading ws */ + while (isspace(*(++colon))) --value_len; + /* skip trailing ws */ + while (isspace(colon[value_len - 1])) --value_len; + + if (value_len < 1) { + /* hm, empty header? */ + add_assoc_stringl(array, key, "", 0, 1); + } else { + add_assoc_stringl(array, key, colon, value_len, 1); + } + efree(key); + } colon = NULL; - header += line - header + 1; + value_len = 0; + header += line - header; } break; @@ -1746,6 +1866,23 @@ PHP_HTTP_API STATUS _http_parse_header(char *header, long header_len, zval *arra } /* }}} */ +/* {{{ void http_get_request_headers(zval *) */ +PHP_HTTP_API void _http_get_request_headers(zval *array TSRMLS_DC) +{ + char *key; + + for ( zend_hash_internal_pointer_reset(HTTP_SERVER_VARS); + zend_hash_get_current_key(HTTP_SERVER_VARS, &key, NULL, 0) != HASH_KEY_NON_EXISTANT; + zend_hash_move_forward(HTTP_SERVER_VARS)) { + if (!strncmp(key, "HTTP_", 5)) { + zval **header; + zend_hash_get_current_data(HTTP_SERVER_VARS, (void **) &header); + add_assoc_stringl(array, pretty_key(key + 5, strlen(key) - 5, 1, 1), Z_STRVAL_PP(header), Z_STRLEN_PP(header), 1); + } + } +} +/* }}} */ + /* {{{ HAVE_CURL */ #ifdef HTTP_HAVE_CURL @@ -1753,18 +1890,30 @@ PHP_HTTP_API STATUS _http_parse_header(char *header, long header_len, zval *arra PHP_HTTP_API STATUS _http_get(const char *URL, HashTable *options, HashTable *info, char **data, size_t *data_len TSRMLS_DC) { + STATUS rs; CURL *ch = curl_easy_init(); if (!ch) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not initialize curl"); return FAILURE; } + + rs = http_get_ex(ch, URL, options, info, data, data_len); + curl_easy_cleanup(ch); + return rs; +} +/* }}} */ +/* {{{ STATUS http_get_ex(CURL *, char *, HashTable *, HashTable *, char **, size_t *) */ +PHP_HTTP_API STATUS _http_get_ex(CURL *ch, const char *URL, HashTable *options, + HashTable *info, char **data, size_t *data_len TSRMLS_DC) +{ http_curl_initbuf(CURLBUF_EVRY); http_curl_setopts(ch, URL, options); + curl_easy_setopt(ch, CURLOPT_NOBODY, 0); + curl_easy_setopt(ch, CURLOPT_POST, 0); if (CURLE_OK != curl_easy_perform(ch)) { - curl_easy_cleanup(ch); http_curl_freebuf(CURLBUF_EVRY); php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not perform request"); return FAILURE; @@ -1772,31 +1921,38 @@ PHP_HTTP_API STATUS _http_get(const char *URL, HashTable *options, if (info) { http_curl_getinfo(ch, info); } - curl_easy_cleanup(ch); - http_curl_movebuf(CURLBUF_EVRY, data, data_len); - return SUCCESS; } -/* }}} */ /* {{{ STATUS http_head(char *, HashTable *, HashTable *, char **data, size_t *) */ PHP_HTTP_API STATUS _http_head(const char *URL, HashTable *options, HashTable *info, char **data, size_t *data_len TSRMLS_DC) { + STATUS rs; CURL *ch = curl_easy_init(); if (!ch) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not initialize curl"); return FAILURE; } + + rs = http_head_ex(ch, URL, options, info, data, data_len); + curl_easy_cleanup(ch); + return rs; +} +/* }}} */ +/* {{{ STATUS http_head_ex(CURL *, char *, HashTable *, HashTable *, char **data, size_t *) */ +PHP_HTTP_API STATUS _http_head_ex(CURL *ch, const char *URL, HashTable *options, + HashTable *info, char **data, size_t *data_len TSRMLS_DC) +{ http_curl_initbuf(CURLBUF_HDRS); http_curl_setopts(ch, URL, options); curl_easy_setopt(ch, CURLOPT_NOBODY, 1); + curl_easy_setopt(ch, CURLOPT_POST, 0); if (CURLE_OK != curl_easy_perform(ch)) { - curl_easy_cleanup(ch); http_curl_freebuf(CURLBUF_HDRS); php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not perform request"); return FAILURE; @@ -1804,26 +1960,33 @@ PHP_HTTP_API STATUS _http_head(const char *URL, HashTable *options, if (info) { http_curl_getinfo(ch, info); } - curl_easy_cleanup(ch); - http_curl_movebuf(CURLBUF_HDRS, data, data_len); - return SUCCESS; } -/* }}} */ /* {{{ STATUS http_post_data(char *, char *, size_t, HashTable *, HashTable *, char **, size_t *) */ PHP_HTTP_API STATUS _http_post_data(const char *URL, char *postdata, size_t postdata_len, HashTable *options, HashTable *info, char **data, size_t *data_len TSRMLS_DC) { + STATUS rs; CURL *ch = curl_easy_init(); if (!ch) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not initialize curl"); return FAILURE; } + rs = http_post_data_ex(ch, URL, postdata, postdata_len, options, info, data, data_len); + curl_easy_cleanup(ch); + return rs; +} +/* }}} */ +/* {{{ STATUS http_post_data_ex(CURL *, char *, char *, size_t, HashTable *, HashTable *, char **, size_t *) */ +PHP_HTTP_API STATUS _http_post_data_ex(CURL *ch, const char *URL, char *postdata, + size_t postdata_len, HashTable *options, HashTable *info, char **data, + size_t *data_len TSRMLS_DC) +{ http_curl_initbuf(CURLBUF_EVRY); http_curl_setopts(ch, URL, options); curl_easy_setopt(ch, CURLOPT_POST, 1); @@ -1831,7 +1994,6 @@ PHP_HTTP_API STATUS _http_post_data(const char *URL, char *postdata, curl_easy_setopt(ch, CURLOPT_POSTFIELDSIZE, postdata_len); if (CURLE_OK != curl_easy_perform(ch)) { - curl_easy_cleanup(ch); http_curl_freebuf(CURLBUF_EVRY); php_error_docref(NULL TSRMLS_CC, E_WARNING, "Could not perform request"); return FAILURE; @@ -1839,10 +2001,7 @@ PHP_HTTP_API STATUS _http_post_data(const char *URL, char *postdata, if (info) { http_curl_getinfo(ch, info); } - curl_easy_cleanup(ch); - http_curl_movebuf(CURLBUF_EVRY, data, data_len); - return SUCCESS; } /* }}} */ @@ -1874,12 +2033,12 @@ PHP_HTTP_API STATUS _http_post_array(const char *URL, HashTable *postarray, #endif /* }}} HAVE_CURL */ -/* {{{ void http_auth_header(char *, char*) */ -PHP_HTTP_API void _http_auth_header(const char *type, const char *realm TSRMLS_DC) +/* {{{ STATUS http_auth_header(char *, char*) */ +PHP_HTTP_API STATUS _http_auth_header(const char *type, const char *realm TSRMLS_DC) { - char realm_header[1024]; - snprintf(realm_header, 1024, "WWW-Authenticate: %s realm=\"%s\"", type, realm); - http_send_status_header(401, realm_header); + char realm_header[1024] = {0}; + snprintf(realm_header, 1023, "WWW-Authenticate: %s realm=\"%s\"", type, realm); + return http_send_status_header(401, realm_header); } /* }}} */