fis querystring offset set bug
[m6w6/ext-http] / php_http_querystring.c
index 8b9e2c6e6377ebacb08eebc4c280d50d00ca19da..d2657484668ade531a876860c51354707e06a99e 100644 (file)
@@ -6,28 +6,77 @@
     | modification, are permitted provided that the conditions mentioned |
     | in the accompanying LICENSE file are met.                          |
     +--------------------------------------------------------------------+
-    | Copyright (c) 2004-2010, Michael Wallner <mike@php.net>            |
+    | Copyright (c) 2004-2014, Michael Wallner <mike@php.net>            |
     +--------------------------------------------------------------------+
 */
 
-/* $Id$ */
+#include "php_http_api.h"
 
-#include "php_http.h"
-
-#include <main/php_variables.h>
+#include <php_variables.h>
 #include <ext/spl/spl_array.h>
-#include <Zend/zend_interfaces.h>
 
 #ifdef PHP_HTTP_HAVE_ICONV
 #      undef PHP_ATOM_INC
 #      include <ext/iconv/php_iconv.h>
 #endif
 
-static inline int php_http_querystring_modify_array_ex(zval *qarray, int key_type, char *key, int keylen, ulong idx, zval *params_entry TSRMLS_DC);
-static inline int php_http_querystring_modify_array(zval *qarray, zval *params TSRMLS_DC);
+#define QS_MERGE 1
+
+static inline void php_http_querystring_set(zval *instance, zval *params, int flags TSRMLS_DC)
+{
+       zval *qa;
+
+       if (flags & QS_MERGE) {
+               qa = php_http_zsep(1, IS_ARRAY, zend_read_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), 0 TSRMLS_CC));
+       } else {
+               MAKE_STD_ZVAL(qa);
+               array_init(qa);
+       }
+
+       php_http_querystring_update(qa, params, NULL TSRMLS_CC);
+       zend_update_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), qa TSRMLS_CC);
+       zval_ptr_dtor(&qa);
+}
+
+static inline void php_http_querystring_str(zval *instance, zval *return_value TSRMLS_DC)
+{
+       zval *qa = zend_read_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+
+       if (Z_TYPE_P(qa) == IS_ARRAY) {
+               php_http_querystring_update(qa, NULL, return_value TSRMLS_CC);
+       } else {
+               RETURN_EMPTY_STRING();
+       }
+}
+
+static inline void php_http_querystring_get(zval *this_ptr, int type, char *name, uint name_len, zval *defval, zend_bool del, zval *return_value TSRMLS_DC)
+{
+       zval **arrval, *qarray = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+
+       if ((Z_TYPE_P(qarray) == IS_ARRAY) && (SUCCESS == zend_symtable_find(Z_ARRVAL_P(qarray), name, name_len + 1, (void *) &arrval))) {
+               if (type) {
+                       zval *value = php_http_ztyp(type, *arrval);
+                       RETVAL_ZVAL(value, 1, 1);
+               } else {
+                       RETVAL_ZVAL(*arrval, 1, 0);
+               }
+
+               if (del) {
+                       zval *delarr;
+
+                       MAKE_STD_ZVAL(delarr);
+                       array_init(delarr);
+                       add_assoc_null_ex(delarr, name, name_len + 1);
+                       php_http_querystring_set(this_ptr, delarr, QS_MERGE TSRMLS_CC);
+                       zval_ptr_dtor(&delarr);
+               }
+       } else if(defval) {
+               RETURN_ZVAL(defval, 1, 0);
+       }
+}
 
 #ifdef PHP_HTTP_HAVE_ICONV
-PHP_HTTP_API int php_http_querystring_xlate(zval *array, zval *param, const char *ie, const char *oe TSRMLS_DC)
+ZEND_RESULT_CODE php_http_querystring_xlate(zval *dst, zval *src, const char *ie, const char *oe TSRMLS_DC)
 {
        HashPosition pos;
        zval **entry = NULL;
@@ -35,10 +84,10 @@ PHP_HTTP_API int php_http_querystring_xlate(zval *array, zval *param, const char
        size_t xlate_len = 0, xlen;
        php_http_array_hashkey_t key = php_http_array_hashkey_init(0);
        
-       FOREACH_KEYVAL(pos, param, key, entry) {
+       FOREACH_KEYVAL(pos, src, key, entry) {
                if (key.type == HASH_KEY_IS_STRING) {
                        if (PHP_ICONV_ERR_SUCCESS != php_iconv_string(key.str, key.len-1, &xkey, &xlen, oe, ie)) {
-                               php_http_error(HE_WARNING, PHP_HTTP_E_QUERYSTRING, "Failed to convert '%.*s' from '%s' to '%s'", key.len-1, key.str, ie, oe);
+                               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to convert '%.*s' from '%s' to '%s'", key.len-1, key.str, ie, oe);
                                return FAILURE;
                        }
                }
@@ -48,13 +97,13 @@ PHP_HTTP_API int php_http_querystring_xlate(zval *array, zval *param, const char
                                if (key.type == HASH_KEY_IS_STRING) {
                                        efree(xkey);
                                }
-                               php_http_error(HE_WARNING, PHP_HTTP_E_QUERYSTRING, "Failed to convert '%.*s' from '%s' to '%s'", Z_STRLEN_PP(entry), Z_STRVAL_PP(entry), ie, oe);
+                               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to convert '%.*s' from '%s' to '%s'", Z_STRLEN_PP(entry), Z_STRVAL_PP(entry), ie, oe);
                                return FAILURE;
                        }
                        if (key.type == HASH_KEY_IS_STRING) {
-                               add_assoc_stringl_ex(array, xkey, xlen+1, xlate_str, xlate_len, 0);
+                               add_assoc_stringl_ex(dst, xkey, xlen+1, xlate_str, xlate_len, 0);
                        } else {
-                               add_index_stringl(array, key.num, xlate_str, xlate_len, 0);
+                               add_index_stringl(dst, key.num, xlate_str, xlate_len, 0);
                        }
                } else if (Z_TYPE_PP(entry) == IS_ARRAY) {
                        zval *subarray;
@@ -62,9 +111,9 @@ PHP_HTTP_API int php_http_querystring_xlate(zval *array, zval *param, const char
                        MAKE_STD_ZVAL(subarray);
                        array_init(subarray);
                        if (key.type == HASH_KEY_IS_STRING) {
-                               add_assoc_zval_ex(array, xkey, xlen+1, subarray);
+                               add_assoc_zval_ex(dst, xkey, xlen+1, subarray);
                        } else {
-                               add_index_zval(array, key.num, subarray);
+                               add_index_zval(dst, key.num, subarray);
                        }
                        if (SUCCESS != php_http_querystring_xlate(subarray, *entry, ie, oe TSRMLS_CC)) {
                                if (key.type == HASH_KEY_IS_STRING) {
@@ -82,389 +131,291 @@ PHP_HTTP_API int php_http_querystring_xlate(zval *array, zval *param, const char
 }
 #endif /* HAVE_ICONV */
 
-PHP_HTTP_API void php_http_querystring_update(zval *qarray, zval *qstring TSRMLS_DC)
+ZEND_RESULT_CODE php_http_querystring_ctor(zval *instance, zval *params TSRMLS_DC)
 {
-       char *s = NULL;
-       size_t l = 0;
-       
-       if (Z_TYPE_P(qarray) != IS_ARRAY) {
-               convert_to_array(qarray);
-       }
-       if (SUCCESS == php_http_url_encode_hash(Z_ARRVAL_P(qarray), 0, NULL, 0, &s, &l TSRMLS_CC)) {
-               if (Z_TYPE_P(qstring) == IS_STRING)
-               zval_dtor(qstring);
-               ZVAL_STRINGL(qstring, s, l, 0);
-       } else {
-               php_http_error(HE_WARNING, PHP_HTTP_E_QUERYSTRING, "Failed to update query string");
-       }
+       php_http_querystring_set(instance, params, 0 TSRMLS_CC);
+       return SUCCESS;
 }
 
-PHP_HTTP_API int php_http_querystring_modify(zval *qarray, zval *params TSRMLS_DC)
+static int apply_querystring(void *pData TSRMLS_DC)
 {
-       if (Z_TYPE_P(params) == IS_ARRAY) {
-               return php_http_querystring_modify_array(qarray, params TSRMLS_CC);
-       } else if (Z_TYPE_P(params) == IS_OBJECT) {
-               if (instanceof_function(Z_OBJCE_P(params), php_http_querystring_class_entry TSRMLS_CC)) {
-                       return php_http_querystring_modify_array(qarray, zend_read_property(php_http_querystring_class_entry, params, ZEND_STRL("queryArray"), 0 TSRMLS_CC) TSRMLS_CC);
-               } else {
-                       return  php_http_querystring_modify_array(qarray, params TSRMLS_CC);
-               }
-       } else {
-               int rv;
-               zval array;
-               zval *qstring = php_http_zsep(IS_STRING, params);
-               
-               INIT_PZVAL(&array);
-               array_init(&array);
-               
-               php_default_treat_data(PARSE_STRING, estrdup(Z_STRVAL_P(qstring)), &array TSRMLS_CC);
-               zval_ptr_dtor(&qstring);
-               
-               rv = php_http_querystring_modify_array(qarray, &array TSRMLS_CC);
-               zval_dtor(&array);
-               return rv;
-       }
-}
+       zval **val = pData;
 
-static inline int php_http_querystring_modify_array(zval *qarray, zval *params TSRMLS_DC)
-{
-       int rv = 0;
-       php_http_array_hashkey_t key = php_http_array_hashkey_init(0);
-       HashPosition pos;
-       zval **params_entry = NULL;
-       
-       FOREACH_HASH_KEYVAL(pos, HASH_OF(params), key, params_entry) {
-               /* only public properties */
-               if ((key.type != HASH_KEY_IS_STRING || *key.str) && php_http_querystring_modify_array_ex(qarray, key.type, key.str, key.len, key.num, *params_entry TSRMLS_CC)) {
-                       rv = 1;
-               }
-       }
-       
-       return rv;
-}
+       if (Z_TYPE_PP(val) == IS_ARRAY) {
+               zval **zvalue;
 
-static inline int php_http_querystring_modify_array_ex(zval *qarray, int key_type, char *key, int keylen, ulong idx, zval *params_entry TSRMLS_DC)
-{
-       zval **qarray_entry;
+               if (SUCCESS == zend_hash_find(Z_ARRVAL_PP(val), ZEND_STRS("value"), (void *) &zvalue)) {
+                       zval *tmp = *val;
 
-       /* ensure array type */
-       if (Z_TYPE_P(qarray) != IS_ARRAY) {
-               convert_to_array(qarray);
-       }
-       
-       /* delete */
-       if (Z_TYPE_P(params_entry) == IS_NULL) {
-               if (key_type == HASH_KEY_IS_STRING) {
-                       return (SUCCESS == zend_hash_del(Z_ARRVAL_P(qarray), key, keylen));
-               } else {
-                       return (SUCCESS == zend_hash_index_del(Z_ARRVAL_P(qarray), idx));
+                       Z_ADDREF_PP(zvalue);
+                       *val = *zvalue;
+                       zval_dtor(tmp);
+                       Z_TYPE_P(tmp) = IS_NULL;
+                       zval_ptr_dtor(&tmp);
                }
        }
-       
-       /* update */
-       if (    ((key_type == HASH_KEY_IS_STRING) && (SUCCESS == zend_hash_find(Z_ARRVAL_P(qarray), key, keylen, (void *) &qarray_entry))) ||
-                       ((key_type == HASH_KEY_IS_LONG) && (SUCCESS == zend_hash_index_find(Z_ARRVAL_P(qarray), idx, (void *) &qarray_entry)))) {
-               zval equal;
-               
-               /* recursive */
-               if (Z_TYPE_P(params_entry) == IS_ARRAY || Z_TYPE_P(params_entry) == IS_OBJECT) {
-                       return php_http_querystring_modify(*qarray_entry, params_entry TSRMLS_CC);
-               }
-               /* equal */
-               if ((SUCCESS == is_equal_function(&equal, *qarray_entry, params_entry TSRMLS_CC)) && Z_BVAL(equal)) {
-                       return 0;
-               }
-       }
-       
-       /* add */
-       if (Z_TYPE_P(params_entry) == IS_OBJECT) {
-               zval *new_array;
-               
-               MAKE_STD_ZVAL(new_array);
-               array_init(new_array);
-               php_http_querystring_modify_array(new_array, params_entry TSRMLS_CC);
-               params_entry = new_array;
-       } else {
-               Z_ADDREF_P(params_entry);
-       }
-       if (key_type == HASH_KEY_IS_STRING) {
-               add_assoc_zval_ex(qarray, key, keylen, params_entry);
-       } else {
-               add_index_zval(qarray, idx, params_entry);
-       }
-       return 1;
-}
-
-#define PHP_HTTP_BEGIN_ARGS(method, req_args)                  PHP_HTTP_BEGIN_ARGS_EX(HttpQueryString, method, 0, req_args)
-#define PHP_HTTP_EMPTY_ARGS(method)                                            PHP_HTTP_EMPTY_ARGS_EX(HttpQueryString, method, 0)
-#define PHP_HTTP_QUERYSTRING_ME(method, visibility)            PHP_ME(HttpQueryString, method, PHP_HTTP_ARGS(HttpQueryString, method), visibility)
-#define PHP_HTTP_QUERYSTRING_GME(method, visibility)   PHP_ME(HttpQueryString, method, PHP_HTTP_ARGS(HttpQueryString, __getter), visibility)
-
-PHP_HTTP_BEGIN_ARGS(__construct, 0)
-       PHP_HTTP_ARG_VAL(params, 0)
-PHP_HTTP_END_ARGS;
-
-PHP_HTTP_EMPTY_ARGS(getGlobalInstance);
-
-PHP_HTTP_EMPTY_ARGS(toArray);
-PHP_HTTP_EMPTY_ARGS(toString);
 
-PHP_HTTP_BEGIN_ARGS(get, 0)
-       PHP_HTTP_ARG_VAL(name, 0)
-       PHP_HTTP_ARG_VAL(type, 0)
-       PHP_HTTP_ARG_VAL(defval, 0)
-       PHP_HTTP_ARG_VAL(delete, 0)
-PHP_HTTP_END_ARGS;
-
-PHP_HTTP_BEGIN_ARGS(set, 1)
-       PHP_HTTP_ARG_VAL(params, 0)
-PHP_HTTP_END_ARGS;
-
-PHP_HTTP_BEGIN_ARGS(mod, 0)
-       PHP_HTTP_ARG_VAL(params, 0)
-PHP_HTTP_END_ARGS;
+       return ZEND_HASH_APPLY_KEEP;
+}
 
-PHP_HTTP_BEGIN_ARGS(__getter, 1)
-       PHP_HTTP_ARG_VAL(name, 0)
-       PHP_HTTP_ARG_VAL(defval, 0)
-       PHP_HTTP_ARG_VAL(delete, 0)
-PHP_HTTP_END_ARGS;
+ZEND_RESULT_CODE php_http_querystring_parse(HashTable *ht, const char *str, size_t len TSRMLS_DC)
+{
+       ZEND_RESULT_CODE rv = FAILURE;
+       php_http_params_opts_t opts;
+       php_http_params_token_t psep = { ZEND_STRL("&") }, *psepp[] = { &psep, NULL };
+       php_http_params_token_t vsep = { ZEND_STRL("=") }, *vsepp[] = { &vsep, NULL };
+       const char *asi_str = NULL;
+       size_t asi_len = 0;
 
-#ifdef PHP_HTTP_HAVE_ICONV
-PHP_HTTP_BEGIN_ARGS(xlate, 2)
-       PHP_HTTP_ARG_VAL(from_encoding, 0)
-       PHP_HTTP_ARG_VAL(to_encoding, 0)
-PHP_HTTP_END_ARGS;
-#endif
+       opts.input.str = estrndup(str, len);
+       opts.input.len = len;
+       opts.param = psepp;
+       opts.arg = NULL;
+       opts.val = vsepp;
+       opts.flags = PHP_HTTP_PARAMS_QUERY;
 
-PHP_HTTP_EMPTY_ARGS(serialize);
-PHP_HTTP_BEGIN_ARGS(unserialize, 1)
-       PHP_HTTP_ARG_VAL(serialized, 0)
-PHP_HTTP_END_ARGS;
+       if (SUCCESS == php_http_ini_entry(ZEND_STRL("arg_separator.input"), &asi_str, &asi_len, 0 TSRMLS_CC) && asi_len) {
+               zval *arr;
 
-PHP_HTTP_BEGIN_ARGS(offsetGet, 1)
-       PHP_HTTP_ARG_VAL(offset, 0)
-PHP_HTTP_END_ARGS;
+               MAKE_STD_ZVAL(arr);
+               array_init_size(arr, asi_len);
 
-PHP_HTTP_BEGIN_ARGS(offsetSet, 2)
-       PHP_HTTP_ARG_VAL(offset, 0)
-       PHP_HTTP_ARG_VAL(value, 0)
-PHP_HTTP_END_ARGS;
+               do {
+                       add_next_index_stringl(arr, asi_str++, 1, 1);
+               } while (*asi_str);
 
-PHP_HTTP_BEGIN_ARGS(offsetExists, 1)
-       PHP_HTTP_ARG_VAL(offset, 0)
-PHP_HTTP_END_ARGS;
+               opts.param = php_http_params_separator_init(arr TSRMLS_CC);
 
-PHP_HTTP_BEGIN_ARGS(offsetUnset, 1)
-       PHP_HTTP_ARG_VAL(offset, 0)
-PHP_HTTP_END_ARGS;
+               zval_ptr_dtor(&arr);
+       }
 
-PHP_HTTP_EMPTY_ARGS(getIterator);
+       MAKE_STD_ZVAL(opts.defval);
+       ZVAL_NULL(opts.defval);
 
-zend_class_entry *php_http_querystring_class_entry;
-zend_function_entry php_http_querystring_method_entry[] = {
-       PHP_HTTP_QUERYSTRING_ME(__construct, ZEND_ACC_PUBLIC|ZEND_ACC_CTOR|ZEND_ACC_FINAL)
-       
-       PHP_HTTP_QUERYSTRING_ME(toArray, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(toString, ZEND_ACC_PUBLIC)
-       ZEND_MALIAS(HttpQueryString, __toString, toString, PHP_HTTP_ARGS(HttpQueryString, toString), ZEND_ACC_PUBLIC)
-       
-       PHP_HTTP_QUERYSTRING_ME(get, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(set, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(mod, ZEND_ACC_PUBLIC)
-       
-       PHP_HTTP_QUERYSTRING_GME(getBool, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_GME(getInt, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_GME(getFloat, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_GME(getString, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_GME(getArray, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_GME(getObject, ZEND_ACC_PUBLIC)
-       
-       PHP_HTTP_QUERYSTRING_ME(getIterator, ZEND_ACC_PUBLIC)
+       if (php_http_params_parse(ht, &opts TSRMLS_CC)) {
+               zend_hash_apply(ht, apply_querystring TSRMLS_CC);
+               rv = SUCCESS;
+       }
 
-       PHP_HTTP_QUERYSTRING_ME(getGlobalInstance, ZEND_ACC_PUBLIC|ZEND_ACC_STATIC)
-#ifdef PHP_HTTP_HAVE_ICONV
-       PHP_HTTP_QUERYSTRING_ME(xlate, ZEND_ACC_PUBLIC)
-#endif
-       
-       /* Implements Serializable */
-       PHP_HTTP_QUERYSTRING_ME(serialize, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(unserialize, ZEND_ACC_PUBLIC)
-       
-       /* Implements ArrayAccess */
-       PHP_HTTP_QUERYSTRING_ME(offsetGet, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(offsetSet, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(offsetExists, ZEND_ACC_PUBLIC)
-       PHP_HTTP_QUERYSTRING_ME(offsetUnset, ZEND_ACC_PUBLIC)
-       
-       EMPTY_FUNCTION_ENTRY
-};
+       if (asi_len) {
+               php_http_params_separator_free(opts.param);
+       }
 
-PHP_MINIT_FUNCTION(http_querystring)
-{
-       PHP_HTTP_REGISTER_CLASS(http, QueryString, http_querystring, php_http_object_class_entry, 0);
-       
-       zend_class_implements(php_http_querystring_class_entry TSRMLS_CC, 3, zend_ce_serializable, zend_ce_arrayaccess, zend_ce_aggregate);
-       
-       zend_declare_property_null(php_http_querystring_class_entry, ZEND_STRL("instance"), (ZEND_ACC_STATIC|ZEND_ACC_PRIVATE) TSRMLS_CC);
-       zend_declare_property_null(php_http_querystring_class_entry, ZEND_STRL("queryArray"), ZEND_ACC_PRIVATE TSRMLS_CC);
-       zend_declare_property_null(php_http_querystring_class_entry, ZEND_STRL("queryString"), ZEND_ACC_PRIVATE TSRMLS_CC);
-       
-       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_BOOL"), PHP_HTTP_QUERYSTRING_TYPE_BOOL TSRMLS_CC);
-       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_INT"), PHP_HTTP_QUERYSTRING_TYPE_INT TSRMLS_CC);
-       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_FLOAT"), PHP_HTTP_QUERYSTRING_TYPE_FLOAT TSRMLS_CC);
-       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_STRING"), PHP_HTTP_QUERYSTRING_TYPE_STRING TSRMLS_CC);
-       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_ARRAY"), PHP_HTTP_QUERYSTRING_TYPE_ARRAY TSRMLS_CC);
-       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_OBJECT"), PHP_HTTP_QUERYSTRING_TYPE_OBJECT TSRMLS_CC);
-       
-       return SUCCESS;
+       zval_ptr_dtor(&opts.defval);
+       efree(opts.input.str);
+       return rv;
 }
 
-static inline void php_http_querystring_get(zval *this_ptr, int type, char *name, uint name_len, zval *defval, zend_bool del, zval *return_value TSRMLS_DC)
+ZEND_RESULT_CODE php_http_querystring_update(zval *qarray, zval *params, zval *outstring TSRMLS_DC)
 {
-       zval **arrval, *qarray = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
-               
-       if ((Z_TYPE_P(qarray) == IS_ARRAY) && (SUCCESS == zend_hash_find(Z_ARRVAL_P(qarray), name, name_len + 1, (void *) &arrval))) {
-               if (type) {
-                       zval *value = php_http_zsep(type, *arrval);
-                       RETVAL_ZVAL(value, 1, 1);
-               } else {
-                       RETVAL_ZVAL(*arrval, 1, 0);
-               }
-                       
-               if (del && (SUCCESS == zend_hash_del(Z_ARRVAL_P(qarray), name, name_len + 1))) {
-                       php_http_querystring_update(qarray, zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryString"), 0 TSRMLS_CC) TSRMLS_CC);
-               }
-       } else if(defval) {
-               RETURN_ZVAL(defval, 1, 0);
+       /* enforce proper type */
+       if (Z_TYPE_P(qarray) != IS_ARRAY) {
+               convert_to_array(qarray);
        }
-}
-
-static inline void php_http_querystring_set(zval *instance, zval *params TSRMLS_DC)
-{
-       zval *na = NULL, *qa = zend_read_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), 0 TSRMLS_CC);
 
-       if (Z_TYPE_P(qa) != IS_ARRAY) {
-               MAKE_STD_ZVAL(qa);
-               array_init(qa);
-               zend_update_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), qa TSRMLS_CC);
-               na = qa;
-       }
+       /* modify qarray */
+       if (params) {
+               HashPosition pos;
+               HashTable *ptr;
+               php_http_array_hashkey_t key = php_http_array_hashkey_init(0);
+               zval **params_entry,  **qarray_entry;
+               zval zv, *zv_ptr = NULL;
+
+               INIT_PZVAL(&zv);
+               ZVAL_NULL(&zv);
+
+               /* squeeze the hash out of the zval */
+               if (Z_TYPE_P(params) == IS_OBJECT && instanceof_function(Z_OBJCE_P(params), php_http_querystring_class_entry TSRMLS_CC)) {
+                       zv_ptr = php_http_ztyp(IS_ARRAY, zend_read_property(php_http_querystring_class_entry, params, ZEND_STRL("queryArray"), 0 TSRMLS_CC));
+                       ptr = Z_ARRVAL_P(zv_ptr);
+               } else if (Z_TYPE_P(params) == IS_OBJECT || Z_TYPE_P(params) == IS_ARRAY) {
+                       ptr = HASH_OF(params);
+               } else {
+                       zv_ptr = php_http_ztyp(IS_STRING, params);
+                       array_init(&zv);
+                       php_http_querystring_parse(Z_ARRVAL(zv), Z_STRVAL_P(zv_ptr), Z_STRLEN_P(zv_ptr) TSRMLS_CC);
+                       zval_ptr_dtor(&zv_ptr);
+                       zv_ptr = NULL;
+                       ptr = Z_ARRVAL(zv);
+               }
 
-       if (params && php_http_querystring_modify(qa, params TSRMLS_CC)) {
-               zval *ns = NULL, *qs = zend_read_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryString"), 0 TSRMLS_CC);
+               FOREACH_HASH_KEYVAL(pos, ptr, key, params_entry) {
+                       /* only public properties */
+                       if (key.type != HASH_KEY_IS_STRING || *key.str) {
+                               if (Z_TYPE_PP(params_entry) == IS_NULL) {
+                                       /*
+                                        * delete
+                                        */
+                                       if (key.type == HASH_KEY_IS_STRING) {
+                                               zend_hash_del(Z_ARRVAL_P(qarray), key.str, key.len);
+                                       } else {
+                                               zend_hash_index_del(Z_ARRVAL_P(qarray), key.num);
+                                       }
+                               } else if (     ((key.type == HASH_KEY_IS_STRING) && (SUCCESS == zend_hash_find(Z_ARRVAL_P(qarray), key.str, key.len, (void *) &qarray_entry)))
+                                               ||      ((key.type == HASH_KEY_IS_LONG) && (SUCCESS == zend_hash_index_find(Z_ARRVAL_P(qarray), key.num, (void *) &qarray_entry)))) {
+                                       /*
+                                        * update
+                                        */
+                                       zval equal, *entry = NULL;
+
+                                       /* recursive */
+                                       if (Z_TYPE_PP(params_entry) == IS_ARRAY || Z_TYPE_PP(params_entry) == IS_OBJECT) {
+                                               entry = php_http_zsep(1, IS_ARRAY, *qarray_entry);
+                                               php_http_querystring_update(entry, *params_entry, NULL TSRMLS_CC);
+                                       } else if ((FAILURE == is_equal_function(&equal, *qarray_entry, *params_entry TSRMLS_CC)) || !Z_BVAL(equal)) {
+                                               Z_ADDREF_PP(params_entry);
+                                               entry = *params_entry;
+                                       }
 
-               if (Z_TYPE_P(qs) != IS_STRING) {
-                       MAKE_STD_ZVAL(qs);
-                       ZVAL_EMPTY_STRING(qs);
-                       zend_update_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryString"), qs TSRMLS_CC);
-                       ns = qs;
+                                       if (entry) {
+                                               if (key.type == HASH_KEY_IS_STRING) {
+                                                       zend_hash_update(Z_ARRVAL_P(qarray), key.str, key.len, (void *) &entry, sizeof(zval *), NULL);
+                                               } else {
+                                                       zend_hash_index_update(Z_ARRVAL_P(qarray), key.num, (void *) &entry, sizeof(zval *), NULL);
+                                               }
+                                       }
+                               } else {
+                                       zval *entry;
+                                       /*
+                                        * add
+                                        */
+                                       if (Z_TYPE_PP(params_entry) == IS_OBJECT) {
+                                               MAKE_STD_ZVAL(entry);
+                                               array_init(entry);
+                                               php_http_querystring_update(entry, *params_entry, NULL TSRMLS_CC);
+                                       } else {
+                                               Z_ADDREF_PP(params_entry);
+                                               entry = *params_entry;
+                                       }
+                                       if (key.type == HASH_KEY_IS_STRING) {
+                                               add_assoc_zval_ex(qarray, key.str, key.len, entry);
+                                       } else {
+                                               add_index_zval(qarray, key.num, entry);
+                                       }
+                               }
+                       }
                }
+               /* clean up */
+               if (zv_ptr) {
+                       zval_ptr_dtor(&zv_ptr);
+               }
+               zval_dtor(&zv);
+       }
 
-               php_http_querystring_update(qa, qs TSRMLS_CC);
+       /* serialize to string */
+       if (outstring) {
+               char *s;
+               size_t l;
 
-               if (ns) {
-                       zval_ptr_dtor(&ns);
+               if (SUCCESS == php_http_url_encode_hash(Z_ARRVAL_P(qarray), NULL, 0, &s, &l TSRMLS_CC)) {
+                       zval_dtor(outstring);
+                       ZVAL_STRINGL(outstring, s, l, 0);
+               } else {
+                       php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed to encode query string");
+                       return FAILURE;
                }
        }
 
-       if (na) {
-               zval_ptr_dtor(&na);
-       }
+       return SUCCESS;
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString___construct, 0, 0, 0)
+       ZEND_ARG_INFO(0, params)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, __construct)
 {
        zval *params = NULL;
+       zend_error_handling zeh;
        
-       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(runtime)) {
-               if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|z", &params)) {
-                       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(querystring)) {
-                               php_http_querystring_set(getThis(), params TSRMLS_CC);
-                       } end_error_handling();
-               }
-       } end_error_handling();
+       php_http_expect(SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|z", &params), invalid_arg, return);
+
+       zend_replace_error_handling(EH_THROW, php_http_exception_bad_querystring_class_entry, &zeh TSRMLS_CC);
+       php_http_querystring_set(getThis(), params, 0 TSRMLS_CC);
+       zend_restore_error_handling(&zeh TSRMLS_CC);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_getGlobalInstance, 0, 0, 0)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, getGlobalInstance)
 {
-       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(runtime)) {
-               if (SUCCESS == zend_parse_parameters_none()) {
-                       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(querystring)) {
-                               zval *instance = *zend_std_get_static_property(php_http_querystring_class_entry, ZEND_STRL("instance"), 0, NULL TSRMLS_CC);
-
-                               if (Z_TYPE_P(instance) != IS_OBJECT) {
-                                       zval **_SERVER = NULL, **_GET = NULL, **QUERY_STRING = NULL;
-
-                                       zend_is_auto_global("_GET", lenof("_GET") TSRMLS_CC);
-                                       zend_is_auto_global("_SERVER", lenof("_SERVER") TSRMLS_CC);
-
-                                       if ((SUCCESS == zend_hash_find(&EG(symbol_table), "_SERVER", sizeof("_SERVER"), (void *) &_SERVER))
-                                       &&      (Z_TYPE_PP(_SERVER) == IS_ARRAY)
-                                       &&      (SUCCESS == zend_hash_find(Z_ARRVAL_PP(_SERVER), "QUERY_STRING", sizeof("QUERY_STRING"), (void *) &QUERY_STRING))
-                                       &&      (SUCCESS == zend_hash_find(&EG(symbol_table), "_GET", sizeof("_GET"), (void *) &_GET))
-                                       &&      (Z_TYPE_PP(_GET) == IS_ARRAY)
-                                       ) {
-                                               zval *qstring = *QUERY_STRING, *qarray = *_GET;
-
-                                               if (Z_TYPE_P(qstring) != IS_STRING) {
-                                                       convert_to_string(qstring);
-                                               }
+       zval *instance;
 
-                                               MAKE_STD_ZVAL(instance);
-                                               ZVAL_OBJVAL(instance, php_http_querystring_object_new(php_http_querystring_class_entry TSRMLS_CC), 0);
+       php_http_expect(SUCCESS == zend_parse_parameters_none(), invalid_arg, return);
 
-                                               zend_update_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), qarray TSRMLS_CC);
-                                               zend_update_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryString"), qstring TSRMLS_CC);
+       instance = *zend_std_get_static_property(php_http_querystring_class_entry, ZEND_STRL("instance"), 0 PHP_HTTP_ZEND_LITERAL_CCN TSRMLS_CC);
 
-                                               Z_SET_ISREF_P(zend_read_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), 0 TSRMLS_CC));
-                                               Z_SET_ISREF_P(zend_read_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryString"), 0 TSRMLS_CC));
+       if (Z_TYPE_P(instance) != IS_OBJECT) {
+               zval **_GET = NULL;
 
-                                               zend_update_static_property(php_http_querystring_class_entry, ZEND_STRL("instance"), instance TSRMLS_CC);
-                                               zval_ptr_dtor(&instance);
-                                       } else {
-                                               php_http_error(HE_WARNING, PHP_HTTP_E_QUERYSTRING, "Could not acquire reference to superglobal GET or QUERY_STRING");
-                                       }
-                               }
-                               RETVAL_ZVAL(instance, 1, 0);
-                       } end_error_handling();
+               zend_is_auto_global("_GET", lenof("_GET") TSRMLS_CC);
+
+               if ((SUCCESS == zend_hash_find(&EG(symbol_table), "_GET", sizeof("_GET"), (void *) &_GET))
+               &&      (Z_TYPE_PP(_GET) == IS_ARRAY)
+               ) {
+                       MAKE_STD_ZVAL(instance);
+                       ZVAL_OBJVAL(instance, php_http_querystring_object_new(php_http_querystring_class_entry TSRMLS_CC), 0);
+
+                       SEPARATE_ZVAL_TO_MAKE_IS_REF(_GET);
+                       convert_to_array(*_GET);
+                       zend_update_property(php_http_querystring_class_entry, instance, ZEND_STRL("queryArray"), *_GET TSRMLS_CC);
+
+                       zend_update_static_property(php_http_querystring_class_entry, ZEND_STRL("instance"), instance TSRMLS_CC);
+                       zval_ptr_dtor(&instance);
+               } else {
+                       php_http_throw(unexpected_val, "Could not acquire reference to superglobal GET array", NULL);
                }
-       } end_error_handling();
+       }
+
+       RETVAL_ZVAL(instance, 1, 0);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_getIterator, 0, 0, 0)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, getIterator)
 {
-       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(runtime)) {
-               if (SUCCESS == zend_parse_parameters_none()) {
-                       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(querystring)) {
-                               zval *retval = NULL, *qa = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
-
-                               object_init_ex(return_value, spl_ce_RecursiveArrayIterator);
-                               zend_call_method_with_1_params(&return_value, spl_ce_RecursiveArrayIterator, NULL, "__construct", &retval, qa);
-                               if (retval) {
-                                       zval_ptr_dtor(&retval);
-                               }
-                       } end_error_handling();
-               }
-       } end_error_handling();
+       zval *retval = NULL, *qa;
+
+       php_http_expect(SUCCESS == zend_parse_parameters_none(), invalid_arg, return);
+
+       qa = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+
+       object_init_ex(return_value, spl_ce_RecursiveArrayIterator);
+       zend_call_method_with_1_params(&return_value, spl_ce_RecursiveArrayIterator, NULL, "__construct", &retval, qa);
+       if (retval) {
+               zval_ptr_dtor(&retval);
+       }
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_toString, 0, 0, 0)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, toString)
 {
-       if (SUCCESS == zend_parse_parameters_none()) {
-               RETURN_PROP(php_http_querystring_class_entry, "queryString");
+       if (SUCCESS != zend_parse_parameters_none()) {
+               return;
        }
-       RETURN_EMPTY_STRING();
+       php_http_querystring_str(getThis(), return_value TSRMLS_CC);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_toArray, 0, 0, 0)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, toArray)
 {
-       if (SUCCESS == zend_parse_parameters_none()) {
-               RETURN_PROP(php_http_querystring_class_entry, "queryArray");
+       zval *zqa;
+
+       if (SUCCESS != zend_parse_parameters_none()) {
+               return;
        }
-       RETURN_FALSE;
+
+       zqa = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+       RETURN_ZVAL(zqa, 1, 0);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_get, 0, 0, 0)
+       ZEND_ARG_INFO(0, name)
+       ZEND_ARG_INFO(0, type)
+       ZEND_ARG_INFO(0, defval)
+       ZEND_ARG_INFO(0, delete)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, get)
 {
        char *name_str = NULL;
@@ -501,37 +452,47 @@ PHP_METHOD(HttpQueryString, get)
                        }
                        php_http_querystring_get(getThis(), type, name_str, name_len, defval, del, return_value TSRMLS_CC);
                } else {
-                       RETURN_PROP(php_http_querystring_class_entry, "queryString");
+                       php_http_querystring_str(getThis(), return_value TSRMLS_CC);
                }
        }
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_set, 0, 0, 1)
+       ZEND_ARG_INFO(0, params)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, set)
 {
        zval *params;
        
-       if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &params)) {
-               php_http_querystring_set(getThis(), params TSRMLS_CC);
-               RETURN_PROP(php_http_querystring_class_entry, "queryString");
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &params)) {
+               return;
        }
        
-       RETURN_FALSE;
+       php_http_querystring_set(getThis(), params, QS_MERGE TSRMLS_CC);
+       RETVAL_ZVAL(getThis(), 1, 0);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_mod, 0, 0, 0)
+       ZEND_ARG_INFO(0, params)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, mod)
 {
        zval *params;
+       zend_error_handling zeh;
+
+       php_http_expect(SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &params), invalid_arg, return);
        
-       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(runtime)) {
-               if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &params)) {
-                       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(querystring)) {
-                               ZVAL_OBJVAL(return_value, Z_OBJ_HT_P(getThis())->clone_obj(getThis() TSRMLS_CC), 0);
-                               php_http_querystring_set(return_value, params TSRMLS_CC);
-                       } end_error_handling();
-               }
-       } end_error_handling();
+       zend_replace_error_handling(EH_THROW, php_http_exception_bad_querystring_class_entry, &zeh TSRMLS_CC);
+       ZVAL_OBJVAL(return_value, Z_OBJ_HT_P(getThis())->clone_obj(getThis() TSRMLS_CC), 0);
+       php_http_querystring_set(return_value, params, QS_MERGE TSRMLS_CC);
+       zend_restore_error_handling(&zeh TSRMLS_CC);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString___getter, 0, 0, 1)
+       ZEND_ARG_INFO(0, name)
+       ZEND_ARG_INFO(0, defval)
+       ZEND_ARG_INFO(0, delete)
+ZEND_END_ARG_INFO();
 #define PHP_HTTP_QUERYSTRING_GETTER(method, TYPE) \
 PHP_METHOD(HttpQueryString, method) \
 { \
@@ -551,133 +512,220 @@ PHP_HTTP_QUERYSTRING_GETTER(getArray, IS_ARRAY);
 PHP_HTTP_QUERYSTRING_GETTER(getObject, IS_OBJECT);
 
 #ifdef PHP_HTTP_HAVE_ICONV
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_xlate, 0, 0, 2)
+       ZEND_ARG_INFO(0, from_encoding)
+       ZEND_ARG_INFO(0, to_encoding)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, xlate)
 {
-       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(runtime)) {
-               char *ie, *oe;
-               int ie_len, oe_len;
-
-               if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss", &ie, &ie_len, &oe, &oe_len)) {
-                       with_error_handling(EH_THROW,  PHP_HTTP_EX_CE(querystring)) {
-                               zval *qa = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
-
-                               if (Z_TYPE_P(qa) != IS_ARRAY) {
-                                       MAKE_STD_ZVAL(qa);
-                                       array_init(qa);
-                                       zend_update_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), qa TSRMLS_CC);
-                                       zval_ptr_dtor(&qa);
-                               } else {
-                                       zval xa;
-
-                                       INIT_PZVAL(&xa);
-                                       array_init(&xa);
-                                       if (SUCCESS == php_http_querystring_xlate(&xa, qa, ie, oe TSRMLS_CC)) {
-                                               zval *ns = NULL, *qs = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryString"), 0 TSRMLS_CC);
-
-                                               /* shitty internal zvals */
-                                               if (Z_TYPE_P(qs) != IS_STRING) {
-                                                       MAKE_STD_ZVAL(qs);
-                                                       ZVAL_EMPTY_STRING(qs);
-                                                       zend_update_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryString"), qs TSRMLS_CC);
-                                                       ns = qs;
-                                               }
+       char *ie, *oe;
+       int ie_len, oe_len;
+       zval *na, *qa;
 
-                                               zend_hash_clean(Z_ARRVAL_P(qa));
-                                               array_copy(Z_ARRVAL(xa), Z_ARRVAL_P(qa));
-                                               php_http_querystring_update(qa, qs TSRMLS_CC);
+       php_http_expect(SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss", &ie, &ie_len, &oe, &oe_len), invalid_arg, return);
 
-                                               if (ns) {
-                                                       zval_ptr_dtor(&ns);
-                                               }
-                                       }
-                                       zval_dtor(&xa);
-                               }
-                               RETVAL_ZVAL(getThis(), 1, 0);
-                       } end_error_handling();
-               }
-       } end_error_handling();
+       MAKE_STD_ZVAL(na);
+       array_init(na);
+       qa = php_http_ztyp(IS_ARRAY, zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC));
+
+       php_http_expect(SUCCESS == php_http_querystring_xlate(na, qa, ie, oe TSRMLS_CC), bad_conversion,
+                       zval_ptr_dtor(&na);
+                       zval_ptr_dtor(&qa);
+                       return;
+       );
+
+       php_http_querystring_set(getThis(), na, 0 TSRMLS_CC);
+       RETVAL_ZVAL(getThis(), 1, 0);
        
+       zval_ptr_dtor(&na);
+       zval_ptr_dtor(&qa);
 }
 #endif /* HAVE_ICONV */
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_serialize, 0, 0, 0)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, serialize)
 {
-       if (SUCCESS == zend_parse_parameters_none()) {
-               RETURN_PROP(php_http_querystring_class_entry, "queryString");
+       if (SUCCESS != zend_parse_parameters_none()) {
+               return;
        }
-       RETURN_FALSE;
+       php_http_querystring_str(getThis(), return_value TSRMLS_CC);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_unserialize, 0, 0, 1)
+       ZEND_ARG_INFO(0, serialized)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, unserialize)
 {
        zval *serialized;
        
-       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(runtime)) {
-               if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &serialized)) {
-                       with_error_handling(EH_THROW, PHP_HTTP_EX_CE(querystring)) {
-                               if (Z_TYPE_P(serialized) == IS_STRING) {
-                                       php_http_querystring_set(getThis(), serialized TSRMLS_CC);
-                               } else {
-                                       php_http_error(HE_WARNING, PHP_HTTP_E_QUERYSTRING, "Expected a string as parameter");
-                               }
-                       } end_error_handling();
-               }
-       } end_error_handling();
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &serialized)) {
+               return;
+       }
+
+       if (Z_TYPE_P(serialized) == IS_STRING) {
+               php_http_querystring_set(getThis(), serialized, 0 TSRMLS_CC);
+       } else {
+               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Expected a string as parameter");
+       }
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_offsetGet, 0, 0, 1)
+       ZEND_ARG_INFO(0, offset)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, offsetGet)
 {
        char *offset_str;
        int offset_len;
-       zval **value;
+       zval **value, *qa;
+
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) {
+               return;
+       }
        
-       if ((SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len))
-       &&      (SUCCESS == zend_hash_find(Z_ARRVAL_P(zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC)), offset_str, offset_len + 1, (void *) &value))
-       ) {
-               RETVAL_ZVAL(*value, 1, 0);
+       qa = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+
+       if (Z_TYPE_P(qa) == IS_ARRAY) {
+               if (SUCCESS == zend_symtable_find(Z_ARRVAL_P(qa), offset_str, offset_len + 1, (void *) &value)) {
+                       RETVAL_ZVAL(*value, 1, 0);
+               }
        }
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_offsetSet, 0, 0, 2)
+       ZEND_ARG_INFO(0, offset)
+       ZEND_ARG_INFO(0, value)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, offsetSet)
 {
        char *offset_str;
        int offset_len;
-       zval *value;
+       zval *value, *param;
        
-       if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sz", &offset_str, &offset_len, &value)) {
-               zval *qarr = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC), *qstr = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryString"), 0 TSRMLS_CC);
-               
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sz", &offset_str, &offset_len, &value)) {
+               return;
+       }
+
+       param = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+
+       if (Z_TYPE_P(param) == IS_ARRAY && zend_symtable_exists(Z_ARRVAL_P(param), offset_str, offset_len + 1)) {
+               Z_ADDREF_P(value);
+               zend_symtable_update(Z_ARRVAL_P(param), offset_str, offset_len + 1, (void *) &value, sizeof(zval *), NULL);
+               Z_ADDREF_P(param);
+       } else {
+               MAKE_STD_ZVAL(param);
+               array_init(param);
                Z_ADDREF_P(value);
-               add_assoc_zval_ex(qarr, offset_str, offset_len + 1, value);
-               php_http_querystring_update(qarr, qstr TSRMLS_CC);
+               add_assoc_zval_ex(param, offset_str, offset_len + 1, value);
        }
+       php_http_querystring_set(getThis(), param, QS_MERGE TSRMLS_CC);
+       zval_ptr_dtor(&param);
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_offsetExists, 0, 0, 1)
+       ZEND_ARG_INFO(0, offset)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, offsetExists)
 {
        char *offset_str;
        int offset_len;
-       zval **value;
+       zval **value, *qa;
+
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) {
+               return;
+       }
        
-       if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) {
-               RETURN_BOOL((SUCCESS == zend_hash_find(Z_ARRVAL_P(zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC)), offset_str, offset_len + 1, (void *) &value)) && (Z_TYPE_PP(value) != IS_NULL));
+       qa = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
+
+       if (Z_TYPE_P(qa) == IS_ARRAY) {
+               if (SUCCESS == zend_symtable_find(Z_ARRVAL_P(qa), offset_str, offset_len + 1, (void *) &value)) {
+                       RETURN_BOOL(Z_TYPE_PP(value) != IS_NULL);
+               }
        }
+       RETURN_FALSE;
 }
 
+ZEND_BEGIN_ARG_INFO_EX(ai_HttpQueryString_offsetUnset, 0, 0, 1)
+       ZEND_ARG_INFO(0, offset)
+ZEND_END_ARG_INFO();
 PHP_METHOD(HttpQueryString, offsetUnset)
 {
        char *offset_str;
        int offset_len;
+       zval *param;
        
-       if (SUCCESS == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) {
-               zval *qarr = zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryArray"), 0 TSRMLS_CC);
-               
-               if (SUCCESS == zend_hash_del(Z_ARRVAL_P(qarr), offset_str, offset_len + 1)) {
-                       php_http_querystring_update(qarr, zend_read_property(php_http_querystring_class_entry, getThis(), ZEND_STRL("queryString"), 0 TSRMLS_CC) TSRMLS_CC);
-               }
+       if (SUCCESS != zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &offset_str, &offset_len)) {
+               return;
        }
+
+       MAKE_STD_ZVAL(param);
+       array_init(param);
+       add_assoc_null_ex(param, offset_str, offset_len + 1);
+       php_http_querystring_set(getThis(), param, QS_MERGE TSRMLS_CC);
+       zval_ptr_dtor(&param);
 }
 
+zend_class_entry *php_http_querystring_class_entry;
+
+static zend_function_entry php_http_querystring_methods[] = {
+       PHP_ME(HttpQueryString, __construct, ai_HttpQueryString___construct, ZEND_ACC_PUBLIC|ZEND_ACC_CTOR|ZEND_ACC_FINAL)
+
+       PHP_ME(HttpQueryString, toArray, ai_HttpQueryString_toArray, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, toString, ai_HttpQueryString_toString, ZEND_ACC_PUBLIC)
+       ZEND_MALIAS(HttpQueryString, __toString, toString, ai_HttpQueryString_toString, ZEND_ACC_PUBLIC)
+
+       PHP_ME(HttpQueryString, get, ai_HttpQueryString_get, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, set, ai_HttpQueryString_set, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, mod, ai_HttpQueryString_mod, ZEND_ACC_PUBLIC)
+
+       PHP_ME(HttpQueryString, getBool, ai_HttpQueryString___getter, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, getInt, ai_HttpQueryString___getter, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, getFloat, ai_HttpQueryString___getter, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, getString, ai_HttpQueryString___getter, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, getArray, ai_HttpQueryString___getter, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, getObject, ai_HttpQueryString___getter, ZEND_ACC_PUBLIC)
+
+       PHP_ME(HttpQueryString, getIterator, ai_HttpQueryString_getIterator, ZEND_ACC_PUBLIC)
+
+       PHP_ME(HttpQueryString, getGlobalInstance, ai_HttpQueryString_getGlobalInstance, ZEND_ACC_PUBLIC|ZEND_ACC_STATIC)
+#ifdef PHP_HTTP_HAVE_ICONV
+       PHP_ME(HttpQueryString, xlate, ai_HttpQueryString_xlate, ZEND_ACC_PUBLIC)
+#endif
+
+       /* Implements Serializable */
+       PHP_ME(HttpQueryString, serialize, ai_HttpQueryString_serialize, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, unserialize, ai_HttpQueryString_unserialize, ZEND_ACC_PUBLIC)
+
+       /* Implements ArrayAccess */
+       PHP_ME(HttpQueryString, offsetGet, ai_HttpQueryString_offsetGet, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, offsetSet, ai_HttpQueryString_offsetSet, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, offsetExists, ai_HttpQueryString_offsetExists, ZEND_ACC_PUBLIC)
+       PHP_ME(HttpQueryString, offsetUnset, ai_HttpQueryString_offsetUnset, ZEND_ACC_PUBLIC)
+
+       EMPTY_FUNCTION_ENTRY
+};
+
+PHP_MINIT_FUNCTION(http_querystring)
+{
+       zend_class_entry ce = {0};
+
+       INIT_NS_CLASS_ENTRY(ce, "http", "QueryString", php_http_querystring_methods);
+       php_http_querystring_class_entry = zend_register_internal_class(&ce TSRMLS_CC);
+       php_http_querystring_class_entry->create_object = php_http_querystring_object_new;
+       zend_class_implements(php_http_querystring_class_entry TSRMLS_CC, 3, zend_ce_serializable, zend_ce_arrayaccess, zend_ce_aggregate);
+
+       zend_declare_property_null(php_http_querystring_class_entry, ZEND_STRL("instance"), (ZEND_ACC_STATIC|ZEND_ACC_PRIVATE) TSRMLS_CC);
+       zend_declare_property_null(php_http_querystring_class_entry, ZEND_STRL("queryArray"), ZEND_ACC_PRIVATE TSRMLS_CC);
+
+       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_BOOL"), PHP_HTTP_QUERYSTRING_TYPE_BOOL TSRMLS_CC);
+       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_INT"), PHP_HTTP_QUERYSTRING_TYPE_INT TSRMLS_CC);
+       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_FLOAT"), PHP_HTTP_QUERYSTRING_TYPE_FLOAT TSRMLS_CC);
+       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_STRING"), PHP_HTTP_QUERYSTRING_TYPE_STRING TSRMLS_CC);
+       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_ARRAY"), PHP_HTTP_QUERYSTRING_TYPE_ARRAY TSRMLS_CC);
+       zend_declare_class_constant_long(php_http_querystring_class_entry, ZEND_STRL("TYPE_OBJECT"), PHP_HTTP_QUERYSTRING_TYPE_OBJECT TSRMLS_CC);
+
+       return SUCCESS;
+}
 
 /*
  * Local variables: