From: Remi Collet Date: Tue, 9 Jul 2024 13:33:22 +0000 (+0200) Subject: Fix tests for 8.4 X-Git-Url: https://git.m6w6.name/?a=commitdiff_plain;h=refs%2Fheads%2Fissue-php84;p=m6w6%2Fext-http Fix tests for 8.4 --- diff --git a/tests/client002.phpt b/tests/client002.phpt index d020f16..8849ae9 100644 --- a/tests/client002.phpt +++ b/tests/client002.phpt @@ -15,7 +15,7 @@ echo "Test\n"; class Observer implements SplObserver { #[ReturnTypeWillChange] - function update(SplSubject $client, http\Client\Request $request = null, StdClass $progress = null) { + function update(SplSubject $client, ?http\Client\Request $request = null, ?StdClass $progress = null) { echo "P"; /* fence against buggy infof() calls in some curl versions */ $compare = $client->getProgressInfo($request); diff --git a/tests/client028.phpt b/tests/client028.phpt index f14fb8e..58adc68 100644 --- a/tests/client028.phpt +++ b/tests/client028.phpt @@ -80,7 +80,7 @@ class UserHandler implements http\Client\Curl\User return count($this->client); } - function wait(int $timeout_ms = null) { + function wait(?int $timeout_ms = null) { echo "W"; if ($timeout_ms === null) { diff --git a/tests/info002.phpt b/tests/info002.phpt index 4d03440..44172b8 100644 --- a/tests/info002.phpt +++ b/tests/info002.phpt @@ -37,13 +37,13 @@ Test http\Exception\BadMessageException: http\Message::__construct(): Failed to parse headers: unexpected character '\057' at pos 4 of 'HTTP/1.1 99 Apples in my Basket' in %sinfo002.php:%d Stack trace: #0 %sinfo002.php(%d): http\Message->__construct('HTTP/1.1 99 App...') -#1 %sinfo002.php(%d): {closure}() +#1 %sinfo002.php(%d): {closur%s}() #2 %sinfo002.php(%d): trap(Object(Closure)) #3 {main} http\Exception\BadMessageException: http\Message::__construct(): Failed to parse headers: unexpected character '\040' at pos 7 of 'CONNECT HTTP/1.1' in %sinfo002.php:%d Stack trace: #0 %sinfo002.php(%d): http\Message->__construct('CONNECT HTTP/1....') -#1 %sinfo002.php(%d): {closure}() +#1 %sinfo002.php(%d): {closur%s}() #2 %sinfo002.php(%d): trap(Object(Closure)) #3 {main} HTTP/1.1 200