From: Monty Taylor <mordred@inaugust.com>
Date: Sun, 14 Jun 2009 21:56:19 +0000 (-0700)
Subject: Removed references to -Wconversion. It's just not stable enough of a warning.
X-Git-Tag: 0.31~14^2~17
X-Git-Url: https://git.m6w6.name/?a=commitdiff_plain;h=afb40b8611b1833f1b776ea94f36eef5c4cfe430;p=m6w6%2Flibmemcached

Removed references to -Wconversion. It's just not stable enough of a warning.
---

diff --git a/configure.ac b/configure.ac
index 8a462aa5..9bb23a28 100644
--- a/configure.ac
+++ b/configure.ac
@@ -206,7 +206,6 @@ AC_ARG_ENABLE([unreachable],
 
 dnl We can't do these two warnings, so turn them off
 W_STRICT_ALIASING="-Wno-strict-aliasing"
-ac_cv_safe_to_use_Wconversion_=no
 
 if test "$GCC" = "yes"
 then
@@ -228,31 +227,6 @@ then
   CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wswitch-default -Wswitch-enum -Wcast-align"
   CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual  -Wnon-virtual-dtor -Wctor-dtor-privacy  -Wold-style-cast -Weffc++ -Wno-long-long"
 
-  AC_CACHE_CHECK([whether it is safe to use -Wconversion],
-    [ac_cv_safe_to_use_Wconversion_],
-    [save_CFLAGS="$CFLAGS"
-     CFLAGS="-Werror -Wconversion"
-     AC_COMPILE_IFELSE(
-       [AC_LANG_PROGRAM(
-         [[
-#include <netinet/in.h>
-void foo(in_port_t port)
-{
-  return;
-}
-         ]],[[
-in_port_t x= 0;
-foo(x);
-         ]])],
-       [ac_cv_safe_to_use_Wconversion_=yes],
-       [ac_cv_safe_to_use_Wconversion_=no])
-     CFLAGS="$save_CFLAGS"])
-  dnl disable -Wconversion for now. Will fix later
-  AS_IF([test "$ac_cv_safe_to_use_Wconversion_" = "yes"],
-        [
-          CC_WARNINGS="${CC_WARNINGS} -Wconversion"
-          CXX_WARNINGS="${CXX_WARNINGS} -Wconversion"
-        ])
 
   AC_CACHE_CHECK([whether it is safe to use -Wlogical-op],
     [ac_cv_safe_to_use_Wlogical_op_],