From: Michael Wallner <mike@php.net>
Date: Mon, 13 Jun 2005 17:02:12 +0000 (+0000)
Subject: - yet better a memleak than a segfault
X-Git-Tag: RELEASE_0_9_0~25
X-Git-Url: https://git.m6w6.name/?a=commitdiff_plain;h=3b8f17486dae1d9a0ea68e4c90efc5db30901a24;p=m6w6%2Fext-http

- yet better a memleak than a segfault
---

diff --git a/http_request_object.c b/http_request_object.c
index bc2cfa0..8343507 100644
--- a/http_request_object.c
+++ b/http_request_object.c
@@ -301,7 +301,7 @@ STATUS _http_request_object_responsehandler(http_request_object *obj, zval *this
 	if (msg = http_message_parse(PHPSTR_VAL(&obj->response), PHPSTR_LEN(&obj->response))) {
 		char *body;
 		size_t body_len;
-		zval *headers, *message = GET_PROP(obj, responseMessage), *resp = GET_PROP(obj, responseData), *info = GET_PROP(obj, responseInfo);
+		zval *headers, *message, *resp = GET_PROP(obj, responseData), *info = GET_PROP(obj, responseInfo);
 
 		UPD_PROP(obj, long, responseCode, msg->info.response.code);
 
@@ -314,6 +314,8 @@ STATUS _http_request_object_responsehandler(http_request_object *obj, zval *this
 		add_assoc_zval(resp, "headers", headers);
 		add_assoc_stringl(resp, "body", body, body_len, 0);
 
+		/* XXX */
+		MAKE_STD_ZVAL(message);
 		Z_TYPE_P(message)  = IS_OBJECT;
 		message->value.obj = http_message_object_from_msg(msg);
 		SET_PROP(obj, responseMessage, message);