X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=tests%2Fmemdump.cc;h=ab59c3ce245a594a535fb83dd44e7ae22e0216ca;hb=8c44ea2a34b6cedf545fd07a568bddad74e9b69e;hp=6f9330a536e0d46a2fbd6953eb424ee7ec90e59a;hpb=fed85d3c429c3881cd378d10e4dccd30f4fd2478;p=awesomized%2Flibmemcached diff --git a/tests/memdump.cc b/tests/memdump.cc index 6f9330a5..ab59c3ce 100644 --- a/tests/memdump.cc +++ b/tests/memdump.cc @@ -39,10 +39,10 @@ Test that we are cycling the servers we are creating during testing. */ -#include +#include #include -#include +#include using namespace libtest; @@ -67,7 +67,7 @@ static test_return_t server_test(void *) snprintf(buffer, sizeof(buffer), "--servers=localhost:%d", int(default_port())); const char *args[]= { buffer, 0 }; - test_compare(EXIT_SUCCESS, exec_cmdline(executable, args, true)); + test_true(exec_cmdline(executable, args, true) <= EXIT_FAILURE); return TEST_SUCCESS; } @@ -75,10 +75,10 @@ static test_return_t server_test(void *) static test_return_t FOUND_test(void *) { char buffer[1024]; - snprintf(buffer, sizeof(buffer), "--server=localhost:%d", int(default_port())); + int length= snprintf(buffer, sizeof(buffer), "--server=localhost:%d", int(default_port())); const char *args[]= { buffer, 0 }; - memcached_st *memc= memcached(buffer, strlen(buffer)); + memcached_st *memc= memcached(buffer, length); test_true(memc); test_compare(MEMCACHED_SUCCESS, @@ -91,7 +91,8 @@ static test_return_t FOUND_test(void *) test_null(memcached_get(memc, test_literal_param("foo"), 0, 0, &rc)); test_compare(MEMCACHED_SUCCESS, rc); - test_compare(EXIT_SUCCESS, exec_cmdline(executable, args, true)); + length= snprintf(buffer, sizeof(buffer), "--servers=localhost:%d", int(default_port())); + test_true(exec_cmdline(executable, args, true) <= EXIT_FAILURE); memcached_free(memc); @@ -110,18 +111,11 @@ collection_st collection[] ={ {0, 0, 0, 0} }; -static void *world_create(server_startup_st& servers, test_return_t& error) +static void *world_create(server_startup_st& servers, test_return_t&) { - if (libtest::has_memcached() == false) - { - error= TEST_SKIPPED; - return NULL; - } - - if (server_startup(servers, "memcached", libtest::default_port(), 0, NULL) == false) - { - error= TEST_FAILURE; - } + SKIP_UNLESS(libtest::has_memcached()); + + ASSERT_TRUE(server_startup(servers, "memcached", libtest::default_port(), NULL)); return &servers; }