X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=tests%2Fmem_functions.c;h=48b254dbfcf921de08f853e0af9cd2d303e04961;hb=6c2bd52dfa24287c856b0b679270b7f7681333a5;hp=04d7e21e2a21c73d68ae5fd5f0460294488051aa;hpb=85062bec3fe9000e4da8e0a08cea88ebbccc20b2;p=awesomized%2Flibmemcached diff --git a/tests/mem_functions.c b/tests/mem_functions.c index 04d7e21e..48b254db 100644 --- a/tests/mem_functions.c +++ b/tests/mem_functions.c @@ -10,10 +10,11 @@ Sample test application. */ -#include "libmemcached/common.h" +#include "config.h" #include #include +#include #include #include #include @@ -22,20 +23,18 @@ #include #include #include + +#include "libmemcached/common.h" + #include "server.h" #include "clients/generator.h" #include "clients/execute.h" -#ifndef INT64_MAX -#define INT64_MAX LONG_MAX -#endif -#ifndef INT32_MAX -#define INT32_MAX INT_MAX -#endif - +#define SMALL_STRING_LEN 1024 #include "test.h" + #ifdef HAVE_LIBMEMCACHEDUTIL #include #include "libmemcached/memcached_util.h" @@ -52,9 +51,14 @@ static pairs_st *global_pairs; static const char *global_keys[GLOBAL_COUNT]; static size_t global_keys_length[GLOBAL_COUNT]; -static test_return_t init_test(memcached_st *not_used __attribute__((unused))) +// Prototype +static test_return_t pre_binary(memcached_st *memc); + + +static test_return_t init_test(memcached_st *not_used) { memcached_st memc; + (void)not_used; (void)memcached_create(&memc); memcached_free(&memc); @@ -62,55 +66,80 @@ static test_return_t init_test(memcached_st *not_used __attribute__((unused))) return TEST_SUCCESS; } -static test_return_t server_list_null_test(memcached_st *ptr __attribute__((unused))) +static test_return_t server_list_null_test(memcached_st *ptr) { memcached_server_st *server_list; memcached_return_t rc; + (void)ptr; server_list= memcached_server_list_append_with_weight(NULL, NULL, 0, 0, NULL); - test_truth(server_list == NULL); + test_true(server_list == NULL); server_list= memcached_server_list_append_with_weight(NULL, "localhost", 0, 0, NULL); - test_truth(server_list == NULL); + test_true(server_list == NULL); server_list= memcached_server_list_append_with_weight(NULL, NULL, 0, 0, &rc); - test_truth(server_list == NULL); + test_true(server_list == NULL); return TEST_SUCCESS; } #define TEST_PORT_COUNT 7 -uint32_t test_ports[TEST_PORT_COUNT]; +in_port_t test_ports[TEST_PORT_COUNT]; -static memcached_return_t server_display_function(memcached_st *ptr __attribute__((unused)), memcached_server_st *server, void *context) +static memcached_return_t server_display_function(const memcached_st *ptr, + const memcached_server_st *server, + void *context) { /* Do Nothing */ - uint32_t bigger= *((uint32_t *)(context)); - assert(bigger <= server->port); - *((uint32_t *)(context))= server->port; + size_t bigger= *((size_t *)(context)); + (void)ptr; + assert(bigger <= memcached_server_port(server)); + *((size_t *)(context))= memcached_server_port(server); return MEMCACHED_SUCCESS; } -static test_return_t server_sort_test(memcached_st *ptr __attribute__((unused))) +static memcached_return_t dump_server_information(const memcached_st *ptr, + const memcached_server_st *instance, + void *context) { - uint32_t x; - uint32_t bigger= 0; /* Prime the value for the test_truth in server_display_function */ + /* Do Nothing */ + FILE *stream= (FILE *)context; + (void)ptr; + + fprintf(stream, "Memcached Server: %s %u Version %u.%u.%u\n", + memcached_server_name(instance), + memcached_server_port(instance), + instance->major_version, + instance->minor_version, + instance->micro_version); + + return MEMCACHED_SUCCESS; +} + +static test_return_t server_sort_test(memcached_st *ptr) +{ + size_t bigger= 0; /* Prime the value for the test_true in server_display_function */ + memcached_return_t rc; memcached_server_fn callbacks[1]; memcached_st *local_memc; + (void)ptr; local_memc= memcached_create(NULL); - test_truth(local_memc); + test_true(local_memc); memcached_behavior_set(local_memc, MEMCACHED_BEHAVIOR_SORT_HOSTS, 1); - for (x= 0; x < TEST_PORT_COUNT; x++) + for (size_t x= 0; x < TEST_PORT_COUNT; x++) { - test_ports[x]= (uint32_t)random() % 64000; + test_ports[x]= (in_port_t)random() % 64000; rc= memcached_server_add_with_weight(local_memc, "localhost", test_ports[x], 0); - test_truth(memcached_server_count(local_memc) == x + 1); - test_truth(memcached_servers_count(local_memc->hosts) == x+1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(memcached_server_count(local_memc) == x + 1); +#if 0 // Rewrite + test_true(memcached_server_list_count(memcached_server_list(local_memc)) == x+1); +#endif + test_true(rc == MEMCACHED_SUCCESS); } callbacks[0]= server_display_function; @@ -122,26 +151,33 @@ static test_return_t server_sort_test(memcached_st *ptr __attribute__((unused)) return TEST_SUCCESS; } -static test_return_t server_sort2_test(memcached_st *ptr __attribute__((unused))) +static test_return_t server_sort2_test(memcached_st *ptr) { - uint32_t bigger= 0; /* Prime the value for the test_truth in server_display_function */ + size_t bigger= 0; /* Prime the value for the test_true in server_display_function */ memcached_return_t rc; memcached_server_fn callbacks[1]; memcached_st *local_memc; + memcached_server_instance_st instance; + (void)ptr; local_memc= memcached_create(NULL); - test_truth(local_memc); + test_true(local_memc); rc= memcached_behavior_set(local_memc, MEMCACHED_BEHAVIOR_SORT_HOSTS, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_server_add_with_weight(local_memc, "MEMCACHED_BEHAVIOR_SORT_HOSTS", 43043, 0); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(local_memc->hosts[0].port == 43043); + test_true(rc == MEMCACHED_SUCCESS); + instance= memcached_server_instance_by_position(local_memc, 0); + test_true(memcached_server_port(instance) == 43043); rc= memcached_server_add_with_weight(local_memc, "MEMCACHED_BEHAVIOR_SORT_HOSTS", 43042, 0); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(local_memc->hosts[0].port == 43042); - test_truth(local_memc->hosts[1].port == 43043); + test_true(rc == MEMCACHED_SUCCESS); + + instance= memcached_server_instance_by_position(local_memc, 0); + test_true(memcached_server_port(instance) == 43042); + + instance= memcached_server_instance_by_position(local_memc, 1); + test_true(memcached_server_port(instance) == 43043); callbacks[0]= server_display_function; memcached_server_cursor(local_memc, callbacks, (void *)&bigger, 1); @@ -152,10 +188,54 @@ static test_return_t server_sort2_test(memcached_st *ptr __attribute__((unused) return TEST_SUCCESS; } -static memcached_return_t server_display_unsort_function(memcached_st *ptr __attribute__((unused)), memcached_server_st *server, void *context) +static memcached_return_t server_print_callback(const memcached_st *ptr, + const memcached_server_st *server, + void *context) +{ + (void)server; // Just in case we aren't printing. + (void)ptr; + (void)context; + +#if 0 + fprintf(stderr, "%s(%d)", memcached_server_name(server), memcached_server_port(server)); +#endif + + return MEMCACHED_SUCCESS; +} + +static test_return_t memcached_server_remove_test(memcached_st *ptr) +{ + memcached_return_t rc; + memcached_st local_memc; + memcached_st *memc; + memcached_server_st *servers; + memcached_server_fn callbacks[1]; + + const char *server_string= "localhost:4444, localhost:4445, localhost:4446, localhost:4447, localhost, memcache1.memcache.bk.sapo.pt:11211, memcache1.memcache.bk.sapo.pt:11212, memcache1.memcache.bk.sapo.pt:11213, memcache1.memcache.bk.sapo.pt:11214, memcache2.memcache.bk.sapo.pt:11211, memcache2.memcache.bk.sapo.pt:11212, memcache2.memcache.bk.sapo.pt:11213, memcache2.memcache.bk.sapo.pt:11214"; + (void)ptr; + + memc= memcached_create(&local_memc); + + servers= memcached_servers_parse(server_string); + + rc= memcached_server_push(memc, servers); + memcached_server_list_free(servers); + + callbacks[0]= server_print_callback; + memcached_server_cursor(memc, callbacks, NULL, 1); + + memcached_free(memc); + + return TEST_SUCCESS; +} + +static memcached_return_t server_display_unsort_function(const memcached_st *ptr, + const memcached_server_st *server, + void *context) { /* Do Nothing */ uint32_t x= *((uint32_t *)(context)); + (void)ptr; assert(test_ports[x] == server->port); *((uint32_t *)(context))= ++x; @@ -163,25 +243,27 @@ static memcached_return_t server_display_unsort_function(memcached_st *ptr __att return MEMCACHED_SUCCESS; } -static test_return_t server_unsort_test(memcached_st *ptr __attribute__((unused))) +static test_return_t server_unsort_test(memcached_st *ptr) { - uint32_t x; - uint32_t counter= 0; /* Prime the value for the test_truth in server_display_function */ - uint32_t bigger= 0; /* Prime the value for the test_truth in server_display_function */ + size_t counter= 0; /* Prime the value for the test_true in server_display_function */ + size_t bigger= 0; /* Prime the value for the test_true in server_display_function */ memcached_return_t rc; memcached_server_fn callbacks[1]; memcached_st *local_memc; + (void)ptr; local_memc= memcached_create(NULL); - test_truth(local_memc); + test_true(local_memc); - for (x= 0; x < TEST_PORT_COUNT; x++) + for (size_t x= 0; x < TEST_PORT_COUNT; x++) { - test_ports[x]= (uint32_t)(random() % 64000); + test_ports[x]= (in_port_t)(random() % 64000); rc= memcached_server_add_with_weight(local_memc, "localhost", test_ports[x], 0); - test_truth(memcached_server_count(local_memc) == x+1); - test_truth(memcached_servers_count(local_memc->hosts) == x+1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(memcached_server_count(local_memc) == x+1); +#if 0 // Rewrite + test_true(memcached_server_list_count(memcached_server_list(local_memc)) == x+1); +#endif + test_true(rc == MEMCACHED_SUCCESS); } callbacks[0]= server_display_unsort_function; @@ -198,23 +280,24 @@ static test_return_t server_unsort_test(memcached_st *ptr __attribute__((unused return TEST_SUCCESS; } -static test_return_t allocation_test(memcached_st *not_used __attribute__((unused))) +static test_return_t allocation_test(memcached_st *not_used) { + (void)not_used; memcached_st *memc; memc= memcached_create(NULL); - test_truth(memc); + test_true(memc); memcached_free(memc); return TEST_SUCCESS; } -static test_return_t clone_test(memcached_st *memc) +static test_return_t clone_test(memcached_st *memc) { /* All null? */ { memcached_st *memc_clone; memc_clone= memcached_clone(NULL, NULL); - test_truth(memc_clone); + test_true(memc_clone); memcached_free(memc_clone); } @@ -222,48 +305,51 @@ static test_return_t clone_test(memcached_st *memc) { memcached_st *memc_clone; memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone); - - test_truth(memc_clone->call_free == memc->call_free); - test_truth(memc_clone->call_malloc == memc->call_malloc); - test_truth(memc_clone->call_realloc == memc->call_realloc); - test_truth(memc_clone->call_calloc == memc->call_calloc); - test_truth(memc_clone->connect_timeout == memc->connect_timeout); - test_truth(memc_clone->delete_trigger == memc->delete_trigger); - test_truth(memc_clone->distribution == memc->distribution); + test_true(memc_clone); + + { // Test allocators + test_true(memc_clone->allocators.free == memc->allocators.free); + test_true(memc_clone->allocators.malloc == memc->allocators.malloc); + test_true(memc_clone->allocators.realloc == memc->allocators.realloc); + test_true(memc_clone->allocators.calloc == memc->allocators.calloc); + } + + test_true(memc_clone->connect_timeout == memc->connect_timeout); + test_true(memc_clone->delete_trigger == memc->delete_trigger); + test_true(memc_clone->distribution == memc->distribution); { // Test all of the flags - test_truth(memc_clone->flags.no_block == memc->flags.no_block); - test_truth(memc_clone->flags.tcp_nodelay == memc->flags.tcp_nodelay); - test_truth(memc_clone->flags.reuse_memory == memc->flags.reuse_memory); - test_truth(memc_clone->flags.use_cache_lookups == memc->flags.use_cache_lookups); - test_truth(memc_clone->flags.support_cas == memc->flags.support_cas); - test_truth(memc_clone->flags.buffer_requests == memc->flags.buffer_requests); - test_truth(memc_clone->flags.use_sort_hosts == memc->flags.use_sort_hosts); - test_truth(memc_clone->flags.verify_key == memc->flags.verify_key); - test_truth(memc_clone->flags.ketama_weighted == memc->flags.ketama_weighted); - test_truth(memc_clone->flags.binary_protocol == memc->flags.binary_protocol); - test_truth(memc_clone->flags.hash_with_prefix_key == memc->flags.hash_with_prefix_key); - test_truth(memc_clone->flags.no_reply == memc->flags.no_reply); - test_truth(memc_clone->flags.use_udp == memc->flags.use_udp); - test_truth(memc_clone->flags.auto_eject_hosts == memc->flags.auto_eject_hosts); - test_truth(memc_clone->flags.randomize_replica_read == memc->flags.randomize_replica_read); + test_true(memc_clone->flags.no_block == memc->flags.no_block); + test_true(memc_clone->flags.tcp_nodelay == memc->flags.tcp_nodelay); + test_true(memc_clone->flags.reuse_memory == memc->flags.reuse_memory); + test_true(memc_clone->flags.use_cache_lookups == memc->flags.use_cache_lookups); + test_true(memc_clone->flags.support_cas == memc->flags.support_cas); + test_true(memc_clone->flags.buffer_requests == memc->flags.buffer_requests); + test_true(memc_clone->flags.use_sort_hosts == memc->flags.use_sort_hosts); + test_true(memc_clone->flags.verify_key == memc->flags.verify_key); + test_true(memc_clone->flags.ketama_weighted == memc->flags.ketama_weighted); + test_true(memc_clone->flags.binary_protocol == memc->flags.binary_protocol); + test_true(memc_clone->flags.hash_with_prefix_key == memc->flags.hash_with_prefix_key); + test_true(memc_clone->flags.no_reply == memc->flags.no_reply); + test_true(memc_clone->flags.use_udp == memc->flags.use_udp); + test_true(memc_clone->flags.auto_eject_hosts == memc->flags.auto_eject_hosts); + test_true(memc_clone->flags.randomize_replica_read == memc->flags.randomize_replica_read); } - test_truth(memc_clone->get_key_failure == memc->get_key_failure); - test_truth(memc_clone->hash == memc->hash); - test_truth(memc_clone->distribution_hash == memc->distribution_hash); - test_truth(memc_clone->io_bytes_watermark == memc->io_bytes_watermark); - test_truth(memc_clone->io_msg_watermark == memc->io_msg_watermark); - test_truth(memc_clone->io_key_prefetch == memc->io_key_prefetch); - test_truth(memc_clone->on_cleanup == memc->on_cleanup); - test_truth(memc_clone->on_clone == memc->on_clone); - test_truth(memc_clone->poll_timeout == memc->poll_timeout); - test_truth(memc_clone->rcv_timeout == memc->rcv_timeout); - test_truth(memc_clone->recv_size == memc->recv_size); - test_truth(memc_clone->retry_timeout == memc->retry_timeout); - test_truth(memc_clone->send_size == memc->send_size); - test_truth(memc_clone->server_failure_limit == memc->server_failure_limit); - test_truth(memc_clone->snd_timeout == memc->snd_timeout); - test_truth(memc_clone->user_data == memc->user_data); + test_true(memc_clone->get_key_failure == memc->get_key_failure); + test_true(hashkit_compare(&memc_clone->hashkit, &memc->hashkit)); + test_true(hashkit_compare(&memc_clone->distribution_hashkit, &memc->distribution_hashkit)); + test_true(memc_clone->io_bytes_watermark == memc->io_bytes_watermark); + test_true(memc_clone->io_msg_watermark == memc->io_msg_watermark); + test_true(memc_clone->io_key_prefetch == memc->io_key_prefetch); + test_true(memc_clone->on_cleanup == memc->on_cleanup); + test_true(memc_clone->on_clone == memc->on_clone); + test_true(memc_clone->poll_timeout == memc->poll_timeout); + test_true(memc_clone->rcv_timeout == memc->rcv_timeout); + test_true(memc_clone->recv_size == memc->recv_size); + test_true(memc_clone->retry_timeout == memc->retry_timeout); + test_true(memc_clone->send_size == memc->send_size); + test_true(memc_clone->server_failure_limit == memc->server_failure_limit); + test_true(memc_clone->snd_timeout == memc->snd_timeout); + test_true(memc_clone->user_data == memc->user_data); memcached_free(memc_clone); } @@ -274,7 +360,7 @@ static test_return_t clone_test(memcached_st *memc) memcached_st *memc_clone; memset(&declared_clone, 0 , sizeof(memcached_st)); memc_clone= memcached_clone(&declared_clone, NULL); - test_truth(memc_clone); + test_true(memc_clone); memcached_free(memc_clone); } @@ -284,7 +370,7 @@ static test_return_t clone_test(memcached_st *memc) memcached_st *memc_clone; memset(&declared_clone, 0 , sizeof(memcached_st)); memc_clone= memcached_clone(&declared_clone, memc); - test_truth(memc_clone); + test_true(memc_clone); memcached_free(memc_clone); } @@ -294,24 +380,24 @@ static test_return_t clone_test(memcached_st *memc) static test_return_t userdata_test(memcached_st *memc) { void* foo= NULL; - test_truth(memcached_set_user_data(memc, foo) == NULL); - test_truth(memcached_get_user_data(memc) == foo); - test_truth(memcached_set_user_data(memc, NULL) == foo); + test_true(memcached_set_user_data(memc, foo) == NULL); + test_true(memcached_get_user_data(memc) == foo); + test_true(memcached_set_user_data(memc, NULL) == foo); return TEST_SUCCESS; } -static test_return_t connection_test(memcached_st *memc) +static test_return_t connection_test(memcached_st *memc) { memcached_return_t rc; rc= memcached_server_add_with_weight(memc, "localhost", 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); return TEST_SUCCESS; } -static test_return_t error_test(memcached_st *memc) +static test_return_t error_test(memcached_st *memc) { memcached_return_t rc; uint32_t values[] = { 851992627U, 2337886783U, 3196981036U, 4001849190U, @@ -323,23 +409,29 @@ static test_return_t error_test(memcached_st *memc) 4269430871U, 610793021U, 527273862U, 1437122909U, 2300930706U, 2943759320U, 674306647U, 2400528935U, 54481931U, 4186304426U, 1741088401U, 2979625118U, - 4159057246U, 3425930182U, 2593724503U}; + 4159057246U, 3425930182U, 2593724503U, 1868899624U, + 1769812374U, 2302537950U, 1110330676U }; // You have updated the memcache_error messages but not updated docs/tests. - test_truth(MEMCACHED_MAXIMUM_RETURN == 39); + test_true(MEMCACHED_MAXIMUM_RETURN == 43); for (rc= MEMCACHED_SUCCESS; rc < MEMCACHED_MAXIMUM_RETURN; rc++) { uint32_t hash_val; const char *msg= memcached_strerror(memc, rc); hash_val= memcached_generate_hash_value(msg, strlen(msg), MEMCACHED_HASH_JENKINS); - test_truth(values[rc] == hash_val); + if (values[rc] != hash_val) + { + fprintf(stderr, "\n\nYou have updated memcached_return_t without updating the error_test\n"); + fprintf(stderr, "%u, %s, (%u)\n\n", (uint32_t)rc, memcached_strerror(memc, rc), hash_val); + } + test_true(values[rc] == hash_val); } return TEST_SUCCESS; } -static test_return_t set_test(memcached_st *memc) +static test_return_t set_test(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -348,12 +440,12 @@ static test_return_t set_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); return TEST_SUCCESS; } -static test_return_t append_test(memcached_st *memc) +static test_return_t append_test(memcached_st *memc) { memcached_return_t rc; const char *key= "fig"; @@ -363,80 +455,77 @@ static test_return_t append_test(memcached_st *memc) uint32_t flags; rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_set(memc, key, strlen(key), in_value, strlen(in_value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_append(memc, key, strlen(key), " the", strlen(" the"), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_append(memc, key, strlen(key), " people", strlen(" people"), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); out_value= memcached_get(memc, key, strlen(key), &value_length, &flags, &rc); - test_truth(!memcmp(out_value, "we the people", strlen("we the people"))); - test_truth(strlen("we the people") == value_length); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(!memcmp(out_value, "we the people", strlen("we the people"))); + test_true(strlen("we the people") == value_length); + test_true(rc == MEMCACHED_SUCCESS); free(out_value); return TEST_SUCCESS; } -static test_return_t append_binary_test(memcached_st *memc) +static test_return_t append_binary_test(memcached_st *memc) { memcached_return_t rc; const char *key= "numbers"; - unsigned int *store_ptr; - unsigned int store_list[] = { 23, 56, 499, 98, 32847, 0 }; - char *value; + uint32_t store_list[] = { 23, 56, 499, 98, 32847, 0 }; + uint32_t *value; size_t value_length; uint32_t flags; - unsigned int x; + uint32_t x; rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_set(memc, key, strlen(key), NULL, 0, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); for (x= 0; store_list[x] ; x++) { rc= memcached_append(memc, key, strlen(key), - (char *)&store_list[x], sizeof(unsigned int), + (char *)&store_list[x], sizeof(uint32_t), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } - value= memcached_get(memc, key, strlen(key), + value= (uint32_t *)memcached_get(memc, key, strlen(key), &value_length, &flags, &rc); - test_truth((value_length == (sizeof(unsigned int) * x))); - test_truth(rc == MEMCACHED_SUCCESS); + test_true((value_length == (sizeof(uint32_t) * x))); + test_true(rc == MEMCACHED_SUCCESS); - store_ptr= (unsigned int *)value; - x= 0; - while ((size_t)store_ptr < (size_t)(value + value_length)) + for (uint32_t counter= x, *ptr= value; counter; counter--) { - test_truth(*store_ptr == store_list[x++]); - store_ptr++; + test_true(*ptr == store_list[x - counter]); + ptr++; } free(value); return TEST_SUCCESS; } -static test_return_t cas2_test(memcached_st *memc) +static test_return_t cas2_test(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"fudge", "son", "food"}; @@ -449,7 +538,7 @@ static test_return_t cas2_test(memcached_st *memc) unsigned int set= 1; rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS, set); @@ -458,7 +547,7 @@ static test_return_t cas2_test(memcached_st *memc) rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } rc= memcached_mget(memc, keys, key_length, 3); @@ -466,21 +555,21 @@ static test_return_t cas2_test(memcached_st *memc) results= memcached_result_create(memc, &results_obj); results= memcached_fetch_result(memc, &results_obj, &rc); - test_truth(results); - test_truth(results->cas); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_result_cas(results)); + test_true(results); + test_true(results->item_cas); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_result_cas(results)); - test_truth(!memcmp(value, "we the people", strlen("we the people"))); - test_truth(strlen("we the people") == value_length); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(!memcmp(value, "we the people", strlen("we the people"))); + test_true(strlen("we the people") == value_length); + test_true(rc == MEMCACHED_SUCCESS); memcached_result_free(&results_obj); return TEST_SUCCESS; } -static test_return_t cas_test(memcached_st *memc) +static test_return_t cas_test(memcached_st *memc) { memcached_return_t rc; const char *key= "fun"; @@ -497,50 +586,50 @@ static test_return_t cas_test(memcached_st *memc) unsigned int set= 1; rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS, set); rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_mget(memc, keys, keylengths, 1); results= memcached_result_create(memc, &results_obj); results= memcached_fetch_result(memc, &results_obj, &rc); - test_truth(results); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_result_cas(results)); - test_truth(!memcmp(value, memcached_result_value(results), value_length)); - test_truth(strlen(memcached_result_value(results)) == value_length); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(results); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_result_cas(results)); + test_true(!memcmp(value, memcached_result_value(results), value_length)); + test_true(strlen(memcached_result_value(results)) == value_length); + test_true(rc == MEMCACHED_SUCCESS); uint64_t cas = memcached_result_cas(results); - #if 0 +#if 0 results= memcached_fetch_result(memc, &results_obj, &rc); - test_truth(rc == MEMCACHED_END); - test_truth(results == NULL); + test_true(rc == MEMCACHED_END); + test_true(results == NULL); #endif rc= memcached_cas(memc, key, key_length, value2, value2_length, 0, 0, cas); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); /* * The item will have a new cas value, so try to set it again with the old * value. This should fail! */ rc= memcached_cas(memc, key, key_length, value2, value2_length, 0, 0, cas); - test_truth(rc == MEMCACHED_DATA_EXISTS); + test_true(rc == MEMCACHED_DATA_EXISTS); memcached_result_free(&results_obj); return TEST_SUCCESS; } -static test_return_t prepend_test(memcached_st *memc) +static test_return_t prepend_test(memcached_st *memc) { memcached_return_t rc; const char *key= "fig"; @@ -550,28 +639,28 @@ static test_return_t prepend_test(memcached_st *memc) uint32_t flags; rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_prepend(memc, key, strlen(key), "the ", strlen("the "), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_prepend(memc, key, strlen(key), "we ", strlen("we "), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); out_value= memcached_get(memc, key, strlen(key), &value_length, &flags, &rc); - test_truth(!memcmp(out_value, "we the people", strlen("we the people"))); - test_truth(strlen("we the people") == value_length); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(!memcmp(out_value, "we the people", strlen("we the people"))); + test_true(strlen("we the people") == value_length); + test_true(rc == MEMCACHED_SUCCESS); free(out_value); return TEST_SUCCESS; @@ -581,7 +670,7 @@ static test_return_t prepend_test(memcached_st *memc) Set the value, then quit to make sure it is flushed. Come back in and test that add fails. */ -static test_return_t add_test(memcached_st *memc) +static test_return_t add_test(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -593,7 +682,7 @@ static test_return_t add_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); memcached_quit(memc); rc= memcached_add(memc, key, strlen(key), value, strlen(value), @@ -602,11 +691,11 @@ static test_return_t add_test(memcached_st *memc) /* Too many broken OS'es have broken loopback in async, so we can't be sure of the result */ if (setting_value) { - test_truth(rc == MEMCACHED_NOTSTORED || rc == MEMCACHED_STORED); + test_true(rc == MEMCACHED_NOTSTORED || rc == MEMCACHED_STORED); } else { - test_truth(rc == MEMCACHED_NOTSTORED || rc == MEMCACHED_DATA_EXISTS); + test_true(rc == MEMCACHED_NOTSTORED || rc == MEMCACHED_DATA_EXISTS); } return TEST_SUCCESS; @@ -619,9 +708,8 @@ static test_return_t add_test(memcached_st *memc) ** because the connects starts to time out (the test doesn't do much ** anyway, so just loop 10 iterations) */ -static test_return_t add_wrapper(memcached_st *memc) +static test_return_t add_wrapper(memcached_st *memc) { - unsigned int x; unsigned int max= 10000; #ifdef __sun max= 10; @@ -630,13 +718,13 @@ static test_return_t add_wrapper(memcached_st *memc) max= 10; #endif - for (x= 0; x < max; x++) + for (uint32_t x= 0; x < max; x++) add_test(memc); return TEST_SUCCESS; } -static test_return_t replace_test(memcached_st *memc) +static test_return_t replace_test(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -646,17 +734,17 @@ static test_return_t replace_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), original, strlen(original), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_replace(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); return TEST_SUCCESS; } -static test_return_t delete_test(memcached_st *memc) +static test_return_t delete_test(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -665,34 +753,35 @@ static test_return_t delete_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_delete(memc, key, strlen(key), (time_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); return TEST_SUCCESS; } -static test_return_t flush_test(memcached_st *memc) +static test_return_t flush_test(memcached_st *memc) { memcached_return_t rc; rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); return TEST_SUCCESS; } -static memcached_return_t server_function(memcached_st *ptr __attribute__((unused)), - memcached_server_st *server __attribute__((unused)), - void *context __attribute__((unused))) +static memcached_return_t server_function(const memcached_st *ptr, + const memcached_server_st *server, + void *context) { + (void)ptr; (void)server; (void)context; /* Do Nothing */ return MEMCACHED_SUCCESS; } -static test_return_t memcached_server_cursor_test(memcached_st *memc) +static test_return_t memcached_server_cursor_test(memcached_st *memc) { char context[8]; strcpy(context, "foo bad"); @@ -703,7 +792,7 @@ static test_return_t memcached_server_cursor_test(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t bad_key_test(memcached_st *memc) +static test_return_t bad_key_test(memcached_st *memc) { memcached_return_t rc; const char *key= "foo bad"; @@ -719,41 +808,41 @@ static test_return_t bad_key_test(memcached_st *memc) return TEST_SKIPPED; memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone); + test_true(memc_clone); rc= memcached_behavior_set(memc_clone, MEMCACHED_BEHAVIOR_VERIFY_KEY, set); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); /* All keys are valid in the binary protocol (except for length) */ if (memcached_behavior_get(memc_clone, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) == 0) { string= memcached_get(memc_clone, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); - test_truth(string_length == 0); - test_truth(!string); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(string_length == 0); + test_true(!string); set= 0; rc= memcached_behavior_set(memc_clone, MEMCACHED_BEHAVIOR_VERIFY_KEY, set); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); string= memcached_get(memc_clone, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_NOTFOUND); - test_truth(string_length == 0); - test_truth(!string); + test_true(rc == MEMCACHED_NOTFOUND); + test_true(string_length == 0); + test_true(!string); /* Test multi key for bad keys */ const char *keys[] = { "GoodKey", "Bad Key", "NotMine" }; size_t key_lengths[] = { 7, 7, 7 }; set= 1; rc= memcached_behavior_set(memc_clone, MEMCACHED_BEHAVIOR_VERIFY_KEY, set); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_mget(memc_clone, keys, key_lengths, 3); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); rc= memcached_mget_by_key(memc_clone, "foo daddy", 9, keys, key_lengths, 1); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); max_keylen= 250; @@ -762,7 +851,7 @@ static test_return_t bad_key_test(memcached_st *memc) binary protocol */ rc= memcached_callback_set(memc_clone, MEMCACHED_CALLBACK_PREFIX_KEY, NULL); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); char *longkey= malloc(max_keylen + 1); if (longkey != NULL) @@ -770,15 +859,15 @@ static test_return_t bad_key_test(memcached_st *memc) memset(longkey, 'a', max_keylen + 1); string= memcached_get(memc_clone, longkey, max_keylen, &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_NOTFOUND); - test_truth(string_length == 0); - test_truth(!string); + test_true(rc == MEMCACHED_NOTFOUND); + test_true(string_length == 0); + test_true(!string); string= memcached_get(memc_clone, longkey, max_keylen + 1, &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); - test_truth(string_length == 0); - test_truth(!string); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(string_length == 0); + test_true(!string); free(longkey); } @@ -787,12 +876,12 @@ static test_return_t bad_key_test(memcached_st *memc) /* Make sure zero length keys are marked as bad */ set= 1; rc= memcached_behavior_set(memc_clone, MEMCACHED_BEHAVIOR_VERIFY_KEY, set); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); string= memcached_get(memc_clone, key, 0, &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); - test_truth(string_length == 0); - test_truth(!string); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(string_length == 0); + test_true(!string); memcached_free(memc_clone); @@ -800,12 +889,12 @@ static test_return_t bad_key_test(memcached_st *memc) } #define READ_THROUGH_VALUE "set for me" -static memcached_return_t read_through_trigger(memcached_st *memc __attribute__((unused)), - char *key __attribute__((unused)), - size_t key_length __attribute__((unused)), +static memcached_return_t read_through_trigger(memcached_st *memc, + char *key, + size_t key_length, memcached_result_st *result) { - + (void)memc;(void)key;(void)key_length; return memcached_result_set_value(result, READ_THROUGH_VALUE, strlen(READ_THROUGH_VALUE)); } @@ -821,43 +910,44 @@ static test_return_t read_through(memcached_st *memc) string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(rc == MEMCACHED_NOTFOUND); test_false(string_length); test_false(string); rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_GET_FAILURE, *(void **)&cb); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(string_length == strlen(READ_THROUGH_VALUE)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(string_length == strlen(READ_THROUGH_VALUE)); test_strcmp(READ_THROUGH_VALUE, string); free(string); string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(string_length == strlen(READ_THROUGH_VALUE)); - test_truth(!strcmp(READ_THROUGH_VALUE, string)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(string_length == strlen(READ_THROUGH_VALUE)); + test_true(!strcmp(READ_THROUGH_VALUE, string)); free(string); return TEST_SUCCESS; } -static memcached_return_t delete_trigger(memcached_st *ptr __attribute__((unused)), +static memcached_return_t delete_trigger(memcached_st *ptr, const char *key, - size_t key_length __attribute__((unused))) + size_t key_length) { + (void)ptr;(void)key_length; assert(key); return MEMCACHED_SUCCESS; } -static test_return_t delete_through(memcached_st *memc) +static test_return_t delete_through(memcached_st *memc) { memcached_trigger_delete_key_fn callback; memcached_return_t rc; @@ -865,12 +955,12 @@ static test_return_t delete_through(memcached_st *memc) callback= (memcached_trigger_delete_key_fn)delete_trigger; rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_DELETE_TRIGGER, *(void**)&callback); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); return TEST_SUCCESS; } -static test_return_t get_test(memcached_st *memc) +static test_return_t get_test(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -879,19 +969,19 @@ static test_return_t get_test(memcached_st *memc) uint32_t flags; rc= memcached_delete(memc, key, strlen(key), (time_t)0); - test_truth(rc == MEMCACHED_BUFFERED || rc == MEMCACHED_NOTFOUND); + test_true(rc == MEMCACHED_BUFFERED || rc == MEMCACHED_NOTFOUND); string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(rc == MEMCACHED_NOTFOUND); test_false(string_length); test_false(string); return TEST_SUCCESS; } -static test_return_t get_test2(memcached_st *memc) +static test_return_t get_test2(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -903,22 +993,22 @@ static test_return_t get_test2(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(string); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(string_length == strlen(value)); - test_truth(!memcmp(string, value, string_length)); + test_true(string); + test_true(rc == MEMCACHED_SUCCESS); + test_true(string_length == strlen(value)); + test_true(!memcmp(string, value, string_length)); free(string); return TEST_SUCCESS; } -static test_return_t set_test2(memcached_st *memc) +static test_return_t set_test2(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -931,13 +1021,13 @@ static test_return_t set_test2(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, value_length, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } return TEST_SUCCESS; } -static test_return_t set_test3(memcached_st *memc) +static test_return_t set_test3(memcached_st *memc) { memcached_return_t rc; char *value; @@ -945,7 +1035,7 @@ static test_return_t set_test3(memcached_st *memc) unsigned int x; value = (char*)malloc(value_length); - test_truth(value); + test_true(value); for (x= 0; x < value_length; x++) value[x] = (char) (x % 127); @@ -955,12 +1045,12 @@ static test_return_t set_test3(memcached_st *memc) { char key[16]; - sprintf(key, "foo%u", x); + snprintf(key, sizeof(key), "foo%u", x); rc= memcached_set(memc, key, strlen(key), value, value_length, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } free(value); @@ -968,7 +1058,7 @@ static test_return_t set_test3(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t get_test3(memcached_st *memc) +static test_return_t get_test3(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -980,7 +1070,7 @@ static test_return_t get_test3(memcached_st *memc) uint32_t x; value = (char*)malloc(value_length); - test_truth(value); + test_true(value); for (x= 0; x < value_length; x++) value[x] = (char) (x % 127); @@ -988,15 +1078,15 @@ static test_return_t get_test3(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, value_length, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(string); - test_truth(string_length == value_length); - test_truth(!memcmp(string, value, string_length)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(string); + test_true(string_length == value_length); + test_true(!memcmp(string, value, string_length)); free(string); free(value); @@ -1004,7 +1094,7 @@ static test_return_t get_test3(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t get_test4(memcached_st *memc) +static test_return_t get_test4(memcached_st *memc) { memcached_return_t rc; const char *key= "foo"; @@ -1016,7 +1106,7 @@ static test_return_t get_test4(memcached_st *memc) uint32_t x; value = (char*)malloc(value_length); - test_truth(value); + test_true(value); for (x= 0; x < value_length; x++) value[x] = (char) (x % 127); @@ -1024,17 +1114,17 @@ static test_return_t get_test4(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, value_length, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); for (x= 0; x < 10; x++) { string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(string); - test_truth(string_length == value_length); - test_truth(!memcmp(string, value, string_length)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(string); + test_true(string_length == value_length); + test_true(!memcmp(string, value, string_length)); free(string); } @@ -1061,34 +1151,34 @@ static test_return_t get_test5(memcached_st *memc) memcached_return_t rc= memcached_set(memc, keys[0], lengths[0], keys[0], lengths[0], 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_mget(memc, keys, lengths, 2); memcached_result_st results_obj; memcached_result_st *results; results=memcached_result_create(memc, &results_obj); - test_truth(results); + test_true(results); results=memcached_fetch_result(memc, &results_obj, &rc); - test_truth(results); + test_true(results); memcached_result_free(&results_obj); /* Don't read out the second result, but issue a set instead.. */ rc= memcached_set(memc, keys[0], lengths[0], keys[0], lengths[0], 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); char *val= memcached_get_by_key(memc, keys[0], lengths[0], "yek", 3, &rlen, &flags, &rc); - test_truth(val == NULL); - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(val == NULL); + test_true(rc == MEMCACHED_NOTFOUND); val= memcached_get(memc, keys[0], lengths[0], &rlen, &flags, &rc); - test_truth(val != NULL); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(val != NULL); + test_true(rc == MEMCACHED_SUCCESS); free(val); return TEST_SUCCESS; } -static test_return_t mget_end(memcached_st *memc) +static test_return_t mget_end(memcached_st *memc) { const char *keys[]= { "foo", "foo2" }; size_t lengths[]= { 3, 4 }; @@ -1101,7 +1191,7 @@ static test_return_t mget_end(memcached_st *memc) { rc= memcached_set(memc, keys[i], lengths[i], values[i], strlen(values[i]), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } char *string; @@ -1110,7 +1200,7 @@ static test_return_t mget_end(memcached_st *memc) // retrieve both via mget rc= memcached_mget(memc, keys, lengths, 2); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); char key[MEMCACHED_MAX_KEY]; size_t key_length; @@ -1120,51 +1210,58 @@ static test_return_t mget_end(memcached_st *memc) { string= memcached_fetch(memc, key, &key_length, &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); int val = 0; if (key_length == 4) val= 1; - test_truth(string_length == strlen(values[val])); - test_truth(strncmp(values[val], string, string_length) == 0); + test_true(string_length == strlen(values[val])); + test_true(strncmp(values[val], string, string_length) == 0); free(string); } // this should indicate end string= memcached_fetch(memc, key, &key_length, &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_END); + test_true(rc == MEMCACHED_END); // now get just one rc= memcached_mget(memc, keys, lengths, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); string= memcached_fetch(memc, key, &key_length, &string_length, &flags, &rc); - test_truth(key_length == lengths[0]); - test_truth(strncmp(keys[0], key, key_length) == 0); - test_truth(string_length == strlen(values[0])); - test_truth(strncmp(values[0], string, string_length) == 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(key_length == lengths[0]); + test_true(strncmp(keys[0], key, key_length) == 0); + test_true(string_length == strlen(values[0])); + test_true(strncmp(values[0], string, string_length) == 0); + test_true(rc == MEMCACHED_SUCCESS); free(string); // this should indicate end string= memcached_fetch(memc, key, &key_length, &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_END); + test_true(rc == MEMCACHED_END); return TEST_SUCCESS; } /* Do not copy the style of this code, I just access hosts to testthis function */ -static test_return_t stats_servername_test(memcached_st *memc) +static test_return_t stats_servername_test(memcached_st *memc) { memcached_return_t rc; memcached_stat_st memc_stat; + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); + +#ifdef LIBMEMCACHED_WITH_SASL_SUPPORT + if (memcached_get_sasl_callbacks(memc) != NULL) + return TEST_SKIPPED; +#endif rc= memcached_stat_servername(&memc_stat, NULL, - memc->hosts[0].hostname, - memc->hosts[0].port); + memcached_server_name(instance), + memcached_server_port(instance)); return TEST_SUCCESS; } -static test_return_t increment_test(memcached_st *memc) +static test_return_t increment_test(memcached_st *memc) { uint64_t new_number; memcached_return_t rc; @@ -1174,22 +1271,22 @@ static test_return_t increment_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_increment(memc, key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 1); rc= memcached_increment(memc, key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 2); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 2); return TEST_SUCCESS; } -static test_return_t increment_with_initial_test(memcached_st *memc) +static test_return_t increment_with_initial_test(memcached_st *memc) { if (memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) != 0) { @@ -1200,18 +1297,18 @@ static test_return_t increment_with_initial_test(memcached_st *memc) rc= memcached_increment_with_initial(memc, key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == initial); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == initial); rc= memcached_increment_with_initial(memc, key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == (initial + 1)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == (initial + 1)); } return TEST_SUCCESS; } -static test_return_t decrement_test(memcached_st *memc) +static test_return_t decrement_test(memcached_st *memc) { uint64_t new_number; memcached_return_t rc; @@ -1221,22 +1318,22 @@ static test_return_t decrement_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_decrement(memc, key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 2); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 2); rc= memcached_decrement(memc, key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 1); return TEST_SUCCESS; } -static test_return_t decrement_with_initial_test(memcached_st *memc) +static test_return_t decrement_with_initial_test(memcached_st *memc) { if (memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) != 0) { @@ -1247,18 +1344,18 @@ static test_return_t decrement_with_initial_test(memcached_st *memc) rc= memcached_decrement_with_initial(memc, key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == initial); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == initial); rc= memcached_decrement_with_initial(memc, key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == (initial - 1)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == (initial - 1)); } return TEST_SUCCESS; } -static test_return_t increment_by_key_test(memcached_st *memc) +static test_return_t increment_by_key_test(memcached_st *memc) { uint64_t new_number; memcached_return_t rc; @@ -1270,22 +1367,22 @@ static test_return_t increment_by_key_test(memcached_st *memc) key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_increment_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 1); rc= memcached_increment_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 2); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 2); return TEST_SUCCESS; } -static test_return_t increment_with_initial_by_key_test(memcached_st *memc) +static test_return_t increment_with_initial_by_key_test(memcached_st *memc) { if (memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) != 0) { @@ -1298,19 +1395,19 @@ static test_return_t increment_with_initial_by_key_test(memcached_st *memc) rc= memcached_increment_with_initial_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == initial); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == initial); rc= memcached_increment_with_initial_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == (initial + 1)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == (initial + 1)); } return TEST_SUCCESS; } -static test_return_t decrement_by_key_test(memcached_st *memc) +static test_return_t decrement_by_key_test(memcached_st *memc) { uint64_t new_number; memcached_return_t rc; @@ -1322,24 +1419,24 @@ static test_return_t decrement_by_key_test(memcached_st *memc) key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_decrement_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 2); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 2); rc= memcached_decrement_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == 1); return TEST_SUCCESS; } -static test_return_t decrement_with_initial_by_key_test(memcached_st *memc) +static test_return_t decrement_with_initial_by_key_test(memcached_st *memc) { if (memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) != 0) { @@ -1352,19 +1449,19 @@ static test_return_t decrement_with_initial_by_key_test(memcached_st *memc) rc= memcached_decrement_with_initial_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == initial); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == initial); rc= memcached_decrement_with_initial_by_key(memc, master_key, strlen(master_key), key, strlen(key), 1, initial, 0, &new_number); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(new_number == (initial - 1)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(new_number == (initial - 1)); } return TEST_SUCCESS; } -static test_return_t quit_test(memcached_st *memc) +static test_return_t quit_test(memcached_st *memc) { memcached_return_t rc; const char *key= "fudge"; @@ -1373,18 +1470,18 @@ static test_return_t quit_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)10, (uint32_t)3); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); memcached_quit(memc); rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); return TEST_SUCCESS; } -static test_return_t mget_result_test(memcached_st *memc) +static test_return_t mget_result_test(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"fudge", "son", "food"}; @@ -1395,43 +1492,43 @@ static test_return_t mget_result_test(memcached_st *memc) memcached_result_st *results; results= memcached_result_create(memc, &results_obj); - test_truth(results); - test_truth(&results_obj == results); + test_true(results); + test_true(&results_obj == results); /* We need to empty the server before continueing test */ rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); while ((results= memcached_fetch_result(memc, &results_obj, &rc)) != NULL) { - test_truth(results); + test_true(results); } while ((results= memcached_fetch_result(memc, &results_obj, &rc)) != NULL) - test_truth(!results); - test_truth(rc == MEMCACHED_END); + test_true(!results); + test_true(rc == MEMCACHED_END); for (x= 0; x < 3; x++) { rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); while ((results= memcached_fetch_result(memc, &results_obj, &rc))) { - test_truth(results); - test_truth(&results_obj == results); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_result_key_length(results) == memcached_result_length(results)); - test_truth(!memcmp(memcached_result_key_value(results), + test_true(results); + test_true(&results_obj == results); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_result_key_length(results) == memcached_result_length(results)); + test_true(!memcmp(memcached_result_key_value(results), memcached_result_value(results), memcached_result_length(results))); } @@ -1441,7 +1538,7 @@ static test_return_t mget_result_test(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t mget_result_alloc_test(memcached_st *memc) +static test_return_t mget_result_alloc_test(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"fudge", "son", "food"}; @@ -1452,36 +1549,36 @@ static test_return_t mget_result_alloc_test(memcached_st *memc) /* We need to empty the server before continueing test */ rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); while ((results= memcached_fetch_result(memc, NULL, &rc)) != NULL) { - test_truth(results); + test_true(results); } - test_truth(!results); - test_truth(rc == MEMCACHED_END); + test_true(!results); + test_true(rc == MEMCACHED_END); for (x= 0; x < 3; x++) { rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); x= 0; while ((results= memcached_fetch_result(memc, NULL, &rc))) { - test_truth(results); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_result_key_length(results) == memcached_result_length(results)); - test_truth(!memcmp(memcached_result_key_value(results), + test_true(results); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_result_key_length(results) == memcached_result_length(results)); + test_true(!memcmp(memcached_result_key_value(results), memcached_result_value(results), memcached_result_length(results))); memcached_result_free(results); @@ -1492,24 +1589,25 @@ static test_return_t mget_result_alloc_test(memcached_st *memc) } /* Count the results */ -static memcached_return_t callback_counter(memcached_st *ptr __attribute__((unused)), - memcached_result_st *result __attribute__((unused)), +static memcached_return_t callback_counter(const memcached_st *ptr, + memcached_result_st *result, void *context) { - unsigned int *counter= (unsigned int *)context; + (void)ptr; (void)result; + size_t *counter= (size_t *)context; *counter= *counter + 1; return MEMCACHED_SUCCESS; } -static test_return_t mget_result_function(memcached_st *memc) +static test_return_t mget_result_function(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"fudge", "son", "food"}; size_t key_length[]= {5, 3, 4}; unsigned int x; - unsigned int counter; + size_t counter; memcached_execute_fn callbacks[1]; /* We need to empty the server before continueing test */ @@ -1519,22 +1617,22 @@ static test_return_t mget_result_function(memcached_st *memc) rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); callbacks[0]= &callback_counter; counter= 0; rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); - test_truth(counter == 3); + test_true(counter == 3); return TEST_SUCCESS; } -static test_return_t mget_test(memcached_st *memc) +static test_return_t mget_test(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"fudge", "son", "food"}; @@ -1549,39 +1647,39 @@ static test_return_t mget_test(memcached_st *memc) /* We need to empty the server before continueing test */ rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); while ((return_value= memcached_fetch(memc, return_key, &return_key_length, &return_value_length, &flags, &rc)) != NULL) { - test_truth(return_value); + test_true(return_value); } - test_truth(!return_value); - test_truth(return_value_length == 0); - test_truth(rc == MEMCACHED_END); + test_true(!return_value); + test_true(return_value_length == 0); + test_true(rc == MEMCACHED_END); for (x= 0; x < 3; x++) { rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); x= 0; while ((return_value= memcached_fetch(memc, return_key, &return_key_length, &return_value_length, &flags, &rc))) { - test_truth(return_value); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(return_key_length == return_value_length); - test_truth(!memcmp(return_value, return_key, return_value_length)); + test_true(return_value); + test_true(rc == MEMCACHED_SUCCESS); + test_true(return_key_length == return_value_length); + test_true(!memcmp(return_value, return_key, return_value_length)); free(return_value); x++; } @@ -1592,6 +1690,7 @@ static test_return_t mget_test(memcached_st *memc) static test_return_t mget_execute(memcached_st *memc) { bool binary= false; + if (memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) != 0) binary= true; @@ -1602,50 +1701,56 @@ static test_return_t mget_execute(memcached_st *memc) uint32_t number_of_hosts= memc->number_of_hosts; memc->number_of_hosts= 1; - int max_keys= binary ? 20480 : 1; + size_t max_keys= 20480; - char **keys= calloc((size_t)max_keys, sizeof(char*)); - size_t *key_length=calloc((size_t)max_keys, sizeof(size_t)); + char **keys= calloc(max_keys, sizeof(char*)); + size_t *key_length=calloc(max_keys, sizeof(size_t)); /* First add all of the items.. */ char blob[1024] = {0}; memcached_return_t rc; - for (int x= 0; x < max_keys; ++x) + + for (size_t x= 0; x < max_keys; ++x) { char k[251]; - key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%u", x); + + key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%lu", (unsigned long)x); keys[x]= strdup(k); - test_truth(keys[x] != NULL); + test_true(keys[x] != NULL); rc= memcached_add(memc, keys[x], key_length[x], blob, sizeof(blob), 0, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } /* Try to get all of them with a large multiget */ - unsigned int counter= 0; + size_t counter= 0; memcached_execute_fn callbacks[1]= { [0]= &callback_counter }; rc= memcached_mget_execute(memc, (const char**)keys, key_length, - (size_t)max_keys, callbacks, &counter, 1); + max_keys, callbacks, &counter, 1); - if (binary) + if (rc == MEMCACHED_SUCCESS) { - test_truth(rc == MEMCACHED_SUCCESS); - + test_true(binary); rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); - test_truth(rc == MEMCACHED_END); + test_true(rc == MEMCACHED_END); /* Verify that we got all of the items */ - test_truth(counter == (unsigned int)max_keys); + test_true(counter == max_keys); + } + else if (rc == MEMCACHED_NOT_SUPPORTED) + { + test_true(counter == 0); } else { - test_truth(rc == MEMCACHED_NOT_SUPPORTED); - test_truth(counter == 0); + test_fail("note: this test functions differently when in binary mode"); } /* Release all allocated resources */ - for (int x= 0; x < max_keys; ++x) + for (size_t x= 0; x < max_keys; ++x) + { free(keys[x]); + } free(keys); free(key_length); @@ -1653,7 +1758,52 @@ static test_return_t mget_execute(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t get_stats_keys(memcached_st *memc) +#define REGRESSION_BINARY_VS_BLOCK_COUNT 20480 + +static test_return_t key_setup(memcached_st *memc) +{ + (void)memc; + + if (pre_binary(memc) != TEST_SUCCESS) + return TEST_SKIPPED; + + global_pairs= pairs_generate(REGRESSION_BINARY_VS_BLOCK_COUNT, 0); + + return TEST_SUCCESS; +} + +static test_return_t key_teardown(memcached_st *memc) +{ + (void)memc; + pairs_free(global_pairs); + + return TEST_SUCCESS; +} + +static test_return_t block_add_regression(memcached_st *memc) +{ + /* First add all of the items.. */ + for (size_t x= 0; x < REGRESSION_BINARY_VS_BLOCK_COUNT; ++x) + { + memcached_return_t rc; + char blob[1024] = {0}; + + rc= memcached_add_by_key(memc, "bob", 3, global_pairs[x].key, global_pairs[x].key_length, blob, sizeof(blob), 0, 0); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + } + + return TEST_SUCCESS; +} + +static test_return_t binary_add_regression(memcached_st *memc) +{ + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + test_return_t rc= block_add_regression(memc); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 0); + return rc; +} + +static test_return_t get_stats_keys(memcached_st *memc) { char **stat_list; char **ptr; @@ -1661,44 +1811,44 @@ static test_return_t get_stats_keys(memcached_st *memc) memcached_return_t rc; stat_list= memcached_stat_get_keys(memc, &memc_stat, &rc); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); for (ptr= stat_list; *ptr; ptr++) - test_truth(*ptr); + test_true(*ptr); free(stat_list); return TEST_SUCCESS; } -static test_return_t version_string_test(memcached_st *memc __attribute__((unused))) +static test_return_t version_string_test(memcached_st *memc) { const char *version_string; + (void)memc; version_string= memcached_lib_version(); - test_truth(!strcmp(version_string, LIBMEMCACHED_VERSION_STRING)); + test_true(!strcmp(version_string, LIBMEMCACHED_VERSION_STRING)); return TEST_SUCCESS; } -static test_return_t get_stats(memcached_st *memc) +static test_return_t get_stats(memcached_st *memc) { - unsigned int x; char **stat_list; char **ptr; memcached_return_t rc; memcached_stat_st *memc_stat; memc_stat= memcached_stat(memc, NULL, &rc); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memc_stat); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memc_stat); - for (x= 0; x < memcached_server_count(memc); x++) + for (uint32_t x= 0; x < memcached_server_count(memc); x++) { stat_list= memcached_stat_get_keys(memc, memc_stat+x, &rc); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); for (ptr= stat_list; *ptr; ptr++); free(stat_list); @@ -1709,7 +1859,7 @@ static test_return_t get_stats(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t add_host_test(memcached_st *memc) +static test_return_t add_host_test(memcached_st *memc) { unsigned int x; memcached_server_st *servers; @@ -1717,8 +1867,8 @@ static test_return_t add_host_test(memcached_st *memc) char servername[]= "0.example.com"; servers= memcached_server_list_append_with_weight(NULL, servername, 400, 0, &rc); - test_truth(servers); - test_truth(1 == memcached_server_list_count(servers)); + test_true(servers); + test_true(1 == memcached_server_list_count(servers)); for (x= 2; x < 20; x++) { @@ -1727,31 +1877,33 @@ static test_return_t add_host_test(memcached_st *memc) snprintf(buffer, SMALL_STRING_LEN, "%u.example.com", 400+x); servers= memcached_server_list_append_with_weight(servers, buffer, 401, 0, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(x == memcached_server_list_count(servers)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(x == memcached_server_list_count(servers)); } rc= memcached_server_push(memc, servers); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_server_push(memc, servers); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_server_list_free(servers); return TEST_SUCCESS; } -static memcached_return_t clone_test_callback(memcached_st *parent __attribute__((unused)), memcached_st *memc_clone __attribute__((unused))) +static memcached_return_t clone_test_callback(memcached_st *parent, memcached_st *memc_clone) { + (void)parent;(void)memc_clone; return MEMCACHED_SUCCESS; } -static memcached_return_t cleanup_test_callback(memcached_st *ptr __attribute__((unused))) +static memcached_return_t cleanup_test_callback(memcached_st *ptr) { + (void)ptr; return MEMCACHED_SUCCESS; } -static test_return_t callback_test(memcached_st *memc) +static test_return_t callback_test(memcached_st *memc) { /* Test User Data */ { @@ -1760,9 +1912,9 @@ static test_return_t callback_test(memcached_st *memc) memcached_return_t rc; rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_USER_DATA, &x); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); test_ptr= (int *)memcached_callback_get(memc, MEMCACHED_CALLBACK_USER_DATA, &rc); - test_truth(*test_ptr == x); + test_true(*test_ptr == x); } /* Test Clone Callback */ @@ -1774,9 +1926,9 @@ static test_return_t callback_test(memcached_st *memc) rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_CLONE_FUNCTION, clone_cb_ptr); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); temp_function= memcached_callback_get(memc, MEMCACHED_CALLBACK_CLONE_FUNCTION, &rc); - test_truth(temp_function == clone_cb_ptr); + test_true(temp_function == clone_cb_ptr); } /* Test Cleanup Callback */ @@ -1789,67 +1941,138 @@ static test_return_t callback_test(memcached_st *memc) rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_CLONE_FUNCTION, cleanup_cb_ptr); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); temp_function= memcached_callback_get(memc, MEMCACHED_CALLBACK_CLONE_FUNCTION, &rc); - test_truth(temp_function == cleanup_cb_ptr); + test_true(temp_function == cleanup_cb_ptr); } return TEST_SUCCESS; } /* We don't test the behavior itself, we test the switches */ -static test_return_t behavior_test(memcached_st *memc) +static test_return_t behavior_test(memcached_st *memc) { uint64_t value; uint32_t set= 1; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NO_BLOCK); - test_truth(value == 1); + test_true(value == 1); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY); - test_truth(value == 1); + test_true(value == 1); set= MEMCACHED_HASH_MD5; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_HASH); - test_truth(value == MEMCACHED_HASH_MD5); + test_true(value == MEMCACHED_HASH_MD5); set= 0; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NO_BLOCK); - test_truth(value == 0); + test_true(value == 0); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY); - test_truth(value == 0); + test_true(value == 0); set= MEMCACHED_HASH_DEFAULT; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_HASH); - test_truth(value == MEMCACHED_HASH_DEFAULT); + test_true(value == MEMCACHED_HASH_DEFAULT); set= MEMCACHED_HASH_CRC; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, set); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_HASH); - test_truth(value == MEMCACHED_HASH_CRC); + test_true(value == MEMCACHED_HASH_CRC); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_SOCKET_SEND_SIZE); - test_truth(value > 0); + test_true(value > 0); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_SOCKET_RECV_SIZE); - test_truth(value > 0); + test_true(value > 0); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS, value + 1); - test_truth((value + 1) == memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS)); + test_true((value + 1) == memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS)); + + return TEST_SUCCESS; +} + +static test_return_t MEMCACHED_BEHAVIOR_CORK_test(memcached_st *memc) +{ + memcached_return_t rc; + bool set= true; + bool value; + + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_CORK, set); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_NOT_SUPPORTED); + + value= (bool)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_CORK); + + if (rc == MEMCACHED_SUCCESS) + { + test_true((bool)value == set); + } + else + { + test_false((bool)value == set); + } + + return TEST_SUCCESS; +} + + +static test_return_t MEMCACHED_BEHAVIOR_TCP_KEEPALIVE_test(memcached_st *memc) +{ + memcached_return_t rc; + bool set= true; + bool value; + + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_KEEPALIVE, set); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_NOT_SUPPORTED); + + value= (bool)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_TCP_KEEPALIVE); + + if (rc == MEMCACHED_SUCCESS) + { + test_true((bool)value == set); + } + else + { + test_false((bool)value == set); + } + + return TEST_SUCCESS; +} + + +static test_return_t MEMCACHED_BEHAVIOR_TCP_KEEPIDLE_test(memcached_st *memc) +{ + memcached_return_t rc; + bool set= true; + bool value; + + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_KEEPIDLE, set); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_NOT_SUPPORTED); + + value= (bool)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_TCP_KEEPIDLE); + + if (rc == MEMCACHED_SUCCESS) + { + test_true((bool)value == set); + } + else + { + test_false((bool)value == set); + } return TEST_SUCCESS; } -static test_return_t fetch_all_results(memcached_st *memc) +static test_return_t fetch_all_results(memcached_st *memc, size_t *keys_returned) { memcached_return_t rc= MEMCACHED_SUCCESS; char return_key[MEMCACHED_MAX_KEY]; @@ -1858,22 +2081,26 @@ static test_return_t fetch_all_results(memcached_st *memc) size_t return_value_length; uint32_t flags; + *keys_returned= 0; + while ((return_value= memcached_fetch(memc, return_key, &return_key_length, &return_value_length, &flags, &rc))) { - test_truth(return_value); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(return_value); + test_true(rc == MEMCACHED_SUCCESS); free(return_value); + *keys_returned= *keys_returned +1; } - return ((rc == MEMCACHED_END) || (rc == MEMCACHED_SUCCESS)) ? TEST_SUCCESS : TEST_FAILURE; + test_true_got(rc == MEMCACHED_END || rc == MEMCACHED_SUCCESS, memcached_strerror(NULL, rc)); + + return TEST_SUCCESS; } /* Test case provided by Cal Haldenbrand */ -static test_return_t user_supplied_bug1(memcached_st *memc) +static test_return_t user_supplied_bug1(memcached_st *memc) { unsigned int setter= 1; - unsigned int x; unsigned long long total= 0; uint32_t size= 0; @@ -1891,39 +2118,37 @@ static test_return_t user_supplied_bug1(memcached_st *memc) /* add key */ - for (x= 0 ; total < 20 * 1024576 ; x++ ) + for (uint32_t x= 0 ; total < 20 * 1024576 ; x++ ) { unsigned int j= 0; size= (uint32_t)(rand() % ( 5 * 1024 ) ) + 400; memset(randomstuff, 0, 6 * 1024); - test_truth(size < 6 * 1024); /* Being safe here */ + test_true(size < 6 * 1024); /* Being safe here */ for (j= 0 ; j < size ;j++) randomstuff[j] = (signed char) ((rand() % 26) + 97); total += size; - sprintf(key, "%d", x); + snprintf(key, sizeof(key), "%u", x); rc = memcached_set(memc, key, strlen(key), randomstuff, strlen(randomstuff), 10, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); /* If we fail, lets try again */ if (rc != MEMCACHED_SUCCESS && rc != MEMCACHED_BUFFERED) rc = memcached_set(memc, key, strlen(key), randomstuff, strlen(randomstuff), 10, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } return TEST_SUCCESS; } /* Test case provided by Cal Haldenbrand */ -static test_return_t user_supplied_bug2(memcached_st *memc) +static test_return_t user_supplied_bug2(memcached_st *memc) { - int errors; unsigned int setter; - unsigned int x; - unsigned long long total; + size_t total= 0; setter= 1; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, setter); @@ -1936,10 +2161,10 @@ static test_return_t user_supplied_bug2(memcached_st *memc) getter = memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_SOCKET_SEND_SIZE); getter = memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_SOCKET_RECV_SIZE); - for (x= 0, errors= 0, total= 0 ; total < 20 * 1024576 ; x++) + for (x= 0, errors= 0; total < 20 * 1024576 ; x++) #endif - for (x= 0, errors= 0, total= 0 ; total < 24576 ; x++) + for (uint32_t x= 0, errors= 0; total < 24576 ; x++) { memcached_return_t rc= MEMCACHED_SUCCESS; char buffer[SMALL_STRING_LEN]; @@ -1949,7 +2174,7 @@ static test_return_t user_supplied_bug2(memcached_st *memc) memset(buffer, 0, SMALL_STRING_LEN); - snprintf(buffer, SMALL_STRING_LEN, "%u", x); + snprintf(buffer, sizeof(buffer), "%u", x); getval= memcached_get(memc, buffer, strlen(buffer), &val_len, &flags, &rc); if (rc != MEMCACHED_SUCCESS) @@ -1958,7 +2183,7 @@ static test_return_t user_supplied_bug2(memcached_st *memc) errors++; else { - test_truth(rc); + test_true(rc); } continue; @@ -1973,7 +2198,7 @@ static test_return_t user_supplied_bug2(memcached_st *memc) /* Do a large mget() over all the keys we think exist */ #define KEY_COUNT 3000 // * 1024576 -static test_return_t user_supplied_bug3(memcached_st *memc) +static test_return_t user_supplied_bug3(memcached_st *memc) { memcached_return_t rc; unsigned int setter; @@ -1994,7 +2219,7 @@ static test_return_t user_supplied_bug3(memcached_st *memc) #endif keys= calloc(KEY_COUNT, sizeof(char *)); - test_truth(keys); + test_true(keys); for (x= 0; x < KEY_COUNT; x++) { char buffer[30]; @@ -2005,9 +2230,10 @@ static test_return_t user_supplied_bug3(memcached_st *memc) } rc= memcached_mget(memc, (const char **)keys, key_lengths, KEY_COUNT); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); - test_truth(fetch_all_results(memc) == TEST_SUCCESS); + size_t keys_returned; + test_true(fetch_all_results(memc, &keys_returned) == TEST_SUCCESS); for (x= 0; x < KEY_COUNT; x++) free(keys[x]); @@ -2017,7 +2243,7 @@ static test_return_t user_supplied_bug3(memcached_st *memc) } /* Make sure we behave properly if server list has no values */ -static test_return_t user_supplied_bug4(memcached_st *memc) +static test_return_t user_supplied_bug4(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"fudge", "son", "food"}; @@ -2035,39 +2261,39 @@ static test_return_t user_supplied_bug4(memcached_st *memc) /* We need to empty the server before continueing test */ rc= memcached_flush(memc, 0); - test_truth(rc == MEMCACHED_NO_SERVERS); + test_true(rc == MEMCACHED_NO_SERVERS); rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_NO_SERVERS); + test_true(rc == MEMCACHED_NO_SERVERS); while ((return_value= memcached_fetch(memc, return_key, &return_key_length, &return_value_length, &flags, &rc)) != NULL) { - test_truth(return_value); + test_true(return_value); } - test_truth(!return_value); - test_truth(return_value_length == 0); - test_truth(rc == MEMCACHED_NO_SERVERS); + test_true(!return_value); + test_true(return_value_length == 0); + test_true(rc == MEMCACHED_NO_SERVERS); for (x= 0; x < 3; x++) { rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_NO_SERVERS); + test_true(rc == MEMCACHED_NO_SERVERS); } rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_NO_SERVERS); + test_true(rc == MEMCACHED_NO_SERVERS); x= 0; while ((return_value= memcached_fetch(memc, return_key, &return_key_length, &return_value_length, &flags, &rc))) { - test_truth(return_value); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(return_key_length == return_value_length); - test_truth(!memcmp(return_value, return_key, return_value_length)); + test_true(return_value); + test_true(rc == MEMCACHED_SUCCESS); + test_true(return_key_length == return_value_length); + test_true(!memcmp(return_value, return_key, return_value_length)); free(return_value); x++; } @@ -2076,7 +2302,7 @@ static test_return_t user_supplied_bug4(memcached_st *memc) } #define VALUE_SIZE_BUG5 1048064 -static test_return_t user_supplied_bug5(memcached_st *memc) +static test_return_t user_supplied_bug5(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"036790384900", "036790384902", "036790384904", "036790384906"}; @@ -2096,28 +2322,28 @@ static test_return_t user_supplied_bug5(memcached_st *memc) memcached_flush(memc, 0); value= memcached_get(memc, keys[0], key_length[0], &value_length, &flags, &rc); - test_truth(value == NULL); + test_true(value == NULL); rc= memcached_mget(memc, keys, key_length, 4); count= 0; while ((value= memcached_fetch(memc, return_key, &return_key_length, &value_length, &flags, &rc))) count++; - test_truth(count == 0); + test_true(count == 0); for (x= 0; x < 4; x++) { rc= memcached_set(memc, keys[x], key_length[x], insert_data, VALUE_SIZE_BUG5, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } for (x= 0; x < 10; x++) { value= memcached_get(memc, keys[0], key_length[0], &value_length, &flags, &rc); - test_truth(value); + test_true(value); free(value); rc= memcached_mget(memc, keys, key_length, 4); @@ -2128,13 +2354,13 @@ static test_return_t user_supplied_bug5(memcached_st *memc) count++; free(value); } - test_truth(count == 4); + test_true(count == 4); } return TEST_SUCCESS; } -static test_return_t user_supplied_bug6(memcached_st *memc) +static test_return_t user_supplied_bug6(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"036790384900", "036790384902", "036790384904", "036790384906"}; @@ -2154,44 +2380,44 @@ static test_return_t user_supplied_bug6(memcached_st *memc) memcached_flush(memc, 0); value= memcached_get(memc, keys[0], key_length[0], &value_length, &flags, &rc); - test_truth(value == NULL); - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(value == NULL); + test_true(rc == MEMCACHED_NOTFOUND); rc= memcached_mget(memc, keys, key_length, 4); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); count= 0; while ((value= memcached_fetch(memc, return_key, &return_key_length, &value_length, &flags, &rc))) count++; - test_truth(count == 0); - test_truth(rc == MEMCACHED_END); + test_true(count == 0); + test_true(rc == MEMCACHED_END); for (x= 0; x < 4; x++) { rc= memcached_set(memc, keys[x], key_length[x], insert_data, VALUE_SIZE_BUG5, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } for (x= 0; x < 2; x++) { value= memcached_get(memc, keys[0], key_length[0], &value_length, &flags, &rc); - test_truth(value); + test_true(value); free(value); rc= memcached_mget(memc, keys, key_length, 4); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); count= 3; /* We test for purge of partial complete fetches */ for (count= 3; count; count--) { value= memcached_fetch(memc, return_key, &return_key_length, &value_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(!(memcmp(value, insert_data, value_length))); - test_truth(value_length); + test_true(rc == MEMCACHED_SUCCESS); + test_true(!(memcmp(value, insert_data, value_length))); + test_true(value_length); free(value); } } @@ -2199,7 +2425,7 @@ static test_return_t user_supplied_bug6(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t user_supplied_bug8(memcached_st *memc __attribute__((unused))) +static test_return_t user_supplied_bug8(memcached_st *memc) { memcached_return_t rc; memcached_st *mine; @@ -2208,15 +2434,16 @@ static test_return_t user_supplied_bug8(memcached_st *memc __attribute__((unuse memcached_server_st *servers; const char *server_list= "memcache1.memcache.bk.sapo.pt:11211, memcache1.memcache.bk.sapo.pt:11212, memcache1.memcache.bk.sapo.pt:11213, memcache1.memcache.bk.sapo.pt:11214, memcache2.memcache.bk.sapo.pt:11211, memcache2.memcache.bk.sapo.pt:11212, memcache2.memcache.bk.sapo.pt:11213, memcache2.memcache.bk.sapo.pt:11214"; + (void)memc; servers= memcached_servers_parse(server_list); - test_truth(servers); + test_true(servers); mine= memcached_create(NULL); rc= memcached_server_push(mine, servers); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_server_list_free(servers); - test_truth(mine); + test_true(mine); memc_clone= memcached_clone(NULL, mine); memcached_quit(mine); @@ -2230,7 +2457,7 @@ static test_return_t user_supplied_bug8(memcached_st *memc __attribute__((unuse } /* Test flag store/retrieve */ -static test_return_t user_supplied_bug7(memcached_st *memc) +static test_return_t user_supplied_bug7(memcached_st *memc) { memcached_return_t rc; const char *keys= "036790384900"; @@ -2252,13 +2479,13 @@ static test_return_t user_supplied_bug7(memcached_st *memc) rc= memcached_set(memc, keys, key_length, insert_data, VALUE_SIZE_BUG5, (time_t)0, flags); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); flags= 0; value= memcached_get(memc, keys, key_length, &value_length, &flags, &rc); - test_truth(flags == 245); - test_truth(value); + test_true(flags == 245); + test_true(value); free(value); rc= memcached_mget(memc, &keys, &key_length, 1); @@ -2266,15 +2493,15 @@ static test_return_t user_supplied_bug7(memcached_st *memc) flags= 0; value= memcached_fetch(memc, return_key, &return_key_length, &value_length, &flags, &rc); - test_truth(flags == 245); - test_truth(value); + test_true(flags == 245); + test_true(value); free(value); return TEST_SUCCESS; } -static test_return_t user_supplied_bug9(memcached_st *memc) +static test_return_t user_supplied_bug9(memcached_st *memc) { memcached_return_t rc; const char *keys[]= {"UDATA:edevil@sapo.pt", "fudge&*@#", "for^#@&$not"}; @@ -2299,27 +2526,27 @@ static test_return_t user_supplied_bug9(memcached_st *memc) rc= memcached_set(memc, keys[x], key_length[x], keys[x], key_length[x], (time_t)50, (uint32_t)9); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } rc= memcached_mget(memc, keys, key_length, 3); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); /* We need to empty the server before continueing test */ while ((return_value= memcached_fetch(memc, return_key, &return_key_length, &return_value_length, &flags, &rc)) != NULL) { - test_truth(return_value); + test_true(return_value); free(return_value); count++; } - test_truth(count == 3); + test_true(count == 3); return TEST_SUCCESS; } /* We are testing with aggressive timeout to get failures */ -static test_return_t user_supplied_bug10(memcached_st *memc) +static test_return_t user_supplied_bug10(memcached_st *memc) { const char *key= "foo"; char *value; @@ -2346,7 +2573,7 @@ static test_return_t user_supplied_bug10(memcached_st *memc) { rc= memcached_set(mclone, key, key_len,value, value_length, 0, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_WRITE_FAILURE || + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_WRITE_FAILURE || rc == MEMCACHED_BUFFERED || rc == MEMCACHED_TIMEOUT); if (rc == MEMCACHED_WRITE_FAILURE || rc == MEMCACHED_TIMEOUT) @@ -2362,7 +2589,7 @@ static test_return_t user_supplied_bug10(memcached_st *memc) /* We are looking failures in the async protocol */ -static test_return_t user_supplied_bug11(memcached_st *memc) +static test_return_t user_supplied_bug11(memcached_st *memc) { const char *key= "foo"; char *value; @@ -2382,7 +2609,7 @@ static test_return_t user_supplied_bug11(memcached_st *memc) timeout= (int32_t)memcached_behavior_get(mclone, MEMCACHED_BEHAVIOR_POLL_TIMEOUT); - test_truth(timeout == -1); + test_true(timeout == -1); value = (char*)malloc(value_length * sizeof(char)); @@ -2403,7 +2630,7 @@ static test_return_t user_supplied_bug11(memcached_st *memc) /* Bug found where incr was not returning MEMCACHED_NOTFOUND when object did not exist. */ -static test_return_t user_supplied_bug12(memcached_st *memc) +static test_return_t user_supplied_bug12(memcached_st *memc) { memcached_return_t rc; uint32_t flags; @@ -2413,35 +2640,35 @@ static test_return_t user_supplied_bug12(memcached_st *memc) value= memcached_get(memc, "autoincrement", strlen("autoincrement"), &value_length, &flags, &rc); - test_truth(value == NULL); - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(value == NULL); + test_true(rc == MEMCACHED_NOTFOUND); rc= memcached_increment(memc, "autoincrement", strlen("autoincrement"), 1, &number_value); - test_truth(value == NULL); + test_true(value == NULL); /* The binary protocol will set the key if it doesn't exist */ if (memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) == 1) { - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } else { - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(rc == MEMCACHED_NOTFOUND); } rc= memcached_set(memc, "autoincrement", strlen("autoincrement"), "1", 1, 0, 0); value= memcached_get(memc, "autoincrement", strlen("autoincrement"), &value_length, &flags, &rc); - test_truth(value); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(value); + test_true(rc == MEMCACHED_SUCCESS); free(value); rc= memcached_increment(memc, "autoincrement", strlen("autoincrement"), 1, &number_value); - test_truth(number_value == 2); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(number_value == 2); + test_true(rc == MEMCACHED_SUCCESS); return TEST_SUCCESS; } @@ -2450,7 +2677,7 @@ static test_return_t user_supplied_bug12(memcached_st *memc) Bug found where command total one more than MEMCACHED_MAX_BUFFER set key34567890 0 0 8169 \r\n is sent followed by buffer of size 8169, followed by 8169 */ -static test_return_t user_supplied_bug13(memcached_st *memc) +static test_return_t user_supplied_bug13(memcached_st *memc) { char key[] = "key34567890"; char *overflow; @@ -2469,12 +2696,12 @@ static test_return_t user_supplied_bug13(memcached_st *memc) for (testSize= overflowSize - 1; testSize < overflowSize + 1; testSize++) { overflow= malloc(testSize); - test_truth(overflow != NULL); + test_true(overflow != NULL); memset(overflow, 'x', testSize); rc= memcached_set(memc, key, strlen(key), overflow, testSize, 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); free(overflow); } @@ -2488,7 +2715,7 @@ static test_return_t user_supplied_bug13(memcached_st *memc) set key34567890 0 0 8169 \r\n is sent followed by buffer of size 8169, followed by 8169 */ -static test_return_t user_supplied_bug14(memcached_st *memc) +static test_return_t user_supplied_bug14(memcached_st *memc) { size_t setter= 1; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY, setter); @@ -2503,7 +2730,7 @@ static test_return_t user_supplied_bug14(memcached_st *memc) size_t current_length; value = (char*)malloc(value_length); - test_truth(value); + test_true(value); for (x= 0; x < value_length; x++) value[x] = (char) (x % 127); @@ -2513,14 +2740,14 @@ static test_return_t user_supplied_bug14(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, current_length, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); string= memcached_get(memc, key, strlen(key), &string_length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(string_length == current_length); - test_truth(!memcmp(string, value, string_length)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(string_length == current_length); + test_true(!memcmp(string, value, string_length)); free(string); } @@ -2533,7 +2760,7 @@ static test_return_t user_supplied_bug14(memcached_st *memc) /* Look for zero length value problems */ -static test_return_t user_supplied_bug15(memcached_st *memc) +static test_return_t user_supplied_bug15(memcached_st *memc) { uint32_t x; memcached_return_t rc; @@ -2548,30 +2775,30 @@ static test_return_t user_supplied_bug15(memcached_st *memc) NULL, 0, (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_get(memc, key, strlen(key), &length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(value == NULL); - test_truth(length == 0); - test_truth(flags == 0); + test_true(rc == MEMCACHED_SUCCESS); + test_true(value == NULL); + test_true(length == 0); + test_true(flags == 0); value= memcached_get(memc, key, strlen(key), &length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(value == NULL); - test_truth(length == 0); - test_truth(flags == 0); + test_true(rc == MEMCACHED_SUCCESS); + test_true(value == NULL); + test_true(length == 0); + test_true(flags == 0); } return TEST_SUCCESS; } /* Check the return sizes on FLAGS to make sure it stores 32bit unsigned values correctly */ -static test_return_t user_supplied_bug16(memcached_st *memc) +static test_return_t user_supplied_bug16(memcached_st *memc) { memcached_return_t rc; const char *key= "mykey"; @@ -2583,22 +2810,22 @@ static test_return_t user_supplied_bug16(memcached_st *memc) NULL, 0, (time_t)0, UINT32_MAX); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_get(memc, key, strlen(key), &length, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(value == NULL); - test_truth(length == 0); - test_truth(flags == UINT32_MAX); + test_true(rc == MEMCACHED_SUCCESS); + test_true(value == NULL); + test_true(length == 0); + test_true(flags == UINT32_MAX); return TEST_SUCCESS; } -#ifndef __sun +#if !defined(__sun) && !defined(__OpenBSD__) /* Check the validity of chinese key*/ -static test_return_t user_supplied_bug17(memcached_st *memc) +static test_return_t user_supplied_bug17(memcached_st *memc) { memcached_return_t rc; const char *key= "豆瓣"; @@ -2611,14 +2838,14 @@ static test_return_t user_supplied_bug17(memcached_st *memc) value, strlen(value), (time_t)0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value2= memcached_get(memc, key, strlen(key), &length, &flags, &rc); - test_truth(length==strlen(value)); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcmp(value, value2, length)==0); + test_true(length==strlen(value)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcmp(value, value2, length)==0); free(value2); return TEST_SUCCESS; @@ -2629,22 +2856,21 @@ static test_return_t user_supplied_bug17(memcached_st *memc) From Andrei on IRC */ -static test_return_t user_supplied_bug19(memcached_st *memc) +static test_return_t user_supplied_bug19(memcached_st *not_used) { - memcached_st *m; - memcached_server_st *s; + memcached_st *memc; + const memcached_server_st *server; memcached_return_t res; - (void)memc; + (void)not_used; - m= memcached_create(NULL); - memcached_server_add_with_weight(m, "localhost", 11311, 100); - memcached_server_add_with_weight(m, "localhost", 11312, 100); + memc= memcached_create(NULL); + memcached_server_add_with_weight(memc, "localhost", 11311, 100); + memcached_server_add_with_weight(memc, "localhost", 11312, 100); - s= memcached_server_by_key(m, "a", 1, &res); - memcached_server_free(s); + server= memcached_server_by_key(memc, "a", 1, &res); - memcached_free(m); + memcached_free(memc); return TEST_SUCCESS; } @@ -2662,19 +2888,19 @@ static test_return_t user_supplied_bug20(memcached_st *memc) memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS, 1); status = memcached_set(memc, key, key_len, value, value_len, (time_t)0, (uint32_t)0); - test_truth(status == MEMCACHED_SUCCESS); + test_true(status == MEMCACHED_SUCCESS); status = memcached_mget(memc, &key, &key_len, 1); - test_truth(status == MEMCACHED_SUCCESS); + test_true(status == MEMCACHED_SUCCESS); result= memcached_result_create(memc, &result_obj); - test_truth(result); + test_true(result); memcached_result_create(memc, &result_obj); result= memcached_fetch_result(memc, &result_obj, &status); - test_truth(result); - test_truth(status == MEMCACHED_SUCCESS); + test_true(result); + test_true(status == MEMCACHED_SUCCESS); memcached_result_free(result); @@ -2693,45 +2919,49 @@ static test_return_t user_supplied_bug18(memcached_st *trash) (void)trash; memc= memcached_create(NULL); - test_truth(memc); + test_true(memc); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED); - test_truth(value == 1); + test_true(value == 1); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH, MEMCACHED_HASH_MD5); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH); - test_truth(value == MEMCACHED_HASH_MD5); + test_true(value == MEMCACHED_HASH_MD5); server_pool = memcached_servers_parse("10.0.1.1:11211 600,10.0.1.2:11211 300,10.0.1.3:11211 200,10.0.1.4:11211 350,10.0.1.5:11211 1000,10.0.1.6:11211 800,10.0.1.7:11211 950,10.0.1.8:11211 100"); memcached_server_push(memc, server_pool); /* verify that the server list was parsed okay. */ - test_truth(memcached_server_count(memc) == 8); - test_truth(strcmp(server_pool[0].hostname, "10.0.1.1") == 0); - test_truth(server_pool[0].port == 11211); - test_truth(server_pool[0].weight == 600); - test_truth(strcmp(server_pool[2].hostname, "10.0.1.3") == 0); - test_truth(server_pool[2].port == 11211); - test_truth(server_pool[2].weight == 200); - test_truth(strcmp(server_pool[7].hostname, "10.0.1.8") == 0); - test_truth(server_pool[7].port == 11211); - test_truth(server_pool[7].weight == 100); + test_true(memcached_server_count(memc) == 8); + test_true(strcmp(server_pool[0].hostname, "10.0.1.1") == 0); + test_true(server_pool[0].port == 11211); + test_true(server_pool[0].weight == 600); + test_true(strcmp(server_pool[2].hostname, "10.0.1.3") == 0); + test_true(server_pool[2].port == 11211); + test_true(server_pool[2].weight == 200); + test_true(strcmp(server_pool[7].hostname, "10.0.1.8") == 0); + test_true(server_pool[7].port == 11211); + test_true(server_pool[7].weight == 100); /* VDEAAAAA hashes to fffcd1b5, after the last continuum point, and lets * us test the boundary wraparound. */ - test_truth(memcached_generate_hash(memc, (char *)"VDEAAAAA", 8) == memc->continuum[0].index); + test_true(memcached_generate_hash(memc, (char *)"VDEAAAAA", 8) == memc->continuum[0].index); /* verify the standard ketama set. */ for (x= 0; x < 99; x++) { uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); - char *hostname = memc->hosts[server_idx].hostname; + + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, server_idx); + + const char *hostname = memcached_server_name(instance); test_strcmp(hostname, ketama_test_cases[x].server); } @@ -2749,14 +2979,20 @@ static test_return_t user_supplied_bug18(memcached_st *trash) */ /* sighandler_t function that always asserts false */ -static void fail(int unused __attribute__((unused))) +static void fail(int unused) { + (void)unused; assert(0); } -static test_return_t _user_supplied_bug21(memcached_st* memc, size_t key_count) +static test_return_t _user_supplied_bug21(memcached_st* memc, size_t key_count) { +#ifdef WIN32 + (void)memc; + (void)key_count; + return TEST_SKIPPED; +#else memcached_return_t rc; unsigned int x; char **keys; @@ -2765,18 +3001,18 @@ static test_return_t _user_supplied_bug21(memcached_st* memc, size_t key_count) memcached_st *memc_clone; memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone); + test_true(memc_clone); /* only binproto uses getq for mget */ memcached_behavior_set(memc_clone, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); /* empty the cache to ensure misses (hence non-responses) */ rc= memcached_flush(memc_clone, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); key_lengths= calloc(key_count, sizeof(size_t)); keys= calloc(key_count, sizeof(char *)); - test_truth(keys); + test_true(keys); for (x= 0; x < key_count; x++) { char buffer[30]; @@ -2790,12 +3026,13 @@ static test_return_t _user_supplied_bug21(memcached_st* memc, size_t key_count) alarm(5); rc= memcached_mget(memc_clone, (const char **)keys, key_lengths, key_count); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); alarm(0); signal(SIGALRM, oldalarm); - test_truth(fetch_all_results(memc) == TEST_SUCCESS); + size_t keys_returned; + test_true(fetch_all_results(memc, &keys_returned) == TEST_SUCCESS); for (x= 0; x < key_count; x++) free(keys[x]); @@ -2805,10 +3042,9 @@ static test_return_t _user_supplied_bug21(memcached_st* memc, size_t key_count) memcached_free(memc_clone); return TEST_SUCCESS; +#endif } -static test_return_t pre_binary(memcached_st *memc); - static test_return_t user_supplied_bug21(memcached_st *memc) { test_return_t test_rc; @@ -2821,11 +3057,11 @@ static test_return_t user_supplied_bug21(memcached_st *memc) /* should work as of r580 */ rc= _user_supplied_bug21(memc, 10); - test_truth(rc == TEST_SUCCESS); + test_true(rc == TEST_SUCCESS); /* should fail as of r580 */ rc= _user_supplied_bug21(memc, 1000); - test_truth(rc == TEST_SUCCESS); + test_true(rc == TEST_SUCCESS); return TEST_SUCCESS; } @@ -2833,65 +3069,74 @@ static test_return_t user_supplied_bug21(memcached_st *memc) static test_return_t auto_eject_hosts(memcached_st *trash) { (void) trash; + memcached_server_instance_st instance; memcached_return_t rc; memcached_st *memc= memcached_create(NULL); - test_truth(memc); + test_true(memc); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); uint64_t value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED); - test_truth(value == 1); + test_true(value == 1); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH, MEMCACHED_HASH_MD5); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH); - test_truth(value == MEMCACHED_HASH_MD5); + test_true(value == MEMCACHED_HASH_MD5); /* server should be removed when in delay */ rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_AUTO_EJECT_HOSTS, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_AUTO_EJECT_HOSTS); - test_truth(value == 1); + test_true(value == 1); memcached_server_st *server_pool; server_pool = memcached_servers_parse("10.0.1.1:11211 600,10.0.1.2:11211 300,10.0.1.3:11211 200,10.0.1.4:11211 350,10.0.1.5:11211 1000,10.0.1.6:11211 800,10.0.1.7:11211 950,10.0.1.8:11211 100"); memcached_server_push(memc, server_pool); /* verify that the server list was parsed okay. */ - test_truth(memcached_server_count(memc) == 8); - test_truth(strcmp(server_pool[0].hostname, "10.0.1.1") == 0); - test_truth(server_pool[0].port == 11211); - test_truth(server_pool[0].weight == 600); - test_truth(strcmp(server_pool[2].hostname, "10.0.1.3") == 0); - test_truth(server_pool[2].port == 11211); - test_truth(server_pool[2].weight == 200); - test_truth(strcmp(server_pool[7].hostname, "10.0.1.8") == 0); - test_truth(server_pool[7].port == 11211); - test_truth(server_pool[7].weight == 100); - - memc->hosts[2].next_retry = time(NULL) + 15; + test_true(memcached_server_count(memc) == 8); + test_true(strcmp(server_pool[0].hostname, "10.0.1.1") == 0); + test_true(server_pool[0].port == 11211); + test_true(server_pool[0].weight == 600); + test_true(strcmp(server_pool[2].hostname, "10.0.1.3") == 0); + test_true(server_pool[2].port == 11211); + test_true(server_pool[2].weight == 200); + test_true(strcmp(server_pool[7].hostname, "10.0.1.8") == 0); + test_true(server_pool[7].port == 11211); + test_true(server_pool[7].weight == 100); + + instance= memcached_server_instance_by_position(memc, 2); + ((memcached_server_write_instance_st)instance)->next_retry = time(NULL) + 15; memc->next_distribution_rebuild= time(NULL) - 1; - for (int x= 0; x < 99; x++) + /* + This would not work if there were only two hosts. + */ + for (size_t x= 0; x < 99; x++) { - uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); - test_truth(server_idx != 2); + memcached_autoeject(memc); + uint32_t server_idx= memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); + test_true(server_idx != 2); } /* and re-added when it's back. */ - memc->hosts[2].next_retry = time(NULL) - 1; + ((memcached_server_write_instance_st)instance)->next_retry = time(NULL) - 1; memc->next_distribution_rebuild= time(NULL) - 1; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_DISTRIBUTION, memc->distribution); - for (int x= 0; x < 99; x++) + for (size_t x= 0; x < 99; x++) { uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); - char *hostname = memc->hosts[server_idx].hostname; - test_truth(strcmp(hostname, ketama_test_cases[x].server) == 0); + // We re-use instance from above. + instance= + memcached_server_instance_by_position(memc, server_idx); + const char *hostname = memcached_server_name(instance); + test_true(strcmp(hostname, ketama_test_cases[x].server) == 0); } memcached_server_list_free(server_pool); @@ -2906,23 +3151,23 @@ static test_return_t output_ketama_weighted_keys(memcached_st *trash) memcached_return_t rc; memcached_st *memc= memcached_create(NULL); - test_truth(memc); + test_true(memc); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); uint64_t value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED); - test_truth(value == 1); + test_true(value == 1); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH, MEMCACHED_HASH_MD5); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH); - test_truth(value == MEMCACHED_HASH_MD5); + test_true(value == MEMCACHED_HASH_MD5); - test_truth(memcached_behavior_set_distribution(memc, MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA_SPY) == MEMCACHED_SUCCESS); + test_true(memcached_behavior_set_distribution(memc, MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA_SPY) == MEMCACHED_SUCCESS); memcached_server_st *server_pool; server_pool = memcached_servers_parse("10.0.1.1:11211,10.0.1.2:11211,10.0.1.3:11211,10.0.1.4:11211,10.0.1.5:11211,10.0.1.6:11211,10.0.1.7:11211,10.0.1.8:11211,192.168.1.1:11211,192.168.100.1:11211"); @@ -2942,12 +3187,14 @@ static test_return_t output_ketama_weighted_keys(memcached_st *trash) for (int x= 0; x < 10000; x++) { char key[10]; - sprintf(key, "%d", x); + snprintf(key, sizeof(key), "%d", x); uint32_t server_idx = memcached_generate_hash(memc, key, strlen(key)); char *hostname = memc->hosts[server_idx].hostname; in_port_t port = memc->hosts[server_idx].port; fprintf(fp, "key %s is on host /%s:%u\n", key, hostname, port); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, host_index); } fclose(fp); #endif @@ -2958,97 +3205,97 @@ static test_return_t output_ketama_weighted_keys(memcached_st *trash) } -static test_return_t result_static(memcached_st *memc) +static test_return_t result_static(memcached_st *memc) { memcached_result_st result; memcached_result_st *result_ptr; result_ptr= memcached_result_create(memc, &result); - test_truth(result.options.is_allocated == false); - test_truth(memcached_is_initialized(&result) == true); - test_truth(result_ptr); - test_truth(result_ptr == &result); + test_true(result.options.is_allocated == false); + test_true(memcached_is_initialized(&result) == true); + test_true(result_ptr); + test_true(result_ptr == &result); memcached_result_free(&result); - test_truth(result.options.is_allocated == false); - test_truth(memcached_is_initialized(&result) == false); + test_true(result.options.is_allocated == false); + test_true(memcached_is_initialized(&result) == false); return TEST_SUCCESS; } -static test_return_t result_alloc(memcached_st *memc) +static test_return_t result_alloc(memcached_st *memc) { memcached_result_st *result_ptr; result_ptr= memcached_result_create(memc, NULL); - test_truth(result_ptr); - test_truth(result_ptr->options.is_allocated == true); - test_truth(memcached_is_initialized(result_ptr) == true); + test_true(result_ptr); + test_true(result_ptr->options.is_allocated == true); + test_true(memcached_is_initialized(result_ptr) == true); memcached_result_free(result_ptr); return TEST_SUCCESS; } -static test_return_t string_static_null(memcached_st *memc) +static test_return_t string_static_null(memcached_st *memc) { memcached_string_st string; memcached_string_st *string_ptr; string_ptr= memcached_string_create(memc, &string, 0); - test_truth(string.options.is_initialized == true); - test_truth(string_ptr); + test_true(string.options.is_initialized == true); + test_true(string_ptr); /* The following two better be the same! */ - test_truth(memcached_is_allocated(string_ptr) == false); - test_truth(memcached_is_allocated(&string) == false); - test_truth(&string == string_ptr); + test_true(memcached_is_allocated(string_ptr) == false); + test_true(memcached_is_allocated(&string) == false); + test_true(&string == string_ptr); - test_truth(string.options.is_initialized == true); - test_truth(memcached_is_initialized(&string) == true); + test_true(string.options.is_initialized == true); + test_true(memcached_is_initialized(&string) == true); memcached_string_free(&string); - test_truth(memcached_is_initialized(&string) == false); + test_true(memcached_is_initialized(&string) == false); return TEST_SUCCESS; } -static test_return_t string_alloc_null(memcached_st *memc) +static test_return_t string_alloc_null(memcached_st *memc) { memcached_string_st *string; string= memcached_string_create(memc, NULL, 0); - test_truth(string); - test_truth(memcached_is_allocated(string) == true); - test_truth(memcached_is_initialized(string) == true); + test_true(string); + test_true(memcached_is_allocated(string) == true); + test_true(memcached_is_initialized(string) == true); memcached_string_free(string); return TEST_SUCCESS; } -static test_return_t string_alloc_with_size(memcached_st *memc) +static test_return_t string_alloc_with_size(memcached_st *memc) { memcached_string_st *string; string= memcached_string_create(memc, NULL, 1024); - test_truth(string); - test_truth(memcached_is_allocated(string) == true); - test_truth(memcached_is_initialized(string) == true); + test_true(string); + test_true(memcached_is_allocated(string) == true); + test_true(memcached_is_initialized(string) == true); memcached_string_free(string); return TEST_SUCCESS; } -static test_return_t string_alloc_with_size_toobig(memcached_st *memc) +static test_return_t string_alloc_with_size_toobig(memcached_st *memc) { memcached_string_st *string; string= memcached_string_create(memc, NULL, SIZE_MAX); - test_truth(string == NULL); + test_true(string == NULL); return TEST_SUCCESS; } -static test_return_t string_alloc_append(memcached_st *memc) +static test_return_t string_alloc_append(memcached_st *memc) { unsigned int x; char buffer[SMALL_STRING_LEN]; @@ -3058,23 +3305,23 @@ static test_return_t string_alloc_append(memcached_st *memc) memset(buffer, 6, SMALL_STRING_LEN); string= memcached_string_create(memc, NULL, 100); - test_truth(string); - test_truth(memcached_is_allocated(string) == true); - test_truth(memcached_is_initialized(string) == true); + test_true(string); + test_true(memcached_is_allocated(string) == true); + test_true(memcached_is_initialized(string) == true); for (x= 0; x < 1024; x++) { memcached_return_t rc; rc= memcached_string_append(string, buffer, SMALL_STRING_LEN); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } - test_truth(memcached_is_allocated(string) == true); + test_true(memcached_is_allocated(string) == true); memcached_string_free(string); return TEST_SUCCESS; } -static test_return_t string_alloc_append_toobig(memcached_st *memc) +static test_return_t string_alloc_append_toobig(memcached_st *memc) { memcached_return_t rc; unsigned int x; @@ -3085,37 +3332,38 @@ static test_return_t string_alloc_append_toobig(memcached_st *memc) memset(buffer, 6, SMALL_STRING_LEN); string= memcached_string_create(memc, NULL, 100); - test_truth(string); - test_truth(memcached_is_allocated(string) == true); - test_truth(memcached_is_initialized(string) == true); + test_true(string); + test_true(memcached_is_allocated(string) == true); + test_true(memcached_is_initialized(string) == true); for (x= 0; x < 1024; x++) { rc= memcached_string_append(string, buffer, SMALL_STRING_LEN); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } rc= memcached_string_append(string, buffer, SIZE_MAX); - test_truth(rc == MEMCACHED_MEMORY_ALLOCATION_FAILURE); - test_truth(memcached_is_allocated(string) == true); + test_true(rc == MEMCACHED_MEMORY_ALLOCATION_FAILURE); + test_true(memcached_is_allocated(string) == true); memcached_string_free(string); return TEST_SUCCESS; } -static test_return_t cleanup_pairs(memcached_st *memc __attribute__((unused))) +static test_return_t cleanup_pairs(memcached_st *memc) { + (void)memc; pairs_free(global_pairs); return TEST_SUCCESS; } -static test_return_t generate_pairs(memcached_st *memc __attribute__((unused))) +static test_return_t generate_pairs(memcached_st *memc) { - unsigned long long x; + (void)memc; global_pairs= pairs_generate(GLOBAL_COUNT, 400); global_count= GLOBAL_COUNT; - for (x= 0; x < global_count; x++) + for (size_t x= 0; x < global_count; x++) { global_keys[x]= global_pairs[x].key; global_keys_length[x]= global_pairs[x].key_length; @@ -3124,13 +3372,13 @@ static test_return_t generate_pairs(memcached_st *memc __attribute__((unused))) return TEST_SUCCESS; } -static test_return_t generate_large_pairs(memcached_st *memc __attribute__((unused))) +static test_return_t generate_large_pairs(memcached_st *memc) { - unsigned long long x; + (void)memc; global_pairs= pairs_generate(GLOBAL2_COUNT, MEMCACHED_MAX_BUFFER+10); global_count= GLOBAL2_COUNT; - for (x= 0; x < global_count; x++) + for (size_t x= 0; x < global_count; x++) { global_keys[x]= global_pairs[x].key; global_keys_length[x]= global_pairs[x].key_length; @@ -3139,38 +3387,45 @@ static test_return_t generate_large_pairs(memcached_st *memc __attribute__((unu return TEST_SUCCESS; } -static test_return_t generate_data(memcached_st *memc) +static test_return_t generate_data(memcached_st *memc) { - execute_set(memc, global_pairs, global_count); + unsigned int check_execute= execute_set(memc, global_pairs, global_count); + + test_true(check_execute == global_count); return TEST_SUCCESS; } -static test_return_t generate_data_with_stats(memcached_st *memc) +static test_return_t generate_data_with_stats(memcached_st *memc) { memcached_stat_st *stat_p; memcached_return_t rc; uint32_t host_index= 0; - execute_set(memc, global_pairs, global_count); + unsigned int check_execute= execute_set(memc, global_pairs, global_count); + + test_true(check_execute == global_count); //TODO: hosts used size stats stat_p= memcached_stat(memc, NULL, &rc); - test_truth(stat_p); + test_true(stat_p); for (host_index= 0; host_index < SERVERS_TO_CREATE; host_index++) { /* This test was changes so that "make test" would work properlly */ #ifdef DEBUG - printf("\nserver %u|%s|%u bytes: %llu\n", host_index, (memc->hosts)[host_index].hostname, (memc->hosts)[host_index].port, (unsigned long long)(stat_p + host_index)->bytes); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, host_index); + + printf("\nserver %u|%s|%u bytes: %llu\n", host_index, instance->hostname, instance->port, (unsigned long long)(stat_p + host_index)->bytes); #endif - test_truth((unsigned long long)(stat_p + host_index)->bytes); + test_true((unsigned long long)(stat_p + host_index)->bytes); } memcached_stat_free(NULL, stat_p); return TEST_SUCCESS; } -static test_return_t generate_buffer_data(memcached_st *memc) +static test_return_t generate_buffer_data(memcached_st *memc) { size_t latch= 0; @@ -3181,14 +3436,13 @@ static test_return_t generate_buffer_data(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t get_read_count(memcached_st *memc) +static test_return_t get_read_count(memcached_st *memc) { - unsigned int x; memcached_return_t rc; memcached_st *memc_clone; memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone); + test_true(memc_clone); memcached_server_add_with_weight(memc_clone, "localhost", 6666, 0); @@ -3198,7 +3452,7 @@ static test_return_t get_read_count(memcached_st *memc) uint32_t flags; uint32_t count; - for (x= count= 0; x < global_count; x++) + for (size_t x= count= 0; x < global_count; x++) { return_value= memcached_get(memc_clone, global_keys[x], global_keys_length[x], &return_value_length, &flags, &rc); @@ -3216,9 +3470,8 @@ static test_return_t get_read_count(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t get_read(memcached_st *memc) +static test_return_t get_read(memcached_st *memc) { - unsigned int x; memcached_return_t rc; { @@ -3226,13 +3479,13 @@ static test_return_t get_read(memcached_st *memc) size_t return_value_length; uint32_t flags; - for (x= 0; x < global_count; x++) + for (size_t x= 0; x < global_count; x++) { return_value= memcached_get(memc, global_keys[x], global_keys_length[x], &return_value_length, &flags, &rc); /* - test_truth(return_value); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(return_value); + test_true(rc == MEMCACHED_SUCCESS); */ if (rc == MEMCACHED_SUCCESS && return_value) free(return_value); @@ -3242,23 +3495,41 @@ static test_return_t get_read(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t mget_read(memcached_st *memc) +static test_return_t mget_read(memcached_st *memc) { memcached_return_t rc; + if (! libmemcached_util_version_check(memc, 1, 4, 4)) + return TEST_SKIPPED; + rc= memcached_mget(memc, global_keys, global_keys_length, global_count); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(fetch_all_results(memc) == TEST_SUCCESS); + + test_true_got(rc == MEMCACHED_SUCCESS, memcached_strerror(NULL, rc)); + + // Go fetch the keys and test to see if all of them were returned + { + size_t keys_returned; + test_true(fetch_all_results(memc, &keys_returned) == TEST_SUCCESS); + char buffer[30]; + snprintf(buffer, sizeof(buffer), "%lu", (unsigned long)keys_returned); + test_true_got(global_count == keys_returned, buffer); + } + return TEST_SUCCESS; } -static test_return_t mget_read_result(memcached_st *memc) +static test_return_t mget_read_result(memcached_st *memc) { memcached_return_t rc; + if (! libmemcached_util_version_check(memc, 1, 4, 4)) + return TEST_SKIPPED; + rc= memcached_mget(memc, global_keys, global_keys_length, global_count); - test_truth(rc == MEMCACHED_SUCCESS); + + test_true_got(rc == MEMCACHED_SUCCESS, memcached_strerror(NULL, rc)); + /* Turn this into a help function */ { memcached_result_st results_obj; @@ -3268,8 +3539,8 @@ static test_return_t mget_read_result(memcached_st *memc) while ((results= memcached_fetch_result(memc, &results_obj, &rc))) { - test_truth(results); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(results); + test_true(rc == MEMCACHED_SUCCESS); } memcached_result_free(&results_obj); @@ -3278,14 +3549,18 @@ static test_return_t mget_read_result(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t mget_read_function(memcached_st *memc) +static test_return_t mget_read_function(memcached_st *memc) { memcached_return_t rc; - unsigned int counter; + size_t counter; memcached_execute_fn callbacks[1]; + if (! libmemcached_util_version_check(memc, 1, 4, 4)) + return TEST_SKIPPED; + rc= memcached_mget(memc, global_keys, global_keys_length, global_count); - test_truth(rc == MEMCACHED_SUCCESS); + + test_true_got(rc == MEMCACHED_SUCCESS, memcached_strerror(NULL, rc)); callbacks[0]= &callback_counter; counter= 0; @@ -3294,11 +3569,9 @@ static test_return_t mget_read_function(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t delete_generate(memcached_st *memc) +static test_return_t delete_generate(memcached_st *memc) { - unsigned int x; - - for (x= 0; x < global_count; x++) + for (size_t x= 0; x < global_count; x++) { (void)memcached_delete(memc, global_keys[x], global_keys_length[x], (time_t)0); } @@ -3306,15 +3579,14 @@ static test_return_t delete_generate(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t delete_buffer_generate(memcached_st *memc) +static test_return_t delete_buffer_generate(memcached_st *memc) { - size_t latch= 0; - unsigned int x; + uint64_t latch= 0; latch= 1; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, latch); - for (x= 0; x < global_count; x++) + for (size_t x= 0; x < global_count; x++) { (void)memcached_delete(memc, global_keys[x], global_keys_length[x], (time_t)0); } @@ -3322,62 +3594,94 @@ static test_return_t delete_buffer_generate(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t add_host_test1(memcached_st *memc) +static test_return_t add_host_test1(memcached_st *memc) { - unsigned int x; memcached_return_t rc; char servername[]= "0.example.com"; memcached_server_st *servers; servers= memcached_server_list_append_with_weight(NULL, servername, 400, 0, &rc); - test_truth(servers); - test_truth(1 == memcached_server_list_count(servers)); + test_true(servers); + test_true(1 == memcached_server_list_count(servers)); - for (x= 2; x < 20; x++) + for (size_t x= 2; x < 20; x++) { char buffer[SMALL_STRING_LEN]; - snprintf(buffer, SMALL_STRING_LEN, "%u.example.com", 400+x); + snprintf(buffer, SMALL_STRING_LEN, "%lu.example.com", (unsigned long)(400 +x)); servers= memcached_server_list_append_with_weight(servers, buffer, 401, 0, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(x == memcached_server_list_count(servers)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(x == memcached_server_list_count(servers)); } rc= memcached_server_push(memc, servers); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_server_push(memc, servers); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_server_list_free(servers); return TEST_SUCCESS; } -static test_return_t pre_nonblock(memcached_st *memc) +static test_return_t pre_nonblock(memcached_st *memc) { memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, 0); return TEST_SUCCESS; } +static test_return_t pre_cork(memcached_st *memc) +{ + memcached_return_t rc; + bool set= true; + + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_CORK, set); + +#ifdef __APPLE__ + return TEST_SKIPPED; +#endif + + if (rc == MEMCACHED_SUCCESS) + return TEST_SUCCESS; + + return TEST_SKIPPED; +} + +static test_return_t pre_cork_and_nonblock(memcached_st *memc) +{ + test_return_t rc; + + rc= pre_cork(memc); + +#ifdef __APPLE__ + return TEST_SKIPPED; +#endif + + if (rc != TEST_SUCCESS) + return rc; + + return pre_nonblock(memc); +} + static test_return_t pre_nonblock_binary(memcached_st *memc) { memcached_return_t rc= MEMCACHED_FAILURE; memcached_st *memc_clone; memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone); + test_true(memc_clone); // The memcached_version needs to be done on a clone, because the server // will not toggle protocol on an connection. memcached_version(memc_clone); - if (memc_clone->hosts[0].major_version >= 1 && memc_clone->hosts[0].minor_version > 2) + if (libmemcached_util_version_check(memc_clone, 1, 4, 4)) { memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, 0); rc = memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) == 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) == 1); } else { @@ -3463,10 +3767,10 @@ static test_return_t pre_behavior_ketama(memcached_st *memc) uint64_t value; rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA); - test_truth(value == 1); + test_true(value == 1); return TEST_SUCCESS; } @@ -3477,16 +3781,16 @@ static test_return_t pre_behavior_ketama_weighted(memcached_st *memc) uint64_t value; rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED); - test_truth(value == 1); + test_true(value == 1); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH, MEMCACHED_HASH_MD5); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_HASH); - test_truth(value == MEMCACHED_HASH_MD5); + test_true(value == MEMCACHED_HASH_MD5); return TEST_SUCCESS; } @@ -3497,26 +3801,42 @@ static test_return_t pre_behavior_ketama_weighted(memcached_st *memc) static test_return_t pre_binary(memcached_st *memc) { memcached_return_t rc= MEMCACHED_FAILURE; - memcached_st *memc_clone; - - memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone); - // The memcached_version needs to be done on a clone, because the server - // will not toggle protocol on an connection. - memcached_version(memc_clone); - if (memc_clone->hosts[0].major_version >= 1 && memc_clone->hosts[0].minor_version > 2) + if (libmemcached_util_version_check(memc, 1, 4, 4)) { rc = memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) == 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL) == 1); } - memcached_free(memc_clone); - return rc == MEMCACHED_SUCCESS ? TEST_SUCCESS : TEST_SKIPPED; } +static test_return_t pre_sasl(memcached_st *memc) +{ + memcached_return_t rc= MEMCACHED_FAILURE; + +#ifdef LIBMEMCACHED_WITH_SASL_SUPPORT + const char *server= getenv("LIBMEMCACHED_TEST_SASL_SERVER"); + const char *user= getenv("LIBMEMCACHED_TEST_SASL_USERNAME"); + const char *pass= getenv("LIBMEMCACHED_TEST_SASL_PASSWORD"); + + if (server != NULL && user != NULL && pass != NULL) + { + memcached_server_st *servers= memcached_servers_parse(server); + test_true(servers != NULL); + memcached_servers_reset(memc); + test_true(memcached_server_push(memc, servers) == MEMCACHED_SUCCESS); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + rc= memcached_set_sasl_auth_data(memc, user, pass); + test_true(rc == MEMCACHED_SUCCESS); + } +#else + (void)memc; +#endif + + return rc == MEMCACHED_SUCCESS ? TEST_SUCCESS : TEST_SKIPPED; +} static test_return_t pre_replication(memcached_st *memc) { @@ -3533,8 +3853,8 @@ static test_return_t pre_replication(memcached_st *memc) memcached_return_t rc; rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS, memcached_server_count(memc) - 1); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS) == memcached_server_count(memc) - 1); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS) == memcached_server_count(memc) - 1); return rc == MEMCACHED_SUCCESS ? TEST_SUCCESS : TEST_SKIPPED; } @@ -3554,8 +3874,10 @@ static test_return_t pre_replication_noblock(memcached_st *memc) } -static void my_free(memcached_st *ptr __attribute__((unused)), void *mem) +static void my_free(const memcached_st *ptr, void *mem, void *context) { + (void)context; + (void)ptr; #ifdef HARD_MALLOC_TESTS void *real_ptr= (mem == NULL) ? mem : (void*)((caddr_t)mem - 8); free(real_ptr); @@ -3565,8 +3887,10 @@ static void my_free(memcached_st *ptr __attribute__((unused)), void *mem) } -static void *my_malloc(memcached_st *ptr __attribute__((unused)), const size_t size) +static void *my_malloc(const memcached_st *ptr, const size_t size, void *context) { + (void)context; + (void)ptr; #ifdef HARD_MALLOC_TESTS void *ret= malloc(size + 8); if (ret != NULL) @@ -3586,8 +3910,9 @@ static void *my_malloc(memcached_st *ptr __attribute__((unused)), const size_t s } -static void *my_realloc(memcached_st *ptr __attribute__((unused)), void *mem, const size_t size) +static void *my_realloc(const memcached_st *ptr, void *mem, const size_t size, void *context) { + (void)context; #ifdef HARD_MALLOC_TESTS void *real_ptr= (mem == NULL) ? NULL : (void*)((caddr_t)mem - 8); void *nmem= realloc(real_ptr, size + 8); @@ -3600,13 +3925,15 @@ static void *my_realloc(memcached_st *ptr __attribute__((unused)), void *mem, co return ret; #else + (void)ptr; return realloc(mem, size); #endif } -static void *my_calloc(memcached_st *ptr __attribute__((unused)), size_t nelem, const size_t size) +static void *my_calloc(const memcached_st *ptr, size_t nelem, const size_t size, void *context) { + (void)context; #ifdef HARD_MALLOC_TESTS void *mem= my_malloc(ptr, nelem * size); if (mem) @@ -3616,6 +3943,7 @@ static void *my_calloc(memcached_st *ptr __attribute__((unused)), size_t nelem, return mem; #else + (void)ptr; return calloc(nelem, size); #endif } @@ -3629,30 +3957,30 @@ static test_return_t set_prefix(memcached_st *memc) /* Make sure be default none exists */ value= memcached_callback_get(memc, MEMCACHED_CALLBACK_PREFIX_KEY, &rc); - test_truth(rc == MEMCACHED_FAILURE); + test_true(rc == MEMCACHED_FAILURE); /* Test a clean set */ rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, (void *)key); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_callback_get(memc, MEMCACHED_CALLBACK_PREFIX_KEY, &rc); - test_truth(memcmp(value, key, 4) == 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(memcmp(value, key, 4) == 0); + test_true(rc == MEMCACHED_SUCCESS); /* Test that we can turn it off */ rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, NULL); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_callback_get(memc, MEMCACHED_CALLBACK_PREFIX_KEY, &rc); - test_truth(rc == MEMCACHED_FAILURE); + test_true(rc == MEMCACHED_FAILURE); /* Now setup for main test */ rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, (void *)key); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_callback_get(memc, MEMCACHED_CALLBACK_PREFIX_KEY, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memcmp(value, key, 4) == 0); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memcmp(value, key, 4) == 0); /* Set to Zero, and then Set to something too large */ { @@ -3660,31 +3988,31 @@ static test_return_t set_prefix(memcached_st *memc) memset(long_key, 0, 255); rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, NULL); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_callback_get(memc, MEMCACHED_CALLBACK_PREFIX_KEY, &rc); - test_truth(rc == MEMCACHED_FAILURE); - test_truth(value == NULL); + test_true(rc == MEMCACHED_FAILURE); + test_true(value == NULL); /* Test a long key for failure */ /* TODO, extend test to determine based on setting, what result should be */ strcpy(long_key, "Thisismorethentheallottednumberofcharacters"); rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, long_key); - //test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); - test_truth(rc == MEMCACHED_SUCCESS); + //test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(rc == MEMCACHED_SUCCESS); /* Now test a key with spaces (which will fail from long key, since bad key is not set) */ strcpy(long_key, "This is more then the allotted number of characters"); rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, long_key); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); /* Test for a bad prefix, but with a short key */ rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_VERIFY_KEY, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); strcpy(long_key, "dog cat"); rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_PREFIX_KEY, long_key); - test_truth(rc == MEMCACHED_BAD_KEY_PROVIDED); + test_true(rc == MEMCACHED_BAD_KEY_PROVIDED); } return TEST_SUCCESS; @@ -3703,10 +4031,10 @@ static test_return_t deprecated_set_memory_alloc(memcached_st *memc) memcached_return_t rc; rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_MALLOC_FUNCTION, cb_ptr); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); test_ptr= memcached_callback_get(memc, MEMCACHED_CALLBACK_MALLOC_FUNCTION, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(test_ptr == cb_ptr); + test_true(rc == MEMCACHED_SUCCESS); + test_true(test_ptr == cb_ptr); } { @@ -3716,10 +4044,10 @@ static test_return_t deprecated_set_memory_alloc(memcached_st *memc) memcached_return_t rc; rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_REALLOC_FUNCTION, cb_ptr); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); test_ptr= memcached_callback_get(memc, MEMCACHED_CALLBACK_REALLOC_FUNCTION, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(test_ptr == cb_ptr); + test_true(rc == MEMCACHED_SUCCESS); + test_true(test_ptr == cb_ptr); } { @@ -3729,10 +4057,10 @@ static test_return_t deprecated_set_memory_alloc(memcached_st *memc) memcached_return_t rc; rc= memcached_callback_set(memc, MEMCACHED_CALLBACK_FREE_FUNCTION, cb_ptr); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); test_ptr= memcached_callback_get(memc, MEMCACHED_CALLBACK_FREE_FUNCTION, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(test_ptr == cb_ptr); + test_true(rc == MEMCACHED_SUCCESS); + test_true(test_ptr == cb_ptr); } return TEST_SUCCESS; @@ -3744,11 +4072,11 @@ static test_return_t set_memory_alloc(memcached_st *memc) { memcached_return_t rc; rc= memcached_set_memory_allocators(memc, NULL, my_free, - my_realloc, my_calloc); - test_truth(rc == MEMCACHED_FAILURE); + my_realloc, my_calloc, NULL); + test_true(rc == MEMCACHED_FAILURE); rc= memcached_set_memory_allocators(memc, my_malloc, my_free, - my_realloc, my_calloc); + my_realloc, my_calloc, NULL); memcached_malloc_fn mem_malloc; memcached_free_fn mem_free; @@ -3757,10 +4085,10 @@ static test_return_t set_memory_alloc(memcached_st *memc) memcached_get_memory_allocators(memc, &mem_malloc, &mem_free, &mem_realloc, &mem_calloc); - test_truth(mem_malloc == my_malloc); - test_truth(mem_realloc == my_realloc); - test_truth(mem_calloc == my_calloc); - test_truth(mem_free == my_free); + test_true(mem_malloc == my_malloc); + test_true(mem_realloc == my_realloc); + test_true(mem_calloc == my_calloc); + test_true(mem_free == my_free); return TEST_SUCCESS; } @@ -3775,7 +4103,7 @@ static test_return_t enable_consistent_crc(memcached_st *memc) return rc; value= (memcached_server_distribution_t)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_DISTRIBUTION); - test_truth(value == MEMCACHED_DISTRIBUTION_CONSISTENT); + test_true(value == MEMCACHED_DISTRIBUTION_CONSISTENT); hash= (memcached_hash_t)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_HASH); @@ -3795,7 +4123,7 @@ static test_return_t enable_consistent_hsieh(memcached_st *memc) return rc; value= (memcached_server_distribution_t)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_DISTRIBUTION); - test_truth(value == MEMCACHED_DISTRIBUTION_CONSISTENT); + test_true(value == MEMCACHED_DISTRIBUTION_CONSISTENT); hash= (memcached_hash_t)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_HASH); @@ -3810,10 +4138,7 @@ static test_return_t enable_cas(memcached_st *memc) { unsigned int set= 1; - memcached_version(memc); - - if ((memc->hosts[0].major_version >= 1 && (memc->hosts[0].minor_version == 2 && memc->hosts[0].micro_version >= 4)) - || memc->hosts[0].minor_version > 2) + if (libmemcached_util_version_check(memc, 1, 2, 4)) { memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS, set); @@ -3823,18 +4148,23 @@ static test_return_t enable_cas(memcached_st *memc) return TEST_SKIPPED; } -static test_return_t check_for_1_2_3(memcached_st *memc) +static test_return_t check_for_1_2_3(memcached_st *memc) { memcached_version(memc); - if ((memc->hosts[0].major_version >= 1 && (memc->hosts[0].minor_version == 2 && memc->hosts[0].micro_version >= 4)) - || memc->hosts[0].minor_version > 2) + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); + + if ((instance->major_version >= 1 && (instance->minor_version == 2 && instance->micro_version >= 4)) + || instance->minor_version > 2) + { return TEST_SUCCESS; + } return TEST_SKIPPED; } -static test_return_t pre_unix_socket(memcached_st *memc) +static test_return_t pre_unix_socket(memcached_st *memc) { memcached_return_t rc; struct stat buf; @@ -3849,7 +4179,7 @@ static test_return_t pre_unix_socket(memcached_st *memc) return ( rc == MEMCACHED_SUCCESS ? TEST_SUCCESS : TEST_FAILURE ); } -static test_return_t pre_nodelay(memcached_st *memc) +static test_return_t pre_nodelay(memcached_st *memc) { memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, 0); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY, 0); @@ -3857,7 +4187,7 @@ static test_return_t pre_nodelay(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t pre_settimer(memcached_st *memc) +static test_return_t pre_settimer(memcached_st *memc) { memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SND_TIMEOUT, 1000); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RCV_TIMEOUT, 1000); @@ -3865,7 +4195,7 @@ static test_return_t pre_settimer(memcached_st *memc) return TEST_SUCCESS; } -static test_return_t poll_timeout(memcached_st *memc) +static test_return_t poll_timeout(memcached_st *memc) { size_t timeout; @@ -3875,7 +4205,7 @@ static test_return_t poll_timeout(memcached_st *memc) timeout= (size_t)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_POLL_TIMEOUT); - test_truth(timeout == 100); + test_true(timeout == 100); return TEST_SUCCESS; } @@ -3884,21 +4214,25 @@ static test_return_t noreply_test(memcached_st *memc) { memcached_return_t ret; ret= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 1); - test_truth(ret == MEMCACHED_SUCCESS); + test_true(ret == MEMCACHED_SUCCESS); ret= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1); - test_truth(ret == MEMCACHED_SUCCESS); + test_true(ret == MEMCACHED_SUCCESS); ret= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS, 1); - test_truth(ret == MEMCACHED_SUCCESS); - test_truth(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NOREPLY) == 1); - test_truth(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS) == 1); - test_truth(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS) == 1); + test_true(ret == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_NOREPLY) == 1); + test_true(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS) == 1); + test_true(memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_SUPPORT_CAS) == 1); for (int count=0; count < 5; ++count) { - for (int x=0; x < 100; ++x) + for (size_t x= 0; x < 100; ++x) { char key[10]; - size_t len= (size_t)sprintf(key, "%d", x); + int check_length= (size_t)snprintf(key, sizeof(key), "%lu", (unsigned long)x); + test_false((size_t)check_length >= sizeof(key) || check_length < 0); + + size_t len= (size_t)check_length; + switch (count) { case 0: @@ -3917,10 +4251,10 @@ static test_return_t noreply_test(memcached_st *memc) ret= memcached_prepend(memc, key, len, key, len, 0, 0); break; default: - test_truth(count); + test_true(count); break; } - test_truth(ret == MEMCACHED_SUCCESS || ret == MEMCACHED_BUFFERED); + test_true(ret == MEMCACHED_SUCCESS || ret == MEMCACHED_BUFFERED); } /* @@ -3929,40 +4263,49 @@ static test_return_t noreply_test(memcached_st *memc) ** way it is supposed to do!!!! */ int no_msg=0; - for (uint32_t x=0; x < memcached_server_count(memc); ++x) - no_msg+=(int)(memc->hosts[x].cursor_active); + for (uint32_t x= 0; x < memcached_server_count(memc); ++x) + { + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, x); + no_msg+=(int)(instance->cursor_active); + } - test_truth(no_msg == 0); - test_truth(memcached_flush_buffers(memc) == MEMCACHED_SUCCESS); + test_true(no_msg == 0); + test_true(memcached_flush_buffers(memc) == MEMCACHED_SUCCESS); /* ** Now validate that all items was set properly! */ - for (int x=0; x < 100; ++x) + for (size_t x= 0; x < 100; ++x) { char key[10]; - size_t len= (size_t)sprintf(key, "%d", x); + + int check_length= (size_t)snprintf(key, sizeof(key), "%lu", (unsigned long)x); + + test_false((size_t)check_length >= sizeof(key) || check_length < 0); + + size_t len= (size_t)check_length; size_t length; uint32_t flags; char* value=memcached_get(memc, key, strlen(key), &length, &flags, &ret); - test_truth(ret == MEMCACHED_SUCCESS && value != NULL); + test_true(ret == MEMCACHED_SUCCESS && value != NULL); switch (count) { case 0: /* FALLTHROUGH */ case 1: /* FALLTHROUGH */ case 2: - test_truth(strncmp(value, key, len) == 0); - test_truth(len == length); + test_true(strncmp(value, key, len) == 0); + test_true(len == length); break; case 3: - test_truth(length == len * 2); + test_true(length == len * 2); break; case 4: - test_truth(length == len * 3); + test_true(length == len * 3); break; default: - test_truth(count); + test_true(count); break; } free(value); @@ -3979,28 +4322,28 @@ static test_return_t noreply_test(memcached_st *memc) memcached_result_st results_obj; memcached_result_st *results; ret= memcached_mget(memc, keys, lengths, 1); - test_truth(ret == MEMCACHED_SUCCESS); + test_true(ret == MEMCACHED_SUCCESS); results= memcached_result_create(memc, &results_obj); - test_truth(results); + test_true(results); results= memcached_fetch_result(memc, &results_obj, &ret); - test_truth(results); - test_truth(ret == MEMCACHED_SUCCESS); + test_true(results); + test_true(ret == MEMCACHED_SUCCESS); uint64_t cas= memcached_result_cas(results); memcached_result_free(&results_obj); ret= memcached_cas(memc, keys[0], lengths[0], keys[0], lengths[0], 0, 0, cas); - test_truth(ret == MEMCACHED_SUCCESS); + test_true(ret == MEMCACHED_SUCCESS); /* * The item will have a new cas value, so try to set it again with the old * value. This should fail! */ ret= memcached_cas(memc, keys[0], lengths[0], keys[0], lengths[0], 0, 0, cas); - test_truth(ret == MEMCACHED_SUCCESS); - test_truth(memcached_flush_buffers(memc) == MEMCACHED_SUCCESS); + test_true(ret == MEMCACHED_SUCCESS); + test_true(memcached_flush_buffers(memc) == MEMCACHED_SUCCESS); char* value=memcached_get(memc, keys[0], lengths[0], &length, &flags, &ret); - test_truth(ret == MEMCACHED_SUCCESS && value != NULL); + test_true(ret == MEMCACHED_SUCCESS && value != NULL); free(value); return TEST_SUCCESS; @@ -4013,12 +4356,12 @@ static test_return_t analyzer_test(memcached_st *memc) memcached_analysis_st *report; memc_stat= memcached_stat(memc, NULL, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(memc_stat); + test_true(rc == MEMCACHED_SUCCESS); + test_true(memc_stat); report= memcached_analyze(memc, memc_stat, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(report); + test_true(rc == MEMCACHED_SUCCESS); + test_true(report); free(report); memcached_stat_free(NULL, memc_stat); @@ -4027,12 +4370,13 @@ static test_return_t analyzer_test(memcached_st *memc) } /* Count the objects */ -static memcached_return_t callback_dump_counter(memcached_st *ptr __attribute__((unused)), - const char *key __attribute__((unused)), - size_t key_length __attribute__((unused)), - void *context) +static memcached_return_t callback_dump_counter(const memcached_st *ptr, + const char *key, + size_t key_length, + void *context) { - uint32_t *counter= (uint32_t *)context; + (void)ptr; (void)key; (void)key_length; + size_t *counter= (size_t *)context; *counter= *counter + 1; @@ -4042,7 +4386,7 @@ static memcached_return_t callback_dump_counter(memcached_st *ptr __attribute__( static test_return_t dump_test(memcached_st *memc) { memcached_return_t rc; - uint32_t counter= 0; + size_t counter= 0; memcached_dump_fn callbacks[1]; test_return_t main_rc; @@ -4054,13 +4398,13 @@ static test_return_t dump_test(memcached_st *memc) main_rc= set_test3(memc); - test_truth (main_rc == TEST_SUCCESS); + test_true (main_rc == TEST_SUCCESS); rc= memcached_dump(memc, callbacks, (void *)&counter, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); /* We may have more then 32 if our previous flush has not completed */ - test_truth(counter >= 32); + test_true(counter >= 32); return TEST_SUCCESS; } @@ -4078,21 +4422,23 @@ static void* connection_release(void *arg) return arg; } +#define POOL_SIZE 10 static test_return_t connection_pool_test(memcached_st *memc) { - memcached_pool_st* pool= memcached_pool_create(memc, 5, 10); - test_truth(pool != NULL); - memcached_st* mmc[10]; + memcached_pool_st* pool= memcached_pool_create(memc, 5, POOL_SIZE); + test_true(pool != NULL); + memcached_st *mmc[POOL_SIZE]; memcached_return_t rc; - for (int x= 0; x < 10; ++x) { + for (size_t x= 0; x < POOL_SIZE; ++x) + { mmc[x]= memcached_pool_pop(pool, false, &rc); - test_truth(mmc[x] != NULL); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(mmc[x] != NULL); + test_true(rc == MEMCACHED_SUCCESS); } - test_truth(memcached_pool_pop(pool, false, &rc) == NULL); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(memcached_pool_pop(pool, false, &rc) == NULL); + test_true(rc == MEMCACHED_SUCCESS); pthread_t tid; struct { @@ -4101,26 +4447,29 @@ static test_return_t connection_pool_test(memcached_st *memc) } item= { .pool = pool, .mmc = mmc[9] }; pthread_create(&tid, NULL, connection_release, &item); mmc[9]= memcached_pool_pop(pool, true, &rc); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); pthread_join(tid, NULL); - test_truth(mmc[9] == item.mmc); + test_true(mmc[9] == item.mmc); const char *key= "key"; size_t keylen= strlen(key); // verify that I can do ops with all connections rc= memcached_set(mmc[0], key, keylen, "0", 1, 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); - for (unsigned int x= 0; x < 10; ++x) { + for (size_t x= 0; x < POOL_SIZE; ++x) + { uint64_t number_value; rc= memcached_increment(mmc[x], key, keylen, 1, &number_value); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(number_value == (x+1)); + test_true(rc == MEMCACHED_SUCCESS); + test_true(number_value == (x+1)); } // Release them.. - for (int x= 0; x < 10; ++x) - test_truth(memcached_pool_push(pool, mmc[x]) == MEMCACHED_SUCCESS); + for (size_t x= 0; x < POOL_SIZE; ++x) + { + test_true(memcached_pool_push(pool, mmc[x]) == MEMCACHED_SUCCESS); + } /* verify that I can set behaviors on the pool when I don't have all @@ -4128,24 +4477,94 @@ static test_return_t connection_pool_test(memcached_st *memc) * when I push the item into the pool */ mmc[0]= memcached_pool_pop(pool, false, &rc); - test_truth(mmc[0] != NULL); + test_true(mmc[0] != NULL); rc= memcached_pool_behavior_set(pool, MEMCACHED_BEHAVIOR_IO_MSG_WATERMARK, 9999); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); mmc[1]= memcached_pool_pop(pool, false, &rc); - test_truth(mmc[1] != NULL); + test_true(mmc[1] != NULL); - test_truth(memcached_behavior_get(mmc[1], MEMCACHED_BEHAVIOR_IO_MSG_WATERMARK) == 9999); - test_truth(memcached_pool_push(pool, mmc[1]) == MEMCACHED_SUCCESS); - test_truth(memcached_pool_push(pool, mmc[0]) == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get(mmc[1], MEMCACHED_BEHAVIOR_IO_MSG_WATERMARK) == 9999); + test_true(memcached_pool_push(pool, mmc[1]) == MEMCACHED_SUCCESS); + test_true(memcached_pool_push(pool, mmc[0]) == MEMCACHED_SUCCESS); mmc[0]= memcached_pool_pop(pool, false, &rc); - test_truth(memcached_behavior_get(mmc[0], MEMCACHED_BEHAVIOR_IO_MSG_WATERMARK) == 9999); - test_truth(memcached_pool_push(pool, mmc[0]) == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get(mmc[0], MEMCACHED_BEHAVIOR_IO_MSG_WATERMARK) == 9999); + test_true(memcached_pool_push(pool, mmc[0]) == MEMCACHED_SUCCESS); + + test_true(memcached_pool_destroy(pool) == memc); + + return TEST_SUCCESS; +} + +static test_return_t util_version_test(memcached_st *memc) +{ + bool if_successful; + + if_successful= libmemcached_util_version_check(memc, 0, 0, 0); + test_true(if_successful == true); + + if_successful= libmemcached_util_version_check(memc, 9, 9, 9); + + // We expect failure + if (if_successful) + { + fprintf(stderr, "\n----------------------------------------------------------------------\n"); + fprintf(stderr, "\nDumping Server Information\n\n"); + memcached_server_fn callbacks[1]; + + callbacks[0]= dump_server_information; + memcached_server_cursor(memc, callbacks, (void *)stderr, 1); + fprintf(stderr, "\n----------------------------------------------------------------------\n"); + } + test_true(if_successful == false); + + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); + + memcached_version(memc); + + // We only use one binary when we test, so this should be just fine. + if_successful= libmemcached_util_version_check(memc, instance->major_version, instance->minor_version, instance->micro_version); + test_true(if_successful == true); + + if (instance->micro_version > 0) + if_successful= libmemcached_util_version_check(memc, instance->major_version, instance->minor_version, (uint8_t)(instance->micro_version -1)); + else if (instance->minor_version > 0) + if_successful= libmemcached_util_version_check(memc, instance->major_version, (uint8_t)(instance->minor_version - 1), instance->micro_version); + else if (instance->major_version > 0) + if_successful= libmemcached_util_version_check(memc, (uint8_t)(instance->major_version -1), instance->minor_version, instance->micro_version); + + test_true(if_successful == true); + + if (instance->micro_version > 0) + if_successful= libmemcached_util_version_check(memc, instance->major_version, instance->minor_version, (uint8_t)(instance->micro_version +1)); + else if (instance->minor_version > 0) + if_successful= libmemcached_util_version_check(memc, instance->major_version, (uint8_t)(instance->minor_version +1), instance->micro_version); + else if (instance->major_version > 0) + if_successful= libmemcached_util_version_check(memc, (uint8_t)(instance->major_version +1), instance->minor_version, instance->micro_version); + + test_true(if_successful == false); + + return TEST_SUCCESS; +} + +static test_return_t ping_test(memcached_st *memc) +{ + memcached_return_t rc; + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); + + // Test both the version that returns a code, and the one that does not. + test_true(libmemcached_util_ping(memcached_server_name(instance), + memcached_server_port(instance), NULL)); + + test_true(libmemcached_util_ping(memcached_server_name(instance), + memcached_server_port(instance), &rc)); + test_true(rc == MEMCACHED_SUCCESS); - test_truth(memcached_pool_destroy(pool) == memc); return TEST_SUCCESS; } #endif @@ -4157,7 +4576,7 @@ static test_return_t replication_set_test(memcached_st *memc) memcached_behavior_set(memc_clone, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS, 0); rc= memcached_set(memc, "bubba", 5, "0", 1, 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); /* ** We are using the quiet commands to store the replicas, so we need @@ -4187,8 +4606,8 @@ static test_return_t replication_set_test(memcached_st *memc) uint32_t flags; char *val= memcached_get_by_key(memc_clone, key, 1, "bubba", 5, &len, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(val != NULL); + test_true(rc == MEMCACHED_SUCCESS); + test_true(val != NULL); free(val); } @@ -4209,7 +4628,10 @@ static test_return_t replication_get_test(memcached_st *memc) for (uint32_t host= 0; host < memcached_server_count(memc); ++host) { memcached_st *memc_clone= memcached_clone(NULL, memc); - memc_clone->hosts[host].port= 0; + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc_clone, host); + + ((memcached_server_write_instance_st)instance)->port= 0; for (int x= 'a'; x <= 'z'; ++x) { @@ -4218,8 +4640,8 @@ static test_return_t replication_get_test(memcached_st *memc) uint32_t flags; char *val= memcached_get_by_key(memc_clone, key, 1, "bubba", 5, &len, &flags, &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(val != NULL); + test_true(rc == MEMCACHED_SUCCESS); + test_true(val != NULL); free(val); } @@ -4238,10 +4660,10 @@ static test_return_t replication_mget_test(memcached_st *memc) const char *keys[]= { "bubba", "key1", "key2", "key3" }; size_t len[]= { 5, 4, 4, 4 }; - for (int x=0; x< 4; ++x) + for (size_t x= 0; x< 4; ++x) { rc= memcached_set(memc, keys[x], len[x], "0", 1, 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } /* @@ -4268,24 +4690,26 @@ static test_return_t replication_mget_test(memcached_st *memc) for (uint32_t host= 0; host < memc_clone->number_of_hosts; host++) { memcached_st *new_clone= memcached_clone(NULL, memc); - new_clone->hosts[host].port= 0; + memcached_server_instance_st instance= + memcached_server_instance_by_position(new_clone, host); + ((memcached_server_write_instance_st)instance)->port= 0; for (int x= 'a'; x <= 'z'; ++x) { - const char key[2]= { [0]= (const char)x }; + char key[2]= { [0]= (char)x, [1]= 0 }; rc= memcached_mget_by_key(new_clone, key, 1, keys, len, 4); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_result_st *results= memcached_result_create(new_clone, &result_obj); - test_truth(results); + test_true(results); int hits= 0; while ((results= memcached_fetch_result(new_clone, &result_obj, &rc)) != NULL) { hits++; } - test_truth(hits == 4); + test_true(hits == 4); memcached_result_free(&result_obj); } @@ -4308,29 +4732,30 @@ static test_return_t replication_randomize_mget_test(memcached_st *memc) const char *keys[]= { "key1", "key2", "key3", "key4", "key5", "key6", "key7" }; size_t len[]= { 4, 4, 4, 4, 4, 4, 4 }; - for (int x=0; x< 7; ++x) + for (size_t x= 0; x< 7; ++x) { rc= memcached_set(memc, keys[x], len[x], "1", 1, 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } memcached_quit(memc); - for (int x=0; x< 7; ++x) { + for (size_t x= 0; x< 7; ++x) + { const char key[2]= { [0]= (const char)x }; rc= memcached_mget_by_key(memc_clone, key, 1, keys, len, 7); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_result_st *results= memcached_result_create(memc_clone, &result_obj); - test_truth(results); + test_true(results); int hits= 0; while ((results= memcached_fetch_result(memc_clone, &result_obj, &rc)) != NULL) { ++hits; } - test_truth(hits == 7); + test_true(hits == 7); memcached_result_free(&result_obj); } memcached_free(memc_clone); @@ -4349,10 +4774,10 @@ static test_return_t replication_delete_test(memcached_st *memc) const char *keys[]= { "bubba", "key1", "key2", "key3" }; size_t len[]= { 5, 4, 4, 4 }; - for (int x=0; x< 4; ++x) + for (size_t x= 0; x< 4; ++x) { rc= memcached_delete_by_key(memc, keys[0], len[0], keys[x], len[x], 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } /* @@ -4363,7 +4788,10 @@ static test_return_t replication_delete_test(memcached_st *memc) uint32_t hash= memcached_generate_hash(memc, keys[0], len[0]); for (uint32_t x= 0; x < (repl + 1); ++x) { - memc_clone->hosts[hash].port= 0; + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc_clone, x); + + ((memcached_server_write_instance_st)instance)->port= 0; if (++hash == memc_clone->number_of_hosts) hash= 0; } @@ -4371,22 +4799,22 @@ static test_return_t replication_delete_test(memcached_st *memc) memcached_result_st result_obj; for (uint32_t host= 0; host < memc_clone->number_of_hosts; ++host) { - for (int x= 'a'; x <= 'z'; ++x) + for (size_t x= 'a'; x <= 'z'; ++x) { const char key[2]= { [0]= (const char)x }; rc= memcached_mget_by_key(memc_clone, key, 1, keys, len, 4); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_result_st *results= memcached_result_create(memc_clone, &result_obj); - test_truth(results); + test_true(results); int hits= 0; while ((results= memcached_fetch_result(memc_clone, &result_obj, &rc)) != NULL) { ++hits; } - test_truth(hits == 4); + test_true(hits == 4); memcached_result_free(&result_obj); } } @@ -4395,543 +4823,407 @@ static test_return_t replication_delete_test(memcached_st *memc) return TEST_SUCCESS; } -static void increment_request_id(uint16_t *id) -{ - (*id)++; - if ((*id & UDP_REQUEST_ID_THREAD_MASK) != 0) - *id= 0; -} - -static uint16_t *get_udp_request_ids(memcached_st *memc) +#if 0 +static test_return_t hash_sanity_test (memcached_st *memc) { - uint16_t *ids= malloc(sizeof(uint16_t) * memcached_server_count(memc)); - assert(ids != NULL); - unsigned int x; + (void)memc; - for (x= 0; x < memcached_server_count(memc); x++) - ids[x]= get_udp_datagram_request_id((struct udp_datagram_header_st *) memc->hosts[x].write_buffer); + assert(MEMCACHED_HASH_DEFAULT == MEMCACHED_HASH_DEFAULT); + assert(MEMCACHED_HASH_MD5 == MEMCACHED_HASH_MD5); + assert(MEMCACHED_HASH_CRC == MEMCACHED_HASH_CRC); + assert(MEMCACHED_HASH_FNV1_64 == MEMCACHED_HASH_FNV1_64); + assert(MEMCACHED_HASH_FNV1A_64 == MEMCACHED_HASH_FNV1A_64); + assert(MEMCACHED_HASH_FNV1_32 == MEMCACHED_HASH_FNV1_32); + assert(MEMCACHED_HASH_FNV1A_32 == MEMCACHED_HASH_FNV1A_32); +#ifdef HAVE_HSIEH_HASH + assert(MEMCACHED_HASH_HSIEH == MEMCACHED_HASH_HSIEH); +#endif + assert(MEMCACHED_HASH_MURMUR == MEMCACHED_HASH_MURMUR); + assert(MEMCACHED_HASH_JENKINS == MEMCACHED_HASH_JENKINS); + assert(MEMCACHED_HASH_MAX == MEMCACHED_HASH_MAX); - return ids; + return TEST_SUCCESS; } +#endif -static test_return_t post_udp_op_check(memcached_st *memc, uint16_t *expected_req_ids) +static test_return_t hsieh_avaibility_test (memcached_st *memc) { - unsigned int x; - memcached_server_st *cur_server = memc->hosts; - uint16_t *cur_req_ids = get_udp_request_ids(memc); - - for (x= 0; x < memcached_server_count(memc); x++) - { - test_truth(cur_server[x].cursor_active == 0); - test_truth(cur_req_ids[x] == expected_req_ids[x]); - } - free(expected_req_ids); - free(cur_req_ids); + memcached_return_t expected_rc= MEMCACHED_FAILURE; +#ifdef HAVE_HSIEH_HASH + expected_rc= MEMCACHED_SUCCESS; +#endif + memcached_return_t rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, + (uint64_t)MEMCACHED_HASH_HSIEH); + test_true(rc == expected_rc); return TEST_SUCCESS; } -/* -** There is a little bit of a hack here, instead of removing -** the servers, I just set num host to 0 and them add then new udp servers -**/ -static test_return_t init_udp(memcached_st *memc) +static test_return_t one_at_a_time_run (memcached_st *memc) { - memcached_version(memc); - /* For the time being, only support udp test for >= 1.2.6 && < 1.3 */ - if (memc->hosts[0].major_version != 1 || memc->hosts[0].minor_version != 2 - || memc->hosts[0].micro_version < 6) - return TEST_SKIPPED; - - uint32_t num_hosts= memcached_server_count(memc); - unsigned int x= 0; - memcached_server_st servers[num_hosts]; - memcpy(servers, memc->hosts, sizeof(memcached_server_st) * num_hosts); - for (x= 0; x < num_hosts; x++) - memcached_server_free(&memc->hosts[x]); + uint32_t x; + const char **ptr; + (void)memc; - memc->number_of_hosts= 0; - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_USE_UDP, 1); - for (x= 0; x < num_hosts; x++) + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { - test_truth(memcached_server_add_udp(memc, servers[x].hostname, servers[x].port) == MEMCACHED_SUCCESS); - test_truth(memc->hosts[x].write_buffer_offset == UDP_DATAGRAM_HEADER_LENGTH); + uint32_t hash_val; + + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_DEFAULT); + test_true(one_at_a_time_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t binary_init_udp(memcached_st *memc) -{ - test_return_t test_rc; - test_rc= pre_binary(memc); - - if (test_rc != TEST_SUCCESS) - return test_rc; - - return init_udp(memc); -} - -/* Make sure that I cant add a tcp server to a udp client */ -static test_return_t add_tcp_server_udp_client_test(memcached_st *memc) +static test_return_t md5_run (memcached_st *memc) { + uint32_t x; + const char **ptr; (void)memc; -#if 0 - memcached_server_st server; - memcached_server_clone(&server, &memc->hosts[0]); - test_truth(memcached_server_remove(&(memc->hosts[0])) == MEMCACHED_SUCCESS); - test_truth(memcached_server_add(memc, server.hostname, server.port) == MEMCACHED_INVALID_HOST_PROTOCOL); -#endif - return TEST_SUCCESS; -} -/* Make sure that I cant add a udp server to a tcp client */ -static test_return_t add_udp_server_tcp_client_test(memcached_st *memc) -{ - (void)memc; -#if 0 - memcached_server_st server; - memcached_server_clone(&server, &memc->hosts[0]); - test_truth(memcached_server_remove(&(memc->hosts[0])) == MEMCACHED_SUCCESS); + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; - memcached_st tcp_client; - memcached_create(&tcp_client); - test_truth(memcached_server_add_udp(&tcp_client, server.hostname, server.port) == MEMCACHED_INVALID_HOST_PROTOCOL); -#endif + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MD5); + test_true(md5_values[x] == hash_val); + } return TEST_SUCCESS; } -static test_return_t set_udp_behavior_test(memcached_st *memc) +static test_return_t crc_run (memcached_st *memc) { + uint32_t x; + const char **ptr; + (void)memc; - memcached_quit(memc); - memc->number_of_hosts= 0; - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_DISTRIBUTION, memc->distribution); - test_truth(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_USE_UDP, 1) == MEMCACHED_SUCCESS); - test_truth(memc->flags.use_udp); - test_truth(memc->flags.no_reply); - - test_truth(memcached_server_count(memc) == 0); - - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_USE_UDP,0); - test_truth(! (memc->flags.use_udp)); - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY,0); - test_truth(! (memc->flags.no_reply)); - - return TEST_SUCCESS; -} - -static test_return_t udp_set_test(memcached_st *memc) -{ - unsigned int x= 0; - unsigned int num_iters= 1025; //request id rolls over at 1024 - for (x= 0; x < num_iters;x++) + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { - memcached_return_t rc; - const char *key= "foo"; - const char *value= "when we sanitize"; - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc,key,strlen(key)); - size_t init_offset= memc->hosts[server_key].write_buffer_offset; - rc= memcached_set(memc, key, strlen(key), - value, strlen(value), - (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); - /** NB, the check below assumes that if new write_ptr is less than - * the original write_ptr that we have flushed. For large payloads, this - * maybe an invalid assumption, but for the small payload we have it is OK - */ - if (rc == MEMCACHED_SUCCESS || - memc->hosts[server_key].write_buffer_offset < init_offset) - increment_request_id(&expected_ids[server_key]); + uint32_t hash_val; - if (rc == MEMCACHED_SUCCESS) - { - test_truth(memc->hosts[server_key].write_buffer_offset == UDP_DATAGRAM_HEADER_LENGTH); - } - else - { - test_truth(memc->hosts[server_key].write_buffer_offset != UDP_DATAGRAM_HEADER_LENGTH); - test_truth(memc->hosts[server_key].write_buffer_offset <= MAX_UDP_DATAGRAM_LENGTH); - } - test_truth(post_udp_op_check(memc,expected_ids) == TEST_SUCCESS); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_CRC); + test_true(crc_values[x] == hash_val); } - return TEST_SUCCESS; -} - -static test_return_t udp_buffered_set_test(memcached_st *memc) -{ - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1); - return udp_set_test(memc); -} - -static test_return_t udp_set_too_big_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "bar"; - char value[MAX_UDP_DATAGRAM_LENGTH]; - uint16_t *expected_ids= get_udp_request_ids(memc); - rc= memcached_set(memc, key, strlen(key), - value, MAX_UDP_DATAGRAM_LENGTH, - (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_WRITE_FAILURE); - return post_udp_op_check(memc,expected_ids); -} -static test_return_t udp_delete_test(memcached_st *memc) -{ - unsigned int x= 0; - unsigned int num_iters= 1025; //request id rolls over at 1024 - for (x= 0; x < num_iters;x++) - { - memcached_return_t rc; - const char *key= "foo"; - uint16_t *expected_ids=get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - size_t init_offset= memc->hosts[server_key].write_buffer_offset; - rc= memcached_delete(memc, key, strlen(key), 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); - if (rc == MEMCACHED_SUCCESS || memc->hosts[server_key].write_buffer_offset < init_offset) - increment_request_id(&expected_ids[server_key]); - if (rc == MEMCACHED_SUCCESS) - { - test_truth(memc->hosts[server_key].write_buffer_offset == UDP_DATAGRAM_HEADER_LENGTH); - } - else - { - test_truth(memc->hosts[server_key].write_buffer_offset != UDP_DATAGRAM_HEADER_LENGTH); - test_truth(memc->hosts[server_key].write_buffer_offset <= MAX_UDP_DATAGRAM_LENGTH); - } - test_truth(post_udp_op_check(memc,expected_ids) == TEST_SUCCESS); - } return TEST_SUCCESS; } -static test_return_t udp_buffered_delete_test(memcached_st *memc) -{ - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1); - return udp_delete_test(memc); -} - -static test_return_t udp_verbosity_test(memcached_st *memc) -{ - memcached_return_t rc; - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int x; - for (x= 0; x < memcached_server_count(memc); x++) - increment_request_id(&expected_ids[x]); - - rc= memcached_verbosity(memc,3); - test_truth(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc,expected_ids); -} - -static test_return_t udp_quit_test(memcached_st *memc) -{ - uint16_t *expected_ids= get_udp_request_ids(memc); - memcached_quit(memc); - return post_udp_op_check(memc, expected_ids); -} - -static test_return_t udp_flush_test(memcached_st *memc) +static test_return_t fnv1_64_run (memcached_st *memc) { - memcached_return_t rc; - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int x; - for (x= 0; x < memcached_server_count(memc);x++) - increment_request_id(&expected_ids[x]); - - rc= memcached_flush(memc,0); - test_truth(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc,expected_ids); -} - -static test_return_t udp_incr_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "incr"; - const char *value= "1"; - rc= memcached_set(memc, key, strlen(key), - value, strlen(value), - (time_t)0, (uint32_t)0); + uint32_t x; + const char **ptr; + (void)memc; - test_truth(rc == MEMCACHED_SUCCESS); - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - increment_request_id(&expected_ids[server_key]); - uint64_t newvalue; - rc= memcached_increment(memc, key, strlen(key), 1, &newvalue); - test_truth(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc, expected_ids); -} + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; -static test_return_t udp_decr_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "decr"; - const char *value= "1"; - rc= memcached_set(memc, key, strlen(key), - value, strlen(value), - (time_t)0, (uint32_t)0); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_64); + test_true(fnv1_64_values[x] == hash_val); + } - test_truth(rc == MEMCACHED_SUCCESS); - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - increment_request_id(&expected_ids[server_key]); - uint64_t newvalue; - rc= memcached_decrement(memc, key, strlen(key), 1, &newvalue); - test_truth(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc, expected_ids); + return TEST_SUCCESS; } - -static test_return_t udp_stat_test(memcached_st *memc) +static test_return_t fnv1a_64_run (memcached_st *memc) { - memcached_stat_st * rv= NULL; - memcached_return_t rc; - char args[]= ""; - uint16_t *expected_ids = get_udp_request_ids(memc); - rv = memcached_stat(memc, args, &rc); - free(rv); - test_truth(rc == MEMCACHED_NOT_SUPPORTED); - return post_udp_op_check(memc, expected_ids); -} + uint32_t x; + const char **ptr; + (void)memc; -static test_return_t udp_version_test(memcached_st *memc) -{ - memcached_return_t rc; - uint16_t *expected_ids = get_udp_request_ids(memc); - rc = memcached_version(memc); - test_truth(rc == MEMCACHED_NOT_SUPPORTED); - return post_udp_op_check(memc, expected_ids); -} + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; -static test_return_t udp_get_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "foo"; - size_t vlen; - uint16_t *expected_ids = get_udp_request_ids(memc); - char *val= memcached_get(memc, key, strlen(key), &vlen, (uint32_t)0, &rc); - test_truth(rc == MEMCACHED_NOT_SUPPORTED); - test_truth(val == NULL); - return post_udp_op_check(memc, expected_ids); -} - -static test_return_t udp_mixed_io_test(memcached_st *memc) -{ - test_st current_op; - test_st mixed_io_ops [] ={ - {"udp_set_test", 0, - (test_callback_fn)udp_set_test}, - {"udp_set_too_big_test", 0, - (test_callback_fn)udp_set_too_big_test}, - {"udp_delete_test", 0, - (test_callback_fn)udp_delete_test}, - {"udp_verbosity_test", 0, - (test_callback_fn)udp_verbosity_test}, - {"udp_quit_test", 0, - (test_callback_fn)udp_quit_test}, - {"udp_flush_test", 0, - (test_callback_fn)udp_flush_test}, - {"udp_incr_test", 0, - (test_callback_fn)udp_incr_test}, - {"udp_decr_test", 0, - (test_callback_fn)udp_decr_test}, - {"udp_version_test", 0, - (test_callback_fn)udp_version_test} - }; - unsigned int x= 0; - for (x= 0; x < 500; x++) - { - current_op= mixed_io_ops[random() % 9]; - test_truth(current_op.test_fn(memc) == TEST_SUCCESS); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_64); + test_true(fnv1a_64_values[x] == hash_val); } + return TEST_SUCCESS; } -#if 0 -static test_return_t hash_sanity_test (memcached_st *memc) +static test_return_t fnv1_32_run (memcached_st *memc) { + uint32_t x; + const char **ptr; (void)memc; - assert(MEMCACHED_HASH_DEFAULT == MEMCACHED_HASH_DEFAULT); - assert(MEMCACHED_HASH_MD5 == MEMCACHED_HASH_MD5); - assert(MEMCACHED_HASH_CRC == MEMCACHED_HASH_CRC); - assert(MEMCACHED_HASH_FNV1_64 == MEMCACHED_HASH_FNV1_64); - assert(MEMCACHED_HASH_FNV1A_64 == MEMCACHED_HASH_FNV1A_64); - assert(MEMCACHED_HASH_FNV1_32 == MEMCACHED_HASH_FNV1_32); - assert(MEMCACHED_HASH_FNV1A_32 == MEMCACHED_HASH_FNV1A_32); -#ifdef HAVE_HSIEH_HASH - assert(MEMCACHED_HASH_HSIEH == MEMCACHED_HASH_HSIEH); -#endif - assert(MEMCACHED_HASH_MURMUR == MEMCACHED_HASH_MURMUR); - assert(MEMCACHED_HASH_JENKINS == MEMCACHED_HASH_JENKINS); - assert(MEMCACHED_HASH_MAX == MEMCACHED_HASH_MAX); + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; - return TEST_SUCCESS; -} -#endif + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_32); + test_true(fnv1_32_values[x] == hash_val); + } -static test_return_t hsieh_avaibility_test (memcached_st *memc) -{ - memcached_return_t expected_rc= MEMCACHED_FAILURE; -#ifdef HAVE_HSIEH_HASH - expected_rc= MEMCACHED_SUCCESS; -#endif - memcached_return_t rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, - (uint64_t)MEMCACHED_HASH_HSIEH); - test_truth(rc == expected_rc); return TEST_SUCCESS; } -static test_return_t md5_run (memcached_st *memc __attribute__((unused))) +static test_return_t fnv1a_32_run (memcached_st *memc) { uint32_t x; const char **ptr; + (void)memc; for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MD5); - test_truth(md5_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_32); + test_true(fnv1a_32_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t crc_run (memcached_st *memc __attribute__((unused))) +static test_return_t hsieh_run (memcached_st *memc) { uint32_t x; const char **ptr; + (void)memc; for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_CRC); - test_truth(crc_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_HSIEH); + test_true(hsieh_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t fnv1_64_run (memcached_st *memc __attribute__((unused))) +static test_return_t murmur_run (memcached_st *memc) { +#ifdef WORDS_BIGENDIAN + return TEST_SKIPPED; +#else uint32_t x; const char **ptr; + (void)memc; for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_64); - test_truth(fnv1_64_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MURMUR); + test_true(murmur_values[x] == hash_val); } return TEST_SUCCESS; +#endif } -static test_return_t fnv1a_64_run (memcached_st *memc __attribute__((unused))) +static test_return_t jenkins_run (memcached_st *memc) { uint32_t x; const char **ptr; + (void)memc; for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_64); - test_truth(fnv1a_64_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_JENKINS); + test_true(jenkins_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t fnv1_32_run (memcached_st *memc __attribute__((unused))) +static uint32_t hash_md5_test_function(const char *string, size_t string_length, void *context) +{ + (void)context; + return libhashkit_md5(string, string_length); +} + +static uint32_t hash_crc_test_function(const char *string, size_t string_length, void *context) +{ + (void)context; + return libhashkit_crc32(string, string_length); +} + +static test_return_t memcached_get_hashkit_test (memcached_st *memc) { uint32_t x; const char **ptr; + const hashkit_st *kit; + hashkit_st new_kit; + hashkit_return_t hash_rc; + + uint32_t md5_hosts[]= {4U, 1U, 0U, 1U, 4U, 2U, 0U, 3U, 0U, 0U, 3U, 1U, 0U, 0U, 1U, 3U, 0U, 0U, 0U, 3U, 1U, 0U, 4U, 4U, 3U}; + uint32_t crc_hosts[]= {2U, 4U, 1U, 0U, 2U, 4U, 4U, 4U, 1U, 2U, 3U, 4U, 3U, 4U, 1U, 3U, 3U, 2U, 0U, 0U, 0U, 1U, 2U, 4U, 0U}; + + kit= memcached_get_hashkit(memc); + + hashkit_clone(&new_kit, kit); + hash_rc= hashkit_set_custom_function(&new_kit, hash_md5_test_function, NULL); + test_true(hash_rc == HASHKIT_SUCCESS); + memcached_set_hashkit(memc, &new_kit); + /* + Verify Setting the hash. + */ for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_32); - test_truth(fnv1_32_values[x] == hash_val); + hash_val= hashkit_digest(kit, *ptr, strlen(*ptr)); + test_true(md5_values[x] == hash_val); } - return TEST_SUCCESS; -} - -static test_return_t fnv1a_32_run (memcached_st *memc __attribute__((unused))) -{ - uint32_t x; - const char **ptr; + /* + Now check memcached_st. + */ for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_32); - test_truth(fnv1a_32_values[x] == hash_val); + hash_val= memcached_generate_hash(memc, *ptr, strlen(*ptr)); + test_true(md5_hosts[x] == hash_val); } - return TEST_SUCCESS; -} + hash_rc= hashkit_set_custom_function(&new_kit, hash_crc_test_function, NULL); + test_true(hash_rc == HASHKIT_SUCCESS); -static test_return_t hsieh_run (memcached_st *memc __attribute__((unused))) -{ - uint32_t x; - const char **ptr; + memcached_set_hashkit(memc, &new_kit); + /* + Verify Setting the hash. + */ for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_HSIEH); - test_truth(hsieh_values[x] == hash_val); + hash_val= hashkit_digest(kit, *ptr, strlen(*ptr)); + test_true(crc_values[x] == hash_val); + } + + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; + + hash_val= memcached_generate_hash(memc, *ptr, strlen(*ptr)); + test_true(crc_hosts[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t murmur_run (memcached_st *memc __attribute__((unused))) -{ -#ifdef __sparc - return TEST_SKIPPED; -#else - uint32_t x; - const char **ptr; +/* + Test case adapted from John Gorman + + We are testing the error condition when we connect to a server via memcached_get() + but find that the server is not available. +*/ +static test_return_t memcached_get_MEMCACHED_ERRNO(memcached_st *memc) +{ + (void)memc; + memcached_st *tl_memc_h; + memcached_server_st *servers; + + const char *key= "MemcachedLives"; + size_t len; + uint32_t flags; + memcached_return rc; + char *value; + + // Create a handle. + tl_memc_h= memcached_create(NULL); + servers= memcached_servers_parse("localhost:9898,localhost:9899"); // This server should not exist + memcached_server_push(tl_memc_h, servers); + memcached_server_list_free(servers); + + // See if memcached is reachable. + value= memcached_get(tl_memc_h, key, strlen(key), &len, &flags, &rc); + + test_false(value); + test_true(len == 0); + test_false(rc == MEMCACHED_SUCCESS); + + memcached_free(tl_memc_h); + + return TEST_SUCCESS; +} + +/* + We connect to a server which exists, but search for a key that does not exist. +*/ +static test_return_t memcached_get_MEMCACHED_NOTFOUND(memcached_st *memc) +{ + const char *key= "MemcachedKeyNotEXIST"; + size_t len; + uint32_t flags; + memcached_return rc; + char *value; + + // See if memcached is reachable. + value= memcached_get(memc, key, strlen(key), &len, &flags, &rc); + + test_false(value); + test_true(len == 0); + test_true(rc == MEMCACHED_NOTFOUND); + + return TEST_SUCCESS; +} + +/* + Test case adapted from John Gorman + + We are testing the error condition when we connect to a server via memcached_get_by_key() + but find that the server is not available. +*/ +static test_return_t memcached_get_by_key_MEMCACHED_ERRNO(memcached_st *memc) +{ + (void)memc; + memcached_st *tl_memc_h; + memcached_server_st *servers; + + const char *key= "MemcachedLives"; + size_t len; + uint32_t flags; + memcached_return rc; + char *value; + + // Create a handle. + tl_memc_h= memcached_create(NULL); + servers= memcached_servers_parse("localhost:9898,localhost:9899"); // This server should not exist + memcached_server_push(tl_memc_h, servers); + memcached_server_list_free(servers); - for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) - { - uint32_t hash_val; + // See if memcached is reachable. + value= memcached_get_by_key(tl_memc_h, key, strlen(key), key, strlen(key), &len, &flags, &rc); - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MURMUR); - test_truth(murmur_values[x] == hash_val); - } + test_false(value); + test_true(len == 0); + test_false(rc == MEMCACHED_SUCCESS); + + memcached_free(tl_memc_h); return TEST_SUCCESS; -#endif } -static test_return_t jenkins_run (memcached_st *memc __attribute__((unused))) +/* + We connect to a server which exists, but search for a key that does not exist. +*/ +static test_return_t memcached_get_by_key_MEMCACHED_NOTFOUND(memcached_st *memc) { - uint32_t x; - const char **ptr; - + const char *key= "MemcachedKeyNotEXIST"; + size_t len; + uint32_t flags; + memcached_return rc; + char *value; - for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) - { - uint32_t hash_val; + // See if memcached is reachable. + value= memcached_get_by_key(memc, key, strlen(key), key, strlen(key), &len, &flags, &rc); - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_JENKINS); - test_truth(jenkins_values[x] == hash_val); - } + test_false(value); + test_true(len == 0); + test_true(rc == MEMCACHED_NOTFOUND); return TEST_SUCCESS; } @@ -4948,43 +5240,45 @@ static test_return_t ketama_compatibility_libmemcached(memcached_st *trash) (void)trash; memc= memcached_create(NULL); - test_truth(memc); + test_true(memc); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED); - test_truth(value == 1); + test_true(value == 1); - test_truth(memcached_behavior_set_distribution(memc, MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA) == MEMCACHED_SUCCESS); - test_truth(memcached_behavior_get_distribution(memc) == MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA); + test_true(memcached_behavior_set_distribution(memc, MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA) == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get_distribution(memc) == MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA); server_pool = memcached_servers_parse("10.0.1.1:11211 600,10.0.1.2:11211 300,10.0.1.3:11211 200,10.0.1.4:11211 350,10.0.1.5:11211 1000,10.0.1.6:11211 800,10.0.1.7:11211 950,10.0.1.8:11211 100"); memcached_server_push(memc, server_pool); /* verify that the server list was parsed okay. */ - test_truth(memcached_server_count(memc) == 8); + test_true(memcached_server_count(memc) == 8); test_strcmp(server_pool[0].hostname, "10.0.1.1"); - test_truth(server_pool[0].port == 11211); - test_truth(server_pool[0].weight == 600); + test_true(server_pool[0].port == 11211); + test_true(server_pool[0].weight == 600); test_strcmp(server_pool[2].hostname, "10.0.1.3"); - test_truth(server_pool[2].port == 11211); - test_truth(server_pool[2].weight == 200); + test_true(server_pool[2].port == 11211); + test_true(server_pool[2].weight == 200); test_strcmp(server_pool[7].hostname, "10.0.1.8"); - test_truth(server_pool[7].port == 11211); - test_truth(server_pool[7].weight == 100); + test_true(server_pool[7].port == 11211); + test_true(server_pool[7].weight == 100); /* VDEAAAAA hashes to fffcd1b5, after the last continuum point, and lets * us test the boundary wraparound. */ - test_truth(memcached_generate_hash(memc, (char *)"VDEAAAAA", 8) == memc->continuum[0].index); + test_true(memcached_generate_hash(memc, (char *)"VDEAAAAA", 8) == memc->continuum[0].index); /* verify the standard ketama set. */ for (x= 0; x < 99; x++) { uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); - char *hostname = memc->hosts[server_idx].hostname; + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, server_idx); + const char *hostname = memcached_server_name(instance); test_strcmp(hostname, ketama_test_cases[x].server); } @@ -5006,42 +5300,47 @@ static test_return_t ketama_compatibility_spymemcached(memcached_st *trash) (void)trash; memc= memcached_create(NULL); - test_truth(memc); + test_true(memc); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); value= memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED); - test_truth(value == 1); + test_true(value == 1); - test_truth(memcached_behavior_set_distribution(memc, MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA_SPY) == MEMCACHED_SUCCESS); - test_truth(memcached_behavior_get_distribution(memc) == MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA_SPY); + test_true(memcached_behavior_set_distribution(memc, MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA_SPY) == MEMCACHED_SUCCESS); + test_true(memcached_behavior_get_distribution(memc) == MEMCACHED_DISTRIBUTION_CONSISTENT_KETAMA_SPY); server_pool = memcached_servers_parse("10.0.1.1:11211 600,10.0.1.2:11211 300,10.0.1.3:11211 200,10.0.1.4:11211 350,10.0.1.5:11211 1000,10.0.1.6:11211 800,10.0.1.7:11211 950,10.0.1.8:11211 100"); memcached_server_push(memc, server_pool); /* verify that the server list was parsed okay. */ - test_truth(memcached_server_count(memc) == 8); + test_true(memcached_server_count(memc) == 8); test_strcmp(server_pool[0].hostname, "10.0.1.1"); - test_truth(server_pool[0].port == 11211); - test_truth(server_pool[0].weight == 600); + test_true(server_pool[0].port == 11211); + test_true(server_pool[0].weight == 600); test_strcmp(server_pool[2].hostname, "10.0.1.3"); - test_truth(server_pool[2].port == 11211); - test_truth(server_pool[2].weight == 200); + test_true(server_pool[2].port == 11211); + test_true(server_pool[2].weight == 200); test_strcmp(server_pool[7].hostname, "10.0.1.8"); - test_truth(server_pool[7].port == 11211); - test_truth(server_pool[7].weight == 100); + test_true(server_pool[7].port == 11211); + test_true(server_pool[7].weight == 100); /* VDEAAAAA hashes to fffcd1b5, after the last continuum point, and lets * us test the boundary wraparound. */ - test_truth(memcached_generate_hash(memc, (char *)"VDEAAAAA", 8) == memc->continuum[0].index); + test_true(memcached_generate_hash(memc, (char *)"VDEAAAAA", 8) == memc->continuum[0].index); /* verify the standard ketama set. */ for (x= 0; x < 99; x++) { - uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases_spy[x].key, strlen(ketama_test_cases_spy[x].key)); - char *hostname = memc->hosts[server_idx].hostname; + uint32_t server_idx= memcached_generate_hash(memc, ketama_test_cases_spy[x].key, strlen(ketama_test_cases_spy[x].key)); + + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, server_idx); + + const char *hostname= memcached_server_name(instance); + test_strcmp(hostname, ketama_test_cases_spy[x].server); } @@ -5064,13 +5363,13 @@ static test_return_t regression_bug_434484(memcached_st *memc) size_t keylen= strlen(key); ret= memcached_append(memc, key, keylen, key, keylen, 0, 0); - test_truth(ret == MEMCACHED_NOTSTORED); + test_true(ret == MEMCACHED_NOTSTORED); size_t size= 2048 * 1024; void *data= calloc(1, size); - test_truth(data != NULL); + test_true(data != NULL); ret= memcached_set(memc, key, keylen, data, size, 0, 0); - test_truth(ret == MEMCACHED_E2BIG); + test_true(ret == MEMCACHED_E2BIG); free(data); return TEST_SUCCESS; @@ -5085,7 +5384,7 @@ static test_return_t regression_bug_434843(memcached_st *memc) return test_rc; memcached_return_t rc; - unsigned int counter= 0; + size_t counter= 0; memcached_execute_fn callbacks[1]= { [0]= &callback_counter }; /* @@ -5100,45 +5399,51 @@ static test_return_t regression_bug_434843(memcached_st *memc) char **keys= calloc(max_keys, sizeof(char*)); size_t *key_length=calloc(max_keys, sizeof(size_t)); - for (int x= 0; x < (int)max_keys; ++x) + for (size_t x= 0; x < max_keys; ++x) { char k[251]; - key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%u", x); + + key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%lu", (unsigned long)x); keys[x]= strdup(k); - test_truth(keys[x] != NULL); + test_true(keys[x] != NULL); } /* * Run two times.. the first time we should have 100% cache miss, * and the second time we should have 100% cache hits */ - for (int y= 0; y < 2; ++y) + for (size_t y= 0; y < 2; y++) { rc= memcached_mget(memc, (const char**)keys, key_length, max_keys); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); + if (y == 0) { /* The first iteration should give me a 100% cache miss. verify that*/ - test_truth(counter == 0); char blob[1024]= { 0 }; - for (int x= 0; x < (int)max_keys; ++x) + + test_true(counter == 0); + + for (size_t x= 0; x < max_keys; ++x) { rc= memcached_add(memc, keys[x], key_length[x], blob, sizeof(blob), 0, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } } else { /* Verify that we received all of the key/value pairs */ - test_truth(counter == (unsigned int)max_keys); + test_true(counter == max_keys); } } /* Release allocated resources */ for (size_t x= 0; x < max_keys; ++x) + { free(keys[x]); + } free(keys); free(key_length); @@ -5151,7 +5456,7 @@ static test_return_t regression_bug_434843_buffered(memcached_st *memc) { memcached_return_t rc; rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); return regression_bug_434843(memc); } @@ -5160,23 +5465,23 @@ static test_return_t regression_bug_421108(memcached_st *memc) { memcached_return_t rc; memcached_stat_st *memc_stat= memcached_stat(memc, NULL, &rc); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); char *bytes= memcached_stat_get_value(memc, memc_stat, "bytes", &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(bytes != NULL); + test_true(rc == MEMCACHED_SUCCESS); + test_true(bytes != NULL); char *bytes_read= memcached_stat_get_value(memc, memc_stat, "bytes_read", &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(bytes_read != NULL); + test_true(rc == MEMCACHED_SUCCESS); + test_true(bytes_read != NULL); char *bytes_written= memcached_stat_get_value(memc, memc_stat, "bytes_written", &rc); - test_truth(rc == MEMCACHED_SUCCESS); - test_truth(bytes_written != NULL); + test_true(rc == MEMCACHED_SUCCESS); + test_true(bytes_written != NULL); - test_truth(strcmp(bytes, bytes_read) != 0); - test_truth(strcmp(bytes, bytes_written) != 0); + test_true(strcmp(bytes, bytes_read) != 0); + test_true(strcmp(bytes, bytes_written) != 0); /* Release allocated resources */ free(bytes); @@ -5202,7 +5507,7 @@ static test_return_t regression_bug_442914(memcached_st *memc) { memcached_return_t rc; rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 1); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_NODELAY, 1); uint32_t number_of_hosts= memcached_server_count(memc); @@ -5211,21 +5516,23 @@ static test_return_t regression_bug_442914(memcached_st *memc) char k[250]; size_t len; - for (int x= 0; x < 250; ++x) + for (uint32_t x= 0; x < 250; ++x) { len= (size_t)snprintf(k, sizeof(k), "%0250u", x); rc= memcached_delete(memc, k, len, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); } - len= (size_t)snprintf(k, sizeof(k), "%037u", 251); + (void)snprintf(k, sizeof(k), "%037u", 251U); + len= strlen(k); + rc= memcached_delete(memc, k, len, 0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); rc= memcached_delete(memc, k, len, 0); - test_truth(rc == MEMCACHED_NOTFOUND); + test_true(rc == MEMCACHED_NOTFOUND); memc->number_of_hosts= number_of_hosts; @@ -5234,26 +5541,30 @@ static test_return_t regression_bug_442914(memcached_st *memc) static test_return_t regression_bug_447342(memcached_st *memc) { - if (memcached_server_count(memc) < 3 || pre_replication(memc) != MEMCACHED_SUCCESS) + memcached_server_instance_st instance_one; + memcached_server_instance_st instance_two; + + if (memcached_server_count(memc) < 3 || pre_replication(memc) != TEST_SUCCESS) return TEST_SKIPPED; memcached_return_t rc; rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS, 2); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); const size_t max_keys= 100; char **keys= calloc(max_keys, sizeof(char*)); size_t *key_length= calloc(max_keys, sizeof(size_t)); - for (uint64_t x= 0; x < max_keys; ++x) + for (size_t x= 0; x < max_keys; ++x) { char k[251]; - key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%"PRIu64, x); + + key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%lu", (unsigned long)x); keys[x]= strdup(k); - test_truth(keys[x] != NULL); + test_true(keys[x] != NULL); rc= memcached_set(memc, k, key_length[x], k, key_length[x], 0, 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } /* @@ -5275,13 +5586,13 @@ static test_return_t regression_bug_447342(memcached_st *memc) * into the servers */ rc= memcached_mget(memc, (const char* const *)keys, key_length, max_keys); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); - unsigned int counter= 0; + size_t counter= 0; memcached_execute_fn callbacks[1]= { [0]= &callback_counter }; rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); /* Verify that we received all of the key/value pairs */ - test_truth(counter == (unsigned int)max_keys); + test_true(counter == max_keys); memcached_quit(memc); /* @@ -5290,22 +5601,24 @@ static test_return_t regression_bug_447342(memcached_st *memc) * This is to verify correct behavior in the library. Fake that two servers * are dead.. */ - in_port_t port0= memc->hosts[0].port; - in_port_t port2= memc->hosts[2].port; + instance_one= memcached_server_instance_by_position(memc, 0); + instance_two= memcached_server_instance_by_position(memc, 2); + in_port_t port0= instance_one->port; + in_port_t port2= instance_two->port; - memc->hosts[0].port= 0; - memc->hosts[2].port= 0; + ((memcached_server_write_instance_st)instance_one)->port= 0; + ((memcached_server_write_instance_st)instance_two)->port= 0; rc= memcached_mget(memc, (const char* const *)keys, key_length, max_keys); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); counter= 0; rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); - test_truth(counter == (unsigned int)max_keys); + test_true(counter == (unsigned int)max_keys); /* restore the memc handle */ - memc->hosts[0].port= port0; - memc->hosts[2].port= port2; + ((memcached_server_write_instance_st)instance_one)->port= port0; + ((memcached_server_write_instance_st)instance_two)->port= port2; memcached_quit(memc); @@ -5315,21 +5628,21 @@ static test_return_t regression_bug_447342(memcached_st *memc) if (x & 1) { rc= memcached_delete(memc, keys[x], key_length[x], 0); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); } } memcached_quit(memc); - memc->hosts[0].port= 0; - memc->hosts[2].port= 0; + ((memcached_server_write_instance_st)instance_one)->port= 0; + ((memcached_server_write_instance_st)instance_two)->port= 0; /* now retry the command, this time we should have cache misses */ rc= memcached_mget(memc, (const char* const *)keys, key_length, max_keys); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); counter= 0; rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); - test_truth(counter == (unsigned int)(max_keys >> 1)); + test_true(counter == (unsigned int)(max_keys >> 1)); /* Release allocated resources */ for (size_t x= 0; x < max_keys; ++x) @@ -5340,8 +5653,8 @@ static test_return_t regression_bug_447342(memcached_st *memc) free(key_length); /* restore the memc handle */ - memc->hosts[0].port= port0; - memc->hosts[2].port= port2; + ((memcached_server_write_instance_st)instance_one)->port= port0; + ((memcached_server_write_instance_st)instance_two)->port= port2; return TEST_SUCCESS; } @@ -5349,54 +5662,57 @@ static test_return_t regression_bug_447342(memcached_st *memc) static test_return_t regression_bug_463297(memcached_st *memc) { memcached_st *memc_clone= memcached_clone(NULL, memc); - test_truth(memc_clone != NULL); - test_truth(memcached_version(memc_clone) == MEMCACHED_SUCCESS); - - if (memc_clone->hosts[0].major_version > 1 || - (memc_clone->hosts[0].major_version == 1 && - memc_clone->hosts[0].minor_version > 2)) - { - /* Binary protocol doesn't support deferred delete */ - memcached_st *bin_clone= memcached_clone(NULL, memc); - test_truth(bin_clone != NULL); - test_truth(memcached_behavior_set(bin_clone, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1) == MEMCACHED_SUCCESS); - test_truth(memcached_delete(bin_clone, "foo", 3, 1) == MEMCACHED_INVALID_ARGUMENTS); - memcached_free(bin_clone); + test_true(memc_clone != NULL); + test_true(memcached_version(memc_clone) == MEMCACHED_SUCCESS); - memcached_quit(memc_clone); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc_clone, 0); - /* If we know the server version, deferred delete should fail - * with invalid arguments */ - test_truth(memcached_delete(memc_clone, "foo", 3, 1) == MEMCACHED_INVALID_ARGUMENTS); - - /* If we don't know the server version, we should get a protocol error */ - memcached_return_t rc= memcached_delete(memc, "foo", 3, 1); - - /* but there is a bug in some of the memcached servers (1.4) that treats - * the counter as noreply so it doesn't send the proper error message - */ - test_truth(rc == MEMCACHED_PROTOCOL_ERROR || rc == MEMCACHED_NOTFOUND || rc == MEMCACHED_CLIENT_ERROR); + if (instance->major_version > 1 || + (instance->major_version == 1 && + instance->minor_version > 2)) + { + /* Binary protocol doesn't support deferred delete */ + memcached_st *bin_clone= memcached_clone(NULL, memc); + test_true(bin_clone != NULL); + test_true(memcached_behavior_set(bin_clone, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1) == MEMCACHED_SUCCESS); + test_true(memcached_delete(bin_clone, "foo", 3, 1) == MEMCACHED_INVALID_ARGUMENTS); + memcached_free(bin_clone); - /* And buffered mode should be disabled and we should get protocol error */ - test_truth(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1) == MEMCACHED_SUCCESS); - rc= memcached_delete(memc, "foo", 3, 1); - test_truth(rc == MEMCACHED_PROTOCOL_ERROR || rc == MEMCACHED_NOTFOUND || rc == MEMCACHED_CLIENT_ERROR); + memcached_quit(memc_clone); - /* Same goes for noreply... */ - test_truth(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 1) == MEMCACHED_SUCCESS); - rc= memcached_delete(memc, "foo", 3, 1); - test_truth(rc == MEMCACHED_PROTOCOL_ERROR || rc == MEMCACHED_NOTFOUND || rc == MEMCACHED_CLIENT_ERROR); + /* If we know the server version, deferred delete should fail + * with invalid arguments */ + test_true(memcached_delete(memc_clone, "foo", 3, 1) == MEMCACHED_INVALID_ARGUMENTS); - /* but a normal request should go through (and be buffered) */ - test_truth((rc= memcached_delete(memc, "foo", 3, 0)) == MEMCACHED_BUFFERED); - test_truth(memcached_flush_buffers(memc) == MEMCACHED_SUCCESS); + /* If we don't know the server version, we should get a protocol error */ + memcached_return_t rc= memcached_delete(memc, "foo", 3, 1); - test_truth(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 0) == MEMCACHED_SUCCESS); - /* unbuffered noreply should be success */ - test_truth(memcached_delete(memc, "foo", 3, 0) == MEMCACHED_SUCCESS); - /* unbuffered with reply should be not found... */ - test_truth(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 0) == MEMCACHED_SUCCESS); - test_truth(memcached_delete(memc, "foo", 3, 0) == MEMCACHED_NOTFOUND); + /* but there is a bug in some of the memcached servers (1.4) that treats + * the counter as noreply so it doesn't send the proper error message + */ + test_true_got(rc == MEMCACHED_PROTOCOL_ERROR || rc == MEMCACHED_NOTFOUND || rc == MEMCACHED_CLIENT_ERROR || rc == MEMCACHED_INVALID_ARGUMENTS, memcached_strerror(NULL, rc)); + + /* And buffered mode should be disabled and we should get protocol error */ + test_true(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1) == MEMCACHED_SUCCESS); + rc= memcached_delete(memc, "foo", 3, 1); + test_true_got(rc == MEMCACHED_PROTOCOL_ERROR || rc == MEMCACHED_NOTFOUND || rc == MEMCACHED_CLIENT_ERROR || rc == MEMCACHED_INVALID_ARGUMENTS, memcached_strerror(NULL, rc)); + + /* Same goes for noreply... */ + test_true(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 1) == MEMCACHED_SUCCESS); + rc= memcached_delete(memc, "foo", 3, 1); + test_true_got(rc == MEMCACHED_PROTOCOL_ERROR || rc == MEMCACHED_NOTFOUND || rc == MEMCACHED_CLIENT_ERROR || rc == MEMCACHED_INVALID_ARGUMENTS, memcached_strerror(NULL, rc)); + + /* but a normal request should go through (and be buffered) */ + test_true((rc= memcached_delete(memc, "foo", 3, 0)) == MEMCACHED_BUFFERED); + test_true(memcached_flush_buffers(memc) == MEMCACHED_SUCCESS); + + test_true(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 0) == MEMCACHED_SUCCESS); + /* unbuffered noreply should be success */ + test_true(memcached_delete(memc, "foo", 3, 0) == MEMCACHED_SUCCESS); + /* unbuffered with reply should be not found... */ + test_true(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY, 0) == MEMCACHED_SUCCESS); + test_true(memcached_delete(memc, "foo", 3, 0) == MEMCACHED_NOTFOUND); } memcached_free(memc_clone); @@ -5408,22 +5724,23 @@ static test_return_t regression_bug_463297(memcached_st *memc) * For a working server set, shall be NULL * For a set of non existing server, shall not be NULL */ -static test_return_t test_get_last_disconnect(memcached_st *memc) +static test_return_t test_get_last_disconnect(memcached_st *memc) { memcached_return_t rc; - memcached_server_st *disconnected_server; + memcached_server_instance_st disconnected_server; /* With the working set of server */ const char *key= "marmotte"; const char *value= "milka"; + memcached_reset_last_disconnected_server(memc); rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); disconnected_server = memcached_server_get_last_disconnect(memc); - test_truth(disconnected_server == NULL); + test_true(disconnected_server == NULL); /* With a non existing server */ memcached_st *mine; @@ -5432,22 +5749,27 @@ static test_return_t test_get_last_disconnect(memcached_st *memc) const char *server_list= "localhost:9"; servers= memcached_servers_parse(server_list); - test_truth(servers); + test_true(servers); mine= memcached_create(NULL); rc= memcached_server_push(mine, servers); - test_truth(rc == MEMCACHED_SUCCESS); + test_true(rc == MEMCACHED_SUCCESS); memcached_server_list_free(servers); - test_truth(mine); + test_true(mine); rc= memcached_set(mine, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc != MEMCACHED_SUCCESS); + test_true(rc != MEMCACHED_SUCCESS); - disconnected_server = memcached_server_get_last_disconnect(mine); - test_truth(disconnected_server != NULL); - test_truth(disconnected_server->port == 9); - test_truth(strncmp(disconnected_server->hostname,"localhost",9) == 0); + disconnected_server= memcached_server_get_last_disconnect(mine); + if (disconnected_server == NULL) + { + fprintf(stderr, "RC %s\n", memcached_strerror(mine, rc)); + abort(); + } + test_true(disconnected_server != NULL); + test_true(memcached_server_port(disconnected_server)== 9); + test_true(strncmp(memcached_server_name(disconnected_server),"localhost",9) == 0); memcached_quit(mine); memcached_free(mine); @@ -5455,6 +5777,100 @@ static test_return_t test_get_last_disconnect(memcached_st *memc) return TEST_SUCCESS; } +static test_return_t test_verbosity(memcached_st *memc) +{ + memcached_verbosity(memc, 3); + + return TEST_SUCCESS; +} + +static test_return_t test_server_failure(memcached_st *memc) +{ + memcached_st *local_memc; + memcached_server_instance_st instance= memcached_server_instance_by_position(memc, 0); + + local_memc= memcached_create(NULL); + + memcached_server_add(local_memc, memcached_server_name(instance), memcached_server_port(instance)); + memcached_behavior_set(local_memc, MEMCACHED_BEHAVIOR_SERVER_FAILURE_LIMIT, 2); + + uint32_t server_count= memcached_server_count(local_memc); + + test_true(server_count == 1); + + // Disable the server + instance= memcached_server_instance_by_position(local_memc, 0); + ((memcached_server_write_instance_st)instance)->server_failure_counter= 2; + + memcached_return_t rc; + rc= memcached_set(local_memc, "foo", strlen("foo"), + NULL, 0, + (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_SERVER_MARKED_DEAD); + + ((memcached_server_write_instance_st)instance)->server_failure_counter= 0; + rc= memcached_set(local_memc, "foo", strlen("foo"), + NULL, 0, + (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_SUCCESS); + + + memcached_free(local_memc); + + return TEST_SUCCESS; +} + +static test_return_t test_cull_servers(memcached_st *memc) +{ + uint32_t count = memcached_server_count(memc); + + // Do not do this in your code, it is not supported. + memc->servers[1].state.is_dead= true; + memc->state.is_time_for_rebuild= true; + + uint32_t new_count= memcached_server_count(memc); + test_true(count == new_count); + +#if 0 + test_true(count == new_count + 1 ); +#endif + + return TEST_SUCCESS; +} + + +static memcached_return_t stat_printer(memcached_server_instance_st server, + const char *key, size_t key_length, + const char *value, size_t value_length, + void *context) +{ + (void)server; + (void)context; + (void)key; + (void)key_length; + (void)value; + (void)value_length; + + return MEMCACHED_SUCCESS; +} + +static test_return_t memcached_stat_execute_test(memcached_st *memc) +{ + memcached_return_t rc= memcached_stat_execute(memc, NULL, stat_printer, NULL); + test_true(rc == MEMCACHED_SUCCESS); + + rc= memcached_stat_execute(memc, "slabs", stat_printer, NULL); + test_true(rc == MEMCACHED_SUCCESS); + + rc= memcached_stat_execute(memc, "items", stat_printer, NULL); + test_true(rc == MEMCACHED_SUCCESS); + + rc= memcached_stat_execute(memc, "sizes", stat_printer, NULL); + test_true(rc == MEMCACHED_SUCCESS); + + return TEST_SUCCESS; +} + /* * This test ensures that the failure counter isn't incremented during * normal termination of the memcached instance. @@ -5462,6 +5878,7 @@ static test_return_t test_get_last_disconnect(memcached_st *memc) static test_return_t wrong_failure_counter_test(memcached_st *memc) { memcached_return_t rc; + memcached_server_instance_st instance; /* Set value to force connection to the server */ const char *key= "marmotte"; @@ -5479,14 +5896,15 @@ static test_return_t wrong_failure_counter_test(memcached_st *memc) rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); - test_truth(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + instance= memcached_server_instance_by_position(memc, 0); /* The test is to see that the memcached_quit doesn't increase the * the server failure conter, so let's ensure that it is zero * before sending quit */ - memc->hosts[0].server_failure_counter= 0; + ((memcached_server_write_instance_st)instance)->server_failure_counter= 0; memcached_quit(memc); @@ -5494,7 +5912,7 @@ static test_return_t wrong_failure_counter_test(memcached_st *memc) * Please note that this isn't bullet proof, because an error could * occur... */ - test_truth(memc->hosts[0].server_failure_counter == 0); + test_true(instance->server_failure_counter == 0); /* restore the instance */ memc->number_of_hosts= number_of_hosts; @@ -5502,33 +5920,290 @@ static test_return_t wrong_failure_counter_test(memcached_st *memc) return TEST_SUCCESS; } -test_st udp_setup_server_tests[] ={ - {"set_udp_behavior_test", 0, (test_callback_fn)set_udp_behavior_test}, - {"add_tcp_server_udp_client_test", 0, (test_callback_fn)add_tcp_server_udp_client_test}, - {"add_udp_server_tcp_client_test", 0, (test_callback_fn)add_udp_server_tcp_client_test}, - {0, 0, 0} -}; -test_st upd_io_tests[] ={ - {"udp_set_test", 0, (test_callback_fn)udp_set_test}, - {"udp_buffered_set_test", 0, (test_callback_fn)udp_buffered_set_test}, - {"udp_set_too_big_test", 0, (test_callback_fn)udp_set_too_big_test}, - {"udp_delete_test", 0, (test_callback_fn)udp_delete_test}, - {"udp_buffered_delete_test", 0, (test_callback_fn)udp_buffered_delete_test}, - {"udp_verbosity_test", 0, (test_callback_fn)udp_verbosity_test}, - {"udp_quit_test", 0, (test_callback_fn)udp_quit_test}, - {"udp_flush_test", 0, (test_callback_fn)udp_flush_test}, - {"udp_incr_test", 0, (test_callback_fn)udp_incr_test}, - {"udp_decr_test", 0, (test_callback_fn)udp_decr_test}, - {"udp_stat_test", 0, (test_callback_fn)udp_stat_test}, - {"udp_version_test", 0, (test_callback_fn)udp_version_test}, - {"udp_get_test", 0, (test_callback_fn)udp_get_test}, - {"udp_mixed_io_test", 0, (test_callback_fn)udp_mixed_io_test}, - {0, 0, 0} -}; + + +/* + * Test that ensures mget_execute does not end into recursive calls that finally fails + */ +static test_return_t regression_bug_490486(memcached_st *memc) +{ + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK, 1); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_POLL_TIMEOUT, 1000); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SERVER_FAILURE_LIMIT, 1); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RETRY_TIMEOUT, 3600); + +#ifdef __APPLE__ + return TEST_SKIPPED; // My MAC can't handle this test +#endif + + /* + * I only want to hit _one_ server so I know the number of requests I'm + * sending in the pipeline. + */ + uint32_t number_of_hosts= memc->number_of_hosts; + memc->number_of_hosts= 1; + size_t max_keys= 20480; + + + char **keys= calloc(max_keys, sizeof(char*)); + size_t *key_length=calloc(max_keys, sizeof(size_t)); + + /* First add all of the items.. */ + bool slept= false; + char blob[1024]= { 0 }; + memcached_return rc; + for (size_t x= 0; x < max_keys; ++x) + { + char k[251]; + key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%lu", (unsigned long)x); + keys[x]= strdup(k); + assert(keys[x] != NULL); + rc= memcached_set(memc, keys[x], key_length[x], blob, sizeof(blob), 0, 0); +#ifdef __APPLE__ + if (rc == MEMCACHED_SERVER_MARKED_DEAD) + { + break; // We are out of business + } +#endif + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED || rc == MEMCACHED_TIMEOUT); // MEMCACHED_TIMEOUT <-- only observed on OSX + + if (rc == MEMCACHED_TIMEOUT && slept == false) + { + x++; + sleep(1);// We will try to sleep + slept= true; + } + else if (rc == MEMCACHED_TIMEOUT && slept == true) + { + // We failed to send everything. + break; + } + } + + if (rc != MEMCACHED_SERVER_MARKED_DEAD) + { + + /* Try to get all of them with a large multiget */ + size_t counter= 0; + memcached_execute_function callbacks[1]= { [0]= &callback_counter }; + rc= memcached_mget_execute(memc, (const char**)keys, key_length, + (size_t)max_keys, callbacks, &counter, 1); + + assert(rc == MEMCACHED_SUCCESS); + char* the_value= NULL; + char the_key[MEMCACHED_MAX_KEY]; + size_t the_key_length; + size_t the_value_length; + uint32_t the_flags; + + do { + the_value= memcached_fetch(memc, the_key, &the_key_length, &the_value_length, &the_flags, &rc); + + if ((the_value!= NULL) && (rc == MEMCACHED_SUCCESS)) + { + ++counter; + free(the_value); + } + + } while ( (the_value!= NULL) && (rc == MEMCACHED_SUCCESS)); + + + assert(rc == MEMCACHED_END); + + /* Verify that we got all of the items */ + assert(counter == max_keys); + } + + /* Release all allocated resources */ + for (size_t x= 0; x < max_keys; ++x) + { + free(keys[x]); + } + free(keys); + free(key_length); + + memc->number_of_hosts= number_of_hosts; + + return TEST_SUCCESS; +} + +static test_return_t regression_bug_583031(memcached_st *unused) +{ + (void)unused; + + memcached_st *memc= memcached_create(NULL); + assert(memc); + memcached_server_add(memc, "10.2.3.4", 11211); + + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_CONNECT_TIMEOUT, 1000); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RETRY_TIMEOUT, 1000); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SND_TIMEOUT, 1000); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RCV_TIMEOUT, 1000); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_POLL_TIMEOUT, 1000); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SERVER_FAILURE_LIMIT, 3); + + memcached_return_t rc; + size_t length; + uint32_t flags; + + (void)memcached_get(memc, "dsf", 3, &length, &flags, &rc); + + test_true_got(rc == MEMCACHED_TIMEOUT, memcached_strerror(NULL, rc)); + + memcached_free(memc); + + return TEST_SUCCESS; +} + +static void memcached_die(memcached_st* mc, memcached_return error, const char* what, uint32_t it) +{ + fprintf(stderr, "Iteration #%u: ", it); + + if(error == MEMCACHED_ERRNO) + { + fprintf(stderr, "system error %d from %s: %s\n", + errno, what, strerror(errno)); + } + else + { + fprintf(stderr, "error %d from %s: %s\n", error, what, + memcached_strerror(mc, error)); + } +} + +#define TEST_CONSTANT_CREATION 200 + +static test_return_t regression_bug_(memcached_st *memc) +{ + const char *remote_server; + (void)memc; + + if (! (remote_server= getenv("LIBMEMCACHED_REMOTE_SERVER"))) + { + return TEST_SKIPPED; + } + + for (uint32_t x= 0; x < TEST_CONSTANT_CREATION; x++) + { + memcached_st* mc= memcached_create(NULL); + memcached_return rc; + + rc= memcached_behavior_set(mc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_behavior_set", x); + } + + rc= memcached_behavior_set(mc, MEMCACHED_BEHAVIOR_CACHE_LOOKUPS, 1); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_behavior_set", x); + } + + rc= memcached_server_add(mc, remote_server, 0); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_server_add", x); + } + + const char *set_key= "akey"; + const size_t set_key_len= strlen(set_key); + const char *set_value= "a value"; + const size_t set_value_len= strlen(set_value); + + if (rc == MEMCACHED_SUCCESS) + { + if (x > 0) + { + size_t get_value_len; + char *get_value; + uint32_t get_value_flags; + + get_value= memcached_get(mc, set_key, set_key_len, &get_value_len, + &get_value_flags, &rc); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_get", x); + } + else + { + + if (x != 0 && + (get_value_len != set_value_len + || 0!=strncmp(get_value, set_value, get_value_len))) + { + fprintf(stderr, "Values don't match?\n"); + rc= MEMCACHED_FAILURE; + } + free(get_value); + } + } + + rc= memcached_set(mc, + set_key, set_key_len, + set_value, set_value_len, + 0, /* time */ + 0 /* flags */ + ); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_set", x); + } + } + + memcached_quit(mc); + memcached_free(mc); + + if (rc != MEMCACHED_SUCCESS) + { + break; + } + } + + return TEST_SUCCESS; +} + +/* + * Test that the sasl authentication works. We cannot use the default + * pool of servers, because that would require that all servers we want + * to test supports SASL authentication, and that they use the default + * creds. + */ +static test_return_t sasl_auth_test(memcached_st *memc) +{ +#ifdef LIBMEMCACHED_WITH_SASL_SUPPORT + memcached_return_t rc; + + rc= memcached_set(memc, "foo", 3, "bar", 3, (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_SUCCESS); + test_true((rc= memcached_delete(memc, "foo", 3, 0)) == MEMCACHED_SUCCESS); + test_true((rc= memcached_destroy_sasl_auth_data(memc)) == MEMCACHED_SUCCESS); + test_true((rc= memcached_destroy_sasl_auth_data(memc)) == MEMCACHED_FAILURE); + test_true((rc= memcached_destroy_sasl_auth_data(NULL)) == MEMCACHED_FAILURE); + memcached_quit(memc); + + rc= memcached_set_sasl_auth_data(memc, + getenv("LIBMEMCACHED_TEST_SASL_USERNAME"), + getenv("LIBMEMCACHED_TEST_SASL_SERVER")); + test_true(rc == MEMCACHED_SUCCESS); + + rc= memcached_set(memc, "foo", 3, "bar", 3, (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_AUTH_FAILURE); + test_true(memcached_destroy_sasl_auth_data(memc) == MEMCACHED_SUCCESS); + + memcached_quit(memc); + return TEST_SUCCESS; +#else + (void)memc; + return TEST_FAILURE; +#endif +} /* Clean the server before beginning testing */ test_st tests[] ={ + {"util_version", 1, (test_callback_fn)util_version_test }, {"flush", 0, (test_callback_fn)flush_test }, {"init", 0, (test_callback_fn)init_test }, {"allocation", 0, (test_callback_fn)allocation_test }, @@ -5536,6 +6211,7 @@ test_st tests[] ={ {"server_unsort", 0, (test_callback_fn)server_unsort_test}, {"server_sort", 0, (test_callback_fn)server_sort_test}, {"server_sort2", 0, (test_callback_fn)server_sort2_test}, + {"memcached_server_remove", 0, (test_callback_fn)memcached_server_remove_test}, {"clone_test", 0, (test_callback_fn)clone_test }, {"connection_test", 0, (test_callback_fn)connection_test}, {"callback_test", 0, (test_callback_fn)callback_test}, @@ -5582,13 +6258,27 @@ test_st tests[] ={ {"analyzer", 1, (test_callback_fn)analyzer_test}, #ifdef HAVE_LIBMEMCACHEDUTIL {"connectionpool", 1, (test_callback_fn)connection_pool_test }, + {"ping", 1, (test_callback_fn)ping_test }, #endif {"test_get_last_disconnect", 1, (test_callback_fn)test_get_last_disconnect}, + {"verbosity", 1, (test_callback_fn)test_verbosity}, + {"test_server_failure", 1, (test_callback_fn)test_server_failure}, + {"cull_servers", 1, (test_callback_fn)test_cull_servers}, + {"memcached_stat_execute", 1, (test_callback_fn)memcached_stat_execute_test}, {0, 0, 0} }; test_st behavior_tests[] ={ {"behavior_test", 0, (test_callback_fn)behavior_test}, + {"MEMCACHED_BEHAVIOR_CORK", 0, (test_callback_fn)MEMCACHED_BEHAVIOR_CORK_test}, + {"MEMCACHED_BEHAVIOR_TCP_KEEPALIVE", 0, (test_callback_fn)MEMCACHED_BEHAVIOR_TCP_KEEPALIVE_test}, + {"MEMCACHED_BEHAVIOR_TCP_KEEPIDLE", 0, (test_callback_fn)MEMCACHED_BEHAVIOR_TCP_KEEPIDLE_test}, + {0, 0, 0} +}; + +test_st regression_binary_vs_block[] ={ + {"block add", 1, (test_callback_fn)block_add_regression}, + {"binary add", 1, (test_callback_fn)binary_add_regression}, {0, 0, 0} }; @@ -5639,7 +6329,7 @@ test_st user_tests[] ={ {"user_supplied_bug14", 1, (test_callback_fn)user_supplied_bug14 }, {"user_supplied_bug15", 1, (test_callback_fn)user_supplied_bug15 }, {"user_supplied_bug16", 1, (test_callback_fn)user_supplied_bug16 }, -#ifndef __sun +#if !defined(__sun) && !defined(__OpenBSD__) /* ** It seems to be something weird with the character sets.. ** value_fetch is unable to parse the value line (iscntrl "fails"), so I @@ -5675,11 +6365,19 @@ test_st replication_tests[]= { test_st regression_tests[]= { {"lp:434484", 1, (test_callback_fn)regression_bug_434484 }, {"lp:434843", 1, (test_callback_fn)regression_bug_434843 }, - {"lp:434843 buffered", 1, (test_callback_fn)regression_bug_434843_buffered }, + {"lp:434843-buffered", 1, (test_callback_fn)regression_bug_434843_buffered }, {"lp:421108", 1, (test_callback_fn)regression_bug_421108 }, {"lp:442914", 1, (test_callback_fn)regression_bug_442914 }, {"lp:447342", 1, (test_callback_fn)regression_bug_447342 }, {"lp:463297", 1, (test_callback_fn)regression_bug_463297 }, + {"lp:490486", 1, (test_callback_fn)regression_bug_490486 }, + {"lp:583031", 1, (test_callback_fn)regression_bug_583031 }, + {"lp:?", 1, (test_callback_fn)regression_bug_ }, + {0, 0, (test_callback_fn)0} +}; + +test_st sasl_auth_tests[]= { + {"sasl_auth", 1, (test_callback_fn)sasl_auth_test }, {0, 0, (test_callback_fn)0} }; @@ -5743,6 +6441,7 @@ test_st ketama_auto_eject_hosts[] ={ }; test_st hash_tests[] ={ + {"one_at_a_time_run", 0, (test_callback_fn)one_at_a_time_run }, {"md5", 0, (test_callback_fn)md5_run }, {"crc", 0, (test_callback_fn)crc_run }, {"fnv1_64", 0, (test_callback_fn)fnv1_64_run }, @@ -5752,6 +6451,15 @@ test_st hash_tests[] ={ {"hsieh", 0, (test_callback_fn)hsieh_run }, {"murmur", 0, (test_callback_fn)murmur_run }, {"jenkis", 0, (test_callback_fn)jenkins_run }, + {"memcached_get_hashkit", 0, (test_callback_fn)memcached_get_hashkit_test }, + {0, 0, (test_callback_fn)0} +}; + +test_st error_conditions[] ={ + {"memcached_get_MEMCACHED_ERRNO", 0, (test_callback_fn)memcached_get_MEMCACHED_ERRNO }, + {"memcached_get_MEMCACHED_NOTFOUND", 0, (test_callback_fn)memcached_get_MEMCACHED_NOTFOUND }, + {"memcached_get_by_key_MEMCACHED_ERRNO", 0, (test_callback_fn)memcached_get_by_key_MEMCACHED_ERRNO }, + {"memcached_get_by_key_MEMCACHED_NOTFOUND", 0, (test_callback_fn)memcached_get_by_key_MEMCACHED_NOTFOUND }, {0, 0, (test_callback_fn)0} }; @@ -5760,9 +6468,6 @@ collection_st collection[] ={ {"hash_sanity", 0, 0, hash_sanity}, #endif {"hsieh_availability", 0, 0, hsieh_availability}, - {"udp_setup", (test_callback_fn)init_udp, 0, udp_setup_server_tests}, - {"udp_io", (test_callback_fn)init_udp, 0, upd_io_tests}, - {"udp_binary_io", (test_callback_fn)binary_init_udp, 0, upd_io_tests}, {"block", 0, 0, tests}, {"binary", (test_callback_fn)pre_binary, 0, tests}, {"nonblock", (test_callback_fn)pre_nonblock, 0, tests}, @@ -5789,6 +6494,8 @@ collection_st collection[] ={ #endif {"memory_allocators", (test_callback_fn)set_memory_alloc, 0, tests}, {"prefix", (test_callback_fn)set_prefix, 0, tests}, + {"sasl_auth", (test_callback_fn)pre_sasl, 0, sasl_auth_tests }, + {"sasl", (test_callback_fn)pre_sasl, 0, tests }, {"version_1_2_3", (test_callback_fn)check_for_1_2_3, 0, version_1_2_3}, {"string", 0, 0, string_tests}, {"result", 0, 0, result_tests}, @@ -5803,6 +6510,9 @@ collection_st collection[] ={ {"generate_murmur", (test_callback_fn)pre_murmur, 0, generate_tests}, {"generate_jenkins", (test_callback_fn)pre_jenkins, 0, generate_tests}, {"generate_nonblock", (test_callback_fn)pre_nonblock, 0, generate_tests}, + // Too slow + {"generate_corked", (test_callback_fn)pre_cork, 0, generate_tests}, + {"generate_corked_and_nonblock", (test_callback_fn)pre_cork_and_nonblock, 0, generate_tests}, {"consistent_not", 0, 0, consistent_tests}, {"consistent_ketama", (test_callback_fn)pre_behavior_ketama, 0, consistent_tests}, {"consistent_ketama_weighted", (test_callback_fn)pre_behavior_ketama_weighted, 0, consistent_weighted_tests}, @@ -5812,6 +6522,8 @@ collection_st collection[] ={ {"replication_noblock", (test_callback_fn)pre_replication_noblock, 0, replication_tests}, {"regression", 0, 0, regression_tests}, {"behaviors", 0, 0, behavior_tests}, + {"regression_binary_vs_block", (test_callback_fn)key_setup, (test_callback_fn)key_teardown, regression_binary_vs_block}, + {"error_conditions", 0, 0, error_conditions}, {0, 0, 0, 0} };