X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=tests%2Fmem_functions.c;h=01f769a4aac2655572d3663c6053cf37f72df81d;hb=ea260e7bce23c9a41c3c60fd68f55b33608714a9;hp=14550dcbf8e7445814779939aaae1a63ed28b114;hpb=7e592f0e6938506a8f9e228b40557c5bb8a10a0b;p=m6w6%2Flibmemcached diff --git a/tests/mem_functions.c b/tests/mem_functions.c index 14550dcb..01f769a4 100644 --- a/tests/mem_functions.c +++ b/tests/mem_functions.c @@ -52,6 +52,10 @@ static pairs_st *global_pairs; static const char *global_keys[GLOBAL_COUNT]; static size_t global_keys_length[GLOBAL_COUNT]; +// Prototype +static test_return_t pre_binary(memcached_st *memc); + + static test_return_t init_test(memcached_st *not_used __attribute__((unused))) { memcached_st memc; @@ -83,12 +87,13 @@ static test_return_t server_list_null_test(memcached_st *ptr __attribute__((unus in_port_t test_ports[TEST_PORT_COUNT]; static memcached_return_t server_display_function(const memcached_st *ptr __attribute__((unused)), - memcached_server_st *server, void *context) + const memcached_server_st *server, + void *context) { /* Do Nothing */ size_t bigger= *((size_t *)(context)); - assert(bigger <= server->port); - *((size_t *)(context))= server->port; + assert(bigger <= memcached_server_port(server)); + *((size_t *)(context))= memcached_server_port(server); return MEMCACHED_SUCCESS; } @@ -110,7 +115,9 @@ static test_return_t server_sort_test(memcached_st *ptr __attribute__((unused))) test_ports[x]= (in_port_t)random() % 64000; rc= memcached_server_add_with_weight(local_memc, "localhost", test_ports[x], 0); test_true(memcached_server_count(local_memc) == x + 1); - test_true(memcached_servers_count(memcached_server_list(local_memc)) == x+1); +#if 0 // Rewrite + test_true(memcached_server_list_count(memcached_server_list(local_memc)) == x+1); +#endif test_true(rc == MEMCACHED_SUCCESS); } @@ -129,7 +136,7 @@ static test_return_t server_sort2_test(memcached_st *ptr __attribute__((unused)) memcached_return_t rc; memcached_server_fn callbacks[1]; memcached_st *local_memc; - memcached_server_instance_st *instance; + memcached_server_instance_st instance; local_memc= memcached_create(NULL); test_true(local_memc); @@ -138,17 +145,17 @@ static test_return_t server_sort2_test(memcached_st *ptr __attribute__((unused)) rc= memcached_server_add_with_weight(local_memc, "MEMCACHED_BEHAVIOR_SORT_HOSTS", 43043, 0); test_true(rc == MEMCACHED_SUCCESS); - instance= memcached_server_instance_fetch(local_memc, 0); - test_true(instance->port == 43043); + instance= memcached_server_instance_by_position(local_memc, 0); + test_true(memcached_server_port(instance) == 43043); rc= memcached_server_add_with_weight(local_memc, "MEMCACHED_BEHAVIOR_SORT_HOSTS", 43042, 0); test_true(rc == MEMCACHED_SUCCESS); - instance= memcached_server_instance_fetch(local_memc, 0); - test_true(instance->port == 43042); + instance= memcached_server_instance_by_position(local_memc, 0); + test_true(memcached_server_port(instance) == 43042); - instance= memcached_server_instance_fetch(local_memc, 1); - test_true(instance->port == 43043); + instance= memcached_server_instance_by_position(local_memc, 1); + test_true(memcached_server_port(instance) == 43043); callbacks[0]= server_display_function; memcached_server_cursor(local_memc, callbacks, (void *)&bigger, 1); @@ -159,7 +166,47 @@ static test_return_t server_sort2_test(memcached_st *ptr __attribute__((unused)) return TEST_SUCCESS; } -static memcached_return_t server_display_unsort_function(const memcached_st *ptr __attribute__((unused)), memcached_server_st *server, void *context) +static memcached_return_t server_print_callback(const memcached_st *ptr __attribute__((unused)), + const memcached_server_st *server, + void *context __attribute__((unused))) +{ + (void)server; // Just in case we aren't printing. + +#if 0 + fprintf(stderr, "%s(%d)", memcached_server_name(server), memcached_server_port(server)); +#endif + + return MEMCACHED_SUCCESS; +} + +static test_return_t memcached_server_remove_test(memcached_st *ptr __attribute__((unused))) +{ + memcached_return_t rc; + memcached_st local_memc; + memcached_st *memc; + memcached_server_st *servers; + memcached_server_fn callbacks[1]; + + const char *server_string= "localhost:4444, localhost:4445, localhost:4446, localhost:4447, localhost, memcache1.memcache.bk.sapo.pt:11211, memcache1.memcache.bk.sapo.pt:11212, memcache1.memcache.bk.sapo.pt:11213, memcache1.memcache.bk.sapo.pt:11214, memcache2.memcache.bk.sapo.pt:11211, memcache2.memcache.bk.sapo.pt:11212, memcache2.memcache.bk.sapo.pt:11213, memcache2.memcache.bk.sapo.pt:11214"; + + memc= memcached_create(&local_memc); + + servers= memcached_servers_parse(server_string); + + rc= memcached_server_push(memc, servers); + memcached_server_list_free(servers); + + callbacks[0]= server_print_callback; + memcached_server_cursor(memc, callbacks, NULL, 1); + + memcached_free(memc); + + return TEST_SUCCESS; +} + +static memcached_return_t server_display_unsort_function(const memcached_st *ptr __attribute__((unused)), + const memcached_server_st *server, + void *context) { /* Do Nothing */ uint32_t x= *((uint32_t *)(context)); @@ -186,7 +233,9 @@ static test_return_t server_unsort_test(memcached_st *ptr __attribute__((unused) test_ports[x]= (in_port_t)(random() % 64000); rc= memcached_server_add_with_weight(local_memc, "localhost", test_ports[x], 0); test_true(memcached_server_count(local_memc) == x+1); - test_true(memcached_servers_count(memcached_server_list(local_memc)) == x+1); +#if 0 // Rewrite + test_true(memcached_server_list_count(memcached_server_list(local_memc)) == x+1); +#endif test_true(rc == MEMCACHED_SUCCESS); } @@ -258,8 +307,8 @@ static test_return_t clone_test(memcached_st *memc) test_true(memc_clone->flags.randomize_replica_read == memc->flags.randomize_replica_read); } test_true(memc_clone->get_key_failure == memc->get_key_failure); - test_true(memc_clone->hash == memc->hash); - test_true(memc_clone->distribution_hash == memc->distribution_hash); + test_true(hashkit_compare(&memc_clone->hashkit, &memc->hashkit)); + test_true(hashkit_compare(&memc_clone->distribution_hashkit, &memc->distribution_hashkit)); test_true(memc_clone->io_bytes_watermark == memc->io_bytes_watermark); test_true(memc_clone->io_msg_watermark == memc->io_msg_watermark); test_true(memc_clone->io_key_prefetch == memc->io_key_prefetch); @@ -332,10 +381,11 @@ static test_return_t error_test(memcached_st *memc) 4269430871U, 610793021U, 527273862U, 1437122909U, 2300930706U, 2943759320U, 674306647U, 2400528935U, 54481931U, 4186304426U, 1741088401U, 2979625118U, - 4159057246U, 3425930182U, 2593724503U, 1868899624U}; + 4159057246U, 3425930182U, 2593724503U, 1868899624U, + 1769812374U, 2302537950U, 1110330676U }; // You have updated the memcache_error messages but not updated docs/tests. - test_true(MEMCACHED_MAXIMUM_RETURN == 40); + test_true(MEMCACHED_MAXIMUM_RETURN == 43); for (rc= MEMCACHED_SUCCESS; rc < MEMCACHED_MAXIMUM_RETURN; rc++) { uint32_t hash_val; @@ -530,7 +580,7 @@ static test_return_t cas_test(memcached_st *memc) test_true(rc == MEMCACHED_SUCCESS); uint64_t cas = memcached_result_cas(results); - #if 0 +#if 0 results= memcached_fetch_result(memc, &results_obj, &rc); test_true(rc == MEMCACHED_END); test_true(results == NULL); @@ -695,7 +745,7 @@ static test_return_t flush_test(memcached_st *memc) } static memcached_return_t server_function(const memcached_st *ptr __attribute__((unused)), - memcached_server_st *server __attribute__((unused)), + const memcached_server_st *server __attribute__((unused)), void *context __attribute__((unused))) { /* Do Nothing */ @@ -1168,12 +1218,16 @@ static test_return_t stats_servername_test(memcached_st *memc) { memcached_return_t rc; memcached_stat_st memc_stat; - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, 0); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); +#ifdef LIBMEMCACHED_WITH_SASL_SUPPORT + if (memcached_get_sasl_callbacks(memc) != NULL) + return TEST_SKIPPED; +#endif rc= memcached_stat_servername(&memc_stat, NULL, - instance->hostname, - instance->port); + memcached_server_name(instance), + memcached_server_port(instance)); return TEST_SUCCESS; } @@ -1617,7 +1671,7 @@ static test_return_t mget_execute(memcached_st *memc) uint32_t number_of_hosts= memc->number_of_hosts; memc->number_of_hosts= 1; - size_t max_keys= binary ? 20480 : 1; + size_t max_keys= 20480; char **keys= calloc(max_keys, sizeof(char*)); @@ -1626,6 +1680,7 @@ static test_return_t mget_execute(memcached_st *memc) /* First add all of the items.. */ char blob[1024] = {0}; memcached_return_t rc; + for (size_t x= 0; x < max_keys; ++x) { char k[251]; @@ -1643,21 +1698,23 @@ static test_return_t mget_execute(memcached_st *memc) rc= memcached_mget_execute(memc, (const char**)keys, key_length, max_keys, callbacks, &counter, 1); - if (binary) + if (rc == MEMCACHED_SUCCESS) { - test_true(rc == MEMCACHED_SUCCESS); - + test_true(binary); rc= memcached_fetch_execute(memc, callbacks, (void *)&counter, 1); test_true(rc == MEMCACHED_END); /* Verify that we got all of the items */ test_true(counter == max_keys); } - else + else if (rc == MEMCACHED_NOT_SUPPORTED) { - test_true(rc == MEMCACHED_NOT_SUPPORTED); test_true(counter == 0); } + else + { + test_fail("note: this test functions differently when in binary mode"); + } /* Release all allocated resources */ for (size_t x= 0; x < max_keys; ++x) @@ -1671,6 +1728,51 @@ static test_return_t mget_execute(memcached_st *memc) return TEST_SUCCESS; } +#define REGRESSION_BINARY_VS_BLOCK_COUNT 20480 + +static test_return_t key_setup(memcached_st *memc) +{ + (void)memc; + + if (pre_binary(memc) != TEST_SUCCESS) + return TEST_SKIPPED; + + global_pairs= pairs_generate(REGRESSION_BINARY_VS_BLOCK_COUNT, 0); + + return TEST_SUCCESS; +} + +static test_return_t key_teardown(memcached_st *memc) +{ + (void)memc; + pairs_free(global_pairs); + + return TEST_SUCCESS; +} + +static test_return_t block_add_regression(memcached_st *memc) +{ + /* First add all of the items.. */ + for (size_t x= 0; x < REGRESSION_BINARY_VS_BLOCK_COUNT; ++x) + { + memcached_return_t rc; + char blob[1024] = {0}; + + rc= memcached_add_by_key(memc, "bob", 3, global_pairs[x].key, global_pairs[x].key_length, blob, sizeof(blob), 0, 0); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); + } + + return TEST_SUCCESS; +} + +static test_return_t binary_add_regression(memcached_st *memc) +{ + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + test_return_t rc= block_add_regression(memc); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 0); + return rc; +} + static test_return_t get_stats_keys(memcached_st *memc) { char **stat_list; @@ -1889,6 +1991,54 @@ static test_return_t MEMCACHED_BEHAVIOR_CORK_test(memcached_st *memc) return TEST_SUCCESS; } + +static test_return_t MEMCACHED_BEHAVIOR_TCP_KEEPALIVE_test(memcached_st *memc) +{ + memcached_return_t rc; + bool set= true; + bool value; + + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_KEEPALIVE, set); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_NOT_SUPPORTED); + + value= (bool)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_TCP_KEEPALIVE); + + if (rc == MEMCACHED_SUCCESS) + { + test_true((bool)value == set); + } + else + { + test_false((bool)value == set); + } + + return TEST_SUCCESS; +} + + +static test_return_t MEMCACHED_BEHAVIOR_TCP_KEEPIDLE_test(memcached_st *memc) +{ + memcached_return_t rc; + bool set= true; + bool value; + + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_TCP_KEEPIDLE, set); + test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_NOT_SUPPORTED); + + value= (bool)memcached_behavior_get(memc, MEMCACHED_BEHAVIOR_TCP_KEEPIDLE); + + if (rc == MEMCACHED_SUCCESS) + { + test_true((bool)value == set); + } + else + { + test_false((bool)value == set); + } + + return TEST_SUCCESS; +} + static test_return_t fetch_all_results(memcached_st *memc) { memcached_return_t rc= MEMCACHED_SUCCESS; @@ -2666,22 +2816,21 @@ static test_return_t user_supplied_bug17(memcached_st *memc) From Andrei on IRC */ -static test_return_t user_supplied_bug19(memcached_st *memc) +static test_return_t user_supplied_bug19(memcached_st *not_used) { - memcached_st *m; - memcached_server_st *s; + memcached_st *memc; + const memcached_server_st *server; memcached_return_t res; - (void)memc; + (void)not_used; - m= memcached_create(NULL); - memcached_server_add_with_weight(m, "localhost", 11311, 100); - memcached_server_add_with_weight(m, "localhost", 11312, 100); + memc= memcached_create(NULL); + memcached_server_add_with_weight(memc, "localhost", 11311, 100); + memcached_server_add_with_weight(memc, "localhost", 11312, 100); - s= memcached_server_by_key(m, "a", 1, &res); - memcached_server_free(s); + server= memcached_server_by_key(memc, "a", 1, &res); - memcached_free(m); + memcached_free(memc); return TEST_SUCCESS; } @@ -2768,9 +2917,11 @@ static test_return_t user_supplied_bug18(memcached_st *trash) for (x= 0; x < 99; x++) { uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, server_idx); - char *hostname = instance->hostname; + + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, server_idx); + + const char *hostname = memcached_server_name(instance); test_strcmp(hostname, ketama_test_cases[x].server); } @@ -2846,8 +2997,6 @@ static test_return_t _user_supplied_bug21(memcached_st* memc, size_t key_count) return TEST_SUCCESS; } -static test_return_t pre_binary(memcached_st *memc); - static test_return_t user_supplied_bug21(memcached_st *memc) { test_return_t test_rc; @@ -2872,7 +3021,7 @@ static test_return_t user_supplied_bug21(memcached_st *memc) static test_return_t auto_eject_hosts(memcached_st *trash) { (void) trash; - memcached_server_instance_st *instance; + memcached_server_instance_st instance; memcached_return_t rc; memcached_st *memc= memcached_create(NULL); @@ -2913,18 +3062,22 @@ static test_return_t auto_eject_hosts(memcached_st *trash) test_true(server_pool[7].port == 11211); test_true(server_pool[7].weight == 100); - instance= memcached_server_instance_fetch(memc, 2); - instance->next_retry = time(NULL) + 15; + instance= memcached_server_instance_by_position(memc, 2); + ((memcached_server_write_instance_st)instance)->next_retry = time(NULL) + 15; memc->next_distribution_rebuild= time(NULL) - 1; + /* + This would not work if there were only two hosts. + */ for (size_t x= 0; x < 99; x++) { - uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); + memcached_autoeject(memc); + uint32_t server_idx= memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); test_true(server_idx != 2); } /* and re-added when it's back. */ - instance->next_retry = time(NULL) - 1; + ((memcached_server_write_instance_st)instance)->next_retry = time(NULL) - 1; memc->next_distribution_rebuild= time(NULL) - 1; memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_DISTRIBUTION, memc->distribution); @@ -2933,8 +3086,8 @@ static test_return_t auto_eject_hosts(memcached_st *trash) uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); // We re-use instance from above. instance= - memcached_server_instance_fetch(memc, server_idx); - char *hostname = instance->hostname; + memcached_server_instance_by_position(memc, server_idx); + const char *hostname = memcached_server_name(instance); test_true(strcmp(hostname, ketama_test_cases[x].server) == 0); } @@ -3203,8 +3356,8 @@ static test_return_t generate_data_with_stats(memcached_st *memc) { /* This test was changes so that "make test" would work properlly */ #ifdef DEBUG - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, host_index); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, host_index); printf("\nserver %u|%s|%u bytes: %llu\n", host_index, instance->hostname, instance->port, (unsigned long long)(stat_p + host_index)->bytes); #endif @@ -3404,8 +3557,13 @@ static test_return_t pre_cork(memcached_st *memc) { memcached_return_t rc; bool set= true; + rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_CORK, set); +#ifdef __APPLE__ + return TEST_SKIPPED; +#endif + if (rc == MEMCACHED_SUCCESS) return TEST_SUCCESS; @@ -3415,9 +3573,13 @@ static test_return_t pre_cork(memcached_st *memc) static test_return_t pre_cork_and_nonblock(memcached_st *memc) { test_return_t rc; - + rc= pre_cork(memc); +#ifdef __APPLE__ + return TEST_SKIPPED; +#endif + if (rc != TEST_SUCCESS) return rc; @@ -3428,7 +3590,7 @@ static test_return_t pre_nonblock_binary(memcached_st *memc) { memcached_return_t rc= MEMCACHED_FAILURE; memcached_st *memc_clone; - memcached_server_instance_st *instance; + memcached_server_instance_st instance; memc_clone= memcached_clone(NULL, memc); test_true(memc_clone); @@ -3436,7 +3598,7 @@ static test_return_t pre_nonblock_binary(memcached_st *memc) // will not toggle protocol on an connection. memcached_version(memc_clone); - instance= memcached_server_instance_fetch(memc_clone, 0); + instance= memcached_server_instance_by_position(memc_clone, 0); if (instance->major_version >= 1 && instance->minor_version > 2) { @@ -3564,7 +3726,7 @@ static test_return_t pre_binary(memcached_st *memc) { memcached_return_t rc= MEMCACHED_FAILURE; memcached_st *memc_clone; - memcached_server_instance_st *instance; + memcached_server_instance_st instance; memc_clone= memcached_clone(NULL, memc); test_true(memc_clone); @@ -3572,7 +3734,7 @@ static test_return_t pre_binary(memcached_st *memc) // will not toggle protocol on an connection. memcached_version(memc_clone); - instance= memcached_server_instance_fetch(memc_clone, 0); + instance= memcached_server_instance_by_position(memc_clone, 0); if (instance->major_version >= 1 && instance->minor_version > 2) { @@ -3586,6 +3748,31 @@ static test_return_t pre_binary(memcached_st *memc) return rc == MEMCACHED_SUCCESS ? TEST_SUCCESS : TEST_SKIPPED; } +static test_return_t pre_sasl(memcached_st *memc) +{ + memcached_return_t rc= MEMCACHED_FAILURE; + +#ifdef LIBMEMCACHED_WITH_SASL_SUPPORT + const char *server= getenv("LIBMEMCACHED_TEST_SASL_SERVER"); + const char *user= getenv("LIBMEMCACHED_TEST_SASL_USERNAME"); + const char *pass= getenv("LIBMEMCACHED_TEST_SASL_PASSWORD"); + + if (server != NULL && user != NULL && pass != NULL) + { + memcached_server_st *servers= memcached_servers_parse(server); + test_true(servers != NULL); + memcached_servers_reset(memc); + test_true(memcached_server_push(memc, servers) == MEMCACHED_SUCCESS); + memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + rc= memcached_set_sasl_auth_data(memc, user, pass); + test_true(rc == MEMCACHED_SUCCESS); + } +#else + (void)memc; +#endif + + return rc == MEMCACHED_SUCCESS ? TEST_SUCCESS : TEST_SKIPPED; +} static test_return_t pre_replication(memcached_st *memc) { @@ -3883,8 +4070,8 @@ static test_return_t enable_cas(memcached_st *memc) { unsigned int set= 1; - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, 0); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); memcached_version(memc); @@ -3902,8 +4089,9 @@ static test_return_t enable_cas(memcached_st *memc) static test_return_t check_for_1_2_3(memcached_st *memc) { memcached_version(memc); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, 0); + + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, 0); if ((instance->major_version >= 1 && (instance->minor_version == 2 && instance->micro_version >= 4)) || instance->minor_version > 2) @@ -4009,8 +4197,8 @@ static test_return_t noreply_test(memcached_st *memc) int no_msg=0; for (uint32_t x= 0; x < memcached_server_count(memc); ++x) { - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, x); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, x); no_msg+=(int)(instance->cursor_active); } @@ -4195,7 +4383,7 @@ static test_return_t connection_pool_test(memcached_st *memc) rc= memcached_set(mmc[0], key, keylen, "0", 1, 0, 0); test_true(rc == MEMCACHED_SUCCESS); - for (size_t x= 0; x < 10; ++x) + for (size_t x= 0; x < 10; ++x) { uint64_t number_value; rc= memcached_increment(mmc[x], key, keylen, 1, &number_value); @@ -4296,10 +4484,10 @@ static test_return_t replication_get_test(memcached_st *memc) for (uint32_t host= 0; host < memcached_server_count(memc); ++host) { memcached_st *memc_clone= memcached_clone(NULL, memc); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc_clone, host); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc_clone, host); - instance->port= 0; + ((memcached_server_write_instance_st)instance)->port= 0; for (int x= 'a'; x <= 'z'; ++x) { @@ -4358,9 +4546,9 @@ static test_return_t replication_mget_test(memcached_st *memc) for (uint32_t host= 0; host < memc_clone->number_of_hosts; host++) { memcached_st *new_clone= memcached_clone(NULL, memc); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(new_clone, host); - instance->port= 0; + memcached_server_instance_st instance= + memcached_server_instance_by_position(new_clone, host); + ((memcached_server_write_instance_st)instance)->port= 0; for (int x= 'a'; x <= 'z'; ++x) { @@ -4400,7 +4588,7 @@ static test_return_t replication_randomize_mget_test(memcached_st *memc) const char *keys[]= { "key1", "key2", "key3", "key4", "key5", "key6", "key7" }; size_t len[]= { 4, 4, 4, 4, 4, 4, 4 }; - for (int x=0; x< 7; ++x) + for (size_t x= 0; x< 7; ++x) { rc= memcached_set(memc, keys[x], len[x], "1", 1, 0, 0); test_true(rc == MEMCACHED_SUCCESS); @@ -4456,10 +4644,10 @@ static test_return_t replication_delete_test(memcached_st *memc) uint32_t hash= memcached_generate_hash(memc, keys[0], len[0]); for (uint32_t x= 0; x < (repl + 1); ++x) { - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc_clone, x); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc_clone, x); - instance->port= 0; + ((memcached_server_write_instance_st)instance)->port= 0; if (++hash == memc_clone->number_of_hosts) hash= 0; } @@ -4491,427 +4679,140 @@ static test_return_t replication_delete_test(memcached_st *memc) return TEST_SUCCESS; } -static void increment_request_id(uint16_t *id) +#if 0 +static test_return_t hash_sanity_test (memcached_st *memc) { - (*id)++; - if ((*id & UDP_REQUEST_ID_THREAD_MASK) != 0) - *id= 0; -} + (void)memc; -static uint16_t *get_udp_request_ids(memcached_st *memc) -{ - uint16_t *ids= malloc(sizeof(uint16_t) * memcached_server_count(memc)); - assert(ids != NULL); + assert(MEMCACHED_HASH_DEFAULT == MEMCACHED_HASH_DEFAULT); + assert(MEMCACHED_HASH_MD5 == MEMCACHED_HASH_MD5); + assert(MEMCACHED_HASH_CRC == MEMCACHED_HASH_CRC); + assert(MEMCACHED_HASH_FNV1_64 == MEMCACHED_HASH_FNV1_64); + assert(MEMCACHED_HASH_FNV1A_64 == MEMCACHED_HASH_FNV1A_64); + assert(MEMCACHED_HASH_FNV1_32 == MEMCACHED_HASH_FNV1_32); + assert(MEMCACHED_HASH_FNV1A_32 == MEMCACHED_HASH_FNV1A_32); +#ifdef HAVE_HSIEH_HASH + assert(MEMCACHED_HASH_HSIEH == MEMCACHED_HASH_HSIEH); +#endif + assert(MEMCACHED_HASH_MURMUR == MEMCACHED_HASH_MURMUR); + assert(MEMCACHED_HASH_JENKINS == MEMCACHED_HASH_JENKINS); + assert(MEMCACHED_HASH_MAX == MEMCACHED_HASH_MAX); - for (uint32_t x= 0; x < memcached_server_count(memc); x++) - { - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, x); + return TEST_SUCCESS; +} +#endif - ids[x]= get_udp_datagram_request_id((struct udp_datagram_header_st *) instance->write_buffer); - } +static test_return_t hsieh_avaibility_test (memcached_st *memc) +{ + memcached_return_t expected_rc= MEMCACHED_FAILURE; +#ifdef HAVE_HSIEH_HASH + expected_rc= MEMCACHED_SUCCESS; +#endif + memcached_return_t rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, + (uint64_t)MEMCACHED_HASH_HSIEH); + test_true(rc == expected_rc); - return ids; + return TEST_SUCCESS; } -static test_return_t post_udp_op_check(memcached_st *memc, uint16_t *expected_req_ids) +static test_return_t one_at_a_time_run (memcached_st *memc __attribute__((unused))) { - memcached_server_st *cur_server = memcached_server_list(memc); - uint16_t *cur_req_ids = get_udp_request_ids(memc); + uint32_t x; + const char **ptr; - for (size_t x= 0; x < memcached_server_count(memc); x++) + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { - test_true(cur_server[x].cursor_active == 0); - test_true(cur_req_ids[x] == expected_req_ids[x]); + uint32_t hash_val; + + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_DEFAULT); + test_true(one_at_a_time_values[x] == hash_val); } - free(expected_req_ids); - free(cur_req_ids); return TEST_SUCCESS; } -/* -** There is a little bit of a hack here, instead of removing -** the servers, I just set num host to 0 and them add then new udp servers -**/ -static test_return_t init_udp(memcached_st *memc) +static test_return_t md5_run (memcached_st *memc __attribute__((unused))) { - memcached_version(memc); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, 0); - - /* For the time being, only support udp test for >= 1.2.6 && < 1.3 */ - if (instance->major_version != 1 || instance->minor_version != 2 - || instance->micro_version < 6) - return TEST_SKIPPED; - - uint32_t num_hosts= memcached_server_count(memc); - memcached_server_st servers[num_hosts]; - memcpy(servers, memcached_server_list(memc), sizeof(memcached_server_st) * num_hosts); - for (uint32_t x= 0; x < num_hosts; x++) - { - memcached_server_instance_st *set_instance= - memcached_server_instance_fetch(memc, x); - - memcached_server_free(set_instance); - } + uint32_t x; + const char **ptr; - memc->number_of_hosts= 0; - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_USE_UDP, 1); - for (uint32_t x= 0; x < num_hosts; x++) + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { - memcached_server_instance_st *set_instance= - memcached_server_instance_fetch(memc, x); + uint32_t hash_val; - test_true(memcached_server_add_udp(memc, servers[x].hostname, servers[x].port) == MEMCACHED_SUCCESS); - test_true(set_instance->write_buffer_offset == UDP_DATAGRAM_HEADER_LENGTH); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MD5); + test_true(md5_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t binary_init_udp(memcached_st *memc) +static test_return_t crc_run (memcached_st *memc __attribute__((unused))) { - test_return_t test_rc; - test_rc= pre_binary(memc); + uint32_t x; + const char **ptr; - if (test_rc != TEST_SUCCESS) - return test_rc; + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; - return init_udp(memc); -} + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_CRC); + test_true(crc_values[x] == hash_val); + } -/* Make sure that I cant add a tcp server to a udp client */ -static test_return_t add_tcp_server_udp_client_test(memcached_st *memc) -{ - (void)memc; -#if 0 - memcached_server_st server; - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, 0); - memcached_server_clone(&server, &memc->hosts[0]); - test_true(memcached_server_remove(&(memc->hosts[0])) == MEMCACHED_SUCCESS); - test_true(memcached_server_add(memc, server.hostname, server.port) == MEMCACHED_INVALID_HOST_PROTOCOL); -#endif return TEST_SUCCESS; } -/* Make sure that I cant add a udp server to a tcp client */ -static test_return_t add_udp_server_tcp_client_test(memcached_st *memc) +static test_return_t fnv1_64_run (memcached_st *memc __attribute__((unused))) { - (void)memc; -#if 0 - memcached_server_st server; - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, 0); - memcached_server_clone(&server, &memc->hosts[0]); - test_true(memcached_server_remove(&(memc->hosts[0])) == MEMCACHED_SUCCESS); - - memcached_st tcp_client; - memcached_create(&tcp_client); - test_true(memcached_server_add_udp(&tcp_client, server.hostname, server.port) == MEMCACHED_INVALID_HOST_PROTOCOL); -#endif + uint32_t x; + const char **ptr; + + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; + + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_64); + test_true(fnv1_64_values[x] == hash_val); + } return TEST_SUCCESS; } -static test_return_t set_udp_behavior_test(memcached_st *memc) +static test_return_t fnv1a_64_run (memcached_st *memc __attribute__((unused))) { + uint32_t x; + const char **ptr; - memcached_quit(memc); - memc->number_of_hosts= 0; - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_DISTRIBUTION, memc->distribution); - test_true(memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_USE_UDP, 1) == MEMCACHED_SUCCESS); - test_true(memc->flags.use_udp); - test_true(memc->flags.no_reply); - - test_true(memcached_server_count(memc) == 0); + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) + { + uint32_t hash_val; - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_USE_UDP,0); - test_true(! (memc->flags.use_udp)); - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NOREPLY,0); - test_true(! (memc->flags.no_reply)); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_64); + test_true(fnv1a_64_values[x] == hash_val); + } return TEST_SUCCESS; } -static test_return_t udp_set_test(memcached_st *memc) +static test_return_t fnv1_32_run (memcached_st *memc __attribute__((unused))) { - unsigned int num_iters= 1025; //request id rolls over at 1024 + uint32_t x; + const char **ptr; - for (size_t x= 0; x < num_iters;x++) - { - memcached_return_t rc; - const char *key= "foo"; - const char *value= "when we sanitize"; - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, server_key); - size_t init_offset= instance->write_buffer_offset; - rc= memcached_set(memc, key, strlen(key), - value, strlen(value), - (time_t)0, (uint32_t)0); - test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); - /** NB, the check below assumes that if new write_ptr is less than - * the original write_ptr that we have flushed. For large payloads, this - * maybe an invalid assumption, but for the small payload we have it is OK - */ - if (rc == MEMCACHED_SUCCESS || - instance->write_buffer_offset < init_offset) - increment_request_id(&expected_ids[server_key]); - - if (rc == MEMCACHED_SUCCESS) - { - test_true(instance->write_buffer_offset == UDP_DATAGRAM_HEADER_LENGTH); - } - else - { - test_true(instance->write_buffer_offset != UDP_DATAGRAM_HEADER_LENGTH); - test_true(instance->write_buffer_offset <= MAX_UDP_DATAGRAM_LENGTH); - } - test_true(post_udp_op_check(memc, expected_ids) == TEST_SUCCESS); - } - return TEST_SUCCESS; -} - -static test_return_t udp_buffered_set_test(memcached_st *memc) -{ - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1); - return udp_set_test(memc); -} - -static test_return_t udp_set_too_big_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "bar"; - char value[MAX_UDP_DATAGRAM_LENGTH]; - uint16_t *expected_ids= get_udp_request_ids(memc); - rc= memcached_set(memc, key, strlen(key), - value, MAX_UDP_DATAGRAM_LENGTH, - (time_t)0, (uint32_t)0); - test_true(rc == MEMCACHED_WRITE_FAILURE); - - return post_udp_op_check(memc,expected_ids); -} - -static test_return_t udp_delete_test(memcached_st *memc) -{ - unsigned int num_iters= 1025; //request id rolls over at 1024 - - for (size_t x= 0; x < num_iters;x++) - { - memcached_return_t rc; - const char *key= "foo"; - uint16_t *expected_ids=get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, server_key); - size_t init_offset= instance->write_buffer_offset; - - rc= memcached_delete(memc, key, strlen(key), 0); - test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); - - if (rc == MEMCACHED_SUCCESS || instance->write_buffer_offset < init_offset) - increment_request_id(&expected_ids[server_key]); - if (rc == MEMCACHED_SUCCESS) - { - test_true(instance->write_buffer_offset == UDP_DATAGRAM_HEADER_LENGTH); - } - else - { - test_true(instance->write_buffer_offset != UDP_DATAGRAM_HEADER_LENGTH); - test_true(instance->write_buffer_offset <= MAX_UDP_DATAGRAM_LENGTH); - } - test_true(post_udp_op_check(memc,expected_ids) == TEST_SUCCESS); - } - return TEST_SUCCESS; -} - -static test_return_t udp_buffered_delete_test(memcached_st *memc) -{ - memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BUFFER_REQUESTS, 1); - return udp_delete_test(memc); -} - -static test_return_t udp_verbosity_test(memcached_st *memc) -{ - memcached_return_t rc; - uint16_t *expected_ids= get_udp_request_ids(memc); - - for (size_t x= 0; x < memcached_server_count(memc); x++) - { - increment_request_id(&expected_ids[x]); - } - - rc= memcached_verbosity(memc,3); - test_true(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc,expected_ids); -} - -static test_return_t udp_quit_test(memcached_st *memc) -{ - uint16_t *expected_ids= get_udp_request_ids(memc); - memcached_quit(memc); - return post_udp_op_check(memc, expected_ids); -} - -static test_return_t udp_flush_test(memcached_st *memc) -{ - memcached_return_t rc; - uint16_t *expected_ids= get_udp_request_ids(memc); - - for (size_t x= 0; x < memcached_server_count(memc); x++) + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { - increment_request_id(&expected_ids[x]); - } - - rc= memcached_flush(memc,0); - test_true(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc,expected_ids); -} - -static test_return_t udp_incr_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "incr"; - const char *value= "1"; - rc= memcached_set(memc, key, strlen(key), - value, strlen(value), - (time_t)0, (uint32_t)0); - - test_true(rc == MEMCACHED_SUCCESS); - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - increment_request_id(&expected_ids[server_key]); - uint64_t newvalue; - rc= memcached_increment(memc, key, strlen(key), 1, &newvalue); - test_true(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc, expected_ids); -} - -static test_return_t udp_decr_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "decr"; - const char *value= "1"; - rc= memcached_set(memc, key, strlen(key), - value, strlen(value), - (time_t)0, (uint32_t)0); - - test_true(rc == MEMCACHED_SUCCESS); - uint16_t *expected_ids= get_udp_request_ids(memc); - unsigned int server_key= memcached_generate_hash(memc, key, strlen(key)); - increment_request_id(&expected_ids[server_key]); - uint64_t newvalue; - rc= memcached_decrement(memc, key, strlen(key), 1, &newvalue); - test_true(rc == MEMCACHED_SUCCESS); - return post_udp_op_check(memc, expected_ids); -} - - -static test_return_t udp_stat_test(memcached_st *memc) -{ - memcached_stat_st * rv= NULL; - memcached_return_t rc; - char args[]= ""; - uint16_t *expected_ids = get_udp_request_ids(memc); - rv = memcached_stat(memc, args, &rc); - free(rv); - test_true(rc == MEMCACHED_NOT_SUPPORTED); - return post_udp_op_check(memc, expected_ids); -} - -static test_return_t udp_version_test(memcached_st *memc) -{ - memcached_return_t rc; - uint16_t *expected_ids = get_udp_request_ids(memc); - rc = memcached_version(memc); - test_true(rc == MEMCACHED_NOT_SUPPORTED); - return post_udp_op_check(memc, expected_ids); -} - -static test_return_t udp_get_test(memcached_st *memc) -{ - memcached_return_t rc; - const char *key= "foo"; - size_t vlen; - uint16_t *expected_ids = get_udp_request_ids(memc); - char *val= memcached_get(memc, key, strlen(key), &vlen, (uint32_t)0, &rc); - test_true(rc == MEMCACHED_NOT_SUPPORTED); - test_true(val == NULL); - return post_udp_op_check(memc, expected_ids); -} + uint32_t hash_val; -static test_return_t udp_mixed_io_test(memcached_st *memc) -{ - test_st current_op; - test_st mixed_io_ops [] ={ - {"udp_set_test", 0, - (test_callback_fn)udp_set_test}, - {"udp_set_too_big_test", 0, - (test_callback_fn)udp_set_too_big_test}, - {"udp_delete_test", 0, - (test_callback_fn)udp_delete_test}, - {"udp_verbosity_test", 0, - (test_callback_fn)udp_verbosity_test}, - {"udp_quit_test", 0, - (test_callback_fn)udp_quit_test}, - {"udp_flush_test", 0, - (test_callback_fn)udp_flush_test}, - {"udp_incr_test", 0, - (test_callback_fn)udp_incr_test}, - {"udp_decr_test", 0, - (test_callback_fn)udp_decr_test}, - {"udp_version_test", 0, - (test_callback_fn)udp_version_test} - }; - for (size_t x= 0; x < 500; x++) - { - current_op= mixed_io_ops[random() % 9]; - test_true(current_op.test_fn(memc) == TEST_SUCCESS); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_32); + test_true(fnv1_32_values[x] == hash_val); } - return TEST_SUCCESS; -} - -#if 0 -static test_return_t hash_sanity_test (memcached_st *memc) -{ - (void)memc; - - assert(MEMCACHED_HASH_DEFAULT == MEMCACHED_HASH_DEFAULT); - assert(MEMCACHED_HASH_MD5 == MEMCACHED_HASH_MD5); - assert(MEMCACHED_HASH_CRC == MEMCACHED_HASH_CRC); - assert(MEMCACHED_HASH_FNV1_64 == MEMCACHED_HASH_FNV1_64); - assert(MEMCACHED_HASH_FNV1A_64 == MEMCACHED_HASH_FNV1A_64); - assert(MEMCACHED_HASH_FNV1_32 == MEMCACHED_HASH_FNV1_32); - assert(MEMCACHED_HASH_FNV1A_32 == MEMCACHED_HASH_FNV1A_32); -#ifdef HAVE_HSIEH_HASH - assert(MEMCACHED_HASH_HSIEH == MEMCACHED_HASH_HSIEH); -#endif - assert(MEMCACHED_HASH_MURMUR == MEMCACHED_HASH_MURMUR); - assert(MEMCACHED_HASH_JENKINS == MEMCACHED_HASH_JENKINS); - assert(MEMCACHED_HASH_MAX == MEMCACHED_HASH_MAX); return TEST_SUCCESS; } -#endif -static test_return_t hsieh_avaibility_test (memcached_st *memc) -{ - memcached_return_t expected_rc= MEMCACHED_FAILURE; -#ifdef HAVE_HSIEH_HASH - expected_rc= MEMCACHED_SUCCESS; -#endif - memcached_return_t rc= memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_HASH, - (uint64_t)MEMCACHED_HASH_HSIEH); - test_true(rc == expected_rc); - - return TEST_SUCCESS; -} - -static test_return_t md5_run (memcached_st *memc __attribute__((unused))) +static test_return_t fnv1a_32_run (memcached_st *memc __attribute__((unused))) { uint32_t x; const char **ptr; @@ -4920,14 +4821,14 @@ static test_return_t md5_run (memcached_st *memc __attribute__((unused))) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MD5); - test_true(md5_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_32); + test_true(fnv1a_32_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t crc_run (memcached_st *memc __attribute__((unused))) +static test_return_t hsieh_run (memcached_st *memc __attribute__((unused))) { uint32_t x; const char **ptr; @@ -4936,15 +4837,18 @@ static test_return_t crc_run (memcached_st *memc __attribute__((unused))) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_CRC); - test_true(crc_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_HSIEH); + test_true(hsieh_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t fnv1_64_run (memcached_st *memc __attribute__((unused))) +static test_return_t murmur_run (memcached_st *memc __attribute__((unused))) { +#ifdef WORDS_BIGENDIAN + return TEST_SKIPPED; +#else uint32_t x; const char **ptr; @@ -4952,110 +4856,107 @@ static test_return_t fnv1_64_run (memcached_st *memc __attribute__((unused))) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_64); - test_true(fnv1_64_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MURMUR); + test_true(murmur_values[x] == hash_val); } return TEST_SUCCESS; +#endif } -static test_return_t fnv1a_64_run (memcached_st *memc __attribute__((unused))) +static test_return_t jenkins_run (memcached_st *memc __attribute__((unused))) { uint32_t x; const char **ptr; + for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_64); - test_true(fnv1a_64_values[x] == hash_val); + hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_JENKINS); + test_true(jenkins_values[x] == hash_val); } return TEST_SUCCESS; } -static test_return_t fnv1_32_run (memcached_st *memc __attribute__((unused))) +static uint32_t hash_md5_test_function(const char *string, size_t string_length, void *context) { - uint32_t x; - const char **ptr; - - - for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) - { - uint32_t hash_val; - - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1_32); - test_true(fnv1_32_values[x] == hash_val); - } + (void)context; + return libhashkit_md5(string, string_length); +} - return TEST_SUCCESS; +static uint32_t hash_crc_test_function(const char *string, size_t string_length, void *context) +{ + (void)context; + return libhashkit_crc32(string, string_length); } -static test_return_t fnv1a_32_run (memcached_st *memc __attribute__((unused))) +static test_return_t memcached_get_hashkit_test (memcached_st *memc) { uint32_t x; const char **ptr; + const hashkit_st *kit; + hashkit_st new_kit; + hashkit_return_t hash_rc; + + uint32_t md5_hosts[]= {4U, 1U, 0U, 1U, 4U, 2U, 0U, 3U, 0U, 0U, 3U, 1U, 0U, 0U, 1U, 3U, 0U, 0U, 0U, 3U, 1U, 0U, 4U, 4U, 3U}; + uint32_t crc_hosts[]= {2U, 4U, 1U, 0U, 2U, 4U, 4U, 4U, 1U, 2U, 3U, 4U, 3U, 4U, 1U, 3U, 3U, 2U, 0U, 0U, 0U, 1U, 2U, 4U, 0U}; + + kit= memcached_get_hashkit(memc); + hashkit_clone(&new_kit, kit); + hash_rc= hashkit_set_custom_function(&new_kit, hash_md5_test_function, NULL); + test_true(hash_rc == HASHKIT_SUCCESS); + + memcached_set_hashkit(memc, &new_kit); + + /* + Verify Setting the hash. + */ for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_FNV1A_32); - test_true(fnv1a_32_values[x] == hash_val); + hash_val= hashkit_digest(kit, *ptr, strlen(*ptr)); + test_true(md5_values[x] == hash_val); } - return TEST_SUCCESS; -} - -static test_return_t hsieh_run (memcached_st *memc __attribute__((unused))) -{ - uint32_t x; - const char **ptr; + /* + Now check memcached_st. + */ for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_HSIEH); - test_true(hsieh_values[x] == hash_val); + hash_val= memcached_generate_hash(memc, *ptr, strlen(*ptr)); + test_true(md5_hosts[x] == hash_val); } - return TEST_SUCCESS; -} + hash_rc= hashkit_set_custom_function(&new_kit, hash_crc_test_function, NULL); + test_true(hash_rc == HASHKIT_SUCCESS); -static test_return_t murmur_run (memcached_st *memc __attribute__((unused))) -{ -#ifdef __sparc - return TEST_SKIPPED; -#else - uint32_t x; - const char **ptr; + memcached_set_hashkit(memc, &new_kit); + /* + Verify Setting the hash. + */ for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_MURMUR); - test_true(murmur_values[x] == hash_val); + hash_val= hashkit_digest(kit, *ptr, strlen(*ptr)); + test_true(crc_values[x] == hash_val); } - return TEST_SUCCESS; -#endif -} - -static test_return_t jenkins_run (memcached_st *memc __attribute__((unused))) -{ - uint32_t x; - const char **ptr; - - for (ptr= list_to_hash, x= 0; *ptr; ptr++, x++) { uint32_t hash_val; - hash_val= memcached_generate_hash_value(*ptr, strlen(*ptr), MEMCACHED_HASH_JENKINS); - test_true(jenkins_values[x] == hash_val); + hash_val= memcached_generate_hash(memc, *ptr, strlen(*ptr)); + test_true(crc_hosts[x] == hash_val); } return TEST_SUCCESS; @@ -5109,9 +5010,9 @@ static test_return_t ketama_compatibility_libmemcached(memcached_st *trash) for (x= 0; x < 99; x++) { uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases[x].key, strlen(ketama_test_cases[x].key)); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, server_idx); - char *hostname = instance->hostname; + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, server_idx); + const char *hostname = memcached_server_name(instance); test_strcmp(hostname, ketama_test_cases[x].server); } @@ -5167,10 +5068,13 @@ static test_return_t ketama_compatibility_spymemcached(memcached_st *trash) /* verify the standard ketama set. */ for (x= 0; x < 99; x++) { - uint32_t server_idx = memcached_generate_hash(memc, ketama_test_cases_spy[x].key, strlen(ketama_test_cases_spy[x].key)); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc, server_idx); - char *hostname = instance->hostname; + uint32_t server_idx= memcached_generate_hash(memc, ketama_test_cases_spy[x].key, strlen(ketama_test_cases_spy[x].key)); + + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc, server_idx); + + const char *hostname= memcached_server_name(instance); + test_strcmp(hostname, ketama_test_cases_spy[x].server); } @@ -5371,8 +5275,8 @@ static test_return_t regression_bug_442914(memcached_st *memc) static test_return_t regression_bug_447342(memcached_st *memc) { - memcached_server_instance_st *instance_one; - memcached_server_instance_st *instance_two; + memcached_server_instance_st instance_one; + memcached_server_instance_st instance_two; if (memcached_server_count(memc) < 3 || pre_replication(memc) != MEMCACHED_SUCCESS) return TEST_SKIPPED; @@ -5431,13 +5335,13 @@ static test_return_t regression_bug_447342(memcached_st *memc) * This is to verify correct behavior in the library. Fake that two servers * are dead.. */ - instance_one= memcached_server_instance_fetch(memc, 0); - instance_two= memcached_server_instance_fetch(memc, 2); + instance_one= memcached_server_instance_by_position(memc, 0); + instance_two= memcached_server_instance_by_position(memc, 2); in_port_t port0= instance_one->port; in_port_t port2= instance_two->port; - instance_one->port= 0; - instance_two->port= 0; + ((memcached_server_write_instance_st)instance_one)->port= 0; + ((memcached_server_write_instance_st)instance_two)->port= 0; rc= memcached_mget(memc, (const char* const *)keys, key_length, max_keys); test_true(rc == MEMCACHED_SUCCESS); @@ -5447,8 +5351,8 @@ static test_return_t regression_bug_447342(memcached_st *memc) test_true(counter == (unsigned int)max_keys); /* restore the memc handle */ - instance_one->port= port0; - instance_two->port= port2; + ((memcached_server_write_instance_st)instance_one)->port= port0; + ((memcached_server_write_instance_st)instance_two)->port= port2; memcached_quit(memc); @@ -5463,8 +5367,8 @@ static test_return_t regression_bug_447342(memcached_st *memc) } memcached_quit(memc); - instance_one->port= 0; - instance_two->port= 0; + ((memcached_server_write_instance_st)instance_one)->port= 0; + ((memcached_server_write_instance_st)instance_two)->port= 0; /* now retry the command, this time we should have cache misses */ rc= memcached_mget(memc, (const char* const *)keys, key_length, max_keys); @@ -5483,8 +5387,8 @@ static test_return_t regression_bug_447342(memcached_st *memc) free(key_length); /* restore the memc handle */ - instance_one->port= port0; - instance_two->port= port2; + ((memcached_server_write_instance_st)instance_one)->port= port0; + ((memcached_server_write_instance_st)instance_two)->port= port2; return TEST_SUCCESS; } @@ -5495,8 +5399,8 @@ static test_return_t regression_bug_463297(memcached_st *memc) test_true(memc_clone != NULL); test_true(memcached_version(memc_clone) == MEMCACHED_SUCCESS); - memcached_server_instance_st *instance= - memcached_server_instance_fetch(memc_clone, 0); + memcached_server_instance_st instance= + memcached_server_instance_by_position(memc_clone, 0); if (instance->major_version > 1 || (instance->major_version == 1 && @@ -5557,12 +5461,13 @@ static test_return_t regression_bug_463297(memcached_st *memc) static test_return_t test_get_last_disconnect(memcached_st *memc) { memcached_return_t rc; - memcached_server_st *disconnected_server; + memcached_server_instance_st disconnected_server; /* With the working set of server */ const char *key= "marmotte"; const char *value= "milka"; + memcached_reset_last_disconnected_server(memc); rc= memcached_set(memc, key, strlen(key), value, strlen(value), (time_t)0, (uint32_t)0); @@ -5590,10 +5495,15 @@ static test_return_t test_get_last_disconnect(memcached_st *memc) (time_t)0, (uint32_t)0); test_true(rc != MEMCACHED_SUCCESS); - disconnected_server = memcached_server_get_last_disconnect(mine); + disconnected_server= memcached_server_get_last_disconnect(mine); + if (disconnected_server == NULL) + { + fprintf(stderr, "RC %s\n", memcached_strerror(mine, rc)); + abort(); + } test_true(disconnected_server != NULL); - test_true(disconnected_server->port == 9); - test_true(strncmp(disconnected_server->hostname,"localhost",9) == 0); + test_true(memcached_server_port(disconnected_server)== 9); + test_true(strncmp(memcached_server_name(disconnected_server),"localhost",9) == 0); memcached_quit(mine); memcached_free(mine); @@ -5601,6 +5511,67 @@ static test_return_t test_get_last_disconnect(memcached_st *memc) return TEST_SUCCESS; } +static test_return_t test_verbosity(memcached_st *memc) +{ + memcached_verbosity(memc, 3); + + return TEST_SUCCESS; +} + +static test_return_t test_server_failure(memcached_st *memc) +{ + memcached_st *local_memc; + memcached_server_instance_st instance= memcached_server_instance_by_position(memc, 0); + + local_memc= memcached_create(NULL); + + memcached_server_add(local_memc, memcached_server_name(instance), memcached_server_port(instance)); + memcached_behavior_set(local_memc, MEMCACHED_BEHAVIOR_SERVER_FAILURE_LIMIT, 2); + + uint32_t server_count= memcached_server_count(local_memc); + + test_true(server_count == 1); + + // Disable the server + instance= memcached_server_instance_by_position(local_memc, 0); + ((memcached_server_write_instance_st)instance)->server_failure_counter= 2; + + memcached_return_t rc; + rc= memcached_set(local_memc, "foo", strlen("foo"), + NULL, 0, + (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_SERVER_MARKED_DEAD); + + ((memcached_server_write_instance_st)instance)->server_failure_counter= 0; + rc= memcached_set(local_memc, "foo", strlen("foo"), + NULL, 0, + (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_SUCCESS); + + + memcached_free(local_memc); + + return TEST_SUCCESS; +} + +static test_return_t test_cull_servers(memcached_st *memc) +{ + uint32_t count = memcached_server_count(memc); + + // Do not do this in your code, it is not supported. + memc->servers[1].state.is_dead= true; + memc->state.is_time_for_rebuild= true; + + uint32_t new_count= memcached_server_count(memc); + test_true(count == new_count); + +#if 0 + test_true(count == new_count + 1 ); +#endif + + return TEST_SUCCESS; +} + /* * This test ensures that the failure counter isn't incremented during * normal termination of the memcached instance. @@ -5608,7 +5579,7 @@ static test_return_t test_get_last_disconnect(memcached_st *memc) static test_return_t wrong_failure_counter_test(memcached_st *memc) { memcached_return_t rc; - memcached_server_instance_st *instance; + memcached_server_instance_st instance; /* Set value to force connection to the server */ const char *key= "marmotte"; @@ -5629,12 +5600,12 @@ static test_return_t wrong_failure_counter_test(memcached_st *memc) test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED); - instance= memcached_server_instance_fetch(memc, 0); + instance= memcached_server_instance_by_position(memc, 0); /* The test is to see that the memcached_quit doesn't increase the * the server failure conter, so let's ensure that it is zero * before sending quit */ - instance->server_failure_counter= 0; + ((memcached_server_write_instance_st)instance)->server_failure_counter= 0; memcached_quit(memc); @@ -5732,33 +5703,149 @@ static test_return_t regression_bug_490486(memcached_st *memc) return TEST_SUCCESS; } +static void memcached_die(memcached_st* mc, memcached_return error, const char* what, uint32_t it) +{ + fprintf(stderr, "Iteration #%u: ", it); + if(error == MEMCACHED_ERRNO) + { + fprintf(stderr, "system error %d from %s: %s\n", + errno, what, strerror(errno)); + } + else + { + fprintf(stderr, "error %d from %s: %s\n", error, what, + memcached_strerror(mc, error)); + } +} +#define TEST_CONSTANT_CREATION 200 -test_st udp_setup_server_tests[] ={ - {"set_udp_behavior_test", 0, (test_callback_fn)set_udp_behavior_test}, - {"add_tcp_server_udp_client_test", 0, (test_callback_fn)add_tcp_server_udp_client_test}, - {"add_udp_server_tcp_client_test", 0, (test_callback_fn)add_udp_server_tcp_client_test}, - {0, 0, 0} -}; +static test_return_t regression_bug_(memcached_st *memc) +{ + const char *remote_server; + (void)memc; -test_st upd_io_tests[] ={ - {"udp_set_test", 0, (test_callback_fn)udp_set_test}, - {"udp_buffered_set_test", 0, (test_callback_fn)udp_buffered_set_test}, - {"udp_set_too_big_test", 0, (test_callback_fn)udp_set_too_big_test}, - {"udp_delete_test", 0, (test_callback_fn)udp_delete_test}, - {"udp_buffered_delete_test", 0, (test_callback_fn)udp_buffered_delete_test}, - {"udp_verbosity_test", 0, (test_callback_fn)udp_verbosity_test}, - {"udp_quit_test", 0, (test_callback_fn)udp_quit_test}, - {"udp_flush_test", 0, (test_callback_fn)udp_flush_test}, - {"udp_incr_test", 0, (test_callback_fn)udp_incr_test}, - {"udp_decr_test", 0, (test_callback_fn)udp_decr_test}, - {"udp_stat_test", 0, (test_callback_fn)udp_stat_test}, - {"udp_version_test", 0, (test_callback_fn)udp_version_test}, - {"udp_get_test", 0, (test_callback_fn)udp_get_test}, - {"udp_mixed_io_test", 0, (test_callback_fn)udp_mixed_io_test}, - {0, 0, 0} -}; + if (! (remote_server= getenv("LIBMEMCACHED_REMOTE_SERVER"))) + { + return TEST_SKIPPED; + } + + for (uint32_t x= 0; x < TEST_CONSTANT_CREATION; x++) + { + memcached_st* mc= memcached_create(NULL); + memcached_return rc; + + rc= memcached_behavior_set(mc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_behavior_set", x); + } + + rc= memcached_behavior_set(mc, MEMCACHED_BEHAVIOR_CACHE_LOOKUPS, 1); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_behavior_set", x); + } + + rc= memcached_server_add(mc, remote_server, 0); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_server_add", x); + } + + const char *set_key= "akey"; + const size_t set_key_len= strlen(set_key); + const char *set_value= "a value"; + const size_t set_value_len= strlen(set_value); + + if (rc == MEMCACHED_SUCCESS) + { + if (x > 0) + { + size_t get_value_len; + char *get_value; + uint32_t get_value_flags; + + get_value= memcached_get(mc, set_key, set_key_len, &get_value_len, + &get_value_flags, &rc); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_get", x); + } + else + { + + if (x != 0 && + (get_value_len != set_value_len + || 0!=strncmp(get_value, set_value, get_value_len))) + { + fprintf(stderr, "Values don't match?\n"); + rc= MEMCACHED_FAILURE; + } + free(get_value); + } + } + + rc= memcached_set(mc, + set_key, set_key_len, + set_value, set_value_len, + 0, /* time */ + 0 /* flags */ + ); + if (rc != MEMCACHED_SUCCESS) + { + memcached_die(mc, rc, "memcached_set", x); + } + } + + memcached_quit(mc); + memcached_free(mc); + + if (rc != MEMCACHED_SUCCESS) + { + break; + } + } + + return MEMCACHED_SUCCESS; +} + +/* + * Test that the sasl authentication works. We cannot use the default + * pool of servers, because that would require that all servers we want + * to test supports SASL authentication, and that they use the default + * creds. + */ +static test_return_t sasl_auth_test(memcached_st *memc) +{ +#ifdef LIBMEMCACHED_WITH_SASL_SUPPORT + memcached_return_t rc; + + rc= memcached_set(memc, "foo", 3, "bar", 3, (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_SUCCESS); + test_true((rc= memcached_delete(memc, "foo", 3, 0)) == MEMCACHED_SUCCESS); + test_true((rc= memcached_destroy_sasl_auth_data(memc)) == MEMCACHED_SUCCESS); + test_true((rc= memcached_destroy_sasl_auth_data(memc)) == MEMCACHED_FAILURE); + test_true((rc= memcached_destroy_sasl_auth_data(NULL)) == MEMCACHED_FAILURE); + memcached_quit(memc); + + rc= memcached_set_sasl_auth_data(memc, + getenv("LIBMEMCACHED_TEST_SASL_USERNAME"), + getenv("LIBMEMCACHED_TEST_SASL_SERVER")); + test_true(rc == MEMCACHED_SUCCESS); + + rc= memcached_set(memc, "foo", 3, "bar", 3, (time_t)0, (uint32_t)0); + test_true(rc == MEMCACHED_AUTH_FAILURE); + test_true(memcached_destroy_sasl_auth_data(memc) == MEMCACHED_SUCCESS); + + memcached_quit(memc); + return TEST_SUCCESS; +#else + (void)memc; + return TEST_FAILURE; +#endif +} /* Clean the server before beginning testing */ test_st tests[] ={ @@ -5769,6 +5856,7 @@ test_st tests[] ={ {"server_unsort", 0, (test_callback_fn)server_unsort_test}, {"server_sort", 0, (test_callback_fn)server_sort_test}, {"server_sort2", 0, (test_callback_fn)server_sort2_test}, + {"memcached_server_remove", 0, (test_callback_fn)memcached_server_remove_test}, {"clone_test", 0, (test_callback_fn)clone_test }, {"connection_test", 0, (test_callback_fn)connection_test}, {"callback_test", 0, (test_callback_fn)callback_test}, @@ -5817,12 +5905,23 @@ test_st tests[] ={ {"connectionpool", 1, (test_callback_fn)connection_pool_test }, #endif {"test_get_last_disconnect", 1, (test_callback_fn)test_get_last_disconnect}, + {"verbosity", 1, (test_callback_fn)test_verbosity}, + {"test_server_failure", 1, (test_callback_fn)test_server_failure}, + {"cull_servers", 1, (test_callback_fn)test_cull_servers}, {0, 0, 0} }; test_st behavior_tests[] ={ {"behavior_test", 0, (test_callback_fn)behavior_test}, {"MEMCACHED_BEHAVIOR_CORK", 0, (test_callback_fn)MEMCACHED_BEHAVIOR_CORK_test}, + {"MEMCACHED_BEHAVIOR_TCP_KEEPALIVE", 0, (test_callback_fn)MEMCACHED_BEHAVIOR_TCP_KEEPALIVE_test}, + {"MEMCACHED_BEHAVIOR_TCP_KEEPIDLE", 0, (test_callback_fn)MEMCACHED_BEHAVIOR_TCP_KEEPIDLE_test}, + {0, 0, 0} +}; + +test_st regression_binary_vs_block[] ={ + {"block add", 1, (test_callback_fn)block_add_regression}, + {"binary add", 1, (test_callback_fn)binary_add_regression}, {0, 0, 0} }; @@ -5909,12 +6008,18 @@ test_st replication_tests[]= { test_st regression_tests[]= { {"lp:434484", 1, (test_callback_fn)regression_bug_434484 }, {"lp:434843", 1, (test_callback_fn)regression_bug_434843 }, - {"lp:434843 buffered", 1, (test_callback_fn)regression_bug_434843_buffered }, + {"lp:434843-buffered", 1, (test_callback_fn)regression_bug_434843_buffered }, {"lp:421108", 1, (test_callback_fn)regression_bug_421108 }, {"lp:442914", 1, (test_callback_fn)regression_bug_442914 }, {"lp:447342", 1, (test_callback_fn)regression_bug_447342 }, {"lp:463297", 1, (test_callback_fn)regression_bug_463297 }, {"lp:490486", 1, (test_callback_fn)regression_bug_490486 }, + {"lp:?", 1, (test_callback_fn)regression_bug_ }, + {0, 0, (test_callback_fn)0} +}; + +test_st sasl_auth_tests[]= { + {"sasl_auth", 1, (test_callback_fn)sasl_auth_test }, {0, 0, (test_callback_fn)0} }; @@ -5978,6 +6083,7 @@ test_st ketama_auto_eject_hosts[] ={ }; test_st hash_tests[] ={ + {"one_at_a_time_run", 0, (test_callback_fn)one_at_a_time_run }, {"md5", 0, (test_callback_fn)md5_run }, {"crc", 0, (test_callback_fn)crc_run }, {"fnv1_64", 0, (test_callback_fn)fnv1_64_run }, @@ -5987,6 +6093,7 @@ test_st hash_tests[] ={ {"hsieh", 0, (test_callback_fn)hsieh_run }, {"murmur", 0, (test_callback_fn)murmur_run }, {"jenkis", 0, (test_callback_fn)jenkins_run }, + {"memcached_get_hashkit", 0, (test_callback_fn)memcached_get_hashkit_test }, {0, 0, (test_callback_fn)0} }; @@ -5995,9 +6102,6 @@ collection_st collection[] ={ {"hash_sanity", 0, 0, hash_sanity}, #endif {"hsieh_availability", 0, 0, hsieh_availability}, - {"udp_setup", (test_callback_fn)init_udp, 0, udp_setup_server_tests}, - {"udp_io", (test_callback_fn)init_udp, 0, upd_io_tests}, - {"udp_binary_io", (test_callback_fn)binary_init_udp, 0, upd_io_tests}, {"block", 0, 0, tests}, {"binary", (test_callback_fn)pre_binary, 0, tests}, {"nonblock", (test_callback_fn)pre_nonblock, 0, tests}, @@ -6024,6 +6128,8 @@ collection_st collection[] ={ #endif {"memory_allocators", (test_callback_fn)set_memory_alloc, 0, tests}, {"prefix", (test_callback_fn)set_prefix, 0, tests}, + {"sasl_auth", (test_callback_fn)pre_sasl, 0, sasl_auth_tests }, + {"sasl", (test_callback_fn)pre_sasl, 0, tests }, {"version_1_2_3", (test_callback_fn)check_for_1_2_3, 0, version_1_2_3}, {"string", 0, 0, string_tests}, {"result", 0, 0, result_tests}, @@ -6050,6 +6156,7 @@ collection_st collection[] ={ {"replication_noblock", (test_callback_fn)pre_replication_noblock, 0, replication_tests}, {"regression", 0, 0, regression_tests}, {"behaviors", 0, 0, behavior_tests}, + {"regression_binary_vs_block", (test_callback_fn)key_setup, (test_callback_fn)key_teardown, regression_binary_vs_block}, {0, 0, 0, 0} };