X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=src%2Futilities.c;h=eeec16887fd89829a4990ffe4238462fe2cc1ab6;hb=806525899ce3dff894b829416307a4290cd882e2;hp=5dd66f62731d871651d16eb7a5232bc39797a006;hpb=6d0bec130624e22e695dbf4038fbeed9e1c26c60;p=m6w6%2Flibmemcached

diff --git a/src/utilities.c b/src/utilities.c
index 5dd66f62..eeec1688 100644
--- a/src/utilities.c
+++ b/src/utilities.c
@@ -1,29 +1,38 @@
 #include <memcached.h>
 
 void parse_opt_servers(memcached_st *memc,
-                       char *opt_servers)
+                       char *server_strings)
 {
   char *string;
   unsigned int port;
   char *begin_ptr;
+  char *end_ptr;
 
-  for (begin_ptr= opt_servers, string= index(opt_servers, ','); 
-       begin_ptr[0]; 
-       begin_ptr= ++string, string= index(begin_ptr, ','))
+  assert(server_strings);
+  assert(memc);
+
+  end_ptr= server_strings + strlen(server_strings);
+
+  for (begin_ptr= server_strings, string= index(server_strings, ','); 
+       begin_ptr != end_ptr; 
+       string= index(begin_ptr, ','))
   {
     char buffer[HUGE_STRING_LEN];
     char *ptr;
+    port= 0;
 
     memset(buffer, 0, HUGE_STRING_LEN);
     if (string)
     {
       memcpy(buffer, begin_ptr, string - begin_ptr);
+      begin_ptr= string+1;
     }
     else
     {
-      size_t length= strlen(opt_servers);
+      size_t length= strlen(server_strings);
       memcpy(buffer, begin_ptr, length);
-      string= opt_servers+length;
+      string= server_strings+length;
+      begin_ptr= end_ptr;
     }
 
     ptr= index(buffer, ':');
@@ -35,13 +44,8 @@ void parse_opt_servers(memcached_st *memc,
       ptr++;
 
       port= strtol(ptr, (char **)NULL, 10);
-
-      memcached_server_add(memc, buffer, port);
-    }
-    else
-    {
-      memcached_server_add(memc, buffer, 0);
     }
+
+    memcached_server_add(memc, buffer, port);
   }
 }
-