X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libtest%2Fmemcached.cc;h=3b63c0fc485e08f63c077879ff844e0ae203dae8;hb=b90c798532ec8d4d4e2f5c1eea1ec18354dd2070;hp=8c79b17ddd51984504e182f5d22294bb8f2d7aa1;hpb=e82f6a9bffe896a579ae5013a9cab51180cd003d;p=m6w6%2Flibmemcached

diff --git a/libtest/memcached.cc b/libtest/memcached.cc
index 8c79b17d..3b63c0fc 100644
--- a/libtest/memcached.cc
+++ b/libtest/memcached.cc
@@ -1,9 +1,8 @@
 /*  vim:expandtab:shiftwidth=2:tabstop=2:smarttab:
  * 
- *  Libmemcached library
+ *  libtest
  *
  *  Copyright (C) 2011 Data Differential, http://datadifferential.com/
- *  Copyright (C) 2006-2009 Brian Aker All rights reserved.
  *
  *  Redistribution and use in source and binary forms, with or without
  *  modification, are permitted provided that the following conditions are
@@ -35,307 +34,189 @@
  *
  */
 
+#include <libtest/common.h>
 
-/*
-  Startup, and shutdown the memcached servers.
-*/
-
-#define TEST_PORT_BASE MEMCACHED_DEFAULT_PORT+10
-
-#include <config.h>
+#include <libmemcached/memcached.h>
+#include <libmemcached/util.h>
 
-#include <iso646.h>
+using namespace libtest;
 
-#include <assert.h>
-#include <limits.h>
+#include <cassert>
+#include <cerrno>
+#include <cstdio>
+#include <cstdlib>
+#include <cstring>
+#include <iostream>
 #include <signal.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/time.h>
-#include <time.h>
+#include <sys/types.h>
+#include <sys/wait.h>
 #include <unistd.h>
-#include <errno.h>
-
-#include <libmemcached/memcached.h>
-#include <libmemcached/util.h>
 
 #include <libtest/server.h>
+#include <libtest/wait.h>
 
-static void global_sleep(void)
-{
-  static struct timespec global_sleep_value= { 0, 50000 };
+#include <libtest/memcached.h>
 
-#ifdef WIN32
-  sleep(1);
-#else
-  nanosleep(&global_sleep_value, NULL);
+#ifndef __INTEL_COMPILER
+#pragma GCC diagnostic ignored "-Wold-style-cast"
 #endif
-}
 
-static bool wait_for_file(const char *filename)
+using namespace libtest;
+
+class Memcached : public Server
 {
-  uint32_t timeout= 6;
-  uint32_t waited;
-  uint32_t this_wait;
-  uint32_t retry;
+public:
+  Memcached(const std::string& host_arg, const in_port_t port_arg, const bool is_socket_arg) :
+    Server(host_arg, port_arg, is_socket_arg)
+  { }
 
-  for (waited= 0, retry= 1; ; retry++, waited+= this_wait)
+  pid_t get_pid(bool error_is_ok)
   {
-    if ((! access(filename, R_OK)) || (waited >= timeout))
+    // Memcached is slow to start, so we need to do this
+    if (not pid_file().empty())
     {
-      return true;
+      Wait wait(pid_file(), 0);
+
+      if (error_is_ok and not wait.successful())
+      {
+        Error << "Pidfile was not found:" << pid_file();
+        return -1;
+      }
     }
 
-    this_wait= retry * retry / 3 + 1;
-    sleep(this_wait);
-  }
+    pid_t local_pid;
+    memcached_return_t rc;
+    if (has_socket())
+    {
+      local_pid= libmemcached_util_getpid(socket().c_str(), port(), &rc);
+    }
+    else
+    {
+      local_pid= libmemcached_util_getpid(hostname().c_str(), port(), &rc);
+    }
 
-  return false;
-}
+    if (error_is_ok and ((memcached_failed(rc) or local_pid < 1)))
+    {
+      Error << "libmemcached_util_getpid(" << memcached_strerror(NULL, rc) << ") pid: " << local_pid << " for:" << *this;
+    }
 
-static void kill_file(const char *file_buffer)
-{
-  FILE *fp;
+    return local_pid;
+  }
 
-  while ((fp= fopen(file_buffer, "r")))
+  bool ping()
   {
-    char pid_buffer[1024];
-
-    if (fgets(pid_buffer, sizeof(pid_buffer), fp) != NULL)
+    // Memcached is slow to start, so we need to do this
+    if (not pid_file().empty())
     {
-      pid_t pid= (pid_t)atoi(pid_buffer);
-      if (pid != 0)
+      Wait wait(pid_file(), 0);
+
+      if (not wait.successful())
       {
-        if (kill(pid, SIGTERM) == -1)
-        {
-          remove(file_buffer); // If this happens we may be dealing with a dead server that left its pid file.
-        }
-        else
-        {
-          uint32_t counter= 3;
-          while ((kill(pid, 0) == 0) && --counter)
-          {
-            global_sleep();
-          }
-        }
+        Error << "Pidfile was not found:" << pid_file();
+        return -1;
       }
     }
 
-    global_sleep();
+    memcached_return_t rc;
+    bool ret;
+    if (has_socket())
+    {
+      ret= libmemcached_util_ping(socket().c_str(), 0, &rc);
+    }
+    else
+    {
+      ret= libmemcached_util_ping(hostname().c_str(), port(), &rc);
+    }
 
-    fclose(fp);
+    if (memcached_failed(rc) or not ret)
+    {
+      Error << "libmemcached_util_ping(" << memcached_strerror(NULL, rc) << ")";
+    }
+    return ret;
   }
-}
 
-void server_startup(server_startup_st *construct)
-{
-  if ((construct->server_list= getenv("MEMCACHED_SERVERS")))
+  const char *name()
+  {
+    return "memcached";
+  };
+
+  const char *executable()
   {
-    printf("servers %s\n", construct->server_list);
-    construct->count= 0;
+    return MEMCACHED_BINARY;
   }
-  else
+
+  const char *pid_file_option()
   {
-    {
-      char server_string_buffer[8096];
-      char *end_ptr;
-      end_ptr= server_string_buffer;
+    return "-P ";
+  }
 
-      uint32_t port_base= 0;
-      for (uint32_t x= 0; x < construct->count; x++)
-      {
-        int status;
-
-        snprintf(construct->pid_file[x], FILENAME_MAX, "/tmp/memcached.pidXXXXXX");
-        int fd;
-        if ((fd= mkstemp(construct->pid_file[x])) == -1)
-        {
-          perror("mkstemp");
-          return;
-        }
-        close(fd);
-
-        {
-          char *var;
-          char variable_buffer[1024];
-
-          snprintf(variable_buffer, sizeof(variable_buffer), "LIBMEMCACHED_PORT_%u", x);
-
-          if ((var= getenv(variable_buffer)))
-          {
-            construct->port[x]= (in_port_t)atoi(var);
-          }
-          else
-          {
-            do {
-              construct->port[x]= (in_port_t)(x + TEST_PORT_BASE + port_base);
-
-              if (libmemcached_util_ping("localhost", construct->port[x], NULL))
-              {
-                if (libmemcached_util_flush("localhost", construct->port[x], NULL))
-                { 
-                  fprintf(stderr, "Found server on port %d, flushed it!\n", (int)construct->port[x]);
-                  construct->is_used[x]= true;
-                } // If we can flush it, we will just use it
-                else
-                {
-                  fprintf(stderr, "Found server on port %d, could not flush it, so trying next port.\n", (int)construct->port[x]);
-                  port_base++;
-                  construct->port[x]= 0;
-                }
-              }
-            } while (construct->port[x] == 0);
-          }
-        }
-
-        char buffer[FILENAME_MAX];
-        if (x == 0)
-        {
-          snprintf(buffer, sizeof(buffer), "%s -d -P %s -t 1 -p %u -U %u -m 128",
-                   MEMCACHED_BINARY, construct->pid_file[x], construct->port[x], construct->port[x]);
-        }
-        else
-        {
-          snprintf(buffer, sizeof(buffer), "%s -d -P %s -t 1 -p %u -U %u",
-                   MEMCACHED_BINARY, construct->pid_file[x], construct->port[x], construct->port[x]);
-        }
-
-        if (construct->is_used[x])
-        {
-          fprintf(stderr, "USING SERVER: %s\n", buffer);
-        }
-        else
-        {
-          if (libmemcached_util_ping("localhost", construct->port[x], NULL))
-          {
-            fprintf(stderr, "Server on port %u already exists\n", construct->port[x]);
-          }
-          else
-          {
-            status= system(buffer);
-            fprintf(stderr, "STARTING SERVER: %s  status:%d\n", buffer, status);
-          }
-        }
-
-        size_t remaining_length= sizeof(server_string_buffer) - (size_t)(end_ptr -server_string_buffer);
-        int count= snprintf(end_ptr, remaining_length,  "--server=localhost:%u ", construct->port[x]);
-
-        if ((size_t)count >= remaining_length or count < 0)
-        {
-          fprintf(stderr, "server names grew to be larger then buffer allowed\n");
-          abort();
-        }
-        end_ptr+= count;
-      }
-      *end_ptr= 0;
+  const char *socket_file_option() const
+  {
+    return "-s ";
+  }
 
+  const char *daemon_file_option()
+  {
+    return "-d";
+  }
 
-      for (uint32_t x= 0; x < construct->count; x++)
-      {
-        if (! wait_for_file(construct->pid_file[x]))
-        {
-          abort();
-        }
-      }
+  const char *log_file_option()
+  {
+    return NULL;
+  }
 
-      for (uint32_t x= 0; x < construct->count; x++)
-      {
-        uint32_t counter= 3000; // Absurd, just to catch run away process
-
-        if (construct->is_used[x])
-          continue;
-
-        while (construct->pids[x] <= 0  && --counter)
-        {
-          FILE *file= fopen(construct->pid_file[x], "r");
-          if (file)
-          {
-            char pid_buffer[1024];
-            char *found= fgets(pid_buffer, sizeof(pid_buffer), file);
-
-            if (found)
-            {
-              construct->pids[x]= atoi(pid_buffer);
-              fclose(file);
-
-              if (construct->pids[x] > 0)
-                break;
-            }
-            fclose(file);
-          }
-
-          switch (errno)
-          {
-          default:
-            fprintf(stderr, "Could not open pid file %s -> fopen(%s) -> %s:%d\n", construct->pid_file[x], strerror(errno), __FILE__, __LINE__);
-            abort();
-
-          case ENOENT:
-          case EINTR:
-          case EACCES:
-          case EINPROGRESS:
-            break;
-
-          case ENOTCONN:
-            continue;
-          }
-
-          // Safety 3rd, check to see if the file has gone away
-          if (! wait_for_file(construct->pid_file[x]))
-          {
-            abort();
-          }
-        }
-
-        bool was_started= false;
-        if (construct->pids[x] > 0)
-        {
-          counter= 30;
-          while (--counter)
-          {
-            if (kill(construct->pids[x], 0) == 0)
-            {
-              was_started= true;
-              break;
-            }
-            global_sleep();
-          }
-        }
-
-        if (was_started == false)
-        {
-          fprintf(stderr, "Failed to open buffer %s(%d)\n", construct->pid_file[x], construct->pids[x]);
-          for (uint32_t y= 0; y < construct->count; y++)
-          {
-            if (construct->pids[y] > 0)
-              kill(construct->pids[y], SIGTERM);
-          }
-          abort();
-        }
-      }
+  const char *port_option()
+  {
+    return "-p ";
+  }
 
-      construct->server_list= strndup(server_string_buffer, strlen(server_string_buffer) -1);
-    }
+  bool is_libtool()
+  {
+    return false;
   }
 
-  srandom((unsigned int)time(NULL));
+  // Memcached's pidfile is broken
+  bool broken_pid_file()
+  {
+    return true;
+  }
+
+  bool build(int argc, const char *argv[]);
+};
 
-  printf("\n");
-}
 
-void server_shutdown(server_startup_st *construct)
+#include <sstream>
+
+bool Memcached::build(int argc, const char *argv[])
 {
-  if (construct->server_list)
-  {
-    for (uint32_t x= 0; x < construct->count; x++)
-    {
-      if (construct->is_used[x])
-        continue;
+  std::stringstream arg_buffer;
 
-      kill_file(construct->pid_file[x]);
-    }
+  if (getuid() == 0 or geteuid() == 0)
+  {
+    arg_buffer << " -u root ";
+  }
 
-    free(construct->server_list);
+  for (int x= 1 ; x < argc ; x++)
+  {
+    arg_buffer << " " << argv[x] << " ";
   }
+
+  set_extra_args(arg_buffer.str());
+
+  return true;
 }
+
+namespace libtest {
+
+Server *build_memcached(const std::string& hostname, const in_port_t try_port)
+{
+  return new Memcached(hostname, try_port, false);
+}
+
+Server *build_memcached_socket(const std::string& hostname, const in_port_t try_port)
+{
+  return new Memcached(hostname, try_port, true);
+}
+
+}
+