X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libtest%2Fgearmand.cc;h=7a33b4df058d383984b8af4f211ded631b635b40;hb=7933fa8f9217d7e744876773a4033b3cda4c3c16;hp=dda38fbdfab3b68ca32437fd8c20320c3fa2cf56;hpb=1267d56c788cf8628c4111042d01b926f4a58dba;p=m6w6%2Flibmemcached diff --git a/libtest/gearmand.cc b/libtest/gearmand.cc index dda38fbd..7a33b4df 100644 --- a/libtest/gearmand.cc +++ b/libtest/gearmand.cc @@ -20,6 +20,7 @@ */ +#include #include #include @@ -48,40 +49,6 @@ using namespace libtest; #pragma GCC diagnostic ignored "-Wold-style-cast" #endif -class GetPid : public util::Instance::Finish -{ -private: - pid_t _pid; - -public: - GetPid() : - _pid(-1) - { } - - pid_t pid() - { - return _pid; - } - - - bool call(const bool success, const std::string &response) - { - _pid= -1; - if (success and response.size()) - { - _pid= atoi(response.c_str()); - } - - if (is_pid_valid(_pid) == false) - { - _pid= -1; - return false; - } - - return true; - } -}; - using namespace libtest; class Gearmand : public libtest::Server @@ -89,38 +56,11 @@ class Gearmand : public libtest::Server private: public: Gearmand(const std::string& host_arg, in_port_t port_arg) : - libtest::Server(host_arg, port_arg) + libtest::Server(host_arg, port_arg, GEARMAND_BINARY, true) { set_pid_file(); } - pid_t get_pid(bool error_is_ok) - { - if (pid_file().empty() == false) - { - Wait wait(pid_file(), 0); - - if (error_is_ok and not wait.successful()) - { - Error << "Pidfile was not found:" << pid_file(); - return -1; - } - } - - GetPid *get_instance_pid; - util::Instance instance(hostname(), port()); - instance.set_finish(get_instance_pid= new GetPid); - - instance.push(new util::Operation(test_literal_param("getpid\r\n"), true)); - - if (error_is_ok and instance.run() == false) - { - Error << "Failed to obtain pid of server"; - } - - return get_instance_pid->pid(); - } - bool ping() { gearman_client_st *client= gearman_client_create(NULL); @@ -159,16 +99,6 @@ public: return "gearmand"; }; - const char *executable() - { - return GEARMAND_BINARY; - } - - const char *daemon_file_option() - { - return "--daemon"; - } - void log_file_option(Application& app, const std::string& arg) { if (arg.empty() == false) @@ -192,7 +122,7 @@ public: bool has_syslog() const { - return true; + return false; // --syslog.errmsg-enable } bool has_port_option() const @@ -200,13 +130,11 @@ public: return true; } - bool build(int argc, const char *argv[]); + bool build(size_t argc, const char *argv[]); }; -bool Gearmand::build(int argc, const char *argv[]) +bool Gearmand::build(size_t argc, const char *argv[]) { - std::stringstream arg_buffer; - if (getuid() == 0 or geteuid() == 0) { add_option("-u", "root"); @@ -214,7 +142,7 @@ bool Gearmand::build(int argc, const char *argv[]) add_option("--listen=localhost"); - for (int x= 1 ; x < argc ; x++) + for (size_t x= 0 ; x < argc ; x++) { add_option(argv[x]); }