X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fvirtual_bucket.c;h=951881bd390e42640fbda13bed64f2c230933451;hb=6139acf5af6c33a6ca858306e7abd97e0ee4104f;hp=f91bf4549f089ec887312d186cb54ab9f0d96a7a;hpb=c69776b7cf0d0c26b07abd83da8a797182ff6fae;p=awesomized%2Flibmemcached diff --git a/libmemcached/virtual_bucket.c b/libmemcached/virtual_bucket.c index f91bf454..951881bd 100644 --- a/libmemcached/virtual_bucket.c +++ b/libmemcached/virtual_bucket.c @@ -35,7 +35,6 @@ * */ -#include #include struct bucket_t { @@ -56,7 +55,7 @@ memcached_return_t memcached_virtual_bucket_create(memcached_st *self, const uint32_t buckets, const uint32_t replicas) { - if (! self || ! host_map || ! buckets) + if (self == NULL || host_map == NULL || buckets == 0U) { return MEMCACHED_INVALID_ARGUMENTS; } @@ -65,8 +64,11 @@ memcached_return_t memcached_virtual_bucket_create(memcached_st *self, struct memcached_virtual_bucket_t *virtual_bucket= (struct memcached_virtual_bucket_t *)malloc(sizeof(struct memcached_virtual_bucket_t) + sizeof(struct bucket_t) *buckets); - if (! virtual_bucket) + if (virtual_bucket == NULL) + { return MEMCACHED_MEMORY_ALLOCATION_FAILURE; + } + virtual_bucket->size= buckets; virtual_bucket->replicas= replicas; @@ -85,36 +87,34 @@ memcached_return_t memcached_virtual_bucket_create(memcached_st *self, virtual_bucket->buckets[x].forward= 0; } } - return MEMCACHED_SUCCESS; } void memcached_virtual_bucket_free(memcached_st *self) { - if (! self) - return; - - if (! self->virtual_bucket) - return; - - free(self->virtual_bucket); - self->virtual_bucket= NULL; + if (self) + { + if (self->virtual_bucket) + { + free(self->virtual_bucket); + self->virtual_bucket= NULL; + } + } } uint32_t memcached_virtual_bucket_get(const memcached_st *self, uint32_t digest) { - if (! self) - return 0; - - if (! self->virtual_bucket) - return 0; - - if (self->virtual_bucket) + if (self) { - uint32_t result= (uint32_t) (digest & (self->virtual_bucket->size -1)); - return self->virtual_bucket->buckets[result].master; + if (self->virtual_bucket) + { + uint32_t result= (uint32_t) (digest & (self->virtual_bucket->size -1)); + return self->virtual_bucket->buckets[result].master; + } + + return (uint32_t) (digest & (self->number_of_hosts -1)); } - return (uint32_t) (digest & (self->number_of_hosts -1)); + return 0; }