X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fstring.cc;h=b821aca61edcb1de951774d4a81b2ca1f75b19e5;hb=d169e8c62f8ca4fe7d058d8e2254426105032b7e;hp=c7a47827decfae6ba6e0392c762864cc3ac86b55;hpb=387c65c94bec4333da574771fc82a40deabbc3e2;p=awesomized%2Flibmemcached

diff --git a/libmemcached/string.cc b/libmemcached/string.cc
index c7a47827..b821aca6 100644
--- a/libmemcached/string.cc
+++ b/libmemcached/string.cc
@@ -79,7 +79,7 @@ static inline void _init_string(memcached_string_st *self)
   self->end= self->string= NULL;
 }
 
-memcached_string_st *memcached_string_create(memcached_st *memc, memcached_string_st *self, size_t initial_size)
+memcached_string_st *memcached_string_create(Memcached *memc, memcached_string_st *self, size_t initial_size)
 {
   WATCHPOINT_ASSERT(memc);
 
@@ -115,13 +115,25 @@ memcached_string_st *memcached_string_create(memcached_st *memc, memcached_strin
     return NULL;
   }
 
-  self->options.is_initialized= true;
+  memcached_set_initialized(self, true);
 
   WATCHPOINT_ASSERT(self->string == self->end);
 
   return self;
 }
 
+static memcached_return_t memcached_string_append_null(memcached_string_st& string)
+{
+  if (memcached_failed(_string_check(&string, 1)))
+  {
+    return MEMCACHED_MEMORY_ALLOCATION_FAILURE;
+  }
+
+  *string.end= 0;
+
+  return MEMCACHED_SUCCESS;
+}
+
 static memcached_return_t memcached_string_append_null(memcached_string_st *string)
 {
   if (memcached_failed(_string_check(string, 1)))
@@ -168,13 +180,17 @@ memcached_return_t memcached_string_append(memcached_string_st *string,
 
 char *memcached_string_c_copy(memcached_string_st *string)
 {
-  if (not memcached_string_length(string))
+  if (memcached_string_length(string) == 0)
+  {
     return NULL;
+  }
 
   char *c_ptr= static_cast<char *>(libmemcached_malloc(string->root, (memcached_string_length(string)+1) * sizeof(char)));
 
-  if (not c_ptr)
+  if (c_ptr == NULL)
+  {
     return NULL;
+  }
 
   memcpy(c_ptr, memcached_string_value(string), memcached_string_length(string));
   c_ptr[memcached_string_length(string)]= 0;
@@ -182,16 +198,31 @@ char *memcached_string_c_copy(memcached_string_st *string)
   return c_ptr;
 }
 
-memcached_return_t memcached_string_reset(memcached_string_st *string)
+bool memcached_string_set(memcached_string_st& string, const char* value, size_t length)
+{
+  memcached_string_reset(&string);
+  if (memcached_success(memcached_string_append(&string, value, length)))
+  {
+    memcached_string_append_null(string);
+    return true;
+  }
+
+  return false;
+}
+
+void memcached_string_reset(memcached_string_st *string)
 {
   string->end= string->string;
+}
 
-  return MEMCACHED_SUCCESS;
+void memcached_string_free(memcached_string_st& ptr)
+{
+  memcached_string_free(&ptr);
 }
 
 void memcached_string_free(memcached_string_st *ptr)
 {
-  if (not ptr)
+  if (ptr == NULL)
   {
     return;
   }
@@ -216,11 +247,21 @@ memcached_return_t memcached_string_check(memcached_string_st *string, size_t ne
   return _string_check(string, need);
 }
 
+bool memcached_string_resize(memcached_string_st& string, const size_t need)
+{
+  return memcached_success(_string_check(&string, need));
+}
+
 size_t memcached_string_length(const memcached_string_st *self)
 {
   return size_t(self->end -self->string);
 }
 
+size_t memcached_string_length(const memcached_string_st& self)
+{
+  return size_t(self.end -self.string);
+}
+
 size_t memcached_string_size(const memcached_string_st *self)
 {
   return self->current_size;
@@ -231,19 +272,31 @@ const char *memcached_string_value(const memcached_string_st *self)
   return self->string;
 }
 
+const char *memcached_string_value(const memcached_string_st& self)
+{
+  return self.string;
+}
+
 char *memcached_string_take_value(memcached_string_st *self)
 {
+  char* value= NULL;
+
   assert_msg(self, "Invalid memcached_string_st");
-  // If we fail at adding the null, we copy and move on
-  if (memcached_success(memcached_string_append_null(self)))
+  if (self)
   {
-    return memcached_string_c_copy(self);
+    if (memcached_string_length(self))
+    {
+      // If we fail at adding the null, we copy and move on
+      if (memcached_failed(memcached_string_append_null(self)))
+      {
+        return NULL;
+      }
+
+      value= self->string;
+      _init_string(self);
+    }
   }
 
-  char *value= self->string;
-
-  _init_string(self);
-
   return value;
 }
 
@@ -252,7 +305,26 @@ char *memcached_string_value_mutable(const memcached_string_st *self)
   return self->string;
 }
 
+char *memcached_string_c_str(memcached_string_st& self)
+{
+  return self.string;
+}
+
 void memcached_string_set_length(memcached_string_st *self, size_t length)
 {
-  self->end= self->string + length;
+  self->end= self->string +length;
+}
+
+void memcached_string_set_length(memcached_string_st& self, const size_t length)
+{
+  assert(self.current_size >= length);
+  size_t set_length= length;
+  if (self.current_size > length)
+  {
+    if (memcached_failed(_string_check(&self, length)))
+    {
+      set_length= self.current_size;
+    }
+  }
+  self.end= self.string +set_length;
 }