X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fstorage.cc;h=9d77f51f4e5fd1a6e4ab19c9ebfd0cf7bbcefdee;hb=a4f7c3b9413014291d0ca549f32455b3be10a6c0;hp=c19f7ecc6382f7681d19953a7bc7302e2402d227;hpb=276e5c1e7fefa8f7061270f79443a704231c819e;p=m6w6%2Flibmemcached diff --git a/libmemcached/storage.cc b/libmemcached/storage.cc index c19f7ecc..9d77f51f 100644 --- a/libmemcached/storage.cc +++ b/libmemcached/storage.cc @@ -78,10 +78,14 @@ static inline memcached_return_t memcached_send(memcached_st *ptr, } if (memcached_failed(rc= memcached_validate_key_length(key_length, ptr->flags.binary_protocol))) + { return rc; + } - if (ptr->flags.verify_key && (memcached_key_test((const char **)&key, &key_length, 1) == MEMCACHED_BAD_KEY_PROVIDED)) + if (memcached_failed(memcached_key_test(*ptr, (const char **)&key, &key_length, 1))) + { return MEMCACHED_BAD_KEY_PROVIDED; + } uint32_t server_key= memcached_generate_hash_with_redistribution(ptr, group_key, group_key_length); memcached_server_write_instance_st instance= memcached_server_instance_fetch(ptr, server_key); @@ -107,14 +111,15 @@ static inline memcached_return_t memcached_send(memcached_st *ptr, check_length= snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, "%s %.*s%.*s %u %llu %lu %llu%s\r\n", storage_op_string(verb), - memcached_print_array(ptr->prefix_key), + memcached_print_array(ptr->_namespace), (int)key_length, key, flags, (unsigned long long)expiration, (unsigned long)value_length, (unsigned long long)cas, (ptr->flags.no_reply) ? " noreply" : ""); if (check_length >= MEMCACHED_DEFAULT_COMMAND_SIZE || check_length < 0) { - rc= MEMCACHED_WRITE_FAILURE; + rc= memcached_set_error(*instance, MEMCACHED_MEMORY_ALLOCATION_FAILURE, MEMCACHED_AT, + memcached_literal_param("snprintf(MEMCACHED_DEFAULT_COMMAND_SIZE)")); memcached_io_reset(instance); return rc; @@ -130,10 +135,10 @@ static inline memcached_return_t memcached_send(memcached_st *ptr, memcpy(buffer_ptr, command, strlen(command)); /* Copy in the key prefix, switch to the buffer_ptr */ - buffer_ptr= (char *)memcpy((char *)(buffer_ptr + strlen(command)), (char *)memcached_array_string(ptr->prefix_key), memcached_array_size(ptr->prefix_key)); + buffer_ptr= (char *)memcpy((char *)(buffer_ptr + strlen(command)), (char *)memcached_array_string(ptr->_namespace), memcached_array_size(ptr->_namespace)); /* Copy in the key, adjust point if a key prefix was used. */ - buffer_ptr= (char *)memcpy(buffer_ptr + memcached_array_size(ptr->prefix_key), + buffer_ptr= (char *)memcpy(buffer_ptr + memcached_array_size(ptr->_namespace), key, key_length); buffer_ptr+= key_length; buffer_ptr[0]= ' '; @@ -147,7 +152,8 @@ static inline memcached_return_t memcached_send(memcached_st *ptr, ptr->flags.no_reply ? " noreply" : ""); if ((size_t)check_length >= MEMCACHED_DEFAULT_COMMAND_SIZE -size_t(buffer_ptr - buffer) || check_length < 0) { - rc= MEMCACHED_WRITE_FAILURE; + rc= memcached_set_error(*ptr, MEMCACHED_MEMORY_ALLOCATION_FAILURE, MEMCACHED_AT, + memcached_literal_param("snprintf(MEMCACHED_DEFAULT_COMMAND_SIZE)")); memcached_io_reset(instance); return rc; @@ -477,7 +483,7 @@ static memcached_return_t memcached_send_binary(memcached_st *ptr, request.message.header.request.magic= PROTOCOL_BINARY_REQ; request.message.header.request.opcode= get_com_code(verb, noreply); - request.message.header.request.keylen= htons((uint16_t)(key_length + memcached_array_size(ptr->prefix_key))); + request.message.header.request.keylen= htons((uint16_t)(key_length + memcached_array_size(ptr->_namespace))); request.message.header.request.datatype= PROTOCOL_BINARY_RAW_BYTES; if (verb == APPEND_OP || verb == PREPEND_OP) send_length -= 8; /* append & prepend does not contain extras! */ @@ -488,7 +494,7 @@ static memcached_return_t memcached_send_binary(memcached_st *ptr, request.message.body.expiration= htonl((uint32_t)expiration); } - request.message.header.request.bodylen= htonl((uint32_t) (key_length + memcached_array_size(ptr->prefix_key) + value_length + + request.message.header.request.bodylen= htonl((uint32_t) (key_length + memcached_array_size(ptr->_namespace) + value_length + request.message.header.request.extlen)); if (cas) @@ -513,7 +519,7 @@ static memcached_return_t memcached_send_binary(memcached_st *ptr, struct libmemcached_io_vector_st vector[]= { { send_length, request.bytes }, - { memcached_array_size(ptr->prefix_key), memcached_array_string(ptr->prefix_key) }, + { memcached_array_size(ptr->_namespace), memcached_array_string(ptr->_namespace) }, { key_length, key }, { value_length, value } };