X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fkey.cc;h=19d1f957acefc01214ac2ffdaa2198e613d05093;hb=b341b2b8f8b566641704161f9cc9c28f2d77a358;hp=e92468811ccf8b80ca3338eb7fffad7c9bb22b9c;hpb=51351e672a6a1626e09d5a9d41e3229df44fc3c8;p=m6w6%2Flibmemcached diff --git a/libmemcached/key.cc b/libmemcached/key.cc index e9246881..19d1f957 100644 --- a/libmemcached/key.cc +++ b/libmemcached/key.cc @@ -44,40 +44,40 @@ memcached_return_t memcached_key_test(memcached_st &memc, { if (keys == NULL or key_length == NULL) { - return memcached_set_error(memc, MEMCACHED_BAD_KEY_PROVIDED, MEMCACHED_AT); + return memcached_set_error(memc, MEMCACHED_BAD_KEY_PROVIDED, MEMCACHED_AT, memcached_literal_param("Key was NULL or length of key was zero.")); } // If we don't need to verify the key, or we are using the binary protoocol, // we just check the size of the key if (memc.flags.verify_key == false or memc.flags.binary_protocol == true) { - for (uint32_t x= 0; x < number_of_keys; x++) + for (size_t x= 0; x < number_of_keys; x++) { // We should set binary key, but the memcached server is broken for // longer keys at the moment. memcached_return_t rc= memcached_validate_key_length(*(key_length +x), false /* memc.flags.binary_protocol */); if (memcached_failed(rc)) { - return rc; + return memcached_set_error(memc, rc, MEMCACHED_AT, memcached_literal_param("Key provided was too long.")); } } return MEMCACHED_SUCCESS; } - for (uint32_t x= 0; x < number_of_keys; x++) + for (size_t x= 0; x < number_of_keys; x++) { memcached_return_t rc= memcached_validate_key_length(*(key_length + x), false); if (memcached_failed(rc)) { - return rc; + return memcached_set_error(memc, rc, MEMCACHED_AT, memcached_literal_param("Key provided was too long.")); } for (size_t y= 0; y < *(key_length + x); y++) { if ((isgraph(keys[x][y])) == 0) { - return MEMCACHED_BAD_KEY_PROVIDED; + return memcached_set_error(memc, MEMCACHED_BAD_KEY_PROVIDED, MEMCACHED_AT, memcached_literal_param("Key provided had invalid character.")); } } }